root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

merge main: resolve db.test.ts import conflict

Browse Source 
Combined both branches: TaskStore import from main + rmSync import
from our branch (needed for fresh DB test cleanup).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Timothy Laurent
2026-05-04 14:58:47 -07:00
parent 8e7b8e139f 54f2832691
commit cd09f12c77
38 changed files with 2625 additions and 188 deletions
Download Patch File Download Diff File Expand all files Collapse all files

110
packages/core/src/__tests__/db.test.ts
View File

@@ -1,6 +1,7 @@
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
import { Database, createDatabase, toJson, toJsonNullable, fromJson, normalizeTaskComments } from "../db.js";
import { DEFAULT_PROJECT_SETTINGS } from "../types.js";
import { TaskStore } from "../store.js";
import { mkdtempSync, existsSync, readFileSync, rmSync } from "node:fs";
import { join, dirname } from "node:path";
import { tmpdir } from "node:os";
@@ -109,6 +110,8 @@ describe("Database", () => {
expect(tableNames).toContain("roadmaps");
expect(tableNames).toContain("roadmap_milestones");
expect(tableNames).toContain("roadmap_features");
// Verification cache (migration 61)
expect(tableNames).toContain("verification_cache");
});
it("creates all expected indexes", () => {
@@ -152,10 +155,12 @@ describe("Database", () => {
// Roadmap indexes
expect(indexNames).toContain("idxRoadmapMilestonesRoadmapOrder");
expect(indexNames).toContain("idxRoadmapFeaturesMilestoneOrder");
// Verification cache index (migration 61)
expect(indexNames).toContain("idxVerificationCacheRecordedAt");
});
it("seeds schema version", () => {
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
});
it("seeds lastModified", () => {
@@ -178,7 +183,7 @@ describe("Database", () => {
it("is idempotent - calling init() twice does not fail", () => {
expect(() => db.init()).not.toThrow();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
});
it("does not overwrite existing config on re-init", () => {
@@ -952,7 +957,7 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29 (includes v1→v2 through v26→v29)
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -977,11 +982,11 @@ describe("schema migrations", () => {
const db = new Database(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
// Re-init should not fail
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
db.close();
});
@@ -1016,7 +1021,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("priority");
@@ -1057,7 +1062,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1126,7 +1131,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1229,7 +1234,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const cols = db.prepare("PRAGMA table_info(chat_messages)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("attachments");
@@ -1303,7 +1308,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'agentRatings'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "agentRatings" }]);
@@ -1327,7 +1332,7 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'mission_events'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "mission_events" }]);
@@ -1431,7 +1436,7 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -1900,7 +1905,7 @@ describe("createDatabase factory", () => {
const db = createDatabase(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
expect(db.getLastModified()).toBeGreaterThan(0);
db.close();
@@ -1934,3 +1939,82 @@ describe("createDatabase factory", () => {
db2.close();
});
});
// ── TaskStore — verification cache methods ────────────────────────────────
describe("TaskStore — verification cache", () => {
let rootDir: string;
let globalDir: string;
let store: TaskStore;
beforeEach(async () => {
rootDir = mkdtempSync(join(tmpdir(), "kb-vc-test-"));
globalDir = mkdtempSync(join(tmpdir(), "kb-vc-global-"));
store = new TaskStore(rootDir, globalDir, { inMemoryDb: true });
await store.init();
});
afterEach(async () => {
store.close();
await rm(rootDir, { recursive: true, force: true });
await rm(globalDir, { recursive: true, force: true });
});
it("returns null when no cache entry exists", () => {
const hit = store.getVerificationCacheHit("abc1234", "pnpm test", "pnpm build");
expect(hit).toBeNull();
});
it("records a pass and retrieves it as a cache hit", () => {
const treeSha = "deadbeef1234567890";
store.recordVerificationCachePass(treeSha, "pnpm test", "pnpm build", "FN-001");
const hit = store.getVerificationCacheHit(treeSha, "pnpm test", "pnpm build");
expect(hit).not.toBeNull();
expect(hit!.taskId).toBe("FN-001");
expect(new Date(hit!.recordedAt).toISOString()).toBe(hit!.recordedAt);
});
it("returns null for a different tree sha", () => {
store.recordVerificationCachePass("sha-a", "pnpm test", "", "FN-001");
const hit = store.getVerificationCacheHit("sha-b", "pnpm test", "");
expect(hit).toBeNull();
});
it("distinguishes entries by testCommand", () => {
const treeSha = "aabbccdd";
store.recordVerificationCachePass(treeSha, "pnpm test", "", "FN-001");
expect(store.getVerificationCacheHit(treeSha, "pnpm test", "")).not.toBeNull();
expect(store.getVerificationCacheHit(treeSha, "vitest run", "")).toBeNull();
});
it("distinguishes entries by buildCommand", () => {
const treeSha = "11223344";
store.recordVerificationCachePass(treeSha, "", "pnpm build", "FN-002");
expect(store.getVerificationCacheHit(treeSha, "", "pnpm build")).not.toBeNull();
expect(store.getVerificationCacheHit(treeSha, "", "tsc --noEmit")).toBeNull();
});
it("normalizes undefined to empty string for stable primary key", () => {
const treeSha = "normtest";
// Pass undefined-ish values (coerced via nullish fallback in impl)
store.recordVerificationCachePass(treeSha, "", "", "FN-003");
const hit = store.getVerificationCacheHit(treeSha, "", "");
expect(hit).not.toBeNull();
expect(hit!.taskId).toBe("FN-003");
});
it("overwrites an existing entry on re-record (INSERT OR REPLACE)", () => {
const treeSha = "upserttest";
store.recordVerificationCachePass(treeSha, "pnpm test", "", "FN-010");
store.recordVerificationCachePass(treeSha, "pnpm test", "", "FN-020");
const hit = store.getVerificationCacheHit(treeSha, "pnpm test", "");
expect(hit).not.toBeNull();
expect(hit!.taskId).toBe("FN-020");
});
});

8
packages/core/src/__tests__/insight-store.test.ts
View File

@@ -869,7 +869,7 @@ describe("Migration: pre-33 DB upgrade", () => {
// Step 1: Create a fresh database at v33 (runs all migrations up to 33)
const db1 = createDatabase(legacyDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(60);
expect(db1.getSchemaVersion()).toBe(61);
db1.close();
// Step 2: Manually downgrade to version 32 and drop insight tables
@@ -904,7 +904,7 @@ describe("Migration: pre-33 DB upgrade", () => {
expect(tableNamesBefore).not.toContain("project_insight_runs");
// Now run init — this triggers the v32→v33 migration
db3.init();
expect(db3.getSchemaVersion()).toBe(60);
expect(db3.getSchemaVersion()).toBe(61);
// Step 4: Verify insight tables exist after migration
const tablesAfter = db3.prepare(
@@ -935,12 +935,12 @@ describe("Migration: pre-33 DB upgrade", () => {
try {
const db1 = createDatabase(testDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(60);
expect(db1.getSchemaVersion()).toBe(61);
db1.close();
const db2 = createDatabase(testDir);
expect(() => db2.init()).not.toThrow();
expect(db2.getSchemaVersion()).toBe(60);
expect(db2.getSchemaVersion()).toBe(61);
db2.close();
} finally {
rmSync(testDir, { recursive: true, force: true });

2
packages/core/src/__tests__/mission-store.test.ts
View File

@@ -2629,7 +2629,7 @@ describe("MissionStore", () => {
describe("Loop State & Validator Run Schema (v31)", () => {
it("schema version is 40 after migration", () => {
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
});
it("mission_features table has loop state columns", () => {

2
packages/core/src/__tests__/roadmap-store.test.ts
View File

@@ -742,7 +742,7 @@ describe("RoadmapStore", () => {
describe("schema version", () => {
it("schema version is 40 after init", () => {
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
});
});

2
packages/core/src/__tests__/run-audit.test.ts
View File

@@ -465,7 +465,7 @@ describe("Run Audit", () => {
});
it("schema version is bumped to 40", () => {
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
});
});
});

2
packages/core/src/__tests__/task-documents.test.ts
View File

@@ -51,7 +51,7 @@ describe("TaskStore task documents", () => {
expect(tableNames.has("task_documents")).toBe(true);
expect(tableNames.has("task_document_revisions")).toBe(true);
expect(db.getSchemaVersion()).toBe(60);
expect(db.getSchemaVersion()).toBe(61);
const index = db
.prepare(