root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FN-5726: speed up copilot auth flow test in settings modal

Browse Source 
Reduce runtime overhead in the GitHub Copilot authentication test by replacing slower user-event timing with deterministic timer control.

- import `act` from Testing Library to flush async state transitions explicitly
- switch the Copilot login/copy/open interactions in the target test from `userEvent.click` to `fireEvent.click`
- wrap the flow in `vi.useFakeTimers()`/`vi.useRealTimers()` and advance timers directly instead of waiting with a 5s timeout
- keep existing assertions for clipboard writes, toast feedback, GitHub link opening, and login code expiry behavior

Files changed:
 .../components/__tests__/SettingsModal.test.tsx    | 47 ++++++++++++++--------
 1 file changed, 31 insertions(+), 16 deletions(-)

Fusion-Task-Id: FN-5726
Fusion-Task-Lineage: e9ccf2d0-d5a2-4568-abf5-7d9f7e67d643
This commit is contained in:
gsxdsm
2026-05-30 13:26:41 -07:00
parent 50cdcbf06d
commit d05d335da8
1 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
packages/dashboard/app/components/__tests__/SettingsModal.test.tsx
View File

@@ -1,6 +1,6 @@
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import type { ComponentProps } from "react";
import { render, screen, fireEvent, waitFor, within } from "@testing-library/react";
import { render, screen, fireEvent, waitFor, within, act } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { EditorView } from "@codemirror/view";
import { SettingsModal } from "../SettingsModal";
@@ -2096,26 +2096,41 @@ describe("SettingsModal", () => {
await waitForSettingsModalReady();
await userEvent.click(screen.getByRole("button", { name: "Authentication" }));
const copilotCard = screen.getByTestId("auth-provider-icon-github-copilot").closest(".auth-provider-card") as HTMLElement;
await userEvent.click(within(copilotCard).getByRole("button", { name: "Login" }));
vi.useFakeTimers();
expect(await within(copilotCard).findByText("ABCD-1234")).toBeInTheDocument();
expect(within(copilotCard).queryByTestId("auth-login-instructions-github-copilot")).not.toBeInTheDocument();
expect(openSpy).not.toHaveBeenCalled();
expect(writeText).toHaveBeenCalledWith("ABCD-1234");
expect(writeText).toHaveBeenCalledTimes(1);
try {
const copilotCard = screen.getByTestId("auth-provider-icon-github-copilot").closest(".auth-provider-card") as HTMLElement;
fireEvent.click(within(copilotCard).getByRole("button", { name: "Login" }));
await userEvent.click(within(copilotCard).getByRole("button", { name: "Copy code" }));
expect(writeText).toHaveBeenCalledWith("ABCD-1234");
expect(writeText).toHaveBeenCalledTimes(2);
expect(addToast).toHaveBeenCalledWith("Copied code to clipboard", "success");
await act(async () => {
await Promise.resolve();
});
expect(within(copilotCard).getByText("ABCD-1234")).toBeInTheDocument();
expect(within(copilotCard).queryByTestId("auth-login-instructions-github-copilot")).not.toBeInTheDocument();
expect(openSpy).not.toHaveBeenCalled();
expect(writeText).toHaveBeenCalledWith("ABCD-1234");
expect(writeText).toHaveBeenCalledTimes(1);
await userEvent.click(within(copilotCard).getByRole("button", { name: "Open GitHub" }));
expect(openSpy).toHaveBeenCalledWith("https://github.com/login/device", "_blank");
fireEvent.click(within(copilotCard).getByRole("button", { name: "Copy code" }));
await act(async () => {
await Promise.resolve();
});
expect(writeText).toHaveBeenCalledWith("ABCD-1234");
expect(writeText).toHaveBeenCalledTimes(2);
expect(addToast).toHaveBeenCalledWith("Copied code to clipboard", "success");
fireEvent.click(within(copilotCard).getByRole("button", { name: "Open GitHub" }));
expect(openSpy).toHaveBeenCalledWith("https://github.com/login/device", "_blank");
await act(async () => {
await vi.advanceTimersByTimeAsync(2000);
await vi.advanceTimersByTimeAsync(2000);
});
await waitFor(() => {
expect(within(copilotCard).queryByText("ABCD-1234")).not.toBeInTheDocument();
}, { timeout: 5000 });
} finally {
vi.useRealTimers();
}
});
it("uses execCommand fallback when clipboard API is unavailable", async () => {