root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-5575): merge fusion/fn-5575

Browse Source
This commit is contained in:
gsxdsm
2026-05-23 19:53:57 -07:00
parent a6a57dc40a
commit d7aec5d101
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/dashboard/src/__tests__/github-tracking-state.test.ts
View File

@@ -71,15 +71,22 @@ describe("decideIssueAction", () => {
expect(decideIssueAction("done", to)).toEqual({ action: "reopen", stateReason: "reopened" });
});
it("returns null for done -> archived", () => {
expect(decideIssueAction("done", "archived")).toBeNull();
it("closes on done -> archived", () => {
expect(decideIssueAction("done", "archived")).toEqual({ action: "close", stateReason: "completed" });
});
it("closes on in-review -> archived", () => {
expect(decideIssueAction("in-review", "archived")).toEqual({ action: "close", stateReason: "completed" });
});
it.each(["todo", "triage", "in-progress"] as const)("returns null for %s -> archived", (from) => {
expect(decideIssueAction(from, "archived")).toBeNull();
});
it.each([
["triage", "todo"],
["todo", "in-progress"],
["in-progress", "in-review"],
["in-review", "archived"],
["done", "done"],
["archived", "archived"],
] as const)("returns null for %s -> %s", (from, to) => {
@@ -145,14 +152,14 @@ describe("GitHubTrackingStateService", () => {
expect(store.logEntry).toHaveBeenCalledWith("FN-1", "Reopened linked GitHub tracking issue", "owner/repo#42");
});
it("does nothing for done -> archived", async () => {
it("closes on done -> archived", async () => {
service.start();
store.emit("task:moved", { task: createTask(), from: "done", to: "archived" });
await flushAsync();
expect(mockSetIssueState).not.toHaveBeenCalled();
expect(store.logEntry).not.toHaveBeenCalled();
expect(mockSetIssueState).toHaveBeenCalledWith("owner", "repo", 42, "closed", "completed");
expect(store.logEntry).toHaveBeenCalledWith("FN-1", "Closed linked GitHub tracking issue", "owner/repo#42");
});
it("does nothing for non-done transitions", async () => {

4
packages/dashboard/src/github-tracking-state.ts
View File

@@ -33,6 +33,10 @@ export function decideIssueAction(
return { action: "close", stateReason: "completed" };
}
if (to === "archived" && (from === "done" || from === "in-review")) {
return { action: "close", stateReason: "completed" };
}
if (from === "done" && to !== "done" && to !== "archived") {
return { action: "reopen", stateReason: "reopened" };
}