root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-3402): address shell connection feedback in NativeShellConnectionMa

Browse Source 
Addressed shell connection feedback for FN-3402 in Step 6, updating the NativeShellConnectionManager component and its test file with expanded test coverage and refinements based on review comments.

Fusion-Task-Id: FN-3402
This commit is contained in:
Fusion
2026-05-06 14:05:18 -07:00
committed by gsxdsm
parent bef30d6d55
commit d8f75202e9
2 changed files with 70 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
packages/dashboard/app/components/__tests__/NativeShellConnectionManager.test.tsx
View File

@@ -6,7 +6,13 @@ function createShellApi() {
return {
getState: vi.fn(),
listProfiles: vi.fn(),
saveProfile: vi.fn(async () => ({ id: "p1", name: "Prod", serverUrl: "https://fusion.example.com", createdAt: "", updatedAt: "" })),
saveProfile: vi.fn(async (input?: { id?: string }) => ({
id: input?.id ?? "p2",
name: "Prod",
serverUrl: "https://fusion.example.com",
createdAt: "",
updatedAt: "",
})),
deleteProfile: vi.fn(async () => undefined),
setActiveProfile: vi.fn(async () => ({ host: "mobile-shell", activeProfileId: "p1", profiles: [] })),
setDesktopMode: vi.fn(async () => ({ host: "desktop-shell", desktopMode: "remote", activeProfileId: null, profiles: [] })),
@@ -67,8 +73,30 @@ describe("NativeShellConnectionManager", () => {
fireEvent.click(screen.getByText("Save"));
await waitFor(() => {
expect(shellApi.saveProfile).toHaveBeenCalled();
expect(shellApi.saveProfile).toHaveBeenCalledWith(expect.objectContaining({ id: "p1", serverUrl: "https://next.example.com" }));
expect(shellApi.setActiveProfile).toHaveBeenCalledWith("p1");
});
});
it("adds a new connection", async () => {
const shellApi = createShellApi();
render(
<NativeShellConnectionManager
open={true}
shellApi={shellApi}
shellState={{ host: "mobile-shell", activeProfileId: "p1", profiles: [{ id: "p1", name: "Prod", serverUrl: "https://fusion.example.com", authToken: null, createdAt: "", updatedAt: "" }] }}
onClose={vi.fn()}
/>,
);
fireEvent.click(screen.getByText("Add connection"));
fireEvent.change(screen.getByLabelText("Name"), { target: { value: "Staging" } });
fireEvent.change(screen.getByLabelText("Server URL"), { target: { value: "https://staging.example.com" } });
fireEvent.click(screen.getByText("Save"));
await waitFor(() => {
expect(shellApi.saveProfile).toHaveBeenCalledWith(expect.objectContaining({ id: undefined, name: "Staging", serverUrl: "https://staging.example.com" }));
expect(shellApi.setActiveProfile).toHaveBeenCalledWith("p2");
});
});
});