root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1142 from plarson/fix/pending-review-not-failed

Browse Source 
fix(engine): do not fail tasks parked for pending review
This commit is contained in:
gsxdsm
2026-05-29 08:05:48 -07:00
committed by GitHub
parent b335f3d7c4 b5f2f91e87
commit dbfd71373a
4 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/engine/src/__tests__/executor-step-session.test.ts
View File

@@ -241,7 +241,7 @@ describe("Workflow Steps Execution", () => {
await executor.execute(baseTask as any);
expect(mockedCreateFnAgent).toHaveBeenCalledTimes(1);
expect(store.updateTask).toHaveBeenCalledWith("FN-5436-A", {
expect(store.updateTask).not.toHaveBeenCalledWith("FN-5436-A", {
status: "failed",
error: "executor-exit-while-review-pending",
});
@@ -253,7 +253,7 @@ describe("Workflow Steps Execution", () => {
undefined,
expect.objectContaining({ agentId: "executor" }),
);
expect(onError).toHaveBeenCalledWith(
expect(onError).not.toHaveBeenCalledWith(
expect.objectContaining({ id: "FN-5436-A" }),
expect.objectContaining({ message: "executor-exit-while-review-pending" }),
);
@@ -291,7 +291,7 @@ describe("Workflow Steps Execution", () => {
await executor.execute(baseTask as any);
expect(mockedCreateFnAgent).toHaveBeenCalledTimes(1);
expect(store.updateTask).toHaveBeenCalledWith("FN-5436-B", {
expect(store.updateTask).not.toHaveBeenCalledWith("FN-5436-B", {
status: "failed",
error: "executor-exit-while-review-pending",
});

2
packages/engine/src/__tests__/reliability-interactions/executor-pending-review-skip-retry.test.ts
View File

@@ -85,7 +85,7 @@ describe("reliability interactions: FN-5436 executor pending-review skip", () =>
const executor = new TaskExecutor(store as any, "/repo");
await executor.execute(task);
expect(store.updateTask).toHaveBeenCalledWith("FN-5436-RI-C", {
expect(store.updateTask).not.toHaveBeenCalledWith("FN-5436-RI-C", {
status: "failed",
error: "executor-exit-while-review-pending",
});

10
packages/engine/src/executor.ts
View File

@@ -4536,12 +4536,12 @@ export class TaskExecutor {
this.tokenUsageBaselines.delete(task.id);
session.dispose();
await this.persistTokenUsage(task.id);
await this.store.updateTask(task.id, {
status: "failed",
error: "executor-exit-while-review-pending",
});
// A pending-review block is not an execution failure. The executor
// cannot continue until the reviewer decision is resolved, so park
// the task in review without setting status=failed; otherwise the
// merge/review queue deadlocks on a task that is both in-review and
// failed.
await this.handoffTaskToReview(task, "executor-exit-while-review-pending");
this.options.onError?.(task, new Error("executor-exit-while-review-pending"));
pendingReviewParked = true;
break;
}