test(FN-4890): strengthen board-stall sweep assertions

Fusion-Task-Id: FN-4890
Fusion-Task-Lineage: d1ae6585-7df0-481f-83c3-c7cdd45daf4f

packages/engine/src/__tests__/reliability-interactions/board-stall-auto-recovery.test.ts

@@ -1,33 +1,87 @@
-import { describe, expect, it } from "vitest";
-import { makeReliabilityFixture } from "./_helpers.js";
+import { describe, expect, it, vi } from "vitest";
+import { EventEmitter } from "node:events";
+import type { Settings, Task, TaskStore } from "@fusion/core";
+import { SelfHealingManager } from "../../self-healing.js";
+
+function makeTask(id: string, overrides: Partial<Task> = {}): Task {
+  return {
+    id,
+    title: id,
+    description: id,
+    column: "todo",
+    dependencies: [],
+    steps: [],
+    currentStep: 0,
+    createdAt: new Date().toISOString(),
+    updatedAt: new Date().toISOString(),
+    log: [],
+    ...overrides,
+  } as Task;
+}
+
+function makeStore(tasks: Task[], settings: Partial<Settings> = {}) {
+  const byId = new Map(tasks.map((t) => [t.id, t]));
+  const audits: string[] = [];
+  const emitter = new EventEmitter();
+  const store = Object.assign(emitter, {
+    getSettings: vi.fn(async () => ({
+      globalPause: false,
+      enginePaused: false,
+      pausedScopeDecayMs: 60_000,
+      boardStallSweepWindowMs: 60_000,
+      boardStallBlockedGrowthThreshold: 1,
+      ...settings,
+    })),
+    listTasks: vi.fn(async ({ column, includeArchived }: any = {}) =>
+      [...byId.values()].filter((task) => {
+        if (column && task.column !== column) return false;
+        if (includeArchived === false && task.column === "archived") return false;
+        return true;
+      })),
+    moveTask: vi.fn(async (id: string, column: Task["column"], _opts?: any) => {
+      const prev = byId.get(id)!;
+      const next = { ...prev, column, paused: false, blockedBy: null, overlapBlockedBy: null } as Task;
+      byId.set(id, next);
+      return next;
+    }),
+    getTask: vi.fn(async (id: string) => byId.get(id)),
+    archiveTaskAndCleanup: vi.fn(async () => undefined),
+    logEntry: vi.fn(async () => undefined),
+    recordRunAuditEvent: vi.fn(async (event: any) => {
+      audits.push(event.mutationType);
+    }),
+  });
+  return { store: store as unknown as TaskStore & EventEmitter, byId, audits };
+}
 
 describe("reliability interactions: board stall auto-recovery", () => {
-  it("detects blocked growth and runs decay recovery", async () => {
-    const fixture = await makeReliabilityFixture({
-      taskId: "FN-4867",
-      task: {
-        column: "in-progress",
-        paused: true,
-        pausedReason: "waiting",
-        columnMovedAt: new Date(Date.now() - 1000).toISOString(),
-      },
-      settings: {
-        pausedScopeDecayMs: 60_000,
-        boardStallSweepWindowMs: 60_000,
-        boardStallBlockedGrowthThreshold: 1,
-      },
+  it("emits broken then unrecovered events and notifies once", async () => {
+    const holder = makeTask("FN-1", {
+      column: "in-progress",
+      paused: true,
+      pausedReason: "waiting",
+      columnMovedAt: new Date(Date.now() - 1_000).toISOString(),
+    });
+    const { store, byId, audits } = makeStore([holder]);
+    const notify = vi.fn(async () => undefined);
+    const manager = new SelfHealingManager(store, {
+      rootDir: process.cwd(),
+      getExecutingTaskIds: () => new Set(),
+      ntfyNotifier: { notifyBoardStallUnrecovered: notify },
     });
-    try {
-      await fixture.selfHeal.runBoardStallAutoRecoverySweep();
-      await fixture.store.createTask({ id: "FN-4901", title: "follower", description: "follower", column: "todo", blockedBy: "FN-4867", steps: [] } as any);
-      const first = await fixture.selfHeal.runBoardStallAutoRecoverySweep();
-      expect(first.recovered).toBeGreaterThanOrEqual(0);
 
-      (fixture.manager as any).maintenanceTickCounter++;
-      const second = await fixture.selfHeal.runBoardStallAutoRecoverySweep();
-      expect(typeof second.unrecovered).toBe("boolean");
-    } finally {
-      await fixture.cleanup();
-    }
+    await manager.runBoardStallAutoRecoverySweep();
+    byId.set("FN-2", makeTask("FN-2", { column: "todo", blockedBy: "FN-1" }));
+
+    const first = await manager.runBoardStallAutoRecoverySweep();
+    expect(first.recovered).toBe(1);
+    expect(audits).toContain("task:auto-board-stall-broken");
+    expect(notify).not.toHaveBeenCalled();
+
+    (manager as any).maintenanceTickCounter++;
+    const second = await manager.runBoardStallAutoRecoverySweep();
+    expect(second.unrecovered).toBe(true);
+    expect(audits).toContain("task:auto-board-stall-unrecovered");
+    expect(notify).toHaveBeenCalledTimes(1);
   });
 });