root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-1462): fix compact-and-retry path to not mark task as failed on successful recovery

Browse Source 
- Add return statement after successful context compaction and resume
- When compact-and-resume succeeds (promptWithFallback completes without error),
  executor now returns early instead of falling through to failure path
- This allows the finally block to clean up without marking the task as failed
- Add logging for recovery success and failure paths
- Add regression tests for context limit error detection
- Pattern is conservative: requires both 'context window' and 'exceeds' present
This commit is contained in:
gsxdsm
2026-04-10 03:05:41 -07:00
parent 3cb59159e5
commit e028a57bea
2 changed files with 86 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/engine/src/executor.ts
View File

@@ -1707,6 +1707,7 @@ export class TaskExecutor {
if (compactResult) {
this.loopRecoveryState.set(task.id, { attempts: loopAttempts + 1, pending: true });
executorLog.log(`${task.id} context compaction succeeded — resuming`);
await this.store.logEntry(task.id, "Context compaction succeeded — resuming execution", undefined, this.currentRunContext);
try {
this.options.stuckTaskDetector?.recordProgress(task.id);
@@ -1728,12 +1729,18 @@ export class TaskExecutor {
await promptWithFallback(activeEntry.session, "Continue working on the remaining steps.");
checkSessionError(activeEntry.session);
}
// Compact-and-resume succeeded — return to let the finally block clean up
// without marking the task as failed. The agent will continue execution
// and call task_done or complete implicitly.
return;
} catch (resumeErr: any) {
// Resume after context compaction failed — fall through to normal failure
executorLog.error(`${task.id} resume after context compaction failed: ${resumeErr.message}`);
await this.store.logEntry(task.id, `Resume after context compaction failed: ${resumeErr.message}`, undefined, this.currentRunContext);
}
} else {
executorLog.log(`${task.id} context compaction failed — falling through to normal failure`);
await this.store.logEntry(task.id, "Context compaction failed — proceeding to failure path", undefined, this.currentRunContext);
}
}
} else if (this.options.usageLimitPauser && isUsageLimitError(err.message)) {