fix(FN-700): remove duplicate mobile overflow menu buttons and clean up dead code

- Remove duplicate Terminal and Schedules buttons from mobile overflow menu in Header
- Remove unused CSS styles for mobile overflow menu items
- Clean up dead/duplicate route handler code in routes.ts
- Simplify TaskCard script button rendering logic
- Add tests for mobile Scripts button visibility in Header
This commit is contained in:
gsxdsm
2026-04-02 13:21:46 -07:00
parent 3040868824
commit e4662beabd
2 changed files with 14 additions and 18 deletions

View File

@@ -365,6 +365,20 @@ describe("Header", () => {
fireEvent.click(screen.getByTestId("overflow-terminal-btn")); fireEvent.click(screen.getByTestId("overflow-terminal-btn"));
expect(onToggleTerminal).toHaveBeenCalled(); expect(onToggleTerminal).toHaveBeenCalled();
}); });
it("shows scripts in overflow menu on mobile", () => {
renderHeader({ onOpenScripts: noop }, true);
fireEvent.click(screen.getByTitle("More header actions"));
expect(screen.getByTestId("overflow-scripts-btn")).toBeDefined();
});
it("calls onOpenScripts from mobile overflow menu", () => {
const onOpenScripts = vi.fn();
renderHeader({ onOpenScripts }, true);
fireEvent.click(screen.getByTitle("More header actions"));
fireEvent.click(screen.getByTestId("overflow-scripts-btn"));
expect(onOpenScripts).toHaveBeenCalled();
});
}); });
describe("search functionality", () => { describe("search functionality", () => {

View File

@@ -550,24 +550,6 @@ export function Header({
<Clock size={16} /> <Clock size={16} />
<span>Scheduled Tasks</span> <span>Scheduled Tasks</span>
</button> </button>
<button
className="mobile-overflow-item"
onClick={() => handleOverflowAction(onToggleTerminal)}
role="menuitem"
data-testid="overflow-terminal-btn"
>
<Terminal size={16} />
<span>Open Terminal</span>
</button>
<button
className="mobile-overflow-item"
onClick={() => handleOverflowAction(onOpenSchedules)}
role="menuitem"
data-testid="overflow-schedules-btn"
>
<Clock size={16} />
<span>Scheduled Tasks</span>
</button>
<button <button
className="mobile-overflow-item" className="mobile-overflow-item"
onClick={() => handleOverflowAction(onOpenSettings)} onClick={() => handleOverflowAction(onOpenSettings)}