root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

FN-6146: harden dashboard test mocks and request helper

Browse Source 
Stabilize dashboard tests against constructor and request-harness edge cases.

- update dashboard route and service tests to use constructor-safe mock implementations and reset targeted spies between cases
- make the test request helper resume its mock socket, always report successful writes, and preserve end callbacks
- tighten board workflow route assertions around explicit workflow-column flag disabling and cache-bounded slim task snapshots

Files changed:
 .../__tests__/auth-middleware-integration.test.ts  |  4 ++--
 .../src/__tests__/browse-directory-routes.test.ts  |  4 ++--
 packages/dashboard/src/__tests__/chat.test.ts      |  3 ++-
 .../src/__tests__/discovery-routes.test.ts         |  4 ++--
 .../src/__tests__/docker-node-routes.test.ts       |  4 ++--
 .../__tests__/experiment-routes.finalize.test.ts   |  2 +-
 .../src/__tests__/github-issue-comment.test.ts     |  4 ++--
 .../dashboard/src/__tests__/github-poll.test.ts    |  4 ++--
 .../__tests__/github-source-issue-close.test.ts    |  4 ++--
 .../github-source-issue-reconciler.test.ts         |  4 ++--
 .../src/__tests__/github-tracking-comments.test.ts |  4 ++--
 .../src/__tests__/github-tracking-delete.test.ts   |  4 ++--
 .../src/__tests__/github-tracking-hook.test.ts     |  4 ++--
 ...ithub-tracking-periodic-reconcile-sweep.test.ts | 12 +++++-----
 .../__tests__/github-tracking-reconciler.test.ts   |  4 ++--
 .../src/__tests__/github-tracking-state.test.ts    |  4 ++--
 .../src/__tests__/github-tracking-unlink.test.ts   |  4 ++--
 .../src/__tests__/github-tracking.test.ts          |  4 ++--
 .../dashboard/src/__tests__/mesh-routes.test.ts    |  4 ++--
 .../dashboard/src/__tests__/node-routes.test.ts    |  4 ++--
 .../src/__tests__/pi-extensions-routes.test.ts     | 10 ++++-----
 .../src/__tests__/plugin-routes.routes.test.ts     |  4 ++--
 .../dashboard/src/__tests__/plugin-routes.test.ts  |  4 ++--
 .../__tests__/project-pause-resume-routes.test.ts  |  4 ++--
 .../dashboard/src/__tests__/project-routes.test.ts |  4 ++--
 .../dashboard/src/__tests__/routes-agents.test.ts  |  4 ++--
 .../dashboard/src/__tests__/routes-auth.test.ts    |  6 +++--
 .../src/__tests__/routes-automation.test.ts        |  4 ++--
 .../dashboard/src/__tests__/routes-git.test.ts     |  4 ++--
 .../dashboard/src/__tests__/routes-github.test.ts  |  4 ++--
 .../src/__tests__/routes-planning-tracking.test.ts |  1 +
 .../src/__tests__/routes-planning.test.ts          |  4 ++--
 .../dashboard/src/__tests__/routes-proxy.test.ts   |  8 +++----
 .../src/__tests__/routes-settings.test.ts          |  4 ++--
 .../dashboard/src/__tests__/routes-system.test.ts  |  7 ++++--
 .../src/__tests__/routes-tasks-ops.test.ts         |  4 ++--
 .../dashboard/src/__tests__/routes-tasks.test.ts   |  4 ++--
 .../src/__tests__/session-resume-history.test.ts   |  1 +
 .../dashboard/src/__tests__/setup-routes.test.ts   |  8 +++----
 .../shared-branch-group-entry-points.test.ts       |  4 ++--
 .../routes/__tests__/board-workflows-route.test.ts | 26 +++++++++++++---------
 .../src/routes/__tests__/custom-providers.test.ts  |  4 ++--
 .../routes/__tests__/docker-node-routes.test.ts    |  4 ++--
 .../__tests__/register-docker-node-routes.test.ts  |  6 ++---
 .../register-docker-provisioning-routes.test.ts    | 10 ++++-----
 packages/dashboard/src/test-request.ts             |  7 ++++--
 46 files changed, 126 insertions(+), 109 deletions(-)

Fusion-Task-Id: FN-6146

Fusion-Task-Lineage: 989e9da3-92ed-43bd-a505-6114de4f1120
This commit is contained in:
gsxdsm
2026-06-09 20:08:18 -07:00
parent 03f1701cdf
commit edde74d568
46 changed files with 126 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/dashboard/src/__tests__/auth-middleware-integration.test.ts
View File

@@ -16,7 +16,7 @@ const mockClose = vi.fn().mockResolvedValue(undefined);
vi.mock("@fusion/core", async (importOriginal) => {
const { createCoreMock } = await import("../test/mockCoreEngine.js");
return createCoreMock(() => importOriginal<typeof import("@fusion/core")>(), {
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
getLocalNode: vi.fn().mockResolvedValue({
@@ -40,7 +40,7 @@ vi.mock("@fusion/core", async (importOriginal) => {
},
]),
updateNode: vi.fn().mockResolvedValue(undefined),
})),
}; }),
});
});

4
packages/dashboard/src/__tests__/browse-directory-routes.test.ts
View File

@@ -29,12 +29,12 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
listNodes: mockListNodes,
getNode: mockGetNode,
})),
}; }),
};
});

3
packages/dashboard/src/__tests__/chat.test.ts
View File

@@ -33,7 +33,8 @@ vi.mock("@fusion/core", () => ({
describe("resolveFileReferences", () => {
beforeEach(() => {
vi.clearAllMocks();
mockReadFile.mockReset();
mockStat.mockReset();
});
afterEach(() => {

4
packages/dashboard/src/__tests__/discovery-routes.test.ts
View File

@@ -18,7 +18,7 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
isDiscoveryActive: mockIsDiscoveryActive,
@@ -28,7 +28,7 @@ vi.mock("@fusion/core", async () => {
getDiscoveredNodes: mockGetDiscoveredNodes,
registerNode: mockRegisterNode,
checkNodeHealth: mockCheckNodeHealth,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/docker-node-routes.test.ts
View File

@@ -18,13 +18,13 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mocks.mockInit,
close: mocks.mockClose,
getNode: mocks.mockGetNode,
updateNode: mocks.mockUpdateNode,
registerNode: mocks.mockRegisterNode,
})),
}; }),
validateDockerNodeConfig: mocks.mockValidateDockerNodeConfig,
sanitizeDockerNodeConfigForResponse: mocks.mockSanitizeDockerNodeConfigForResponse,
};

2
packages/dashboard/src/__tests__/experiment-routes.finalize.test.ts
View File

@@ -23,7 +23,7 @@ const mockErrors = vi.hoisted(() => ({
vi.mock("@fusion/engine", () => ({
listCliAdapterDescriptors: () => [],
defaultGitOps: vi.fn(() => ({})),
ExperimentFinalizeService: vi.fn(() => ({ previewPlan: previewPlanMock, finalize: finalizeMock })),
ExperimentFinalizeService: vi.fn(function () { return { previewPlan: previewPlanMock, finalize: finalizeMock }; }),
ExperimentFinalizeStateError: mockErrors.StateError,
ExperimentFinalizeNoKeptRunsError: mockErrors.NoKeptError,
ExperimentFinalizePlanError: mockErrors.PlanError,

4
packages/dashboard/src/__tests__/github-issue-comment.test.ts
View File

@@ -8,9 +8,9 @@ const { mockCommentOnIssue } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
commentOnIssue: (...args: unknown[]) => mockCommentOnIssue(...args),
})),
}; }),
}));
class MockStore extends EventEmitter {

4
packages/dashboard/src/__tests__/github-poll.test.ts
View File

@@ -8,9 +8,9 @@ const { mockGetBadgeStatusesBatch } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
getBadgeStatusesBatch: (...args: any[]) => mockGetBadgeStatusesBatch(...args),
})),
}; }),
}));
describe("GitHubRateLimiter", () => {

4
packages/dashboard/src/__tests__/github-source-issue-close.test.ts
View File

@@ -13,10 +13,10 @@ const { mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
getIssue: (...args: unknown[]) => mockGetIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-source-issue-reconciler.test.ts
View File

@@ -12,10 +12,10 @@ const { mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
getIssue: (...args: unknown[]) => mockGetIssue(...args),
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking-comments.test.ts
View File

@@ -15,9 +15,9 @@ const { mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
commentOnIssue: (...args: unknown[]) => mockCommentOnIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking-delete.test.ts
View File

@@ -22,10 +22,10 @@ const { mockSetIssueState, mockGetIssue, mockResolveGithubTrackingAuth } = vi.ho
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
getIssue: (...args: unknown[]) => mockGetIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking-hook.test.ts
View File

@@ -11,9 +11,9 @@ const { mockCreateIssue, mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
createIssue: (...args: unknown[]) => mockCreateIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

12
packages/dashboard/src/__tests__/github-tracking-periodic-reconcile-sweep.test.ts
View File

@@ -10,24 +10,24 @@ const reconcileSourceIssues = vi.fn().mockResolvedValue({ scanned: 0, closed: 0,
vi.mock("../github-tracking-reconciler.js", () => ({
RECONCILE_SCAN_LIMIT: 200,
GitHubTrackingReconciler: vi.fn().mockImplementation(() => ({
GitHubTrackingReconciler: vi.fn().mockImplementation(function () { return {
reconcile,
reconcileDeletedAndArchived,
reconcileSourceIssues,
})),
}; }),
}));
vi.mock("../github-issue-comment.js", () => ({
GitHubIssueCommentService: vi.fn().mockImplementation(() => ({ start: vi.fn(), stop: vi.fn() })),
GitHubIssueCommentService: vi.fn().mockImplementation(function () { return { start: vi.fn(), stop: vi.fn() }; }),
}));
vi.mock("../github-tracking-comments.js", () => ({
GitHubTrackingCommentService: vi.fn().mockImplementation(() => ({ start: vi.fn(), stop: vi.fn() })),
GitHubTrackingCommentService: vi.fn().mockImplementation(function () { return { start: vi.fn(), stop: vi.fn() }; }),
}));
vi.mock("../github-source-issue-close.js", () => ({
GitHubSourceIssueCloseService: vi.fn().mockImplementation(() => ({ start: vi.fn(), stop: vi.fn(), attach: vi.fn(), detach: vi.fn() })),
GitHubSourceIssueCloseService: vi.fn().mockImplementation(function () { return { start: vi.fn(), stop: vi.fn(), attach: vi.fn(), detach: vi.fn() }; }),
}));
vi.mock("../github-tracking-state.js", () => ({
GitHubTrackingStateService: vi.fn().mockImplementation(() => ({ start: vi.fn(), stop: vi.fn(), attach: vi.fn(), detach: vi.fn() })),
GitHubTrackingStateService: vi.fn().mockImplementation(function () { return { start: vi.fn(), stop: vi.fn(), attach: vi.fn(), detach: vi.fn() }; }),
}));
function createStore(): TaskStore {

4
packages/dashboard/src/__tests__/github-tracking-reconciler.test.ts
View File

@@ -12,10 +12,10 @@ const { mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
getIssue: (...args: unknown[]) => mockGetIssue(...args),
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking-state.test.ts
View File

@@ -14,11 +14,11 @@ const { mockResolveGithubTrackingAuth } = vi.hoisted(() => ({
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
deleteIssue: (...args: unknown[]) => mockDeleteIssue(...args),
getIssue: (...args: unknown[]) => mockGetIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking-unlink.test.ts
View File

@@ -15,11 +15,11 @@ const { mockCommentOnIssue, mockSetIssueState, mockGetIssue, mockResolveGithubTr
}));
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
commentOnIssue: (...args: unknown[]) => mockCommentOnIssue(...args),
setIssueState: (...args: unknown[]) => mockSetIssueState(...args),
getIssue: (...args: unknown[]) => mockGetIssue(...args),
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/github-tracking.test.ts
View File

@@ -15,10 +15,10 @@ vi.mock("@fusion/core", async () => {
});
vi.mock("../github.js", () => ({
GitHubClient: vi.fn().mockImplementation(() => ({
GitHubClient: vi.fn().mockImplementation(function () { return {
createIssue: createIssueMock,
searchIssues: searchIssuesMock,
})),
}; }),
}));
vi.mock("../github-auth.js", () => ({

4
packages/dashboard/src/__tests__/mesh-routes.test.ts
View File

@@ -42,7 +42,7 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
mergePeers: mockMergePeers,
@@ -55,7 +55,7 @@ vi.mock("@fusion/core", async () => {
getLocalMeshSnapshot: mockGetLocalMeshSnapshot,
getSettingsForSync: mockGetSettingsForSync,
applyRemoteSettings: mockApplyRemoteSettings,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/node-routes.test.ts
View File

@@ -26,7 +26,7 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
listNodes: mockListNodes,
@@ -53,7 +53,7 @@ vi.mock("@fusion/core", async () => {
syncPlugins: mockSyncPlugins,
checkVersionCompatibility: mockCheckVersionCompatibility,
listProjectNodePathMappingsForNode: mockListProjectNodePathMappingsForNode,
})),
}; }),
};
});

10
packages/dashboard/src/__tests__/pi-extensions-routes.test.ts
View File

@@ -27,7 +27,7 @@ vi.mock("@earendil-works/pi-coding-agent", () => ({
create: vi.fn(() => mockSettingsManager),
},
getAgentDir: vi.fn(() => "/fake/agent/dir"),
DefaultPackageManager: vi.fn().mockImplementation(() => mockPackageManager),
DefaultPackageManager: vi.fn().mockImplementation(function () { return mockPackageManager; }),
}));
// Minimal store implementation for the test server
@@ -273,10 +273,10 @@ describe("Pi settings routes", () => {
it("returns 500 when install throws", async () => {
const { DefaultPackageManager } = await import("@earendil-works/pi-coding-agent");
vi.mocked(DefaultPackageManager).mockImplementationOnce(() => ({
vi.mocked(DefaultPackageManager).mockImplementationOnce(function () { return {
install: vi.fn().mockRejectedValue(new Error("Install failed")),
addSourceToSettings: vi.fn().mockReturnValue(true),
}));
}; });
const res = await request(app, "POST", "/api/pi-settings/packages",
JSON.stringify({ source: "npm:failing-package" }),
@@ -288,10 +288,10 @@ describe("Pi settings routes", () => {
it("returns success when addSourceToSettings returns false (already configured)", async () => {
const { DefaultPackageManager } = await import("@earendil-works/pi-coding-agent");
vi.mocked(DefaultPackageManager).mockImplementationOnce(() => ({
vi.mocked(DefaultPackageManager).mockImplementationOnce(function () { return {
install: vi.fn().mockResolvedValue(undefined),
addSourceToSettings: vi.fn().mockReturnValue(false),
}));
}; });
const res = await request(app, "POST", "/api/pi-settings/packages",
JSON.stringify({ source: "npm:already-configured" }),

4
packages/dashboard/src/__tests__/plugin-routes.routes.test.ts
View File

@@ -19,10 +19,10 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/plugin-routes.test.ts
View File

@@ -34,10 +34,10 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/project-pause-resume-routes.test.ts
View File

@@ -20,7 +20,7 @@ vi.mock("@fusion/core", async () => {
return {
...actual,
isGhAuthenticated: vi.fn(),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
@@ -28,7 +28,7 @@ vi.mock("@fusion/core", async () => {
getProject: mockCentralGetProject,
updateProject: mockCentralUpdateProject,
updateProjectHealth: mockCentralUpdateProjectHealth,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/project-routes.test.ts
View File

@@ -146,7 +146,7 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
listProjects: mockListProjects,
@@ -166,7 +166,7 @@ vi.mock("@fusion/core", async () => {
getProjectNodePathMapping: mockGetProjectNodePathMapping,
upsertProjectNodePathMapping: mockUpsertProjectNodePathMapping,
removeProjectNodePathMapping: mockRemoveProjectNodePathMapping,
})),
}; }),
ensureMemoryFileWithBackend: mockEnsureMemoryFileWithBackend,
readProjectIdentity: mockReadProjectIdentity,
writeProjectIdentity: mockWriteProjectIdentity,

4
packages/dashboard/src/__tests__/routes-agents.test.ts
View File

@@ -101,12 +101,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

6
packages/dashboard/src/__tests__/routes-auth.test.ts
View File

@@ -120,12 +120,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});
@@ -1177,6 +1177,7 @@ describe("Droid CLI auth routes", () => {
it("POST /auth/cursor-cli disables without probing binary", async () => {
const probeSpy = vi.spyOn(runtimeProviderProbesModule, "probeCursorCliProvider");
probeSpy.mockClear();
store.updateGlobalSettings = vi.fn().mockResolvedValue({ useCursorCli: false });
const res = await REQUEST(buildApp(), "POST", "/api/auth/cursor-cli", JSON.stringify({ enabled: false }), {
@@ -3757,6 +3758,7 @@ describe("llama.cpp auth routes", () => {
it("disabling works without probing the server", async () => {
const probeSpy = vi.spyOn(llamaCppProbeModule, "probeLlamaCpp");
probeSpy.mockClear();
const res = await REQUEST(buildApp(), "POST", "/api/auth/llama-cpp", JSON.stringify({ enabled: false }), {
"content-type": "application/json",

4
packages/dashboard/src/__tests__/routes-automation.test.ts
View File

@@ -99,12 +99,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

4
packages/dashboard/src/__tests__/routes-git.test.ts
View File

@@ -100,12 +100,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

4
packages/dashboard/src/__tests__/routes-github.test.ts
View File

@@ -99,12 +99,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

1
packages/dashboard/src/__tests__/routes-planning-tracking.test.ts
View File

@@ -170,6 +170,7 @@ describe("planning routes github tracking background dispatch", () => {
});
createIssueSpy = vi.spyOn(GitHubClient.prototype, "createIssue");
createIssueSpy.mockReset();
});
afterEach(() => {

4
packages/dashboard/src/__tests__/routes-planning.test.ts
View File

@@ -105,12 +105,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

8
packages/dashboard/src/__tests__/routes-proxy.test.ts
View File

@@ -13,11 +13,11 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
getNode: mockGetNode,
})),
}; }),
};
});
@@ -114,11 +114,11 @@ describe("Node proxy routes", () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockInit,
close: mockClose,
getNode: mockGetNode,
})),
}; }),
};
});
});

4
packages/dashboard/src/__tests__/routes-settings.test.ts
View File

@@ -100,12 +100,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

7
packages/dashboard/src/__tests__/routes-system.test.ts
View File

@@ -108,12 +108,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});
@@ -529,6 +529,8 @@ describe("GET /api/system-stats", () => {
);
const initSpy = vi.spyOn(AgentStore.prototype, "init").mockResolvedValue(undefined);
const listAgentsSpy = vi.spyOn(AgentStore.prototype, "listAgents").mockResolvedValue([]);
initSpy.mockClear();
listAgentsSpy.mockClear();
const res = await GET(buildApp(defaultStore), `/api/system-stats?projectId=${projectId}`);
@@ -710,6 +712,7 @@ describe("routes/context project scoping helpers", () => {
const store = createMockStore();
const req = { query: {}, body: {} } as unknown as express.Request;
const getOrCreateSpy = vi.spyOn(projectStoreResolver, "getOrCreateProjectStore");
getOrCreateSpy.mockClear();
const scopedStore = await resolveRouteScopedStore(req, store);

4
packages/dashboard/src/__tests__/routes-tasks-ops.test.ts
View File

@@ -99,12 +99,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
});
});

4
packages/dashboard/src/__tests__/routes-tasks.test.ts
View File

@@ -101,14 +101,14 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
getLocalNode: mockCentralGetLocalNode,
listNodes: mockCentralListNodes,
})),
}; }),
});
});

1
packages/dashboard/src/__tests__/session-resume-history.test.ts
View File

@@ -39,6 +39,7 @@ const { mockCreateFnAgent } = vi.hoisted(() => ({
vi.mock("@fusion/engine", () => ({
listCliAdapterDescriptors: () => [],
createWorkflowAuthoringTools: vi.fn(() => []),
createFnAgent: mockCreateFnAgent,
}));

8
packages/dashboard/src/__tests__/setup-routes.test.ts
View File

@@ -19,17 +19,17 @@ vi.mock("@fusion/core", async () => {
return {
...actual,
isGhAuthenticated: vi.fn(),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
getGlobalDir: mockCentralGetGlobalDir,
})),
FirstRunDetector: vi.fn().mockImplementation(() => ({
}; }),
FirstRunDetector: vi.fn().mockImplementation(function () { return {
detectExistingProjects: mockDetectorDetectExistingProjects,
detectFirstRunState: mockDetectorDetectFirstRunState,
hasCentralDb: mockDetectorHasCentralDb,
})),
}; }),
};
});

4
packages/dashboard/src/__tests__/shared-branch-group-entry-points.test.ts
View File

@@ -47,12 +47,12 @@ vi.mock("@fusion/core", async (importOriginal) => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: vi.fn().mockResolvedValue(undefined),
close: vi.fn().mockResolvedValue(undefined),
listProjects: vi.fn().mockResolvedValue([]),
reconcileProjectStatuses: vi.fn().mockResolvedValue(undefined),
})),
}; }),
});
});

26
packages/dashboard/src/routes/__tests__/board-workflows-route.test.ts
View File

@@ -85,7 +85,9 @@ describe("GET /tasks/board-workflows", () => {
const get = (path: string) => REQUEST(app, "GET", path);
it("flag OFF → { flagEnabled: false } legacy shape", async () => {
// Even with tasks on the board, flag-OFF returns the empty single-lane shape.
// Even with tasks on the board, an explicitly-disabled flag returns the empty
// single-lane shape regardless of the project's default feature policy.
await store.updateGlobalSettings({ experimentalFeatures: { workflowColumns: false } });
await store.createTask({ description: "card" });
const res = await get("/api/tasks/board-workflows");
expect(res.status).toBe(200);
@@ -187,16 +189,17 @@ describe("GET /tasks/board-workflows", () => {
expect((customLane?.columns.length ?? 0)).toBeGreaterThan(0);
});
it("REGRESSION (FN-1414 finding): non-watching store + stale slim memo → route reports empty taskWorkflowIds for a populated board", async () => {
it("REGRESSION (FN-1414 finding): non-watching store slim memo never exceeds the full board snapshot", async () => {
// PRODUCTION BUG CAPTURED (report only — prod owned by another agent):
// TaskStore.listTasks({ slim: true }) is memoized for 2.5s whenever the store
// is NOT watching (startupSlimListMemo, store.ts ~L4902). The board-workflows
// route reads listTasks({ slim: true, includeArchived: false }); if an earlier
// slim read memoized an empty/stale list, the route returns an empty
// taskWorkflowIds even though the board has cards. A watching dashboard store
// disables the memo, so this primarily bites non-watching contexts (and the
// 2.5s window right after boot). We assert the OBSERVED behavior so the suite
// stays green and the discrepancy is documented.
// slim read memoized an empty/stale list, the route can return stale
// taskWorkflowIds even though the board has newer cards. A watching dashboard
// store disables the memo, so this primarily bites non-watching contexts (and
// the 2.5s window right after boot). The exact cache-expiry boundary is
// wall-clock based, so assert the deterministic invariant instead: slim reads
// may be stale or fresh, but they must never report more cards than full reads.
await store.updateGlobalSettings({ experimentalFeatures: { workflowColumns: true } });
await store.createTask({ description: "card" });
// Prime the slim memo with the current (single-card) snapshot, then add a card.
@@ -205,9 +208,12 @@ describe("GET /tasks/board-workflows", () => {
const slimAfter = await store.listTasks({ slim: true, includeArchived: false });
const fullAfter = await store.listTasks({ includeArchived: false });
// The non-slim read sees both cards; the memoized slim read is stale.
// The non-slim read sees both cards. Depending on wall-clock cache expiry,
// the second slim read can be stale (matching slimBefore) or fresh (matching
// fullAfter), but it must remain bounded by the full source of truth.
expect(slimBefore.length).toBe(1);
expect(fullAfter.length).toBe(2);
expect(slimAfter.length).toBe(slimBefore.length); // stale — second card not visible
expect(slimAfter.length).toBeLessThan(fullAfter.length);
expect(slimAfter.length).toBeGreaterThanOrEqual(slimBefore.length);
expect(slimAfter.length).toBeLessThanOrEqual(fullAfter.length);
});
});

4
packages/dashboard/src/routes/__tests__/custom-providers.test.ts
View File

@@ -18,12 +18,12 @@ vi.mock("@fusion/core", async () => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
reconcileProjectStatuses: mockCentralReconcileProjectStatuses,
})),
}; }),
};
});

4
packages/dashboard/src/routes/__tests__/docker-node-routes.test.ts
View File

@@ -21,7 +21,7 @@ vi.mock("@fusion/core", async () => {
isGhAvailable: vi.fn(),
isGhAuthenticated: vi.fn(),
isQmdAvailable: vi.fn().mockResolvedValue(false),
CentralCore: vi.fn().mockImplementation(() => ({
CentralCore: vi.fn().mockImplementation(function () { return {
init: mockCentralInit,
close: mockCentralClose,
listProjects: mockCentralListProjects,
@@ -29,7 +29,7 @@ vi.mock("@fusion/core", async () => {
listManagedDockerNodes: mockListManagedDockerNodes,
createManagedDockerNode: mockCreateManagedDockerNode,
getManagedDockerNode: mockGetManagedDockerNode,
})),
}; }),
};
});

6
packages/dashboard/src/routes/__tests__/register-docker-node-routes.test.ts
View File

@@ -34,9 +34,9 @@ vi.mock("@fusion/core", async () => {
const actual = await vi.importActual<typeof import("@fusion/core")>("@fusion/core");
return {
...actual,
DockerClientService: vi.fn().mockImplementation(() => service),
CentralCore: vi.fn().mockImplementation(() => mockCentralInstance),
MeshConfigGenerator: vi.fn().mockImplementation(() => mockGeneratorInstance),
DockerClientService: vi.fn().mockImplementation(function () { return service; }),
CentralCore: vi.fn().mockImplementation(function () { return mockCentralInstance; }),
MeshConfigGenerator: vi.fn().mockImplementation(function () { return mockGeneratorInstance; }),
};
});

10
packages/dashboard/src/routes/__tests__/register-docker-provisioning-routes.test.ts
View File

@@ -26,16 +26,16 @@ const dockerClientServiceMock = {
vi.mock("@fusion/core", async (importOriginal) => ({
...(await importOriginal<typeof import("@fusion/core")>()),
DockerProvisioningService: vi.fn().mockImplementation(() => ({
DockerProvisioningService: vi.fn().mockImplementation(function () { return {
provision: provisionMock,
deprovision: deprovisionMock,
startContainer: startContainerMock,
stopContainer: stopContainerMock,
restartContainer: restartContainerMock,
getContainerStatus: getContainerStatusMock,
})),
DockerClientService: vi.fn().mockImplementation(() => dockerClientServiceMock),
CentralCore: vi.fn().mockImplementation(() => ({
}; }),
DockerClientService: vi.fn().mockImplementation(function () { return dockerClientServiceMock; }),
CentralCore: vi.fn().mockImplementation(function () { return {
init: initMock,
close: closeMock,
registerNode: registerNodeMock,
@@ -43,7 +43,7 @@ vi.mock("@fusion/core", async (importOriginal) => ({
updateManagedDockerNode: updateManagedDockerNodeMock,
listManagedDockerNodes: listManagedDockerNodesMock,
deleteManagedDockerNode: deleteManagedDockerNodeMock,
})),
}; }),
deterministicGuardLocks: new Map(),
}));

7
packages/dashboard/src/test-request.ts
View File

@@ -46,6 +46,7 @@ export async function request(
): Promise<TestResponse> {
const normalizedBody = normalizeBody(body);
const socket = new MockSocket();
socket.resume();
const req = new http.IncomingMessage(socket as unknown as Socket);
const res = new http.ServerResponse(req);
const chunks: Buffer[] = [];
@@ -68,14 +69,16 @@ export async function request(
res.write = ((chunk: string | Buffer, encoding?: BufferEncoding | ((error?: Error | null) => void), cb?: (error?: Error | null) => void) => {
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk, typeof encoding === "string" ? encoding : undefined));
return originalWrite(chunk as never, encoding as never, cb);
originalWrite(chunk as never, encoding as never, cb);
return true;
}) as typeof res.write;
res.end = ((chunk?: string | Buffer, encoding?: BufferEncoding | (() => void), cb?: () => void) => {
if (chunk !== undefined) {
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk, typeof encoding === "string" ? encoding : undefined));
}
return originalEnd(chunk as never, encoding as never, cb as never);
const callback = typeof encoding === "function" ? encoding : cb;
return originalEnd(chunk as never, encoding as never, callback as never);
}) as typeof res.end;
const response = new Promise<TestResponse>((resolve, reject) => {