root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(engine): route review via explicit external checkout metadata

Browse Source
This commit is contained in:
Phil Larson
2026-07-01 16:26:54 -07:00
parent 20e42c65d1
commit f76d2f3609
4 changed files with 434 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/engine/src/executor.ts
View File

@@ -6363,6 +6363,18 @@ export class TaskExecutor {
// Worktree isolation (KTD-11): review the instance's OWN worktree when set.
const worktreePath = active.worktreePath || detail.worktree || this.rootDir;
const reviewCwd = resolveReviewCheckoutCwd(detail, worktreePath);
// Make the actual review target visible: explicit
// sourceMetadata.externalReviewCheckout routes review to an external
// checkout; without valid metadata, review defaults to the task worktree.
if (reviewCwd !== worktreePath) {
reviewerLog.log(`${seamTask.id}: review routed to external checkout ${reviewCwd} (task worktree: ${worktreePath})`);
} else {
const sm = detail.sourceMetadata as Record<string, unknown> | undefined;
const hasExternalMeta = sm && typeof sm.externalReviewCheckout === "string" && sm.externalReviewCheckout.trim();
if (hasExternalMeta) {
reviewerLog.warn(`${seamTask.id}: external review checkout metadata present (${sm!.externalReviewCheckout}) but invalid — reviewing task worktree ${worktreePath}`);
}
}
const stepName = detail.steps[stepIndex]?.name ?? `Step ${stepIndex}`;
const promptContent = detail.prompt ?? "";
const userComments = selectUserCommentsForAgentContext(detail, { limit: null });
@@ -12979,6 +12991,18 @@ export class TaskExecutor {
const userComments = selectUserCommentsForAgentContext(latestDetailForReview, { limit: null });
const settings = await mergeEffectiveSettings(store, latestDetailForReview, await store.getSettings());
const reviewCwd = resolveReviewCheckoutCwd(latestDetailForReview, worktreePath);
// Make the actual review target visible: explicit
// sourceMetadata.externalReviewCheckout routes review to an external
// checkout; without valid metadata, review defaults to the task worktree.
if (reviewCwd !== worktreePath) {
reviewerLog.log(`${taskId}: review routed to external checkout ${reviewCwd} (task worktree: ${worktreePath})`);
} else {
const sm = latestDetailForReview.sourceMetadata as Record<string, unknown> | undefined;
const hasExternalMeta = sm && typeof sm.externalReviewCheckout === "string" && sm.externalReviewCheckout.trim();
if (hasExternalMeta) {
reviewerLog.warn(`${taskId}: external review checkout metadata present (${sm!.externalReviewCheckout}) but invalid — reviewing task worktree ${worktreePath}`);
}
}
// Run the reviewer via semaphore.runNested so its slot accounting
// is honest: activeCount transiently bumps to reflect the second
// agent session, but the reviewer doesn't enter the wait queue