From f8fb9b1473dbebf3e68c6ab5255e7d433a936b00 Mon Sep 17 00:00:00 2001
From: gsxdsm <gsxdsm@users.noreply.github.com>
Date: Fri, 31 Jul 2026 07:59:02 -0700
Subject: [PATCH] test(engine): pin the unmet-dependency rebound on a renamed
 board (11th resolver from the coverage map) (#3176)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Eleventh resolver from the verified coverage map on #3115.

`unmetDepReviewColumns` was uncovered: the existing FN-6778/FN-6779 case
uses `in-review`, where the literal is correct, so blinding the resolver
left the file green.

## What the literal costs

The sweep selects **no card**. A review card whose dependency is still
unmet is never rebounded — it sits in review, **eligible for merge,
ahead of the work it depends on**. That is precisely the ordering
violation this sweep exists to prevent, and it fails silently: no error,
no audit event, nothing to notice.

## Measured

3 pass; blinding `unmetDepReviewColumns` fails exactly the new case.

## Map status

**11 of 26 resolvers pinned** across 10 merged PRs. The remaining 15
need real harness work — I threw away two probes earlier today that
passed while proving nothing (`reconcileInReviewBranchRebind` never
entered its loop; `recoverAgentsRunningOnInactiveTasks` stayed green
under both blindings), and recorded them on #3164 rather than shipping
green decoration.

## Verification

`in-review-unmet-dependency-reconcile` **3 passed** · `pnpm test:gate`
full pass · lint — green.
---
 ...-review-unmet-dependency-reconcile.test.ts | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/packages/engine/src/__tests__/in-review-unmet-dependency-reconcile.test.ts b/packages/engine/src/__tests__/in-review-unmet-dependency-reconcile.test.ts
index ea80dba476..af3e79b487 100644
--- a/packages/engine/src/__tests__/in-review-unmet-dependency-reconcile.test.ts
+++ b/packages/engine/src/__tests__/in-review-unmet-dependency-reconcile.test.ts
@@ -88,6 +88,40 @@ describe("in-review unmet dependency reconciliation", () => {
     executingTaskLock._clearForTest();
   });
 
+  /*
+  FNXC:WorkflowResolvedColumns 2026-07-31-16:20:
+  `unmetDepReviewColumns` was UNCOVERED on the #3115 map. The case below uses `in-review`, where the
+  literal is correct, so blinding the resolver leaves it green.
+
+  What that costs on a renamed board: the sweep selects NO card, so a review card whose dependency is
+  still unmet is never rebounded — it sits in review, eligible for merge, ahead of work it depends on.
+  That is the ordering violation this sweep exists to prevent.
+  */
+  it("rebounds a card resting in a RENAMED review lane whose dependency is unmet", async () => {
+    const { store, tasks } = createStore([
+      task({ id: "FN-R", column: "checking", dependencies: ["FN-D"] }),
+      task({ id: "FN-D", column: "building" }),
+    ]);
+    (store as unknown as { listWorkflowDefinitions: unknown }).listWorkflowDefinitions = vi.fn(async () => [{
+      ir: {
+        version: "v2",
+        id: "custom:renamed",
+        nodes: [],
+        edges: [],
+        columns: [
+          { id: "drafting", name: "drafting", traits: [{ trait: "hold", config: { release: "capacity" } }] },
+          { id: "building", name: "building", traits: [{ trait: "wip", config: { limitSetting: "maxConcurrent" } }] },
+          { id: "checking", name: "checking", traits: [{ trait: "merge" }] },
+        ],
+      },
+    }]);
+    const manager = new SelfHealingManager(store, { rootDir: "/tmp/test-project" });
+
+    await expect(manager.reconcileInReviewUnmetDependencies()).resolves.toBe(1);
+    expect(tasks.get("FN-R")).toMatchObject({ status: "queued", blockedBy: "FN-D" });
+    manager.stop();
+  });
+
   it("reproduces FN-6778/FN-6779 review advancement and rebounds to queued todo", async () => {
     const { store, tasks } = createStore([
       task({ id: "FN-6778", column: "in-review", dependencies: ["FN-6777"] }),