fix(FN-4201): add autosize regression coverage and finalize gates

Fusion-Task-Id: FN-4201
Fusion-Task-Lineage: 6bfc2e72-8c11-4e63-b3c7-9245965d2380
This commit is contained in:
Fusion
2026-05-13 03:29:19 -07:00
committed by gsxdsm
parent 600d634a09
commit fcd70d4c07
4 changed files with 234 additions and 2 deletions

View File

@@ -0,0 +1,5 @@
---
"@runfusion/fusion": patch
---
Reset ChatView composer autosize when `messageInput` changes programmatically so send/clear and draft restore paths collapse or clamp textarea height correctly.

View File

@@ -3081,6 +3081,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
const activeTasks = await Promise.all((rows as unknown as TaskRow[]).map(async (row) => {
const task = this.rowToTask(row);
task.inReviewStall = getInReviewStallReason(task, { now });
task.stalledReview = detectStalledReview(task, { now });
// Slim path: aggregate the timed-execution total server-side, then
// strip the heavy log payload from the wire response. Without this

View File

@@ -1,6 +1,5 @@
import type { StalledReviewSignal } from "./stalled-review-detector.js";
import type { InReviewStallSignal } from "./in-review-stall.js";
import type { StalledReviewSignal } from "./stalled-review-detector.js";
/** Valid thinking effort levels for AI agent sessions, controlling the cost/quality tradeoff of reasoning. */
export const THINKING_LEVELS = ["off", "minimal", "low", "medium", "high"] as const;
@@ -1202,6 +1201,8 @@ export interface Task {
/** Server-computed in-review stall signal. Undefined when no stall rule matches.
* Diagnostic-only: must not be used as an auto-completion signal. */
inReviewStall?: InReviewStallSignal;
/** Heuristic stalled-review diagnostic signal (legacy compatibility contract). */
stalledReview?: StalledReviewSignal;
/** Durable aggregate token usage totals for the task. Undefined when no usage has been recorded yet. */
tokenUsage?: TaskTokenUsage;
size?: "S" | "M" | "L";

View File

@@ -0,0 +1,225 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import { render, screen, waitFor } from "@testing-library/react";
import { userEvent } from "@testing-library/user-event";
import { ChatView, clampChatInputHeight } from "../ChatView";
import * as useChatModule from "../../hooks/useChat";
import * as useChatRoomsModule from "../../hooks/useChatRooms";
import type { ChatSessionInfo, UseChatReturn } from "../../hooks/useChat";
import type { UseChatRoomsResult } from "../../hooks/useChatRooms";
import { _resetInitialViewportHeight } from "../../hooks/useMobileKeyboard";
Element.prototype.scrollIntoView = vi.fn();
vi.mock("../../hooks/useChat");
vi.mock("../../hooks/useChatRooms");
vi.mock("../../hooks/useNavigationHistory", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../hooks/useNavigationHistory")>();
return {
...actual,
useNavigationHistoryContext: () => ({ pushNav: vi.fn(), replaceCurrent: vi.fn() }),
};
});
vi.mock("../../api", async (importOriginal) => {
const actual = await importOriginal<typeof import("../../api")>();
return {
...actual,
fetchAgents: vi.fn().mockResolvedValue([]),
fetchDiscoveredSkills: vi.fn().mockResolvedValue([]),
searchFiles: vi.fn().mockResolvedValue({ files: [] }),
};
});
const mockUseChat = vi.mocked(useChatModule.useChat);
const mockUseChatRooms = vi.mocked(useChatRoomsModule.useChatRooms);
const sessionOne: ChatSessionInfo = {
id: "session-001",
agentId: "agent-001",
status: "active",
title: "Session One",
createdAt: "2026-04-08T00:00:00.000Z",
updatedAt: "2026-04-08T00:00:00.000Z",
};
const sessionTwo: ChatSessionInfo = {
...sessionOne,
id: "session-002",
title: "Session Two",
};
const roomOne = {
id: "room-001",
name: "Room One",
slug: "room-one",
description: null,
projectId: "proj-123",
createdBy: "agent-001",
status: "active" as const,
createdAt: "2026-04-08T00:00:00.000Z",
updatedAt: "2026-04-08T00:00:00.000Z",
};
const defaultChatState: UseChatReturn = {
sessions: [sessionOne, sessionTwo],
activeSession: sessionOne,
sessionsLoading: false,
messages: [],
messagesLoading: false,
isStreaming: false,
streamingText: "",
streamingThinking: "",
streamingToolCalls: [],
selectSession: vi.fn(),
createSession: vi.fn().mockResolvedValue(sessionTwo),
archiveSession: vi.fn(),
deleteSession: vi.fn(),
sendMessage: vi.fn(),
stopStreaming: vi.fn(),
pendingMessage: "",
clearPendingMessage: vi.fn(),
loadMoreMessages: vi.fn(),
hasMoreMessages: false,
searchQuery: "",
setSearchQuery: vi.fn(),
filteredSessions: [sessionOne, sessionTwo],
refreshSessions: vi.fn(),
agentsMap: new Map(),
};
const defaultRoomsState: UseChatRoomsResult = {
rooms: [roomOne],
roomsLoading: false,
roomsError: null,
activeRoom: roomOne,
activeRoomMembers: [],
messages: [],
messagesLoading: false,
selectRoom: vi.fn(),
createRoom: vi.fn(),
deleteRoom: vi.fn(),
sendRoomMessage: vi.fn().mockResolvedValue(undefined),
refreshRooms: vi.fn(),
};
function setup(chatOverrides: Partial<UseChatReturn> = {}, roomsOverrides: Partial<UseChatRoomsResult> = {}) {
mockUseChat.mockReturnValue({ ...defaultChatState, ...chatOverrides });
mockUseChatRooms.mockReturnValue({ ...defaultRoomsState, ...roomsOverrides });
}
function mockDesktopViewport() {
if (!window.matchMedia) {
Object.defineProperty(window, "matchMedia", { value: vi.fn(), configurable: true, writable: true });
}
Object.defineProperty(window, "innerWidth", { value: 1280, configurable: true });
vi.spyOn(window, "matchMedia").mockImplementation((query: string) => ({
matches: false,
media: query,
onchange: null,
addListener: vi.fn(),
removeListener: vi.fn(),
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn(),
}));
}
function renderChatView() {
return render(<ChatView projectId="proj-123" addToast={vi.fn()} experimentalFeatures={{ chatRooms: true }} />);
}
describe("ChatView composer autosize", () => {
beforeEach(() => {
_resetInitialViewportHeight();
vi.clearAllMocks();
localStorage.clear();
mockDesktopViewport();
setup();
});
it("resets composer height after send clears messageInput", async () => {
const sendMessage = vi.fn();
setup({ sendMessage });
renderChatView();
const textarea = screen.getByPlaceholderText("Type a message...") as HTMLTextAreaElement;
Object.defineProperty(textarea, "scrollHeight", {
configurable: true,
get: () => (textarea.value.length > 0 ? 900 : 24),
});
await userEvent.type(textarea, "line one\nline two\nline three");
const expandedHeight = Number.parseInt(textarea.style.height, 10);
await userEvent.click(screen.getAllByTestId("chat-send-btn")[0]);
await waitFor(() => {
expect(sendMessage).toHaveBeenCalledWith("line one\nline two\nline three", []);
expect(textarea).toHaveValue("");
const resetHeight = Number.parseInt(textarea.style.height, 10);
expect(resetHeight).toBeLessThan(expandedHeight);
expect(resetHeight).toBe(clampChatInputHeight(24));
});
});
it("recomputes height when draft restore switches to a shorter draft", async () => {
localStorage.setItem("fusion:chat-draft:direct:session-001", "long long long long long");
localStorage.setItem("fusion:chat-draft:direct:session-002", "ok");
const originalScrollHeight = Object.getOwnPropertyDescriptor(HTMLTextAreaElement.prototype, "scrollHeight");
Object.defineProperty(HTMLTextAreaElement.prototype, "scrollHeight", {
configurable: true,
get() {
return (this as HTMLTextAreaElement).value.length > 4 ? 640 : 20;
},
});
const { rerender } = renderChatView();
const textarea = screen.getByPlaceholderText("Type a message...") as HTMLTextAreaElement;
await waitFor(() => {
expect(textarea).toHaveValue("long long long long long");
expect(textarea.style.height).toBe(`${clampChatInputHeight(640)}px`);
});
setup({
activeSession: sessionTwo,
sessions: [sessionOne, sessionTwo],
filteredSessions: [sessionOne, sessionTwo],
});
rerender(<ChatView projectId="proj-123" addToast={vi.fn()} experimentalFeatures={{ chatRooms: true }} />);
await waitFor(() => {
expect(textarea).toHaveValue("ok");
expect(textarea.style.height).toBe(`${clampChatInputHeight(20)}px`);
});
if (originalScrollHeight) {
Object.defineProperty(HTMLTextAreaElement.prototype, "scrollHeight", originalScrollHeight);
}
});
it("uses the same clamp for direct typing and programmatic resets", async () => {
const sendMessage = vi.fn();
setup({ sendMessage });
renderChatView();
const textarea = screen.getByPlaceholderText("Type a message...") as HTMLTextAreaElement;
Object.defineProperty(textarea, "scrollHeight", {
configurable: true,
get: () => 2000,
});
await userEvent.type(textarea, "oversized");
const typingHeight = textarea.style.height;
expect(typingHeight).toBe(`${clampChatInputHeight(2000)}px`);
await userEvent.click(screen.getAllByTestId("chat-send-btn")[0]);
await waitFor(() => {
expect(textarea).toHaveValue("");
expect(textarea.style.height).toBe(`${clampChatInputHeight(2000)}px`);
expect(textarea.style.height).toBe(typingHeight);
});
});
});