root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-1762): fix typecheck errors in engine test files

Browse Source 
- Add SignalListener type definition to child-process-worker.test.ts
- Update mockImplementation callbacks to use unknown type instead of any
- Add proper TypeScript types to createAgentWithTaskDone opts parameter
- Use optional chaining for safer customTools access
- Use () => void | undefined type for resolvePrompt variables
This commit is contained in:
Fusion
2026-04-15 03:40:21 -07:00
committed by gsxdsm
parent 49239b5dfa
commit fed0fd432b
2 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
packages/engine/src/restart.integration.test.ts
View File

@@ -210,9 +210,9 @@ function mockAgentFailure(error = "agent crashed") {
* multiple tasks execute concurrently.
*/
function createAgentWithTaskDone() {
mockedCreateHaiAgent.mockImplementation((async (opts: any) => {
mockedCreateHaiAgent.mockImplementation((async (opts: { customTools?: Array<{ name: string; execute: (name: string, args: unknown) => unknown }> }) => {
// Capture tools per-session to avoid race conditions with concurrent tasks
const localCustomTools = opts.customTools || [];
const localCustomTools = opts?.customTools || [];
const session = {
prompt: vi.fn().mockImplementation(async () => {
// Find and execute task_done tool to set taskDone = true
@@ -232,7 +232,7 @@ function createAgentWithTaskDone() {
beforeEach(() => {
vi.clearAllMocks();
mockedExistsSync.mockReturnValue(true); // Default: worktrees exist (resume scenario)
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
if (String(cmd) === "git worktree list --porcelain") {
return [
"worktree /tmp/test",
@@ -262,7 +262,7 @@ beforeEach(() => {
].join("\n") as any;
}
return Buffer.from("");
});
}) as any);
});
// ── Step 2: In-progress task resume tests ─────────────────────────────────
@@ -536,14 +536,14 @@ describe("In-review merge handling after restart", () => {
store.moveTask.mockResolvedValue(makeTask("FN-051", "done"));
// Branch exists, merge succeeds, no conflicts
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
const cmdStr = String(cmd);
// Post-squash check: squash staged changes → "1"
if (cmdStr.includes("diff --cached --quiet")) return "1" as any;
// Post-agent check: agent committed → "0"
if (cmdStr.includes("diff --cached")) return "0" as any;
return Buffer.from("");
});
}) as any);
mockAgentSuccess();
@@ -563,12 +563,12 @@ describe("In-review merge handling after restart", () => {
store.getTask.mockResolvedValue(makeTaskDetail(taskId, "in-review"));
store.moveTask.mockResolvedValue(makeTask(taskId, "done"));
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
const cmdStr = String(cmd);
if (cmdStr.includes("diff --cached --quiet")) return "1" as any;
if (cmdStr.includes("diff --cached")) return "0" as any;
return Buffer.from("");
});
}) as any);
mockAgentSuccess();
const result = await aiMergeTask(store, "/tmp/root", taskId);
@@ -582,7 +582,7 @@ describe("In-review merge handling after restart", () => {
store.getTask.mockResolvedValue(makeTaskDetail("FN-055", "in-review"));
// Branch exists, merge starts, agent creates but prompt fails
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
const cmdStr = String(cmd);
// Make merge fail so all attempts exhaust
if (cmdStr.includes("merge --squash") || cmdStr.includes("merge -X")) {
@@ -600,7 +600,7 @@ describe("In-review merge handling after restart", () => {
throw err;
}
return Buffer.from("");
});
}) as any);
mockedCreateHaiAgent.mockResolvedValue({
session: {
@@ -629,12 +629,12 @@ describe("In-review merge handling after restart", () => {
store.moveTask.mockResolvedValue(makeTask("FN-056", "done"));
// git rev-parse --verify throws (branch not found)
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
if (typeof cmd === "string" && cmd.includes("git rev-parse --verify")) {
throw new Error("branch not found");
}
return Buffer.from("");
});
}) as any);
const result = await aiMergeTask(store, "/tmp/root", "FN-056");
@@ -679,10 +679,10 @@ describe("Triage re-pick after restart", () => {
store.getTask.mockResolvedValue(makeTaskDetail("FN-062", "triage"));
// Slow agent to keep task in processing
let resolvePrompt: Function;
let resolvePrompt: (() => void) | undefined;
mockedCreateHaiAgent.mockResolvedValue({
session: {
prompt: vi.fn().mockImplementation(() => new Promise((r) => { resolvePrompt = r; })),
prompt: vi.fn().mockImplementation(() => new Promise<void>((r) => { resolvePrompt = r; })),
dispose: vi.fn(),
},
} as any);
@@ -881,7 +881,7 @@ describe("Crash scenario edge cases", () => {
const store = createMockStore();
store.getTask.mockResolvedValue(makeTaskDetail("FN-091", "in-review"));
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
const cmdStr = String(cmd);
// Make merge fail so all attempts exhaust
if (cmdStr.includes("merge --squash") || cmdStr.includes("merge -X")) {
@@ -899,7 +899,7 @@ describe("Crash scenario edge cases", () => {
throw err;
}
return Buffer.from("");
});
}) as any);
// Agent prompt rejects (simulating kill during merge)
mockedCreateHaiAgent.mockResolvedValue({
@@ -930,10 +930,10 @@ describe("Crash scenario edge cases", () => {
store.listTasks.mockResolvedValue([task]);
store.getTask.mockResolvedValue(makeTaskDetail("FN-092", "in-progress"));
let resolvePrompt: Function;
let resolvePrompt: (() => void) | undefined;
mockedCreateHaiAgent.mockResolvedValue({
session: {
prompt: vi.fn().mockImplementation(() => new Promise((r) => { resolvePrompt = r; })),
prompt: vi.fn().mockImplementation(() => new Promise<void>((r) => { resolvePrompt = r; })),
dispose: vi.fn(),
},
} as any);
@@ -998,7 +998,7 @@ function makeDirEntry(name: string) {
}
function mockRegisteredWorktrees(rootDir: string, names: string[]) {
mockedExecSync.mockImplementation((cmd: any) => {
mockedExecSync.mockImplementation(((cmd: unknown) => {
if (String(cmd) === "git worktree list --porcelain") {
return [
`worktree ${rootDir}`,
@@ -1014,7 +1014,7 @@ function mockRegisteredWorktrees(rootDir: string, names: string[]) {
].join("\n") as any;
}
return Buffer.from("");
});
}) as any);
}
describe("Worktree pool restart with recycleWorktrees=true", () => {

19
packages/engine/src/runtimes/child-process-worker.test.ts
View File

@@ -159,11 +159,10 @@ function getHandler<T = unknown>(
}
describe("child-process-worker", () => {
type SignalListener = (...args: unknown[]) => void;
const originalProcessSend = process.send;
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type -- Test mock
let sigtermBaseline: Function[] = [];
// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type -- Test mock
let sigintBaseline: Function[] = [];
let sigtermBaseline: SignalListener[] = [];
let sigintBaseline: SignalListener[] = [];
beforeEach(() => {
vi.resetModules();
@@ -172,8 +171,8 @@ describe("child-process-worker", () => {
mockState.ipcWorkers.length = 0;
mockState.runtimes.length = 0;
sigtermBaseline = process.listeners("SIGTERM");
sigintBaseline = process.listeners("SIGINT");
sigtermBaseline = process.listeners("SIGTERM") as unknown as SignalListener[];
sigintBaseline = process.listeners("SIGINT") as unknown as SignalListener[];
(process as NodeJS.Process & { send?: (...args: unknown[]) => unknown }).send = vi.fn(() => true);
vi.spyOn(process, "exit").mockImplementation((() => undefined) as never);
@@ -181,14 +180,14 @@ describe("child-process-worker", () => {
afterEach(() => {
for (const listener of process.listeners("SIGTERM")) {
if (!sigtermBaseline.includes(listener)) {
process.removeListener("SIGTERM", listener as (...args: any[]) => void);
if (!sigtermBaseline.some((l) => l === listener)) {
process.removeListener("SIGTERM", listener as unknown as SignalListener);
}
}
for (const listener of process.listeners("SIGINT")) {
if (!sigintBaseline.includes(listener)) {
process.removeListener("SIGINT", listener as (...args: any[]) => void);
if (!sigintBaseline.some((l) => l === listener)) {
process.removeListener("SIGINT", listener as unknown as SignalListener);
}
}