fusion

root/fusion

Fork 0

Commit Graph

Author	SHA1	Message	Date
gsxdsm	56a087dac9	fix(engine): restore shipped behaviors dropped by the wave-18 executor peel Full-suite repair, engine harness cluster (~85 red suites). Two causes: (1) graph dispatch now fails closed without options.agentStore (FN-8764/FN-8821, intended) — the shared executor test harness now provisions the workflow-routing agent-store fixture for bare TaskExecutor constructions, with explicit opt-out for the two tests asserting the fail-closed park; (2) the wave-18 'pure peel' (#3317) rebuilt executor.ts from a stale base and silently deleted shipped behaviors, restored here: FN-8864 agent-activity writers (task started/handed-off, workflow gate pass/fail, gate principal attribution via executor/workflow-gate-activity.ts), FN-8768 Plan Review group recognition, convergence primer, and modified-file review scoping, FN-6782's fire-time guard on transient resume-after-restart retries, FN-8868 session usage telemetry boundaries, recommendation-route withheld-tool guidance, and the per-instance worktree retry cap. Stale expectations updated for intended changes (FN-8823 shared-member hold, FN-9060 zero-acquire fail-closed, heartbeat tool inventory, peeled-module seams, PG harness provisioning). Verified: 23 files / 711 tests green, engine typecheck clean, merge gate green. Known follow-ups (not addressed here): step-session error routing may still bypass FN-5866 non-continuable classification (post-done-continuation-no-wedge red), scheduler mission-loop trigger gap (mission-validation-trigger-gap red), and executeWorkflowStep lost routed workflow-principal session identity threading (untested drop from the same peel). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-15 15:52:52 -07:00
gsxdsm	66c51038a5	fix(engine): bind self-owned worktree liveness probe (#3419 ) ## Summary Supersedes #3416 — the fork head is not writable from maintainers, so this branch carries the same fix merged onto current `main`. ## Changes - Bind the self-owned worktree liveness probe in task-executor pure facades (from #3416). - Merge current main so the lifecycle-column census baseline stays green. ## Test plan - [x] `pnpm check:lifecycle-columns` clean after merge - [ ] CI green Closes context from #3416. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * Bug Fixes * Fixed cleanup for self-owned worktrees so it no longer crashes before checking whether an active session is present. * Improved safety during worktree reconciliation by correctly verifying that the worktree is still active before removal. * Documentation * Added a changeset documenting the worktree cleanup fix. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: BESA-Franz <49682134+BESA-Franz@users.noreply.github.com>	2026-08-11 11:28:42 -10:00
gsxdsm	1cf86baa1c	refactor: package code organization wave 18 (executor pure peels) (#3317 ) ## Summary Wave 18 continues the package code-organization program after wave 17 domain folders (U4 Slice A from `docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`). ### What changed Peel pure, behavior-preserving helpers out of `packages/engine/src/executor.ts` into domain modules under `packages/engine/src/executor/`, with stable re-exports from `executor.ts` so deep imports and `vi.mock("../executor.js")` keep working. \| New module \| Symbols \| \|------------\|---------\| \| `executor/task-done-refusal.ts` \| `evaluateTaskDoneRefusal`, `determineRevisionResetStart`, skip-bypass refusal helper \| \| `executor/workflow-feedback-paths.ts` \| `extractReferencedPathsFromWorkflowFeedback`, `isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` \| \| `executor/workflow-step-verdict.ts` \| `FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict` / `parseWorkflowStepOutput`, step outcome types \| \| `executor/await-input-parse.ts` \| `parseAwaitInputSentinel`, `parseAwaitInputQuestionToolCall` \| \| `executor/no-commit-eligibility.ts` \| `getNoCommitEligibilityReason` (+ prompt heuristics) \| `executor.ts` live LOC ~22817 → ~22427 (first pure-peel batch; more peels needed to approach the 2k cap). ### Shims - `old path` `executor.ts` public exports → `new path` `executor/.ts` → delete-when consumer deep-imports are re-pointed (not this PR) ### Test plan - [x] `@fusion/engine` typecheck - [x] Oracle: task-done refusal, skip-bypass, workflow malformed verdict, scope-leak allowlist, executor-step-session, executor-prompt - [x] `vitest --project=engine-core` (merge-gate curated suite) - [ ] CI merge gate Stack:* wave17 (merged) → this PR <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * New Features * Improved recognition of workflow outcomes from structured and conversational responses. * Added support for extracting questions from await-input responses and tool calls. * Improved workflow feedback handling for referenced files and declared scope patterns. * Added clearer guidance for task execution, approvals, verification, and available tools. * Bug Fixes * Prevented completion when required review approvals are missing or revisions remain pending. * Improved handling of workflows that legitimately require no code changes. * Added clearer refusal messages and more reliable revision restarts. * Sanitized repository paths in Git remediation instructions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-08-09 15:46:09 -10:00

Author

SHA1

Message

Date

gsxdsm

56a087dac9

fix(engine): restore shipped behaviors dropped by the wave-18 executor peel

Full-suite repair, engine harness cluster (~85 red suites). Two causes:
(1) graph dispatch now fails closed without options.agentStore
(FN-8764/FN-8821, intended) — the shared executor test harness now
provisions the workflow-routing agent-store fixture for bare
TaskExecutor constructions, with explicit opt-out for the two tests
asserting the fail-closed park; (2) the wave-18 'pure peel' (#3317)
rebuilt executor.ts from a stale base and silently deleted shipped
behaviors, restored here: FN-8864 agent-activity writers (task
started/handed-off, workflow gate pass/fail, gate principal attribution
via executor/workflow-gate-activity.ts), FN-8768 Plan Review group
recognition, convergence primer, and modified-file review scoping,
FN-6782's fire-time guard on transient resume-after-restart retries,
FN-8868 session usage telemetry boundaries, recommendation-route
withheld-tool guidance, and the per-instance worktree retry cap.
Stale expectations updated for intended changes (FN-8823 shared-member
hold, FN-9060 zero-acquire fail-closed, heartbeat tool inventory,
peeled-module seams, PG harness provisioning). Verified: 23 files /
711 tests green, engine typecheck clean, merge gate green.

Known follow-ups (not addressed here): step-session error routing may
still bypass FN-5866 non-continuable classification
(post-done-continuation-no-wedge red), scheduler mission-loop trigger
gap (mission-validation-trigger-gap red), and executeWorkflowStep lost
routed workflow-principal session identity threading (untested drop
from the same peel).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-08-15 15:52:52 -07:00

gsxdsm

66c51038a5

fix(engine): bind self-owned worktree liveness probe (#3419 )

## Summary
Supersedes #3416 — the fork head is not writable from maintainers, so
this branch carries the same fix merged onto current `main`.

## Changes
- Bind the self-owned worktree liveness probe in task-executor pure
facades (from #3416).
- Merge current main so the lifecycle-column census baseline stays
green.

## Test plan
- [x] `pnpm check:lifecycle-columns` clean after merge
- [ ] CI green

Closes context from #3416.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Fixed cleanup for self-owned worktrees so it no longer crashes before
checking whether an active session is present.
* Improved safety during worktree reconciliation by correctly verifying
that the worktree is still active before removal.

* **Documentation**
  * Added a changeset documenting the worktree cleanup fix.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: BESA-Franz <49682134+BESA-Franz@users.noreply.github.com>

2026-08-11 11:28:42 -10:00

gsxdsm

1cf86baa1c

refactor: package code organization wave 18 (executor pure peels) (#3317 )

## Summary

Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).

### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.

| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |

`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).

### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)

### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate

**Stack:** wave17 (merged) → **this PR**

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.

* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
  * Added clearer refusal messages and more reliable revision restarts.
  * Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

2026-08-09 15:46:09 -10:00

3 Commits