gsxdsm
|
3dea1bb851
|
FN-9172: isolate executor run-audit emissions
Keep executor lifecycle transitions moving when run-audit sinks fail or stall.
- Add a shared bounded, best-effort executor audit emission seam.
- Route executor lifecycle audit writes through sink isolation.
- Cover absent, throwing, rejecting, hanging, and late-settling sinks.
- Document the emitter policy and publish a patch changeset.
Files changed:
.changeset/fn-9172-executor-run-audit-isolation.md | 7 +
AGENTS.md | 7 +
docs/run-audit.md | 6 +-
.../src/__tests__/emit-bounded-run-audit.test.ts | 58 +++++
.../executor-run-audit-emitter-isolation.test.ts | 252 +++++++++++++++++++++
.../src/executor/acquire-session-registry-path.ts | 5 +-
.../engine/src/executor/completion-finalization.ts | 3 +-
.../engine/src/executor/create-task-done-tool.ts | 3 +-
.../engine/src/executor/emit-bounded-run-audit.ts | 48 ++++
.../executor/emit-merge-boundary-unproven-audit.ts | 68 ++----
.../engine/src/executor/execute-workflow-graph.ts | 5 +-
.../engine/src/executor/handle-graph-failure.ts | 18 +-
...dle-stale-in-review-parse-pause-abort-replay.ts | 7 +-
...ndle-stale-in-review-plan-pause-abort-replay.ts | 7 +-
.../maybe-dispatch-workflow-work-engine.ts | 7 +-
.../src/executor/no-merge-complete-column.ts | 3 +-
.../reenter-paused-aborted-workflow-node.ts | 7 +-
.../src/executor/required-artifact-recovery.ts | 3 +-
packages/engine/src/executor/run-implementation.ts | 5 +-
19 files changed, 433 insertions(+), 86 deletions(-)
Fusion-Task-Id: FN-9172
Fusion-Task-Lineage: 80c67c36-3bbb-4274-ac4c-9808c4cda3ce
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
|
2026-08-19 20:35:19 -07:00 |
|
gsxdsm
|
1cf86baa1c
|
refactor: package code organization wave 18 (executor pure peels) (#3317)
## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
2026-08-09 15:46:09 -10:00 |
|