Commit Graph

7 Commits

Author SHA1 Message Date
gsxdsm
c12e7e39fb FN-6444: rescue dashboard route API tests
Rescue deterministic dashboard route/API tests from the curated skip-list and quarantine the remaining stale suites.

- Remove dashboard src route/API tests from the curated skip-list once they either run in backfill or move to quarantine.
- Add dated quarantine coverage for stale mission, planning, and session reconnect suites.
- Update rescued route/API test expectations and FNXC comments to match current deterministic behavior.

Files changed:
 .../dashboard/src/__tests__/chat-manager.test.ts   |  4 ++
 .../dashboard/src/__tests__/evals-routes.test.ts   |  8 +++-
 .../src/__tests__/github-tracking-delete.test.ts   |  4 ++
 ...ithub-tracking-periodic-reconcile-sweep.test.ts |  8 +++-
 .../src/__tests__/insights-routes.test.ts          | 12 ++++--
 .../__tests__/routes-run-audit-goal-events.test.ts |  6 ++-
 .../src/__tests__/routes-run-cited-goals.test.ts   |  6 ++-
 .../shared-branch-group-entry-points.test.ts       |  6 +--
 packages/dashboard/src/__tests__/usage.test.ts     |  4 ++
 packages/dashboard/vitest.config.ts                |  6 +++
 scripts/lib/dashboard-curated-skiplist.json        | 44 ----------------------
 scripts/lib/test-quarantine.json                   | 15 ++++++++
 12 files changed, 66 insertions(+), 57 deletions(-)

Fusion-Task-Id: FN-6444

Fusion-Task-Lineage: f314da67-d05e-48c5-9c9c-890c28cf0e5b
2026-06-14 15:29:35 -07:00
gsxdsm
1f540b29d7 FN-6443: rescue dashboard session tests
Rescue skipped dashboard session tests by making planning responses durable before continuation.

- Persist planning-session response history before agent continuation so retry and replay state survives generation errors.
- Isolate dashboard session tests on dedicated SQLite handles and close them before temp cleanup.
- Restore engine mocks for workflow authoring tools and remove the rescued session tests from the curated dashboard skiplist.
- Add a patch changeset for the published CLI bundle.

Files changed:
 .changeset/fn-6443.md                              |  5 +++
 .../src/__tests__/session-cross-tab.test.ts        | 38 ++++++++++++++--------
 .../src/__tests__/session-error-recovery.test.ts   |  2 ++
 .../session-persistence-roundtrip.test.ts          |  2 ++
 .../src/__tests__/session-reconnect.test.ts        | 21 ++++++++++--
 packages/dashboard/src/planning.ts                 | 11 ++++---
 scripts/lib/dashboard-curated-skiplist.json        | 16 ---------
 7 files changed, 58 insertions(+), 37 deletions(-)

Fusion-Task-Id: FN-6443

Fusion-Task-Lineage: 953534e7-6857-4cd5-9a5a-5772354cac5a
2026-06-14 15:29:35 -07:00
gsxdsm
a6d5efce27 FN-6442: rescue dashboard hook tests from skiplist
Rescues three dashboard hook test files by replacing brittle coverage with stable assertions and removing their skiplist entries.

- Stub global localStorage failures directly for quick chat persistence coverage.
- Remove the placeholder skipped useChatRooms pagination test.
- Rework useTaskDiffStats stepVersion tests around active worktree cache behavior.
- Drop the rescued dashboard hook tests from the curated skiplist.

Files changed:
 .../__tests__/quickChatLastSessionStorage.test.ts  | 23 ++++--
 .../app/hooks/__tests__/useChatRooms.test.ts       |  6 --
 .../app/hooks/__tests__/useTaskDiffStats.test.ts   | 94 ++++++++++++----------
 scripts/lib/dashboard-curated-skiplist.json        | 12 ---
 4 files changed, 67 insertions(+), 68 deletions(-)

Fusion-Task-Id: FN-6442
Fusion-Task-Lineage: f2fe4791-1216-420d-9734-3938287779da
2026-06-14 15:29:35 -07:00
gsxdsm
175aab15ac FN-6441: rescue and quarantine dashboard component tests
Rescue passing dashboard component tests and move still-failing orphaned tests under the quarantine ratchet.

- Remove the FN-6441 dashboard component batch from the curated skip-list.
- Keep passing PlanningModeModal, TaskReviewTab, and TerminalModal coverage documented in app backfill.
- Register remaining failing dashboard component/CSS tests in the dated quarantine ledger and Vitest excludes.
- Teach the dashboard curated inventory guard to accept dated quarantine entries without returning them to the skip-list.

Files changed:
 .../PlanningModeModal.ui-interactions.test.tsx     |  9 ++-
 .../components/__tests__/TaskReviewTab.test.tsx    |  4 ++
 .../components/__tests__/TerminalModal.test.tsx    |  4 ++
 packages/dashboard/vitest.config.ts                | 14 +++++
 scripts/__tests__/check-test-inventory.test.mjs    | 32 +++++++++++
 scripts/check-test-inventory.mjs                   | 67 +++++++++++++++++-----
 scripts/lib/dashboard-curated-skiplist.json        | 56 ------------------
 scripts/lib/test-quarantine.json                   | 58 ++++++++++++++++++-
 8 files changed, 172 insertions(+), 72 deletions(-)

Fusion-Task-Id: FN-6441

Fusion-Task-Lineage: 19065d1f-31eb-45fc-a6ce-083773b094e4
2026-06-14 15:29:35 -07:00
gsxdsm
0b047d4fc8 FN-6440: replace dashboard skip-list placeholders
Dashboard curated-gate skip-list entries now point to actionable tracking work.

- Replace placeholder FN-TBD references with concrete Fusion task IDs grouped by affected dashboard area.
- Document the requirement that skip-list reasons cite real tracking tasks unless entries are removed after rescue.
- Preserve the standalone build-output exception while making the remaining skip-list ownership actionable.

Files changed:
 docs/testing.md                             |  1 +
 scripts/lib/dashboard-curated-skiplist.json | 66 ++++++++++++++---------------
 2 files changed, 34 insertions(+), 33 deletions(-)

Fusion-Task-Id: FN-6440
Fusion-Task-Lineage: abf1cef2-8199-4746-b8ec-8b5487eb1ecc
2026-06-14 15:29:35 -07:00
gsxdsm
615d744c8a FN-6066: fix dashboard curated inventory guard
Keep the dashboard curated inventory guard aligned with the current dashboard test surface.

- add the newly required @fusion/core exports to the agent import route test mock
- teach the test inventory script to request file-only vitest listings for dashboard curated checks
- extend the dashboard curated skiplist with the pre-existing chat manager exclusion

Files changed:
 packages/dashboard/src/__tests__/routes-agent-import.test.ts | 3 +++
 scripts/check-test-inventory.mjs                             | 5 +++--
 scripts/lib/dashboard-curated-skiplist.json                  | 4 ++++
 3 files changed, 10 insertions(+), 2 deletions(-)

Fusion-Task-Id: FN-6066

Fusion-Task-Lineage: 51e3c42c-d642-4873-8201-636a420d0991
2026-06-09 02:23:35 -07:00
gsxdsm
c9191b733c test: close dashboard curated-gate and engine-slow coverage holes; add inventory harness
- 427 orphaned dashboard test files ran in NO gate; 395 now gated via self-maintaining backfill lanes (glob minus curated minus skip-list), 31 pre-existing failures + build-output skip-listed with reasons
- settings -t name-filter lanes replaced by one unfiltered lane (describe blocks can no longer fall through filters)
- scripts/check-test-inventory.mjs: --capture/--diff superset harness + --dashboard-curated completeness guard
- pr-checks.yml: engine-slow CI gate (non-empty assertion) + inventory guard job
- docs/testing.md: guard, skip-list policy, harness usage
2026-06-03 17:36:35 -07:00