The structural half of #2784. I re-measured its 123 failures on current
main and **all four reported lanes are green** (143 / 2010 / 1961 / 5149
/ 2103 passing). This fixes the reason nobody saw them.
## The mechanism
`pnpm --filter @fusion/dashboard test` sets `stopScheduling = true` on
the first failing lane, so the rest never run — and there was **no flag
to ask for a full pass**. The report said:
```
[dashboard-quality] skipped 9 lane(s) after first failure
```
Nine lanes with **unknown** status and nine **passing** lanes produce
the same absence of failure text. That is how 123 failures accumulated
behind one red lane, and it is why the original issue could only be
written by running all twelve lanes by hand.
## What changes, and what deliberately does not
Fail-fast stays the **default** — fast feedback on a broken lane is
right, and changing it would slow everyone for a rare case.
- `--all` (alias `--no-fail-fast`) runs every lane and reports every
failure.
- `runQualityTests({ failFast })` so the behaviour is reachable from a
test, not just the CLI.
- The skip line now states the consequence and the remedy: lanes were
**NOT RUN**, status **UNKNOWN rather than passing**, and `--all` shows
the full set.
## Both halves pinned
A flag nobody can prove works is the same as no flag:
| test | asserts |
|---|---|
| DEFAULT stops after the first failing lane | `launched === ["one"]`,
`skipped: 2` |
| `failFast:false` runs all three | `launched ===
["one","two","three"]`, `failed === [one, three]` |
The second is the load-bearing one: **lane three ran even though lane
one had already failed**, and both failures are reported rather than
only the first.
**Anti-vacuity control:** reverting the `if (failFast)` plumbing fails
the second test and only it (`1 failed / 5 passed`); restoring passes
`6/6`.
## Scope
Runner and its tests only. No lane contents, no vitest configs, no CI
workflow — CI already invokes lanes individually, so this changes local
behaviour and the shared helper, not what CI runs.
eslint clean; `check-fnxc-future-dates` exit 0.
Suggest #2784 closes on the measured-green half and links here for the
structural half, so the mechanism does not close along with the symptom
that exposed it.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Added an option to run all quality-test lanes, even when earlier lanes
fail.
* Added `--all` and `--no-fail-fast` command-line options.
* Quality tests now stop on the first failure by default, with clearer
output for skipped lanes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
U1/U2/KTD-6: extract the dashboard heap-runner's process-group kill lifecycle
into a shared scripts/lib/run-vitest-watchdog.mjs with per-class budget bands
(timings only tighten within a generous ceiling) and an inline hang-diagnostics
snapshot. Delegate run-vitest-with-heap.mjs to it (behavior preserved). Add
timeout-minutes backstops to all full-suite.yml test jobs so a wedged run can no
longer hang to GitHub's 6h ceiling.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Improve dashboard vitest wrapper diagnostics so transient SIGTERM handling is easier to trace.
- track the last signal and reason forwarded from the heap wrapper to the vitest process group
- log when the wrapper receives SIGINT or SIGTERM and when timeout shutdown escalates
- extend wrapper tests to assert process-group leadership and emitted diagnostic stderr
Files changed:
.../scripts/__tests__/run-vitest-with-heap.test.ts | 25 +++++++++++++++++++---
.../dashboard/scripts/run-vitest-with-heap.mjs | 19 ++++++++++++----
2 files changed, 37 insertions(+), 7 deletions(-)
Fusion-Task-Id: FN-6184
Fusion-Task-Lineage: b276d88e-a22d-4fdf-a533-c4b0aa4e199d
Prevent dashboard test wrappers from leaving orphaned Vitest subprocesses after interruption or timeout.
- run dashboard vitest wrappers in a detached process group and forward shutdown signals to the whole group
- add an exit-time cleanup path and spawn override seam for process-lifecycle handling without launching real vitest
- cover SIGINT/SIGTERM orphan reaping and keep the dashboard test config guard aligned with the new script test
Files changed:
.../scripts/__tests__/run-vitest-with-heap.test.ts | 172 +++++++++++++++++++++
.../dashboard/scripts/run-vitest-with-heap.mjs | 89 ++++++++++-
.../__tests__/dashboard-test-config-guard.test.ts | 1 +
packages/dashboard/vitest.config.ts | 1 +
4 files changed, 256 insertions(+), 7 deletions(-)
Fusion-Task-Id: FN-5918
Fusion-Task-Lineage: 5c695b3b-14c5-4749-ad9c-eb9f33d5ecd5
