2 Commits

Author	SHA1	Message	Date
gsxdsm	a81486559e	fix: dashboard lucide/CSS/SettingsModal/mcp-helper fixes + expand mock-completeness guard to dashboard (round 11) (#2049) ... ## Summary Fixes all remaining full-suite failures from run 29231108919 (FN-7923–7931 drift) + expands the structural mock-completeness guard to cover dashboard tests. ## Fixes ### Dashboard (shard 4) — 4 files - **`TaskCard.cli-states.test.tsx`** — Proxy lucide-react mock needed `has`/`getOwnPropertyDescriptor` traps; TaskCard now imports `priorityIndicator.tsx` which reads `ArrowDown` at module-init. Vitest validates ESM named exports via `in`/descriptor, not `get`. Also added `useToast` mock. - **`SettingsModalNodeRouting.test.tsx`** — Pass `initialSection="node-routing"` (it's in `ADVANCED_SETTINGS_SECTION_IDS`, nav hidden by default). - **`styles-css-rgba-tokenization.test.ts`** — Removed stale `.settings-sidebar` color-mix expectation (FN-7825 made it structural-only). - **`mcp-helper-forwarding.test.ts`** — Added `resolvePlanningThinkingLevel` to `@fusion/engine` mock (insight extraction calls it before MCP forwarding). ### Structural guard expansion - **`.tsx` blind spot fixed** — `collectTs` and test file filter now include `.tsx` files - **Shorthand property extraction** — key extractor now matches both `key: value` and `key,` (shorthand) - **Convention mapping** — `.test.tsx → .tsx` source resolution added - **Dashboard test coverage** — `@fusion/engine` barrel check now scans `packages/dashboard/src/__tests__/` - **7 latent mock gaps completed** — `pr-conflict-resolver`, `project-pause-resume-routes`, `routes-approval-sandbox-provisioning`, `routes-approval`, `routes-worktrunk`, `session-reconnect`, `setup-routes` ### Engine (shards 1+2) — zero real failures All 3 failing files are local-only (`@agentclientprotocol/sdk` + pi-ai staleness). CI resolves them from lockfile. ## Verification - Gate (with expanded guard): exit 0 ✅ - Dashboard (5 non-local files): 36/36 passed ✅ - 3 files skipped locally (`@agentclientprotocol/sdk`) — CI will verify <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Improved test reliability by completing module mocks across dashboard and routing scenarios. * Updated settings and task card test coverage to reflect current UI behavior. * Enhanced mock validation to cover additional test files, TypeScript React files, and shorthand exports. * Prevented failures related to missing providers, engine helpers, and planning configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-07-13 07:10:14 -07:00
gsxdsm	f7e942e6f4	fix: resolve all full-suite failures + add structural mock-completeness gate check (round 10) (#2040) ... ## Summary Fixes ALL failing shards from the latest full-suite run (29225946428) AND adds a structural gate check to prevent the recurring mock-export drift pattern that has caused every full-suite failure across rounds 1–9. ## What broke (run 29225946428, commit 504b0f8b0) | Shard | Root cause | Tests fixed | |---|---|---| | **3 (CLI)** | `workflowValidateParams` (FN-7911) missing from `@fusion/engine` mock | 8 files | | **3 (CLI)** | `skill-sync.test.ts` — `fn_workflow_validate` missing from engine-tools.md | 1 file | | **4 (dashboard)** | 6 chat default settings keys missing from description allowlist | 1 file | | **1+2 (engine)** | `additionalSkillPaths` missing from `buildSessionSkillContext` mocks (FN-1510/1511) | 10 tests | | **1+2 (engine)** | heartbeat FN-7878 changed paused→error for generic run failures | 1 test | | **1+2 (engine)** | executor `updateTask` exact-match → `objectContaining` (new fields) | 2 tests | | **1+2 (engine)** | `connectMcpSessionTools` mock missing for pi.test MCP forwarding | 1 test | ## Structural fix — `scripts/check-mock-completeness.mjs` (the "fix for good") **New gate check** added to `pnpm test:gate`. Statically validates every hardcoded `vi.mock("@fusion/dashboard")` and `vi.mock("@fusion/engine")` factory covers all named imports the source file uses. Runs in <0.2s, no module evaluation. **How it works:** 1. Extracts named exports from each barrel (`packages/dashboard/src/index.ts`, `packages/engine/src/index.ts`) 2. For each test file with a hardcoded `vi.mock` factory (no `importOriginal`/`importActual` spread): - Resolves source files the test covers (static + dynamic imports, convention mapping) - Extracts what those source files named-import from the barrel - Resolves spread helpers (e.g. `...workflowAuthoringEngineMock`) by reading the helper's exported keys - Reports any barrel exports that are named-imported by source but absent from the mock **Why this fixes the recurring pattern:** Every round 1–9 failure was a new barrel export imported by source but missing from a test mock. This check catches it at gate time, before merge — not after the full-suite fails on main. Also completed all 15 latent mock gaps the guard found on first run (9 dashboard + 6 engine), including expanding the centralized `workflowAuthoringEngineMock` helper with all `extension.ts` named imports. ## Verification - Gate (with new check): exit 0 ✅ - CLI: 355/355 passed ✅ - Engine (6 fixed files): 250/250 passed ✅ - i18n + settings: verified ✅ - Mock completeness guard: ✅ (0 issues) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Documented a new non-destructive workflow validation tool that performs a dry-run and returns typed validation errors. * **Tests** * Updated and strengthened CLI, dashboard, extension, and engine tests with more accurate mock exports and more resilient assertions. * Adjusted expectations for session/heartbeat and retry-related behaviors. * **Chores** * Added an automated mock-completeness gate and integrated it into the test quality gate to keep mocks aligned with available platform exports. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2026-07-12 23:29:06 -07:00