gsxdsm
e2702bab6b
feat(workflows): add reviewer inline fixes
2026-06-30 18:37:10 -07:00
gsxdsm
7e74fe3a9b
FN-7293: honor workflow review revision overrides
...
Allow workflow review steps to opt into unbounded or capped revision retries while keeping recovery caps accurate.
- Add workflow settings for Plan Review and Code Review max revisions with display, docs, and changeset coverage.
- Resolve optional-step revision budgets through workflow settings, node overrides, and existing fallback limits.
- Track revision attempts per workflow step and hydrate slim self-healing rows before enforcing retry caps.
- Cover unbounded, capped, per-step, and slim-row recovery behavior with focused tests.
Files changed:
.changeset/fn-7293-unbounded-review-revisions.md | 7 +
docs/settings-reference.md | 12 +-
docs/workflow-editor.md | 4 +-
docs/workflow-steps.md | 3 +-
.../builtin-workflow-settings-triage.test.ts | 28 +++-
.../core/src/__tests__/builtin-workflows.test.ts | 29 ++++-
.../__tests__/workflow-settings-resolver.test.ts | 73 +++++++++++
packages/core/src/builtin-plan-review-group.ts | 6 +-
packages/core/src/builtin-workflow-settings.ts | 30 +++++
packages/core/src/index.ts | 5 +
packages/core/src/workflow-ir-types.ts | 15 ++-
packages/core/src/workflow-ir.ts | 5 +-
packages/core/src/workflow-settings-resolver.ts | 49 ++++++-
.../__tests__/WorkflowSettingsPanel.test.tsx | 52 ++++++++
.../app/components/workflow-setting-display.ts | 18 +++
packages/engine/src/__tests__/self-healing.test.ts | 143 ++++++++++++++++++++-
.../workflow-graph-optional-step-fix.test.ts | 130 ++++++++++++++++++-
packages/engine/src/executor.ts | 77 +++++++++--
packages/engine/src/self-healing.ts | 82 ++++++++++--
packages/engine/src/workflow-graph-executor.ts | 5 +-
20 files changed, 725 insertions(+), 48 deletions(-)
Fusion-Task-Id: FN-7293
Fusion-Task-Lineage: 19ee533f-ab8d-4e20-9a27-9cf0cf6dfec9
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-30 13:12:27 -07:00
gsxdsm
01e04333ce
FN-7294: pass user context into workflow reviewers
...
Pass operator-authored task context into reviewer and workflow gate prompts.
- Include de-duped user comments and legacy steering in Plan Review, code review, and workflow-step prompt agents.
- Preserve reviewer comment context on reduced context-limit retry prompts and refresh comments before in-session review calls.
- Document workflow prompt-agent comment behavior, add regression coverage, and add a patch changeset.
Files changed:
.changeset/FN-7294-reviewer-comment-context.md | 7 +
docs/workflow-steps.md | 7 +
.../src/__tests__/agent-user-comments.test.ts | 81 ++++++++--
.../executor-review-step-indexing.test.ts | 165 ++++++++++++++++++++-
.../src/__tests__/reviewer-workspace.test.ts | 39 +++++
packages/engine/src/__tests__/reviewer.test.ts | 26 +++-
packages/engine/src/__tests__/triage.test.ts | 49 ++++++
packages/engine/src/agent-user-comments.ts | 42 ++++--
packages/engine/src/executor.ts | 31 +++-
packages/engine/src/reviewer.ts | 10 +-
packages/engine/src/triage.ts | 20 ++-
11 files changed, 443 insertions(+), 34 deletions(-)
Fusion-Task-Id: FN-7294
Fusion-Task-Lineage: ea5ff33e-99ba-4fdd-9257-9778849b91bb
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-30 12:56:03 -07:00
gsxdsm
658b3511c7
FN-7293: scope external evidence to per-step review
2026-06-30 12:25:43 -07:00
gsxdsm
7eca99c8b1
FN-7283: clear optional workflow steps in fast mode
...
Fast mode now treats optional workflow steps as opt-out by default while preserving manual reselection.
- Clear default-on optional workflow steps when switching task creation forms into Fast mode.
- Submit explicit empty optional-step selections in Fast mode to prevent store defaults from reappearing.
- Allow explicitly enabled optional workflow groups to run under Fast mode and during recovery.
- Document the Fast-mode optional-step contract and add regression coverage for dashboard and engine flows.
Files changed:
.changeset/FN-7283-fast-mode-optional-steps.md | 7 ++
docs/workflow-steps.md | 15 ++-
packages/dashboard/app/components/NewTaskModal.tsx | 27 +++--
.../dashboard/app/components/QuickEntryBox.tsx | 29 ++++-
packages/dashboard/app/components/TaskForm.tsx | 42 +++++--
.../app/components/__tests__/NewTaskModal.test.tsx | 58 +++++++++
.../components/__tests__/QuickEntryBox.test.tsx | 84 +++++++++++++
.../app/components/__tests__/TaskForm.test.tsx | 85 ++++++++++++-
.../__tests__/executor-fast-mode-workflows.test.ts | 134 +++++++++++++++++++++
packages/engine/src/executor.ts | 107 ++++++++++------
packages/engine/src/workflow-graph-executor.ts | 14 ++-
11 files changed, 539 insertions(+), 63 deletions(-)
Fusion-Task-Id: FN-7283
Fusion-Task-Lineage: e7028af8-3d05-4db7-8db9-a16c7f7575de
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-30 09:46:26 -07:00
gsxdsm
4441b72bbc
fix(FN-7273): prevent stale step resume regressions
2026-06-30 08:07:40 -07:00
gsxdsm
5ec04ec5cb
fix(FN-7271): keep fast coding tasks from skipping implementation
2026-06-30 07:31:59 -07:00
gsxdsm
41ff08a158
fix(FN-7261): prevent premature fast workflow merges
...
Block the merge requester when fast workflow traversal reaches merge before implementation steps are complete, and recover stale no-op merge proof by requeuing executable work instead of looping in blocked finalization.
Fusion-Task-Id: FN-7261
2026-06-29 23:36:34 -07:00
gsxdsm
9e23d6c403
fix(FN-7265): stop duplicate graph plan reviews
2026-06-29 22:29:22 -07:00
gsxdsm
5a6d110483
fix(engine): stop phantom-reservation audit churn and preserve worktree on phantom reclaim
...
reconcilePhantomCommittedReservations emitted a task:reconcile-phantom-committed-reservation audit row every maintenance tick for the same orphaned committed reservations even when zero child rows were pruned (~19k no-op writes/day). Gate the audit emission on actual pruned work; the FN-7069 contract is unchanged (committed reservation stays committed so the ID is never reused).
clearPhantomExecutorBinding unconditionally unregistered held worktree paths from activeSessionRegistry, defeating the moveTask(preserveWorktree:true) the self-healing phantom reclaim pairs it with: re-dispatch then acquired a brand-new worktree instead of reattaching (FN-7249 lost its first worktree this way). Add a preserveWorktrees option that clears only the stale in-memory executor/lock bookkeeping and leaves the session-registry path entries intact; the self-healing caller opts in. Non-self-healing callers keep the default full-clear behavior.
2026-06-29 21:56:14 -07:00
gsxdsm
095007c640
fix(FN-7262): honor step session setting
2026-06-29 21:51:13 -07:00
Phil Larson
b829821dd9
fix(engine): review explicit external checkouts
2026-06-29 17:17:59 -07:00
gsxdsm
d7f26bb6cf
fix(FN-7219): stabilize compound engineering workflow
2026-06-29 16:42:11 -07:00
gsxdsm
a766813ed9
FN-7239: scope executor prompts and quarantine stale pause test
...
Scope missing executor prompts safely while keeping graph coverage aligned with the post-cutover workflow route.
- Treat absent executor prompts as empty before worktree path scoping.
- Update graph retry, parity, and smoke expectations for plan review, completion summary, and post-merge traversal.
- Quarantine only the stale executor-pause direct-dispatch suite with a ledger entry and engine-default exclude.
Files changed:
.changeset/fn-7239-scope-prompt-guard.md | 7 ++++
.../engine/src/__tests__/executor-pause.test.ts | 10 +++++
.../src/__tests__/task-pipeline-smoke.test.ts | 7 ++++
.../workflow-graph-executor-parity.test.ts | 15 ++++++-
...ow-graph-executor-retry-coding-workflow.test.ts | 48 +++++++++++++++++-----
packages/engine/src/executor.ts | 15 ++++---
packages/engine/vitest.config.ts | 5 +++
scripts/lib/test-quarantine.json | 8 +++-
8 files changed, 97 insertions(+), 18 deletions(-)
Fusion-Task-Id: FN-7239
Fusion-Task-Lineage: 9382e4e0-7cfc-416a-93e8-6ba1c7cd7879
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-29 14:17:29 -07:00
gsxdsm
41c0cf3603
fix(FN-7235): scope workflow remediation recovery
...
Keep merge finalization from stranding scoped workflow tasks on out-of-scope branch residue, move built-in optional gate remediation attempts into workflow config, and guard review remediation against out-of-scope fixes.
Also covers FN-7236 review-remediation scope drift.
2026-06-29 14:00:32 -07:00
gsxdsm
b169072224
fix(FN-7233): enforce workflow summary and done guards
2026-06-29 11:07:11 -07:00
gsxdsm
2135bd653d
fix(FN-7228): record workflow completion summaries
2026-06-29 10:32:51 -07:00
gsxdsm
6fc50d8d9e
fix(FN-7232): enforce workflow merge boundary
2026-06-29 10:05:49 -07:00
gsxdsm
123639c89f
fix(FN-7231): require current workflow merge proof
2026-06-29 09:28:02 -07:00
gsxdsm
4184062288
fix(FN-7224): notify workflow graph task flows
...
Fusion-Task-Id: FN-7224
2026-06-29 08:49:59 -07:00
gsxdsm
57d8065778
fix(FN-7224): let workflow nodes own worktree prep
...
Classify write-capable graph nodes before handler dispatch and let executor adapters fulfill the declared worktree requirement, keeping custom-node execution out of lifecycle decision making.
Fusion-Task-Id: FN-7224
2026-06-29 08:22:49 -07:00
gsxdsm
cb94fc8451
fix(FN-7224): make workflow graph replay idempotent
...
Move completed-step replay and proven-merge finalization into workflow-owned execution paths so graph restarts continue from live task projection instead of failing stale step nodes.
Fusion-Task-Id: FN-7224
2026-06-29 08:15:32 -07:00
gsxdsm
05c54fbe29
fix(FN-7228): complete workflow recovery after reviews pass
...
Fusion-Task-Id: FN-7228
2026-06-29 04:12:13 -07:00
gsxdsm
c088f8a412
fix(FN-7228): preserve plan review status during execution
2026-06-29 03:40:43 -07:00
gsxdsm
984e36255d
fix(FN-7229): stop parking execution errors in review
2026-06-29 03:33:18 -07:00
gsxdsm
50ccd79b9f
fix(FN-7226): land graph step-session commits
2026-06-29 03:15:30 -07:00
gsxdsm
399a4a2a5f
fix(FN-7226): use graph projection for step sessions
2026-06-29 03:09:43 -07:00
gsxdsm
1efcdcfe35
fix(FN-7224): clear stale graph pins on reset
2026-06-29 02:55:35 -07:00
gsxdsm
c93217dee0
fix(FN-7225): honor plan review approvals in workflows
...
Fusion-Task-Id: FN-7225
2026-06-29 02:08:08 -07:00
gsxdsm
1d21241725
fix(FN-7225): auto-retry stale parse pause aborts
2026-06-29 01:13:31 -07:00
gsxdsm
1f365163a4
fix(FN-7225): clear stale pause state on workflow retry
2026-06-29 01:05:44 -07:00
gsxdsm
b86ddf4d10
fix(FN-7225): route failed plan review to triage
2026-06-29 00:48:49 -07:00
gsxdsm
e963be4088
FN-7220: harden workflow recovery lineage checks
...
Harden workflow recovery so pause/resume parks and already-merged detection preserve task ownership lineage.
- Reject already-merged recovery candidates with foreign task or lineage trailers before accepting patch-id, tree, or branch-tip matches.
- Recover benign pause/resume abort parks back to todo when the task has no live executor/session state.
- Add real-git and executor regression coverage plus architecture docs and a changeset for recovery behavior.
Files changed:
.changeset/fn-7220-workflow-recovery-lineage.md | 7 +
docs/architecture.md | 8 +-
.../already-merged-detector.real-git.test.ts | 69 ++++++++
.../executor-paused-abort-todo-benign.test.ts | 194 ++++++++++++++++++---
.../self-healing-already-merged.real-git.test.ts | 64 ++++++-
packages/engine/src/already-merged-detector.ts | 113 +++++++++---
packages/engine/src/executor.ts | 84 +++++++++
packages/engine/src/self-healing.ts | 134 ++++++++++++--
8 files changed, 609 insertions(+), 64 deletions(-)
Fusion-Task-Id: FN-7220
Fusion-Task-Lineage: 186c65bc-fe1a-457a-b90a-abbd73044252
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-28 22:43:02 -07:00
gsxdsm
58a0c1f1d6
FN-7214: make workflow node pause resume re-entrant
...
Workflow graph pause aborts now re-enter interrupted nodes instead of failing the task.
- Track and abort active workflow graph runners during hard cancel and global pause flows.
- Stamp interrupted workflow nodes with typed engine-pause abort context and surface it through graph run results.
- Re-enter safe todo, in-progress, and auto-mergeable in-review graph nodes with retry bounds and run-audit evidence.
- Add regression coverage and architecture notes for paused node re-entry behavior.
Files changed:
.changeset/fn-7214-workflow-graph-node-pause-resume.md | 7 +
docs/architecture.md | 4 +-
packages/engine/src/__tests__/executor-paused-abort-todo-benign.test.ts | 231 ++++++++++++++++++++-
packages/engine/src/__tests__/workflow-graph-paused-node-resume.test.ts | 148 +++++++++++++
packages/engine/src/executor.ts | 158 +++++++++++++-
packages/engine/src/workflow-graph-executor.ts | 50 ++++-
packages/engine/src/workflow-graph-task-runner.ts | 26 ++-
7 files changed, 614 insertions(+), 10 deletions(-)
Fusion-Task-Id: FN-7214
Fusion-Task-Lineage: 1689e3fd-e35f-4e83-8049-aabbab49cecd
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-28 19:42:45 -07:00
gsxdsm
fac7556321
fix(FN-7210): stop merge-retry loop starving executor remediation pass
...
recoverCompletedTask refused workflow-graph re-entry when the live task
has incomplete plan steps or a remediation bounce is already scheduled.
A pre-merge optional/advisory REVISE reopens steps and schedules a
sendTaskBackForFix bounce; a competing graph re-entry re-passed the
advisory step (budget exhausted), advanced to merge, and looped forever
on the 'task has incomplete steps' gate. Defer to the bounce /
stale-incomplete-review recovery so the executor finishes the steps.
Fusion-Task-Id: FN-7210
2026-06-28 19:22:06 -07:00
gsxdsm
9f45f108e5
FN-7174: reset lost steps before stuck requeue cleanup
...
Preserve durable stuck-requeue progress while preventing retries from skipping deleted uncommitted work.
- Reconcile completed and in-progress steps before stuck cleanup removes executor worktrees.
- Reset step progress when a branch has no unique commits or git proof fails before checkout deletion.
- Cover normal, loop-timeout, and force stuck-requeue paths with regression tests and documentation.
Files changed:
.changeset/fn-7174-stuck-requeue-progress.md | 7 +
docs/architecture.md | 2 +-
packages/core/src/types.ts | 9 +-
...xecutor-stuck-requeue-preserve-progress.test.ts | 282 +++++++++++++++++++++
packages/engine/src/executor.ts | 99 ++++----
5 files changed, 349 insertions(+), 50 deletions(-)
Fusion-Task-Id: FN-7174
Fusion-Task-Lineage: 3b8b09e7-fceb-4b3d-af80-993a8842a51a
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-28 00:08:53 -07:00
gsxdsm
987abc763b
FN-7162: reopen actionable steps after review bounces
...
Post-verdict remediation now resumes executable work before rechecking optional gates.
- Reopen the terminal verification/delivery suffix together with the nearest actionable implementation step for revision bounces.
- Cover Code Review, Browser Verification, gate-promoted revisions, and non-revision optional outcomes with regression tests.
- Document post-verdict bounce semantics and add a patch changeset for the published CLI package.
Files changed:
.changeset/fn-7162-post-verdict-bounce-step-completion.md | 7 ++
docs/workflow-steps.md | 9 +-
packages/engine/src/__tests__/executor-step-session.test.ts | 117 +++++++++++++++++++--
packages/engine/src/__tests__/workflow-graph-optional-step-fix.test.ts | 60 +++++++++++
packages/engine/src/executor.ts | 51 +++++++--
5 files changed, 222 insertions(+), 22 deletions(-)
Fusion-Task-Id: FN-7162
Fusion-Task-Lineage: 8d422fc9-54e8-431d-97bb-e7a4a6763eaa
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-27 23:01:10 -07:00
gsxdsm
a593cc7428
FN-7130: require agent-browser for browser verification
...
Browser Verification steps now explicitly request and log agent-browser usage.
- Mark the built-in browser verification workflow step as browser-required and document that it runs through agent-browser.
- Add executor helpers to inject the agent-browser skill, probe CLI availability, and log start/finish outcomes.
- Cover workflow metadata, browser verification execution logging, availability probing, and skill augmentation with tests.
- Add a patch changeset for the published Fusion package.
Files changed:
.../fn-7130-browser-verification-agent-browser.md | 7 +
docs/workflow-steps.md | 4 +-
.../__tests__/builtin-coding-workflow-ir.test.ts | 23 ++
.../core/src/__tests__/builtin-workflows.test.ts | 12 +
.../core/src/builtin-browser-verification-group.ts | 4 +
packages/core/src/types.ts | 7 +
...iltin-coding-browser-verification-group.test.ts | 8 +-
.../executor-browser-verification.test.ts | 267 +++++++++++++++++++++
packages/engine/src/executor.ts | 118 +++++++++
9 files changed, 447 insertions(+), 3 deletions(-)
Fusion-Task-Id: FN-7130
Fusion-Task-Lineage: 3a76522e-70e1-4445-ad18-b9e1b9b355fc
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-27 14:27:06 -07:00
gsxdsm
b1066c62cc
fix: bounce in-review tasks back for pre-merge optional-step fixes
...
A pre-merge optional step REVISE (Code Review / Browser Verification)
reopens the last plan step to pending and schedules a rerun bounce via
sendTaskBackForFix. The hosting graph run reports disposition "completed",
so the outer completion flow can route the task to in-review before the
setTimeout(0) bounce fires. performWorkflowRerunBounce previously handled
only in-progress/todo and threw on in-review ("cannot bounce to
in-progress"), stranding the task in-review with a pending step: the merge
gate blocks forever while self-healing only re-runs the graph (re-passing
the advisory step) and never re-launches the executor — a permanent
deadlock (observed on FN-7122, stuck >1h).
The bounce's only caller (sendTaskBackForFix) unconditionally intends
remediation, so in-review now bounces back to in-progress exactly like
in-progress (todo hop preserving step progress + worktree). Adds a
regression test asserting the in-review bounce returns "bounced" and
re-dispatches.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-27 14:02:34 -07:00
gsxdsm
39d20be05f
FN-7129: add per-step optional revision budgets
...
Add optional workflow-step revision budgets that can cap or unbound remediation loops.
- Add optional-group maxRevisions parsing, validation, exports, and docs.
- Expose numeric and unbounded revision budget controls in the workflow node editor.
- Apply per-step budgets in executor and self-healing fix loops with regression coverage.
Files changed:
.changeset/fn-7129-per-step-revision-budget.md | 7 ++
docs/dashboard-guide.md | 1 +
docs/settings-reference.md | 2 +-
docs/workflow-steps.md | 10 ++-
.../__tests__/workflow-ir-optional-group.test.ts | 29 ++++++-
packages/core/src/index.ts | 2 +
packages/core/src/workflow-ir-types.ts | 37 +++++++++
packages/core/src/workflow-ir.ts | 15 ++++
.../app/components/WorkflowNodeEditor.tsx | 87 ++++++++++++++++----
.../__tests__/WorkflowNodeEditor.test.tsx | 95 ++++++++++++++++++++++
packages/engine/src/__tests__/self-healing.test.ts | 63 ++++++++++++++
.../workflow-graph-optional-group.test.ts | 30 ++++++-
.../workflow-graph-optional-step-fix.test.ts | 53 ++++++++++++
packages/engine/src/executor.ts | 15 ++--
packages/engine/src/self-healing.ts | 64 +++++++++++----
packages/engine/src/workflow-graph-executor.ts | 6 +-
16 files changed, 469 insertions(+), 47 deletions(-)
Fusion-Task-Id: FN-7129
Fusion-Task-Lineage: dbde94e5-3c99-4f67-aed9-458563e845ae
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-27 13:05:50 -07:00
gsxdsm
68282769e6
FN-7128: raise optional-step fix cycle budget
...
Code Review and Browser Verification now rerun through bounded fix passes until they pass.
- Raise the shared maxPostReviewFixes default and fallbacks from 1 to 3.
- Document the built-in optional-step fix cycle and release-note the operator-facing behavior.
- Update workflow graph, settings, and fallback tests for repeated optional-step remediation.
Files changed:
.changeset/fn-7128-optional-step-cycle-default.md | 7 ++
docs/settings-reference.md | 2 +-
docs/workflow-steps.md | 2 +-
.../src/__tests__/workflow-ir-settings.test.ts | 2 +-
packages/core/src/builtin-workflow-settings.ts | 8 +-
packages/core/src/types.ts | 8 +-
.../workflow-graph-optional-group.test.ts | 112 +++++++++++++++++----
.../workflow-graph-optional-step-fix.test.ts | 35 +++++++
.../workflow-settings-fallback-alignment.test.ts | 2 +-
packages/engine/src/executor.ts | 2 +-
packages/engine/src/self-healing.ts | 4 +-
11 files changed, 152 insertions(+), 32 deletions(-)
Fusion-Task-Id: FN-7128
Fusion-Task-Lineage: 8165f746-3828-453a-8ca4-8134c8d33c8f
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-27 11:42:01 -07:00
gsxdsm
5ab4a5961c
FN-7119: rescue quarantined engine and CLI tests
...
Restore quarantined scheduler/reliability coverage while preserving override column-agent model selection.
- remove rescued engine and CLI tests from quarantine configs and the ledger
- add scheduler fake updateSettings coverage so heartbeat writes do not skew call-count assertions
- preserve override column-agent runtime models during initial execution and mid-flight task edits
- update the stale user-configured command guard registry and add a patch changeset
Files changed:
.changeset/fn-7119-column-agent-model.md | 7 +++
docs/testing.md | 2 +
packages/cli/vitest.config.ts | 6 +-
.../executor-column-agent-principal.test.ts | 34 +++++++++-
.../lease-recovery-central-claim.test.ts | 5 ++
.../owning-node-unavailable-interactions.test.ts | 5 ++
.../todo-inprogress-flapping.test.ts | 5 ++
.../src/__tests__/restart.integration.test.ts | 8 +++
.../__tests__/scheduler-ephemeral-toggle.test.ts | 5 ++
.../scheduler-node-unreachable-audit.test.ts | 5 ++
.../__tests__/scheduler-overlap-starvation.test.ts | 5 ++
.../user-configured-command-no-execsync.test.ts | 12 +---
packages/engine/src/executor.ts | 18 ++++--
packages/engine/vitest.config.ts | 26 +++-----
scripts/lib/test-quarantine.json | 73 +---------------------
15 files changed, 106 insertions(+), 110 deletions(-)
Fusion-Task-Id: FN-7119
Fusion-Task-Lineage: 7dc033c8-29d1-4c0e-bfc1-b0ff0d325f43
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai >
2026-06-27 10:50:33 -07:00
gsxdsm
e89a58f276
FN-7066: schedule fixes for failed optional steps
...
Route failed pre-merge optional workflow steps back through executor remediation before review/merge.
- Add a graph-executor seam that schedules bounded executor fixes for pre-merge optional REVISE results.
- Track optional-step fix attempts with the existing post-review fix budget before falling back to advisory/gate behavior.
- Cover optional Code Review / Browser Verification fix scheduling and exhausted-budget behavior with engine tests.
- Document the pre-merge remediation semantics and add a release changeset.
Files changed:
.changeset/fn-7066-optional-step-fix.md | 7 +
docs/workflow-steps.md | 11 +-
packages/engine/src/__tests__/self-healing.test.ts | 43 +++++
.../workflow-graph-optional-group.test.ts | 206 +++++++++++++++++++++
.../workflow-graph-optional-step-fix.test.ts | 89 +++++++++
packages/engine/src/executor.ts | 50 ++++-
packages/engine/src/workflow-graph-executor.ts | 29 +++
packages/engine/src/workflow-graph-task-runner.ts | 5 +-
8 files changed, 436 insertions(+), 4 deletions(-)
Fusion-Task-Id: FN-7066
Fusion-Task-Lineage: 6b584293-4f2a-4851-a0d7-3ec9e68fe31a
2026-06-26 14:17:07 -07:00
gsxdsm
31d3f21e18
FN-7065: add deterministic Fusion co-author trailers
...
Fusion now applies co-author attribution through merge and worktree plumbing instead of relying on prompt-written commit messages.
- Add commit-msg hook support for deterministic Co-authored-by trailers with configured Fusion identity.
- Propagate commit attribution settings through native and worktrunk worktree backends.
- Backfill AI squash merge trailers with Fusion task metadata and co-author attribution.
- Document the settings behavior and add a patch changeset for published CLI behavior.
- Cover hook, executor, AI merge, and real-git trailer behavior with tests.
Files changed:
.changeset/fn-7065-co-author-trailer.md | 7 +++
docs/settings-reference.md | 6 +--
packages/engine/src/__tests__/merger-ai.test.ts | 43 +++++++++++++++++++
.../real-git/commit-msg-trailer.real-git.test.ts | 50 ++++++++++++++++++++++
.../engine/src/__tests__/worktree-hooks.test.ts | 15 +++++++
packages/engine/src/executor.ts | 4 ++
packages/engine/src/merger-ai.ts | 22 ++++++++--
packages/engine/src/step-session-executor.ts | 3 ++
packages/engine/src/worktree-acquisition.ts | 3 ++
packages/engine/src/worktree-backend.ts | 13 +++++-
packages/engine/src/worktree-hooks.ts | 33 +++++++++++++-
11 files changed, 190 insertions(+), 9 deletions(-)
Fusion-Task-Id: FN-7065
Fusion-Task-Lineage: 4f5cd0ff-7193-4f97-bdcd-4cd78c7669b9
2026-06-26 13:13:46 -07:00
gsxdsm
3ee47dec86
merge: integrate origin/main into feature/workflow-steps (FN-7039)
...
Resolve conflicts from 56 upstream commits:
- db.ts: renumber my migrations around main's new migration 130 (columnDwellMs) —
enable-id normalization 130→131, drop-table 131→132, SCHEMA_VERSION→132.
- index.ts / routes.ts: take main's new MCP exports/imports; keep WORKFLOW_STEP_TEMPLATES
array removed (kept the WorkflowStepTemplate type).
- merger.ts: keep the legacy post-merge execution path removed (U7c) over main's version.
- ci-workflow.test.ts (from main): add port-4040/process-supervisor allowlist markers to
the gate-script assertions that reference the checker filenames (pre-existing self-match).
Gate green (engine-core 299, ci-shape 62); boot smoke PASS; migration tests + typecheck clean.
2026-06-26 08:50:22 -07:00
gsxdsm
347842faca
refactor(FN-7039): drop the legacy workflow_steps table; remove all table readers
...
Final cutover — nothing reads workflow_steps at runtime, so migration 131 drops it.
- Removed the merger post-merge execution path entirely (runPostMergeWorkflowSteps,
hasEnabledPostMergeWorkflowSteps, executePostMerge{Prompt,Script}Step, post-merge
worktree helpers + call site). Graph owns post-merge.
- Executor recovery no longer reads getWorkflowStep().gateMode; gate-ness comes from the
recorded WorkflowStepResult.status.
- Removed store CRUD (create/update/deleteWorkflowStep), materializeWorkflowSteps, and
migrateLegacyWorkflowSteps; selectTaskWorkflow now seeds default-on optional-group node
ids (consistent with create-time). KEPT the plugin step-template palette (getWorkflowStep
plugin-only resolver / listWorkflowSteps plugin-only) — never touches the table.
Removed the dashboard migrate-legacy-steps route + editor migration UI.
- SCHEMA_VERSION 130→131; migration 131 DROP TABLE IF EXISTS workflow_steps; SCHEMA_SQL
table def removed; historical migrations 77/105/109/130 guarded with tableExists().
Proof nothing stranded: the graph executes IR nodes resolved from workflowId (never
stepIds/compiled rows) — materializeWorkflowSteps writes were vestigial. Full @fusion/core
suite (6290), reliability backstop (154), boot smoke, and a seed-at-130 drop test all pass
with the table gone.
Plan U7c.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 02:29:32 -07:00
gsxdsm
6c94ee069c
FN-7023: forward MCP runtime config to AI lanes
...
Forward enabled MCP server configuration through AI session creation and validation paths.
- Resolve and materialize effective MCP servers with secret values at runtime for triage, execution, review, merge, evaluation, reflection, mission validation, and dashboard chat/planning lanes.
- Add runtime support guards, Claude CLI MCP config generation, and a dashboard validation route for MCP server reachability probes.
- Cover MCP forwarding, provider support behavior, settings resolution, validation, and pi extension config generation with targeted tests and docs.
Files changed:
.changeset/fn-7023-mcp-runtime-forwarding.md | 7 +
docs/agents.md | 2 +
docs/secrets.md | 1 +
docs/settings-reference.md | 6 +-
.../src/__tests__/mcp-lane-forwarding.test.ts | 79 +++++++++++
.../src/__tests__/mcp-validate-route.test.ts | 111 ++++++++++++++++
packages/dashboard/src/chat.ts | 3 +
packages/dashboard/src/planning.ts | 5 +
packages/dashboard/src/routes.ts | 90 ++++++++++++-
.../src/__tests__/mcp-lane-forwarding.test.ts | 95 ++++++++++++++
.../engine/src/__tests__/mcp-resolution.test.ts | 104 +++++++++++++++
.../src/__tests__/mcp-runtime-support.test.ts | 44 +++++++
.../src/__tests__/mcp-validation-service.test.ts | 69 ++++++++++
packages/engine/src/__tests__/pi.test.ts | 65 +++++++++
packages/engine/src/agent-reflection.ts | 3 +
packages/engine/src/agent-runtime.ts | 36 ++++-
packages/engine/src/agent-session-helpers.ts | 2 +
packages/engine/src/evaluator.ts | 3 +
packages/engine/src/executor.ts | 14 ++
packages/engine/src/index.ts | 3 +
packages/engine/src/mcp-resolution.ts | 81 ++++++++++++
packages/engine/src/mcp-runtime-support.ts | 41 ++++++
packages/engine/src/mcp-validation-service.ts | 146 +++++++++++++++++++++
packages/engine/src/merger-ai.ts | 5 +
packages/engine/src/merger.ts | 14 ++
packages/engine/src/mission-execution-loop.ts | 3 +
packages/engine/src/pi.ts | 44 +++++--
packages/engine/src/reviewer.ts | 3 +
packages/engine/src/runtime-resolution.ts | 8 +-
packages/engine/src/step-session-executor.ts | 6 +-
packages/engine/src/triage.ts | 5 +
packages/pi-claude-cli/index.ts | 20 ++-
packages/pi-claude-cli/src/mcp-config.ts | 65 ++++++++-
33 files changed, 1150 insertions(+), 33 deletions(-)
Fusion-Task-Id: FN-7023
Fusion-Task-Lineage: ea09c6c7-b3c3-4af6-9ca6-0ebbfec17139
2026-06-26 00:57:32 -07:00
gsxdsm
142bce0b93
fix(review): apply code-review fixes — dead code, step output/notes, seam-contract sync
...
From the U1-U6 code review (correctness/adversarial/reliability/maintainability):
- Delete dead code left by the runWorkflowSteps removal: parkTaskAfterWorkflowStepPause,
handleWorkflowRevisionRequest (+ createWorkflowRevisionFollowUpTask,
injectWorkflowRevisionInstructions), handleWorkflowStepFailure, the dead
partitionWorkflowRevisionFeedback export + its test, and 2 orphaned jsdocs;
reword 2 stale comments (executor.ts FN-6722, self-healing.ts jsdoc).
- Record step output/notes on graph workflow-step results: runGraphCustomNode now
emits contextPatch:{output,notes} so the Workflow tab shows real review feedback
and [pre-merge] revision logs carry detail (was always the fallback before).
- Sync the workflow-step seam contract: core (workflow-compiler SEAM_NAMES/order,
workflow-ir column map, builtin-workflow-prompts) now rejects the workflow-step
seam to match the engine's resolveSeamName, preventing a latent run-time crash on
a persisted/cloned def that core would otherwise parse.
Residual (tracked in the PR): re-introduce the FN-4343 per-step scope gate on the
graph path; the parked-failed recovery log wording; malformed-advisory->passed edge
case; recording for non-optional-group/split-branch step realizations.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-26 00:26:03 -07:00
gsxdsm
f987470e6d
refactor(FN-7039): delete legacy runWorkflowSteps execution path; graph is sole executor
...
Removes the legacy workflow-step EXECUTION path now that the graph records results
(U2): delete runWorkflowSteps(), the workflow-step seam + runWorkflowStep primitive
(runtime-primitives, workflow-node-handlers, authoritative-driver), and the legacy
execute() step blocks. Keeps task.workflowStepResults + its store write path (the
graph's sink) and executeWorkflowStep/executeScriptWorkflowStep (reused by the graph).
- Watchdog recoverCompletedTask now re-enters via maybeExecuteWorkflowGraph so the
graph re-runs pending gates, records results, and owns the in-review/back-for-fix
transition (KTD-2).
- maybeExecuteWorkflowGraph fails CLOSED (parks) when a store lacks
getTaskWorkflowSelection AND the task has enabled pre-merge steps — closing the
FN-7039 silent-skip class without changing minimal-store implementation runs (KTD-5).
KNOWN GAP (follow-up): the FN-4343 per-step workflowStepScopeEnforcement leak check
lived only in runWorkflowSteps and is NOT yet replicated on the graph path. Merge-time
File Scope enforcement (FileScopeViolationError, squash overlap) is unaffected.
Plan U4.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-25 23:25:23 -07:00
gsxdsm
cb1691f473
feat(FN-7039): record graph workflow-step results into task.workflowStepResults
...
Enabled optional-group nodes now upsert their outcome into the existing
task.workflowStepResults field keyed by node id, and emit [pre-merge] logs at
parity with the legacy runWorkflowSteps path. Disabled groups stay byte-inert.
Reuses the existing WorkflowStepResult type + store.updateTask path (no new
table/type/store method). Unblocks the unified progress bar for graph-run steps.
Plan U2.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com >
2026-06-25 22:33:08 -07:00