Files
fusion/packages/dashboard/app/components/__tests__/AgentLogViewer.test.tsx
Dustin Byrne bef73c9449 feat(KB-133): fix auto-scroll to use proximity-to-bottom detection
- Replace scroll-direction tracking with proximity-to-bottom check (40px threshold)
- Remove lastScrollTopRef in favor of comparing scrollTop + clientHeight to scrollHeight
- Update existing tests to use container geometry instead of scroll direction
- Add test for scrolling down but not near bottom (stays disabled)
- Add test for exact-bottom edge case (re-enables auto-scroll)
2026-03-27 20:10:41 -04:00

199 lines
8.8 KiB
TypeScript

import { describe, it, expect } from "vitest";
import { render, screen, fireEvent } from "@testing-library/react";
import { AgentLogViewer } from "../AgentLogViewer";
import type { AgentLogEntry } from "@kb/core";
function makeEntry(overrides: Partial<AgentLogEntry> = {}): AgentLogEntry {
return {
timestamp: "2026-01-01T00:00:00Z",
taskId: "KB-001",
text: "Hello world",
type: "text",
...overrides,
};
}
describe("AgentLogViewer", () => {
it("shows loading message when loading with no entries", () => {
render(<AgentLogViewer entries={[]} loading={true} />);
expect(screen.getByText("Loading agent logs…")).toBeTruthy();
});
it("shows empty message when no entries and not loading", () => {
render(<AgentLogViewer entries={[]} loading={false} />);
expect(screen.getByText("No agent output yet.")).toBeTruthy();
});
it("renders text entries as spans", () => {
const entries = [
makeEntry({ text: "first chunk" }),
makeEntry({ text: "second chunk" }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const textSpans = container.querySelectorAll(".agent-log-text");
expect(textSpans).toHaveLength(2);
expect(textSpans[0].textContent).toBe("first chunk");
expect(textSpans[1].textContent).toBe("second chunk");
});
it("renders tool entries with distinct styling", () => {
const entries = [
makeEntry({ text: "Read", type: "tool" }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const toolDiv = container.querySelector(".agent-log-tool");
expect(toolDiv).toBeTruthy();
expect(toolDiv!.textContent).toContain("Read");
});
it("renders a mix of text and tool entries", () => {
const entries = [
makeEntry({ text: "Starting...", type: "text" }),
makeEntry({ text: "Bash", type: "tool" }),
makeEntry({ text: "Done!", type: "text" }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
expect(container.querySelectorAll(".agent-log-text")).toHaveLength(2);
expect(container.querySelectorAll(".agent-log-tool")).toHaveLength(1);
});
it("renders tool entry detail when present", () => {
const entries = [
makeEntry({ text: "Bash", type: "tool", detail: "ls -la packages/" }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const detail = container.querySelector(".agent-log-tool-detail");
expect(detail).toBeTruthy();
expect(detail!.textContent).toContain("ls -la packages/");
});
it("does not render detail span when detail is absent", () => {
const entries = [
makeEntry({ text: "Bash", type: "tool" }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const detail = container.querySelector(".agent-log-tool-detail");
expect(detail).toBeNull();
});
it("renders long detail text without breaking layout", () => {
const longDetail = "a/very/long/path/".repeat(10) + "file.ts";
const entries = [
makeEntry({ text: "Read", type: "tool", detail: longDetail }),
];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const detail = container.querySelector(".agent-log-tool-detail");
expect(detail).toBeTruthy();
expect(detail!.textContent).toContain(longDetail);
// Verify the tool div still renders correctly
const toolDiv = container.querySelector(".agent-log-tool");
expect(toolDiv).toBeTruthy();
});
it("has a monospace font family", () => {
const entries = [makeEntry()];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
expect(viewer.style.fontFamily).toBe("monospace");
});
it("auto-scrolls to the bottom by default when entries are present", () => {
const entries = [makeEntry({ text: "line 1" }), makeEntry({ text: "line 2" })];
const { container } = render(<AgentLogViewer entries={entries} loading={false} />);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
// After render with autoScroll=true, scrollTop should be set to scrollHeight
expect(viewer.scrollTop).toBe(viewer.scrollHeight);
});
it("disables auto-scroll when user scrolls away from bottom", () => {
const entries = [makeEntry({ text: "line 1" })];
const { container, rerender } = render(
<AgentLogViewer entries={entries} loading={false} />,
);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
// Simulate a container with content taller than viewport
Object.defineProperty(viewer, "scrollHeight", { value: 1000, writable: true, configurable: true });
Object.defineProperty(viewer, "clientHeight", { value: 500, writable: true, configurable: true });
// User is scrolled far from bottom
Object.defineProperty(viewer, "scrollTop", { value: 100, writable: true, configurable: true });
fireEvent.scroll(viewer);
// Re-render with new entries — auto-scroll should be disabled, so scrollTop stays
const newEntries = [...entries, makeEntry({ text: "line 2" })];
rerender(<AgentLogViewer entries={newEntries} loading={false} />);
// scrollTop should remain at 100, not jump to scrollHeight
expect(viewer.scrollTop).toBe(100);
});
it("re-enables auto-scroll when user scrolls to near the bottom", () => {
const entries = [makeEntry({ text: "line 1" })];
const { container, rerender } = render(
<AgentLogViewer entries={entries} loading={false} />,
);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
// First scroll away from bottom to disable auto-scroll
Object.defineProperty(viewer, "scrollHeight", { value: 1000, writable: true, configurable: true });
Object.defineProperty(viewer, "clientHeight", { value: 500, writable: true, configurable: true });
Object.defineProperty(viewer, "scrollTop", { value: 100, writable: true, configurable: true });
fireEvent.scroll(viewer);
// Now scroll to near the bottom (within threshold of 40px)
Object.defineProperty(viewer, "scrollTop", { value: 480, writable: true, configurable: true });
fireEvent.scroll(viewer);
// Re-render with new entries — auto-scroll should be re-enabled
const newEntries = [...entries, makeEntry({ text: "line 2" })];
rerender(<AgentLogViewer entries={newEntries} loading={false} />);
// scrollTop should jump to scrollHeight since auto-scroll is re-enabled
expect(viewer.scrollTop).toBe(viewer.scrollHeight);
});
it("does NOT re-enable auto-scroll when user scrolls down but not near bottom", () => {
const entries = [makeEntry({ text: "line 1" })];
const { container, rerender } = render(
<AgentLogViewer entries={entries} loading={false} />,
);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
// Container with scrollable content
Object.defineProperty(viewer, "scrollHeight", { value: 1000, writable: true, configurable: true });
Object.defineProperty(viewer, "clientHeight", { value: 500, writable: true, configurable: true });
// User scrolls partway down — not near bottom
Object.defineProperty(viewer, "scrollTop", { value: 200, writable: true, configurable: true });
fireEvent.scroll(viewer);
// Re-render with new entries — auto-scroll should stay disabled
const newEntries = [...entries, makeEntry({ text: "line 2" })];
rerender(<AgentLogViewer entries={newEntries} loading={false} />);
// scrollTop should remain where user left it
expect(viewer.scrollTop).toBe(200);
});
it("enables auto-scroll when user is exactly at the bottom", () => {
const entries = [makeEntry({ text: "line 1" })];
const { container, rerender } = render(
<AgentLogViewer entries={entries} loading={false} />,
);
const viewer = container.querySelector("[data-testid='agent-log-viewer']") as HTMLElement;
// Container at exact bottom: scrollTop + clientHeight === scrollHeight
Object.defineProperty(viewer, "scrollHeight", { value: 1000, writable: true, configurable: true });
Object.defineProperty(viewer, "clientHeight", { value: 500, writable: true, configurable: true });
Object.defineProperty(viewer, "scrollTop", { value: 500, writable: true, configurable: true });
fireEvent.scroll(viewer);
// Re-render with new entries — auto-scroll should be enabled
const newEntries = [...entries, makeEntry({ text: "line 2" })];
rerender(<AgentLogViewer entries={newEntries} loading={false} />);
// scrollTop should jump to scrollHeight
expect(viewer.scrollTop).toBe(viewer.scrollHeight);
});
});