Files
fusion/packages/dashboard/app/hooks/useNodes.ts
gsxdsm b6243d68fe FN-6197: suppress tab-resume fetch errors in dashboard
Keep cached dashboard data visible while reconnecting after transient tab-resume fetch failures.

- detect likely tab suspension and visibility-resume fetch errors across dashboard data hooks
- suppress transient "Failed to fetch" errors when cached project and node data already exist
- show a "Connecting…" executor status state instead of surfacing raw resume-time fetch errors
- add dashboard tests covering visibility suspension handling and executor reconnect rendering
- add a patch changeset for the published CLI package

Files changed:
 .changeset/tame-tab-resume-fetch.md                |   5 +
 packages/dashboard/app/App.tsx                     |  16 ++-
 .../dashboard/app/components/ExecutorStatusBar.css |  19 ++-
 .../dashboard/app/components/ExecutorStatusBar.tsx |  12 ++
 .../__tests__/ExecutorStatusBar.test.tsx           |  20 ++-
 .../dashboard/app/hooks/__tests__/useNodes.test.ts | 149 ++++++++++++++++++++-
 .../app/hooks/__tests__/useProjects.test.ts        |  72 +++++++++-
 .../hooks/__tests__/visibilitySuspension.test.ts   |  13 ++
 packages/dashboard/app/hooks/useExecutorStats.ts   |  15 ++-
 .../dashboard/app/hooks/useManagedDockerNodes.ts   |  25 +++-
 packages/dashboard/app/hooks/useMeshState.ts       |  25 +++-
 packages/dashboard/app/hooks/useNodes.ts           |  25 +++-
 packages/dashboard/app/hooks/useProjectHealth.ts   |  18 ++-
 packages/dashboard/app/hooks/useProjects.ts        |  27 +++-
 packages/dashboard/app/hooks/useUsageData.ts       |  24 +++-
 .../dashboard/app/hooks/visibilitySuspension.ts    |   4 +
 16 files changed, 435 insertions(+), 34 deletions(-)

Fusion-Task-Id: FN-6197

Fusion-Task-Lineage: 834f56d8-8391-414f-8cbd-7e626c5724d0
2026-06-10 09:21:48 -07:00

245 lines
7.9 KiB
TypeScript

import { useState, useEffect, useCallback, useRef } from "react";
import { useTranslation } from "react-i18next";
import type { DockerNodeConfigInfo, NodeCreateInput, NodeInfo, NodeOnboardingInput, NodeUpdateInput, RemoteNodeProjectDiscoveryResult } from "../api";
import {
fetchDockerConfigDiff,
fetchDockerNodeConfig,
fetchNodes,
registerNode,
updateDockerNodeConfig,
updateNode,
unregisterNode,
checkNodeHealth,
discoverRemoteNodeProjects,
} from "../api";
import { persistNodeProjectPathMappings } from "../api-node";
import { recordResumeEvent } from "../utils/resumeInstrumentation";
import { isVisibilityResumeError, useTabVisibilitySuspension } from "./visibilitySuspension";
export interface UseNodesResult {
nodes: NodeInfo[];
loading: boolean;
error: string | null;
refresh: () => Promise<void>;
register: (input: NodeOnboardingInput) => Promise<NodeInfo>;
update: (id: string, updates: NodeUpdateInput) => Promise<NodeInfo>;
unregister: (id: string) => Promise<void>;
healthCheck: (id: string) => Promise<void>;
fetchDockerConfig: (nodeId: string) => Promise<DockerNodeConfigInfo | null>;
patchDockerConfig: (nodeId: string, config: Partial<DockerNodeConfigInfo>) => Promise<DockerNodeConfigInfo>;
fetchDockerDiff: (nodeId: string) => Promise<{ persistedVersion: number; deployedVersion: number | null; needsRecreate: boolean }>;
discoverRemoteProjects: (input: { url: string; apiKey?: string }) => Promise<RemoteNodeProjectDiscoveryResult>;
}
const POLL_INTERVAL_MS = 10000; // 10 seconds
const VISIBILITY_REFRESH_DEBOUNCE_MS = 1000;
/**
* Hook for fetching and managing node registry state.
* Automatically polls for updates every 10 seconds.
* Refetches when the tab becomes visible again.
*/
export function useNodes(): UseNodesResult {
const { t } = useTranslation("app");
const [nodes, setNodes] = useState<NodeInfo[]>([]);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);
const intervalRef = useRef<NodeJS.Timeout | null>(null);
const lastVisibilityRefreshRef = useRef<number>(0);
const nodesRef = useRef(nodes);
const visibilitySuspension = useTabVisibilitySuspension();
useEffect(() => {
nodesRef.current = nodes;
}, [nodes]);
const shouldSuppressVisibilityResumeError = useCallback((errorMessage: string): boolean => {
return nodesRef.current.length > 0 && isVisibilityResumeError(errorMessage, visibilitySuspension.wasRecentlyHidden());
}, [visibilitySuspension]);
const refresh = useCallback(async () => {
try {
setError(null);
const data = await fetchNodes();
setNodes(data);
} catch (err) {
const errorMessage = err instanceof Error ? err.message : t("nodes.errorFetching", "Failed to fetch nodes");
if (!shouldSuppressVisibilityResumeError(errorMessage)) {
setError(errorMessage);
}
// Keep stale data visible if polling refresh fails
}
}, [shouldSuppressVisibilityResumeError, t]);
useEffect(() => {
let cancelled = false;
async function load() {
setLoading(true);
try {
const data = await fetchNodes();
if (!cancelled) {
setNodes(data);
setError(null);
}
} catch (err) {
const errorMessage = err instanceof Error ? err.message : t("nodes.errorFetching", "Failed to fetch nodes");
if (!cancelled && !shouldSuppressVisibilityResumeError(errorMessage)) {
setError(errorMessage);
}
} finally {
if (!cancelled) {
setLoading(false);
}
}
}
void load();
const handleVisibilityChange = () => {
if (document.visibilityState !== "visible") {
return;
}
const now = Date.now();
const timeSinceLastRefresh = now - lastVisibilityRefreshRef.current;
if (timeSinceLastRefresh < VISIBILITY_REFRESH_DEBOUNCE_MS) {
recordResumeEvent({
view: "useNodes",
trigger: "visibility",
projectId: undefined,
replayAttempted: false,
reason: "debounce-skipped",
detail: { timeSinceLastRefreshMs: timeSinceLastRefresh },
});
return;
}
lastVisibilityRefreshRef.current = now;
recordResumeEvent({
view: "useNodes",
trigger: "visibility",
projectId: undefined,
replayAttempted: false,
reason: "debounced-refresh",
});
void refresh();
};
document.addEventListener("visibilitychange", handleVisibilityChange);
return () => {
cancelled = true;
document.removeEventListener("visibilitychange", handleVisibilityChange);
};
}, [refresh, shouldSuppressVisibilityResumeError, t]);
useEffect(() => {
if (loading) return;
intervalRef.current = setInterval(() => {
void refresh();
}, POLL_INTERVAL_MS);
return () => {
if (intervalRef.current) {
clearInterval(intervalRef.current);
intervalRef.current = null;
}
};
}, [loading, refresh]);
const register = useCallback(async (input: NodeOnboardingInput): Promise<NodeInfo> => {
const { projectMappings, ...nodeInput } = input;
const node = await registerNode(nodeInput as NodeCreateInput);
if (projectMappings.length > 0) {
try {
await persistNodeProjectPathMappings(node.id, projectMappings);
} catch (error) {
const mappingError = error instanceof Error ? error.message : t("nodes.errorPersistMappings", "Failed to persist project mappings");
let cleanupErrorMessage = "";
try {
await unregisterNode(node.id);
} catch (cleanupError) {
cleanupErrorMessage = cleanupError instanceof Error
? cleanupError.message
: t("nodes.errorUnregisterAfterMappingFailure", "Failed to unregister node after mapping failure");
}
await refresh();
if (cleanupErrorMessage) {
throw new Error(`${mappingError}. Cleanup also failed: ${cleanupErrorMessage}`);
}
throw new Error(mappingError);
}
}
await refresh();
return node;
}, [refresh, t]);
const update = useCallback(async (id: string, updates: NodeUpdateInput): Promise<NodeInfo> => {
const node = await updateNode(id, updates);
setNodes((prev) => prev.map((existing) => (existing.id === id ? node : existing)));
return node;
}, []);
const unregister = useCallback(async (id: string): Promise<void> => {
await unregisterNode(id);
setNodes((prev) => prev.filter((node) => node.id !== id));
}, []);
const healthCheck = useCallback(async (id: string): Promise<void> => {
const result = await checkNodeHealth(id);
setNodes((prev) => prev.map((node) => (
node.id === id
? {
...node,
status: result.status,
updatedAt: result.checkedAt,
}
: node
)));
}, []);
const fetchDockerConfig = useCallback((nodeId: string) => fetchDockerNodeConfig(nodeId), []);
const patchDockerConfig = useCallback(async (nodeId: string, config: Partial<DockerNodeConfigInfo>) => {
const updatedConfig = await updateDockerNodeConfig(nodeId, config);
setNodes((prev) => prev.map((node) => (
node.id === nodeId
? { ...node, dockerConfig: updatedConfig }
: node
)));
return updatedConfig;
}, []);
const fetchDockerDiff = useCallback(async (nodeId: string) => {
const diff = await fetchDockerConfigDiff(nodeId);
if ("persistedVersion" in diff) {
return diff;
}
return { persistedVersion: 0, deployedVersion: null, needsRecreate: false };
}, []);
const discoverRemoteProjects = useCallback(async (input: { url: string; apiKey?: string }) => {
return discoverRemoteNodeProjects(input);
}, []);
return {
nodes,
loading,
error,
refresh,
register,
update,
unregister,
healthCheck,
fetchDockerConfig,
patchDockerConfig,
fetchDockerDiff,
discoverRemoteProjects,
};
}