gsxdsm
1cf86baa1c
refactor: package code organization wave 18 (executor pure peels) (#3317)
## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-09 15:46:09 -10:00
..
2026-08-09 06:01:02 -07:00
2026-08-09 15:46:09 -10:00
2026-06-03 17:36:35 -07:00
2026-07-31 00:27:41 -07:00
2026-04-27 08:21:48 -07:00
2026-05-12 07:47:11 -07:00
2026-07-13 19:07:58 -07:00
2026-07-14 23:18:55 -07:00
2026-07-17 22:45:57 -07:00
2026-07-08 04:24:30 -07:00
2026-07-15 08:44:11 -07:00
2026-07-14 23:18:55 -07:00
2026-07-27 21:09:51 -07:00
2026-06-23 23:30:32 -07:00
2026-06-25 23:34:08 -07:00
2026-08-09 15:58:54 -07:00
2026-07-31 19:03:08 -07:00
2026-08-03 16:15:12 -07:00
2026-07-31 22:19:32 -07:00
2026-07-31 00:03:02 -07:00
2026-07-13 07:10:14 -07:00
2026-07-31 21:34:25 -07:00
2026-07-25 06:22:23 -07:00
2026-07-16 10:13:49 -07:00
2026-05-23 19:51:36 -07:00
2026-07-19 14:08:51 -07:00
2026-07-14 08:16:42 -07:00
2026-06-14 15:29:35 -07:00
2026-07-26 07:34:50 -07:00
2026-07-31 01:43:58 -07:00
2026-08-09 06:01:02 -07:00
2026-07-12 21:21:10 -07:00
2026-07-19 15:53:07 -07:00
2026-07-31 18:52:12 -07:00
2026-06-14 15:29:35 -07:00
2026-04-27 08:21:48 -07:00
2026-06-13 19:22:00 -07:00
2026-07-20 00:18:53 -07:00
2026-07-24 06:21:53 -07:00
2026-04-27 08:21:48 -07:00
2026-08-04 08:57:30 -07:00
2026-07-10 13:26:23 -07:00
2026-08-04 08:57:30 -07:00
2026-04-27 08:21:48 -07:00
2026-08-04 08:57:30 -07:00
2026-06-19 20:47:32 -07:00
2026-06-18 16:47:09 -07:00
2026-08-01 16:57:49 -07:00
2026-08-09 15:46:09 -10:00
2026-06-16 18:03:41 -07:00
2026-07-14 23:18:55 -07:00
2026-07-30 23:59:54 -07:00
2026-07-31 00:36:21 -07:00
2026-07-31 00:03:02 -07:00
2026-07-13 19:07:58 -07:00
2026-04-27 08:21:48 -07:00
2026-08-03 12:16:32 -07:00
2026-07-14 23:18:55 -07:00
2026-06-24 19:25:44 -07:00
2026-06-21 10:53:08 -07:00
2026-08-04 09:21:07 -07:00
2026-05-27 21:31:12 -07:00
2026-03-30 23:56:01 -07:00
2026-03-26 01:03:16 -04:00
2026-07-15 08:44:11 -07:00
2026-07-14 23:18:55 -07:00
2026-04-27 08:21:48 -07:00
2026-06-30 08:04:12 -07:00
2026-04-29 08:15:38 -07:00
2026-07-19 00:10:02 -07:00
2026-07-03 07:47:03 -07:00
2026-07-31 02:05:51 -07:00
2026-06-25 17:04:30 -07:00
2026-07-24 06:21:53 -07:00
2026-08-03 20:18:28 -07:00
2026-05-03 05:47:11 -07:00
2026-07-15 14:41:05 -07:00
2026-07-22 18:26:33 -07:00
2026-07-17 22:45:57 -07:00
2026-07-17 23:18:40 -07:00
2026-06-19 05:13:39 -07:00