Files
fusion/packages/dashboard/app/components/__tests__/Board.test.tsx
gsxdsm 3031d05a68 fix(dashboard): clear all 661 test-file type errors
Production typecheck (tsconfig.json + tsconfig.app.json) was already
clean, but a third config that includes test files surfaced 661 errors
across 60+ test files — accumulated drift between mock fixtures and
production types. Six parallel typescript-pro agents fixed every one
without touching production code.

Per-scope before/after (errors → 0):
  ChatView                                                     183
  Mailbox + Agent suite (5 files)                              156
  Task / Modal suite (6 files)                                 127
  App + small components (12 files)                             96
  Hooks + api/auth (8 files)                                    48
  Long tail (32 files)                                          51
  -----------------------------------------------------------------
  Total                                                        661

Major fix categories:
- Untyped state objects inferring `never[]` / `null` literals (root
  cause of ~120 errors in ChatView alone — added a single
  `UseChatReturn` annotation)
- Mock objects missing fields that became required: `WorkflowStep.mode`,
  `ChatMessage.thinkingOutput / metadata`, `ChatSession.projectId`,
  `Task.log`, `ProjectHealth` fields, `PtyTerminalSessionInfo.createdAt`,
  `Agent.metadata`, `InboxResponse.total`, etc.
- Mock objects with stale fields that no longer exist:
  `AgentBudgetStatus.budgetPeriod`, `truncated` on log responses,
  `OutboxResponse.unreadCount`, `MergeResult.source/target/details`
- Modal props that became required (e.g. `PlanningModeModal.onTasksCreated`)
- String literals not in narrowed unions (`Column`, `WorkflowStepPhase`,
  `InsightStatus`, `AgentLogType`, etc.)
- `querySelector` returning `Element` cast to `HTMLElement` for
  `@testing-library/react`'s `within()`
- Vitest mock typing: `.mock.calls` access needing `vi.mocked(...)`,
  zero-param tuple handling, generic `vi.fn(() => [])` inferring
  `never[]`

Helpers introduced in test files (no shared infra):
- `makeSettings(overrides)` in ModelSelectorTab.test.tsx
- `makePromptOverrides(overrides)` in AgentPromptsManager.test.tsx
- `FileBrowserTestOverrides` type alias in FileBrowser.test.tsx
- `makeInboxResponse / makeOutboxResponse` in MailboxView.test.tsx

Verification:
- tsc -p tsconfig.json:        exit 0
- tsc -p tsconfig.app.json:    exit 0
- tsc -p tsconfig.test-check.json (new — includes test files): exit 0
- vitest run:                  9639 / 9641 (2 pre-existing failures
                               in terminal-mobile-keyboard-layout.test.ts
                               unrelated to this work; verified via
                               `git stash` + run on clean HEAD)

Adds packages/dashboard/tsconfig.test-check.json to keep this regression
guard available locally — same as tsconfig.app.json minus the test
exclude.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 19:59:52 -07:00

443 lines
17 KiB
TypeScript

import React from "react";
import { describe, it, expect, vi, beforeEach } from "vitest";
import { render, screen, fireEvent, waitFor } from "@testing-library/react";
import { Board } from "../Board";
import { COLUMNS } from "@fusion/core";
import type { Task } from "@fusion/core";
vi.mock("../../api", () => ({
fetchWorkflowSteps: vi.fn().mockResolvedValue([
{ id: "WS-003", name: "Accessibility Audit", enabled: true },
]),
}));
const columnRenderCounts: Record<string, number> = {};
// Mock child components so we only test Board's own rendering
vi.mock("../Column", () => ({
Column: React.memo(({ column, tasks, onToggleCollapse, favoriteProviders, favoriteModels, onToggleFavorite, onToggleModelFavorite, isSearchActive, workflowStepNameLookup }: { column: string; tasks: Task[]; onToggleCollapse?: () => void; favoriteProviders?: string[]; favoriteModels?: string[]; onToggleFavorite?: (provider: string) => void; onToggleModelFavorite?: (modelId: string) => void; isSearchActive?: boolean; workflowStepNameLookup?: ReadonlyMap<string, string> }) => {
columnRenderCounts[column] = (columnRenderCounts[column] ?? 0) + 1;
return (
<div data-testid={`column-${column}`} data-tasks={JSON.stringify(tasks)} data-favorite-providers={JSON.stringify(favoriteProviders ?? [])} data-favorite-models={JSON.stringify(favoriteModels ?? [])} data-has-toggle-favorite={onToggleFavorite ? "yes" : "no"} data-has-toggle-model-favorite={onToggleModelFavorite ? "yes" : "no"} data-is-search-active={isSearchActive ? "true" : "false"} data-workflow-lookup-size={String(workflowStepNameLookup?.size ?? 0)}>
{onToggleCollapse && <button onClick={onToggleCollapse}>toggle-{column}</button>}
</div>
);
}),
}));
const noop = () => {};
const noopAsync = () => Promise.resolve({} as any);
beforeEach(() => {
for (const key of Object.keys(columnRenderCounts)) {
delete columnRenderCounts[key];
}
});
function createBoardProps(overrides = {}) {
return {
tasks: [],
maxConcurrent: 2,
onMoveTask: noopAsync,
onOpenDetail: noop,
addToast: noop,
onQuickCreate: noopAsync,
onNewTask: noop,
autoMerge: true,
onToggleAutoMerge: noop,
globalPaused: false,
onUpdateTask: undefined,
onArchiveTask: undefined,
onUnarchiveTask: undefined,
...overrides,
};
}
function renderBoard(props = {}) {
return render(<Board {...createBoardProps(props)} />);
}
describe("Board", () => {
it("renders a <main> element with class 'board'", () => {
renderBoard();
const main = screen.getByRole("main");
expect(main).toBeDefined();
expect(main.className).toContain("board");
});
it("renders with id='board' for scroll targeting", () => {
renderBoard();
const main = screen.getByRole("main");
expect(main.id).toBe("board");
});
it("renders all 6 columns", () => {
renderBoard();
for (const col of COLUMNS) {
expect(screen.getByTestId(`column-${col}`)).toBeDefined();
}
});
it("forwards board-level workflow name lookup to columns", async () => {
renderBoard();
await waitFor(() => {
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-workflow-lookup-size")).toBe("1");
}
});
});
it("renders all 6 columns as direct children of .board (CSS selector target)", () => {
renderBoard();
const board = screen.getByRole("main");
// The mock Column renders <div data-testid="column-{col}" />, which are direct children
const directChildren = Array.from(board.children);
expect(directChildren).toHaveLength(COLUMNS.length);
// Each direct child should be one of the column test-id elements
for (const col of COLUMNS) {
const colEl = screen.getByTestId(`column-${col}`);
expect(colEl.parentElement).toBe(board);
}
});
it("renders the board element as a <main> tag (semantic structure)", () => {
renderBoard();
const board = screen.getByRole("main");
expect(board.tagName).toBe("MAIN");
});
describe("search functionality", () => {
const createTask = (overrides: Partial<Task> & { id: string; description: string }): Task => ({
column: "todo",
dependencies: [],
steps: [],
currentStep: 0,
log: [],
createdAt: "2024-01-01T00:00:00.000Z",
updatedAt: "2024-01-01T00:00:00.000Z",
...overrides,
});
it("renders server-filtered tasks by ID when search query is provided", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "First task", column: "todo" }),
createTask({ id: "FN-002", description: "Second task", column: "todo" }),
createTask({ id: "FN-003", description: "Third task", column: "in-progress" }),
];
// Pre-filtered tasks - only FN-002 matches the search
const filteredTasks = [tasks[1]];
renderBoard({ tasks: filteredTasks, searchQuery: "FN-002" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(1);
expect(todoTasks[0].id).toBe("FN-002");
const inProgressColumn = screen.getByTestId("column-in-progress");
const inProgressTasks = JSON.parse(inProgressColumn.getAttribute("data-tasks") || "[]");
expect(inProgressTasks).toHaveLength(0);
});
it("renders server-filtered tasks by title when search query is provided", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", title: "Fix login bug", description: "First task", column: "todo" }),
createTask({ id: "FN-002", title: "Add dashboard feature", description: "Second task", column: "todo" }),
createTask({ id: "FN-003", title: "Update documentation", description: "Third task", column: "todo" }),
];
// Pre-filtered tasks - only dashboard matches
const filteredTasks = [tasks[1]];
renderBoard({ tasks: filteredTasks, searchQuery: "dashboard" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(1);
expect(todoTasks[0].id).toBe("FN-002");
});
it("renders server-filtered tasks by description when search query is provided", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "Implement user authentication", column: "todo" }),
createTask({ id: "FN-002", description: "Fix database connection issue", column: "todo" }),
createTask({ id: "FN-003", description: "Add caching layer", column: "todo" }),
];
// Pre-filtered tasks - only database matches
const filteredTasks = [tasks[1]];
renderBoard({ tasks: filteredTasks, searchQuery: "database" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(1);
expect(todoTasks[0].id).toBe("FN-002");
});
it("search is case-insensitive (server handles this)", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", title: "Fix Login Bug", description: "First task", column: "todo" }),
createTask({ id: "FN-002", title: "Add Dashboard Feature", description: "Second task", column: "todo" }),
];
// Pre-filtered tasks - only FN-001 matches
const filteredTasks = [tasks[0]];
renderBoard({ tasks: filteredTasks, searchQuery: "login" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(1);
expect(todoTasks[0].id).toBe("FN-001");
});
it("search is case-insensitive for lowercase query matching uppercase content (server handles this)", () => {
const tasks: Task[] = [
createTask({ id: "FN-UPPER", title: "UPPERCASE TITLE", description: "DESC", column: "todo" }),
];
// Pre-filtered tasks - FN-UPPER matches
const filteredTasks = [tasks[0]];
renderBoard({ tasks: filteredTasks, searchQuery: "upper" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(1);
expect(todoTasks[0].id).toBe("FN-UPPER");
});
it("shows all tasks when search query is empty", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "First task", column: "todo" }),
createTask({ id: "FN-002", description: "Second task", column: "todo" }),
createTask({ id: "FN-003", description: "Third task", column: "in-progress" }),
];
renderBoard({ tasks, searchQuery: "" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(2);
const inProgressColumn = screen.getByTestId("column-in-progress");
const inProgressTasks = JSON.parse(inProgressColumn.getAttribute("data-tasks") || "[]");
expect(inProgressTasks).toHaveLength(1);
});
it("shows no tasks when search query matches nothing (server returns empty)", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "First task", column: "todo" }),
createTask({ id: "FN-002", description: "Second task", column: "todo" }),
];
// Pre-filtered tasks - empty array because server found no matches
const filteredTasks: Task[] = [];
renderBoard({ tasks: filteredTasks, searchQuery: "nonexistent" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
expect(todoTasks).toHaveLength(0);
});
it("keeps unaffected columns stable when archived collapse toggles", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "Todo task", column: "todo" }),
createTask({ id: "FN-002", description: "Archived task", column: "archived" }),
];
renderBoard({ tasks });
const initialTodoRenders = columnRenderCounts.todo;
const initialArchivedRenders = columnRenderCounts.archived;
fireEvent.click(screen.getByRole("button", { name: "toggle-archived" }));
expect(columnRenderCounts.archived).toBeGreaterThan(initialArchivedRenders);
expect(columnRenderCounts.todo).toBe(initialTodoRenders);
});
it("only re-renders the affected column when a task updates", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "Todo task", column: "todo", title: "Original" }),
createTask({ id: "FN-002", description: "Done task", column: "done", title: "Done" }),
];
const { rerender } = renderBoard({ tasks });
const initialTodoRenders = columnRenderCounts.todo;
const initialDoneRenders = columnRenderCounts.done;
rerender(
<Board
{...createBoardProps({
tasks: [
{ ...tasks[0], title: "Updated" },
tasks[1],
],
})}
/>,
);
const todoTasks = JSON.parse(screen.getByTestId("column-todo").getAttribute("data-tasks") || "[]");
expect(todoTasks[0].title).toBe("Updated");
expect(columnRenderCounts.todo).toBeGreaterThan(initialTodoRenders);
expect(columnRenderCounts.done).toBeGreaterThanOrEqual(initialDoneRenders);
});
it("filtered tasks are sorted correctly (columnMovedAt, createdAt)", () => {
const tasks: Task[] = [
createTask({
id: "FN-001",
description: "Old task with move time",
column: "todo",
columnMovedAt: "2024-01-01T10:00:00.000Z",
createdAt: "2024-01-01T08:00:00.000Z",
}),
createTask({
id: "FN-002",
description: "Newer task with move time",
column: "todo",
columnMovedAt: "2024-01-01T12:00:00.000Z",
createdAt: "2024-01-01T08:00:00.000Z",
}),
createTask({
id: "FN-003",
description: "Legacy task no move time",
column: "todo",
createdAt: "2024-01-01T09:00:00.000Z",
}),
];
renderBoard({ tasks, searchQuery: "task" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]") as Task[];
// Should have all 3 tasks
expect(todoTasks).toHaveLength(3);
// Tasks with columnMovedAt should come first, sorted by columnMovedAt descending (newest first)
// So FN-002 (12:00) should be first, FN-001 (10:00) second
// Legacy tasks (no columnMovedAt) come last, sorted by createdAt ascending
expect(todoTasks[0].id).toBe("FN-002");
expect(todoTasks[1].id).toBe("FN-001");
expect(todoTasks[2].id).toBe("FN-003");
});
it("renders server-filtered tasks matching across multiple fields simultaneously", () => {
const tasks: Task[] = [
createTask({ id: "SEARCH-123", title: "Searchable title", description: "Normal description", column: "todo" }),
createTask({ id: "FN-999", title: "Other task", description: "This has searchable content", column: "todo" }),
createTask({ id: "FN-888", title: "Unrelated", description: "No match here", column: "todo" }),
];
// Pre-filtered tasks - only the two matching tasks
const filteredTasks = [tasks[0], tasks[1]];
renderBoard({ tasks: filteredTasks, searchQuery: "search" });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
// Should have both matching tasks
expect(todoTasks).toHaveLength(2);
expect(todoTasks.map((t: Task) => t.id).sort()).toEqual(["FN-999", "SEARCH-123"]);
});
it("shows all tasks for whitespace-only search query (server treats as empty)", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "First task", column: "todo" }),
];
renderBoard({ tasks, searchQuery: " " });
const todoColumn = screen.getByTestId("column-todo");
const todoTasks = JSON.parse(todoColumn.getAttribute("data-tasks") || "[]");
// Whitespace-only query should be treated as empty, showing all tasks
expect(todoTasks).toHaveLength(1);
});
it("passes isSearchActive=true to columns when search query is non-empty", () => {
const tasks: Task[] = [
createTask({ id: "FN-001", description: "First task", column: "todo" }),
];
renderBoard({ tasks, searchQuery: "first" });
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-is-search-active")).toBe("true");
}
});
it("passes isSearchActive=false to columns when search query is empty", () => {
renderBoard({ searchQuery: "" });
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-is-search-active")).toBe("false");
}
});
it("passes isSearchActive=false to columns when search query is whitespace-only", () => {
renderBoard({ searchQuery: " " });
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-is-search-active")).toBe("false");
}
});
});
it("does not render a .board-project-context badge", () => {
renderBoard();
const badge = document.querySelector(".board-project-context");
expect(badge).toBeNull();
});
describe("favorite model prop forwarding (FN-770)", () => {
it("forwards favoriteProviders and favoriteModels to all columns", () => {
const favoriteProviders = ["anthropic"];
const favoriteModels = ["claude-sonnet-4-5"];
const onToggleFavorite = vi.fn();
const onToggleModelFavorite = vi.fn();
renderBoard({
favoriteProviders,
favoriteModels,
onToggleFavorite,
onToggleModelFavorite,
});
// Every column should receive the favorite props
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-favorite-providers")).toBe(JSON.stringify(favoriteProviders));
expect(columnEl.getAttribute("data-favorite-models")).toBe(JSON.stringify(favoriteModels));
expect(columnEl.getAttribute("data-has-toggle-favorite")).toBe("yes");
expect(columnEl.getAttribute("data-has-toggle-model-favorite")).toBe("yes");
}
});
it("passes empty arrays for favorites when not provided", () => {
renderBoard();
for (const col of COLUMNS) {
const columnEl = screen.getByTestId(`column-${col}`);
expect(columnEl.getAttribute("data-favorite-providers")).toBe("[]");
expect(columnEl.getAttribute("data-favorite-models")).toBe("[]");
expect(columnEl.getAttribute("data-has-toggle-favorite")).toBe("no");
expect(columnEl.getAttribute("data-has-toggle-model-favorite")).toBe("no");
}
});
});
});