gsxdsm
2fd798cb36
core: every review card reported a false stall on a renamed board ( #2970 )
...
**The failure mode worth distinguishing: the rest of this family went
quiet on a renamed board. This one shouted.**
`getInReviewStallReason` satisfied its **own** lane check from
`context.reviewColumns` — then called `getTaskMergeBlocker` **without**
them. That helper re-ran its column-identity check against the literal
`in-review` and returned, for a perfectly healthy card:
```
task is in 'signoff', must be in 'in-review'
```
…which was surfaced as `{ code: "merge-blocker" }`. **Every in-review
card on a renamed board was flagged as stalled**, each citing a lane the
board does not have. That is how a signal stops being read at all.
## A second symptom, found by the revert rather than by reading
On a **genuinely failed** card, the identity message wins over the real
one. The operator saw the bogus column complaint instead of `task is
marked 'failed': merge verification failed`.
So it did not only invent stalls — it **masked the true reason for real
ones**. I would not have noticed that from the diff; it showed up
because the revert run asserted on the reason text.
## Same shape, last one in the family
The outer question was resolved and the inner one was not — the
half-conversion the helper's own comment records for `moves.ts`, and
#2963/#2964 fixed for the merge entry points. This is the last site the
audit turned up where the lane answer was already in scope and simply
not forwarded.
## Revert results
| | reverted → |
| --- | --- |
| the unforwarded call (what ships today) | **2 of 3 fail** — healthy
card reports a merge-blocker stall; failed card reports the wrong reason
|
**Fixture note worth keeping:** `paused` is deliberately *not* the
genuine-stall case. An earlier guard returns `undefined` for a paused
card before the merge blocker is ever consulted, so that case would pass
whether or not the lanes are forwarded — the vacuous shape this series
has produced eight times.
## Verification
`pnpm test:gate` 161 + 487 + 13 + 71; `@fusion/core` full suite **4878
passed** (457 files); `tsc` core clean; lint, lifecycle census
`--strict`, FNXC gate, changesets all clean.
2026-07-30 22:25:24 -07:00
..
2026-07-27 15:25:17 -07:00
2026-07-30 22:25:24 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 12:01:19 -07:00
2026-07-30 21:35:23 -07:00
2026-07-30 21:35:23 -07:00
2026-07-30 21:50:37 -07:00
2026-07-15 10:36:10 -07:00
2026-07-30 02:08:26 -07:00
2026-06-07 18:51:46 -07:00
2026-07-15 16:17:37 -07:00
2026-07-04 10:42:21 -07:00
2026-07-09 19:58:05 -07:00
2026-07-29 22:39:14 -07:00
2026-07-30 08:09:36 -07:00
2026-07-30 05:52:01 -07:00
2026-07-13 19:07:58 -07:00
2026-07-26 12:01:19 -07:00
2026-07-01 16:19:03 -07:00
2026-07-19 13:34:25 -07:00
2026-07-30 21:50:37 -07:00
2026-07-21 23:10:08 -07:00
2026-07-16 17:05:29 -07:00
2026-07-30 09:28:27 -07:00
2026-07-16 16:01:29 -07:00
2026-07-23 20:19:18 -07:00
2026-07-30 21:50:37 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 08:16:42 -07:00
2026-07-28 23:23:13 -07:00
2026-07-16 05:33:55 -07:00
2026-07-24 18:09:32 -07:00
2026-07-18 11:34:42 -07:00
2026-07-16 00:30:59 -07:00
2026-07-16 16:01:29 -07:00
2026-07-13 19:07:58 -07:00
2026-07-18 13:18:08 -07:00
2026-07-18 13:18:08 -07:00
2026-07-16 00:30:59 -07:00
2026-07-14 22:13:30 -07:00
2026-07-21 00:00:08 -07:00
2026-07-30 21:35:23 -07:00
2026-07-30 21:35:23 -07:00
2026-07-13 19:07:58 -07:00
2026-07-16 16:01:29 -07:00
2026-07-14 12:41:10 -07:00
2026-07-26 12:01:19 -07:00
2026-07-17 01:23:32 -07:00
2026-07-14 13:36:08 -07:00
2026-07-26 23:28:42 -07:00
2026-07-12 19:43:41 -07:00
2026-06-21 13:32:19 -07:00
2026-07-16 16:34:09 -07:00
2026-07-16 16:34:09 -07:00
2026-07-30 12:02:53 -07:00
2026-06-07 20:43:44 -07:00
2026-06-03 13:51:13 -07:00
2026-07-05 11:31:48 -07:00
2026-06-29 14:00:32 -07:00
2026-06-29 18:41:43 -07:00
2026-07-26 23:42:46 -07:00
2026-07-28 22:19:28 -07:00
2026-07-01 16:43:08 -07:00
2026-06-29 11:07:11 -07:00
2026-06-29 12:23:20 -07:00
2026-07-26 23:42:46 -07:00
2026-06-29 12:23:20 -07:00
2026-07-05 16:58:42 -07:00
2026-07-29 09:54:39 -07:00
2026-07-26 23:42:46 -07:00
2026-06-08 23:38:32 -07:00
2026-06-26 00:26:03 -07:00
2026-06-29 11:24:41 -07:00
2026-07-29 00:05:29 -07:00
2026-07-29 09:54:39 -07:00
2026-07-29 22:41:17 -07:00
2026-07-14 22:13:30 -07:00
2026-07-24 18:09:32 -07:00
2026-07-24 18:09:32 -07:00
2026-07-16 00:30:59 -07:00
2026-06-04 22:52:20 -07:00
2026-06-05 00:57:49 -07:00
2026-06-05 13:59:50 -07:00
2026-07-30 03:01:36 -07:00
2026-07-20 09:57:38 -07:00
2026-07-16 21:42:44 -07:00
2026-07-18 11:34:42 -07:00
2026-07-13 19:07:58 -07:00
2026-07-13 19:07:58 -07:00
2026-07-30 14:09:10 -07:00
2026-07-18 12:32:07 -07:00
2026-06-26 14:55:01 -07:00
2026-07-26 12:01:19 -07:00
2026-07-30 09:28:27 -07:00
2026-07-30 12:25:00 -07:00
2026-07-30 12:25:00 -07:00
2026-07-22 08:53:31 -07:00
2026-07-30 13:55:10 -07:00
2026-07-14 08:16:42 -07:00
2026-07-14 08:16:42 -07:00
2026-07-13 19:07:58 -07:00
2026-06-26 08:40:59 -07:00
2026-07-26 10:23:00 -07:00
2026-07-21 18:00:35 -07:00
2026-07-16 16:01:29 -07:00
2026-06-12 09:24:02 -07:00
2026-07-14 22:13:30 -07:00
2026-07-30 21:50:58 -07:00
2026-07-17 23:56:34 -07:00
2026-07-18 00:33:14 -07:00
2026-07-17 23:56:34 -07:00
2026-07-30 16:53:12 -07:00
2026-07-02 19:01:09 -07:00
2026-07-30 16:53:12 -07:00
2026-07-02 11:38:34 -07:00
2026-07-16 16:34:09 -07:00
2026-07-18 11:34:42 -07:00
2026-07-09 21:36:14 -07:00
2026-07-18 13:18:08 -07:00
2026-06-28 16:51:49 -07:00
2026-07-30 22:25:24 -07:00
2026-07-30 20:30:18 -07:00
2026-07-30 22:06:24 -07:00
2026-07-30 22:06:24 -07:00
2026-07-13 19:07:58 -07:00
2026-07-13 19:07:58 -07:00
2026-07-22 18:16:00 -07:00
2026-07-30 08:57:52 -07:00
2026-07-26 09:50:43 -07:00
2026-07-16 20:37:05 -07:00
2026-07-26 12:01:19 -07:00
2026-07-22 15:25:20 -07:00
2026-06-26 11:56:12 -07:00
2026-07-11 17:16:49 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 17:48:46 -07:00
2026-07-21 00:00:08 -07:00
2026-07-26 12:01:19 -07:00
2026-07-14 22:13:30 -07:00
2026-07-30 21:35:23 -07:00
2026-07-30 21:35:23 -07:00
2026-07-18 19:18:57 -07:00
2026-07-16 19:48:11 -07:00
2026-07-22 08:53:31 -07:00
2026-06-15 19:57:20 -07:00
2026-06-11 20:53:01 -07:00
2026-07-30 09:28:27 -07:00
2026-06-25 03:44:22 -07:00
2026-07-16 19:36:02 -07:00
2026-06-13 02:54:57 -07:00
2026-07-26 12:01:19 -07:00
2026-07-30 13:08:25 -07:00
2026-06-13 23:20:06 -07:00
2026-07-09 23:12:02 -07:00
2026-07-18 11:49:11 -07:00
2026-07-15 02:19:19 -07:00
2026-07-04 19:29:47 +00:00
2026-07-14 20:27:35 -07:00
2026-07-14 20:27:35 -07:00
2026-07-14 22:13:30 -07:00
2026-07-15 21:33:11 -07:00
2026-07-04 13:51:09 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 20:27:35 -07:00
2026-07-14 20:27:35 -07:00
2026-07-11 22:16:48 -07:00
2026-07-20 17:35:06 -07:00
2026-07-13 19:07:58 -07:00
2026-06-04 01:43:26 -07:00
2026-07-30 21:50:37 -07:00
2026-07-26 08:35:04 -07:00
2026-07-10 07:46:52 -07:00
2026-07-12 11:52:24 -07:00
2026-07-30 19:41:09 -07:00
2026-07-30 21:50:37 -07:00
2026-07-30 21:50:37 -07:00
2026-07-20 01:54:42 -07:00
2026-06-15 19:44:17 -07:00
2026-07-26 09:50:43 -07:00
2026-07-30 16:50:00 -07:00
2026-07-16 16:01:29 -07:00
2026-07-30 20:17:18 -07:00
2026-07-14 22:13:30 -07:00
2026-07-23 11:41:15 -07:00
2026-06-05 03:56:29 -07:00
2026-07-26 12:01:19 -07:00
2026-07-18 16:18:15 -07:00
2026-07-13 19:07:58 -07:00
2026-07-18 16:18:15 -07:00
2026-07-15 20:53:05 -07:00
2026-07-19 11:50:52 -07:00
2026-07-26 23:28:42 -07:00
2026-07-26 23:28:42 -07:00
2026-07-13 19:07:58 -07:00
2026-07-14 20:27:35 -07:00
2026-07-30 21:50:37 -07:00
2026-07-14 22:13:30 -07:00
2026-07-29 23:34:41 -07:00
2026-07-16 15:37:42 -07:00
2026-07-15 13:32:33 -07:00
2026-06-26 00:28:31 -07:00
2026-07-15 10:38:04 -07:00
2026-07-16 20:37:05 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 22:13:30 -07:00
2026-07-30 20:30:18 -07:00
2026-07-27 14:19:32 -07:00
2026-06-30 07:31:59 -07:00
2026-07-30 14:26:11 -07:00
2026-07-19 15:20:39 -07:00
2026-07-18 19:31:30 -07:00
2026-06-21 13:32:19 -07:00
2026-07-30 05:52:01 -07:00
2026-07-26 13:15:36 -07:00
2026-07-26 13:15:36 -07:00
2026-07-22 08:30:12 -07:00
2026-06-04 13:19:55 -07:00
2026-06-28 01:43:08 -07:00
2026-06-19 06:51:57 -07:00
2026-06-18 03:24:57 -07:00
2026-07-30 22:06:24 -07:00
2026-07-30 12:03:07 -07:00
2026-06-24 10:45:21 -07:00
2026-07-30 09:28:27 -07:00
2026-07-19 21:19:56 -07:00
2026-07-30 09:28:27 -07:00
2026-07-30 16:09:14 -07:00
2026-07-16 00:30:59 -07:00
2026-07-14 08:16:42 -07:00
2026-07-30 05:33:27 -07:00
2026-06-04 02:13:48 -07:00
2026-06-04 00:19:57 -07:00
2026-06-04 00:19:58 -07:00
2026-06-04 00:19:58 -07:00
2026-07-30 21:50:37 -07:00
2026-07-26 12:01:19 -07:00
2026-06-03 13:48:02 -07:00
2026-07-30 17:40:48 -07:00
2026-07-30 03:10:35 -07:00
2026-07-14 13:36:08 -07:00
2026-07-27 13:30:13 -07:00
2026-06-07 21:19:10 -07:00
2026-06-07 20:43:44 -07:00
2026-07-30 13:15:04 -07:00
2026-07-29 00:05:29 -07:00
2026-07-27 15:06:19 -07:00
2026-07-30 17:52:56 -07:00
2026-07-01 16:43:08 -07:00
2026-07-26 09:40:37 -07:00
2026-07-21 12:17:47 -07:00
2026-06-21 21:23:41 -07:00
2026-07-28 18:52:46 -07:00
2026-07-23 08:53:06 -07:00
2026-07-16 01:32:23 -07:00
2026-07-26 12:24:29 -07:00
2026-07-10 01:49:15 -07:00
2026-07-19 11:50:52 -07:00
2026-07-29 22:39:33 -07:00
2026-07-16 15:27:03 -07:00
2026-06-13 21:17:20 -07:00