## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
57 lines
2.1 KiB
TypeScript
57 lines
2.1 KiB
TypeScript
/**
|
|
* FNXC:CodeOrganization 2026-08-03-18:30:
|
|
* generateCompletionFeatureVideo + awaitFeatureVideoBounded peeled from TaskExecutor (U4).
|
|
*
|
|
* FNXC:ReviewArtifacts 2026-07-19-10:00:
|
|
* A successful executor handoff may offer reviewers a short local feature-video, but capture is
|
|
* strictly best-effort. Bound and swallow this optional work before the review transition so
|
|
* browser, scenario, and artifact failures never delay or fail it.
|
|
*/
|
|
import type { Task, TaskStore } from "@fusion/core";
|
|
import { executorLog } from "../logger.js";
|
|
import {
|
|
generateFeatureVideo,
|
|
type FeatureVideoResult,
|
|
type GenerateFeatureVideoOptions,
|
|
} from "../review-artifacts/feature-video.js";
|
|
|
|
export type CompletionFeatureVideoDeps = {
|
|
store: TaskStore;
|
|
options: {
|
|
reviewArtifactGenerator?: (opts: GenerateFeatureVideoOptions) => Promise<FeatureVideoResult>;
|
|
[k: string]: unknown;
|
|
};
|
|
};
|
|
|
|
const FEATURE_VIDEO_TIMEOUT_MS = 20_000;
|
|
|
|
export async function awaitFeatureVideoBounded(
|
|
result: Promise<FeatureVideoResult>,
|
|
): Promise<FeatureVideoResult> {
|
|
let timeout: ReturnType<typeof setTimeout> | undefined;
|
|
try {
|
|
return await Promise.race([
|
|
result,
|
|
new Promise<never>((_, reject) => {
|
|
timeout = setTimeout(() => reject(new Error("feature-video timeout")), FEATURE_VIDEO_TIMEOUT_MS);
|
|
}),
|
|
]);
|
|
} finally {
|
|
if (timeout) clearTimeout(timeout);
|
|
}
|
|
}
|
|
|
|
export async function generateCompletionFeatureVideo(
|
|
deps: CompletionFeatureVideoDeps,
|
|
task: Task,
|
|
): Promise<void> {
|
|
try {
|
|
const [settings, detail] = await Promise.all([deps.store.getSettings(), deps.store.getTask(task.id)]);
|
|
const generator = deps.options.reviewArtifactGenerator ?? generateFeatureVideo;
|
|
const result = await awaitFeatureVideoBounded(generator({ store: deps.store, task: detail ?? task, settings }));
|
|
executorLog.log(`${task.id}: feature-video ${result.status}${"reason" in result ? ` (${result.reason})` : ""}`);
|
|
} catch (error) {
|
|
executorLog.warn(`${task.id}: feature-video capture ignored: ${error instanceof Error ? error.message : String(error)}`);
|
|
}
|
|
}
|