Files
fusion/packages/dashboard/app/__tests__/activity-feed-theme-styling.test.ts
gsxdsm c3d1716fdd refactor(dashboard): split monolithic styles.css into per-component files
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).

- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
  React.lazy + Suspense; prefetch all chunks on idle so first navigation is
  instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
  635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.

- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
  so CSS regression tests load the full per-component bundle (mirroring Vite
  source order). Migrate 30+ tests off direct readFileSync('../styles.css').

- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
  imports actually inject styles in jsdom (fixes getComputedStyle assertions).

- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
  dashboard test files; points at loadAllAppCss() instead.

- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
  .form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.

- Mobile fixes along the way: scroll containment for view containers
  (min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
  mobile (with safe-area-inset for iOS home bar), AgentsView single-row
  header layout, ActivityLogModal close button on right, model-combobox
  z-index above the mobile quick-chat panel.

- Bug fix: SkillsView toggle was display:none which hid the input from the
  accessibility tree; replaced with the visually-hidden pattern so screen
  readers + getByRole still find the checkbox.

- Bug fix: standalone Delete button in TaskDetailModal for triage-column
  tasks (Actions dropdown is hidden in triage state, so previously no way
  to delete a freshly-created task without status change first).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 19:39:20 -07:00

129 lines
4.1 KiB
TypeScript

import { describe, it, expect, beforeAll } from "vitest";
import fs from "fs";
import path from "path";
/**
* Theme-safety regression tests for ActivityFeed CSS and component.
*
* These tests verify that ActivityFeed styles use theme-aware tokens
* instead of hardcoded colors, ensuring correct rendering across all
* color themes and light/dark modes.
*/
describe("ActivityFeed theme styling", () => {
let activityFeedCss: string;
beforeAll(() => {
activityFeedCss = fs.readFileSync(
path.resolve(__dirname, "../components/ActivityFeed.css"),
"utf-8",
);
});
function getActivityFeedBlock(): string {
return activityFeedCss;
}
it("does not use hardcoded rgba(88, 166, 255) in the project badge background", () => {
const block = getActivityFeedBlock();
// The old hardcoded blue: rgba(88, 166, 255, 0.1)
expect(block).not.toContain("rgba(88, 166, 255");
// The project badge should use theme-aware color-mix instead
expect(block).toContain("color-mix(in srgb, var(--todo) 10%, transparent)");
});
it("uses --color-error token (not undefined --error) for error message styling", () => {
const block = getActivityFeedBlock();
// --error is not a defined token; --color-error is correct
expect(block).not.toContain("var(--error)");
expect(block).toContain("var(--color-error)");
});
it("uses design tokens for all color references in activity-feed rules", () => {
const block = getActivityFeedBlock();
// Token-based colors should be used (var(--...))
// No raw hex colors (#xxx) in activity feed rules except through tokens
const lines = block.split("\n");
const colorLines = lines.filter(
(line) =>
line.includes("color:") ||
line.includes("background:") ||
line.includes("border-color:")
);
// Every color/background/border-color line should use var() or color-mix()
for (const line of colorLines) {
// Skip lines that are just property declarations without values
const value = line.split(":").slice(1).join(":").trim().replace(/;$/, "");
// Allow transparent, none, inherit, initial
if (["transparent", "none", "inherit", "initial", ""].includes(value)) {
continue;
}
// Every value should use var() or color-mix() — no hardcoded hex/rgb/rgba
expect(
value.includes("var(") || value.includes("color-mix("),
`Expected token-based color but got hardcoded: "${line.trim()}"`
).toBe(true);
}
});
});
describe("ActivityFeed component theme tokens", () => {
const componentPath = path.resolve(
__dirname,
"../components/ActivityFeed.tsx"
);
let source: string;
beforeAll(() => {
source = fs.readFileSync(componentPath, "utf-8");
});
it("does not reference undefined --error token in TYPE_CONFIG", () => {
// --error is not a defined CSS custom property; the correct token is --color-error
// Search for var(--error) but NOT var(--color-error)
const varErrorPattern = /var\(--error\)(?!-)/g;
const matches = source.match(varErrorPattern);
expect(
matches,
`Found var(--error) in ActivityFeed.tsx — use var(--color-error) instead`
).toBeNull();
});
it("uses valid theme tokens for all event type colors", () => {
// Extract color values from TYPE_CONFIG
const typeConfigMatch = source.match(
/TYPE_CONFIG[^=]*=\s*\{([\s\S]*?)\};/
);
expect(typeConfigMatch).not.toBeNull();
const configBlock = typeConfigMatch![1];
const colorValues = [...configBlock.matchAll(/color:\s*"([^"]+)"/g)].map(
(m) => m[1]
);
// Every color should be a var() token reference
for (const color of colorValues) {
expect(
color.startsWith("var(--"),
`Expected token reference but got: "${color}"`
).toBe(true);
}
});
it("does not contain hardcoded hex colors in inline styles", () => {
// No raw #rrggbb or #rgb hex values in the component source
const hexPattern = /"[^"]*#[0-9a-fA-F]{3,8}[^"]*"/g;
const matches = source.match(hexPattern);
expect(
matches,
`Found hardcoded hex colors in ActivityFeed.tsx: ${matches}`
).toBeNull();
});
});