Production typecheck (tsconfig.json + tsconfig.app.json) was already
clean, but a third config that includes test files surfaced 661 errors
across 60+ test files — accumulated drift between mock fixtures and
production types. Six parallel typescript-pro agents fixed every one
without touching production code.
Per-scope before/after (errors → 0):
ChatView 183
Mailbox + Agent suite (5 files) 156
Task / Modal suite (6 files) 127
App + small components (12 files) 96
Hooks + api/auth (8 files) 48
Long tail (32 files) 51
-----------------------------------------------------------------
Total 661
Major fix categories:
- Untyped state objects inferring `never[]` / `null` literals (root
cause of ~120 errors in ChatView alone — added a single
`UseChatReturn` annotation)
- Mock objects missing fields that became required: `WorkflowStep.mode`,
`ChatMessage.thinkingOutput / metadata`, `ChatSession.projectId`,
`Task.log`, `ProjectHealth` fields, `PtyTerminalSessionInfo.createdAt`,
`Agent.metadata`, `InboxResponse.total`, etc.
- Mock objects with stale fields that no longer exist:
`AgentBudgetStatus.budgetPeriod`, `truncated` on log responses,
`OutboxResponse.unreadCount`, `MergeResult.source/target/details`
- Modal props that became required (e.g. `PlanningModeModal.onTasksCreated`)
- String literals not in narrowed unions (`Column`, `WorkflowStepPhase`,
`InsightStatus`, `AgentLogType`, etc.)
- `querySelector` returning `Element` cast to `HTMLElement` for
`@testing-library/react`'s `within()`
- Vitest mock typing: `.mock.calls` access needing `vi.mocked(...)`,
zero-param tuple handling, generic `vi.fn(() => [])` inferring
`never[]`
Helpers introduced in test files (no shared infra):
- `makeSettings(overrides)` in ModelSelectorTab.test.tsx
- `makePromptOverrides(overrides)` in AgentPromptsManager.test.tsx
- `FileBrowserTestOverrides` type alias in FileBrowser.test.tsx
- `makeInboxResponse / makeOutboxResponse` in MailboxView.test.tsx
Verification:
- tsc -p tsconfig.json: exit 0
- tsc -p tsconfig.app.json: exit 0
- tsc -p tsconfig.test-check.json (new — includes test files): exit 0
- vitest run: 9639 / 9641 (2 pre-existing failures
in terminal-mobile-keyboard-layout.test.ts
unrelated to this work; verified via
`git stash` + run on clean HEAD)
Adds packages/dashboard/tsconfig.test-check.json to keep this regression
guard available locally — same as tsconfig.app.json minus the test
exclude.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
233 lines
7.8 KiB
TypeScript
233 lines
7.8 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import { renderHook, act, waitFor } from "@testing-library/react";
|
|
import { useProjectFileEditor } from "../useProjectFileEditor";
|
|
import * as api from "../../api";
|
|
import type { FileContentResponse, SaveFileResponse } from "../../api";
|
|
|
|
// Mock the api module
|
|
vi.mock("../../api", () => ({
|
|
fetchWorkspaceFileContent: vi.fn(),
|
|
saveWorkspaceFileContent: vi.fn(),
|
|
}));
|
|
|
|
const mockFetchWorkspaceFileContent = vi.mocked(api.fetchWorkspaceFileContent);
|
|
const mockSaveWorkspaceFileContent = vi.mocked(api.saveWorkspaceFileContent);
|
|
|
|
describe("useProjectFileEditor", () => {
|
|
beforeEach(() => {
|
|
mockFetchWorkspaceFileContent.mockReset();
|
|
mockSaveWorkspaceFileContent.mockReset();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("initializes with empty content when no file is selected", () => {
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", null, true));
|
|
|
|
expect(result.current.content).toBe("");
|
|
expect(result.current.originalContent).toBe("");
|
|
expect(result.current.loading).toBe(false);
|
|
expect(result.current.saving).toBe(false);
|
|
expect(result.current.error).toBeNull();
|
|
expect(result.current.hasChanges).toBe(false);
|
|
expect(result.current.mtime).toBeNull();
|
|
});
|
|
|
|
it("loads file content when file is selected", async () => {
|
|
const mockResponse: FileContentResponse = {
|
|
content: "console.log('hello');",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 21,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(mockResponse);
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "src/index.ts", true));
|
|
|
|
expect(result.current.loading).toBe(true);
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
expect(result.current.content).toBe("console.log('hello');");
|
|
expect(result.current.originalContent).toBe("console.log('hello');");
|
|
expect(result.current.mtime).toBe("2024-01-01T00:00:00Z");
|
|
expect(result.current.hasChanges).toBe(false);
|
|
expect(mockFetchWorkspaceFileContent).toHaveBeenCalledWith("project", "src/index.ts");
|
|
});
|
|
|
|
it("tracks content changes", async () => {
|
|
const mockResponse: FileContentResponse = {
|
|
content: "original content",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 16,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(mockResponse);
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "file.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
expect(result.current.hasChanges).toBe(false);
|
|
|
|
act(() => {
|
|
result.current.setContent("modified content");
|
|
});
|
|
|
|
expect(result.current.content).toBe("modified content");
|
|
expect(result.current.hasChanges).toBe(true);
|
|
});
|
|
|
|
it("saves changes successfully", async () => {
|
|
const loadResponse: FileContentResponse = {
|
|
content: "original",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 8,
|
|
};
|
|
const saveResponse: SaveFileResponse = {
|
|
success: true,
|
|
mtime: "2024-01-02T00:00:00Z",
|
|
size: 16,
|
|
};
|
|
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(loadResponse);
|
|
mockSaveWorkspaceFileContent.mockResolvedValueOnce(saveResponse);
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "file.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
act(() => {
|
|
result.current.setContent("modified content");
|
|
});
|
|
|
|
expect(result.current.hasChanges).toBe(true);
|
|
|
|
await act(async () => {
|
|
await result.current.save();
|
|
});
|
|
|
|
expect(result.current.originalContent).toBe("modified content");
|
|
expect(result.current.mtime).toBe("2024-01-02T00:00:00Z");
|
|
expect(result.current.hasChanges).toBe(false);
|
|
expect(mockSaveWorkspaceFileContent).toHaveBeenCalledWith("project", "file.txt", "modified content");
|
|
});
|
|
|
|
it("handles load errors", async () => {
|
|
mockFetchWorkspaceFileContent.mockRejectedValueOnce(new Error("Failed to load file"));
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "missing.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
expect(result.current.error).toBe("Failed to load file");
|
|
expect(result.current.content).toBe("");
|
|
expect(result.current.originalContent).toBe("");
|
|
expect(result.current.mtime).toBeNull();
|
|
});
|
|
|
|
it("handles save errors", async () => {
|
|
const loadResponse: FileContentResponse = {
|
|
content: "original",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 8,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(loadResponse);
|
|
mockSaveWorkspaceFileContent.mockRejectedValueOnce(new Error("Failed to save file"));
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "file.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
act(() => {
|
|
result.current.setContent("modified");
|
|
});
|
|
|
|
await act(async () => {
|
|
await expect(result.current.save()).rejects.toThrow("Failed to save file");
|
|
});
|
|
// Wait for React state update after the catch block sets error
|
|
await waitFor(() => expect(result.current.error).toBe("Failed to save file"));
|
|
expect(result.current.hasChanges).toBe(true);
|
|
});
|
|
|
|
it("does not load when disabled", async () => {
|
|
renderHook(() => useProjectFileEditor("/project", "file.txt", false));
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 50));
|
|
|
|
expect(mockFetchWorkspaceFileContent).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("does not save when there are no changes", async () => {
|
|
const loadResponse: FileContentResponse = {
|
|
content: "original",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 8,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(loadResponse);
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "file.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
await act(async () => {
|
|
await result.current.save();
|
|
});
|
|
|
|
expect(mockSaveWorkspaceFileContent).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("clears error when content changes", async () => {
|
|
const loadResponse: FileContentResponse = {
|
|
content: "original",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 8,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(loadResponse);
|
|
mockSaveWorkspaceFileContent.mockRejectedValueOnce(new Error("Save failed"));
|
|
|
|
const { result } = renderHook(() => useProjectFileEditor("/project", "file.txt", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
act(() => {
|
|
result.current.setContent("modified");
|
|
});
|
|
|
|
await act(async () => {
|
|
await expect(result.current.save()).rejects.toThrow("Save failed");
|
|
});
|
|
// Wait for React state update after the catch block sets error
|
|
await waitFor(() => expect(result.current.error).toBe("Save failed"));
|
|
|
|
act(() => {
|
|
result.current.setContent("modified again");
|
|
});
|
|
|
|
expect(result.current.error).toBeNull();
|
|
});
|
|
|
|
it("resets state when filePath becomes null", async () => {
|
|
const loadResponse: FileContentResponse = {
|
|
content: "content",
|
|
mtime: "2024-01-01T00:00:00Z",
|
|
size: 7,
|
|
};
|
|
mockFetchWorkspaceFileContent.mockResolvedValueOnce(loadResponse);
|
|
|
|
const { result, rerender } = renderHook(
|
|
({ filePath }: { filePath: string | null }) => useProjectFileEditor("/project", filePath, true),
|
|
{ initialProps: { filePath: "file.txt" as string | null } }
|
|
);
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
expect(result.current.content).toBe("content");
|
|
|
|
rerender({ filePath: null });
|
|
|
|
expect(result.current.content).toBe("");
|
|
expect(result.current.originalContent).toBe("");
|
|
expect(result.current.mtime).toBeNull();
|
|
expect(result.current.error).toBeNull();
|
|
});
|
|
});
|