1cf86baa1c
## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
50 lines
2.0 KiB
TypeScript
50 lines
2.0 KiB
TypeScript
/**
|
|
* FNXC:CodeOrganization 2026-08-03-15:40:
|
|
* runImplementationPhase peeled from TaskExecutor (U4).
|
|
*
|
|
* Graph-owned implementation runner: one direct runImplementation pass with
|
|
* completion/exit capture — no re-entry through execute() routing.
|
|
*
|
|
* FNXC:WorkflowExecution 2026-07-19-02:10:
|
|
* U5e (R9) — calls runImplementation() DIRECTLY. It used to re-enter execute(),
|
|
* which meant every graph-driven implementation pass made a second trip through
|
|
* routing that had to be suppressed by a signal.
|
|
*/
|
|
import type { Task } from "@fusion/core";
|
|
import type { PreparedWorktree } from "../execution/runtime-primitives.js";
|
|
import type { ImplementationExit, ImplementationExitReporter } from "./implementation-exit.js";
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any -- mirror TaskExecutor method surface
|
|
type AnyFn = (...args: any[]) => any;
|
|
|
|
/** Mirrors TaskExecutor GraphCompletionCallback. */
|
|
export type GraphCompletionCallback = (info: { modifiedFiles: string[] }) => void;
|
|
|
|
export type RunImplementationPhaseDeps = {
|
|
runImplementation: AnyFn;
|
|
};
|
|
|
|
export async function runImplementationPhase(
|
|
deps: RunImplementationPhaseDeps,
|
|
task: Task,
|
|
prepared?: PreparedWorktree,
|
|
): Promise<{ taskDone: boolean; modifiedFiles: string[]; exit?: ImplementationExit }> {
|
|
let captured: { taskDone: boolean; modifiedFiles: string[]; exit?: ImplementationExit } = { taskDone: false, modifiedFiles: [] };
|
|
const graphCompletion: GraphCompletionCallback = (info) => {
|
|
captured = { ...captured, taskDone: true, modifiedFiles: info.modifiedFiles };
|
|
};
|
|
/* Recorded independently of `graphCompletion`: the out-of-band exits never call it. */
|
|
const reportExit: ImplementationExitReporter = (exit) => {
|
|
captured = { ...captured, exit };
|
|
};
|
|
const executionTask = prepared
|
|
? {
|
|
...task,
|
|
worktree: prepared.worktreePath || task.worktree,
|
|
branch: prepared.branchName || task.branch,
|
|
}
|
|
: task;
|
|
await deps.runImplementation(executionTask, graphCompletion, reportExit);
|
|
return captured;
|
|
}
|