# Migrate storage from SQLite to PostgreSQL — full dashboard cutover Migrates Fusion's storage layer to the embedded PostgreSQL `AsyncDataLayer` (the default backend) and **completes the satellite-store + feature cutover** so every dashboard and Command Center surface works in PG mode. ## Status — every surface works in embedded-PG mode Verified live against a running embedded-Postgres dashboard (all **200**, zero 5xx) and gate-tested (**23 files / 99 tests** on embedded PG, plus engine-core 294 and ci-shape 63 in the blocking merge gate; core/engine/cli/dashboard typecheck clean). | Area | Surfaces | State | |---|---|---| | Satellite stores | workflows, todos, insights, research, missions, goals, mailbox | ✅ | | Views | artifacts, documents, evals | ✅ | | Command Center | activity, productivity, team, tokens, tools, **workflows**, **github**, **signals**, **plugin-activations**, **live** (all 10) | ✅ | | Run execution | insight generation, research run execution | ✅ (store-path; AI step needs a provider) | | Live updates | SSE push for mission/research/insight events | ✅ | | Workflow editing | create / update / delete / select (+ id counter) | ✅ | | Engine | mission autopilot, incident-signal ingestion, regression storm-guard, agent wake-on-message | ✅ | | Core | tasks, agents, secrets, automations, memory, chat, usage, PRs, git | ✅ | ## Approach Each satellite store gets an `Async<Store>` wrapper exposing the sync store's method names over the existing `async-*-store.ts` helpers; `get<Store>Store()` returns a `Sync | Async` union; consumers `await` (harmless on sync), and engine/CLI paths that can't convert use `instanceof Sync` graceful fallback. Analytics aggregators branch on `"ping" in dbOrLayer` to run schema-qualified raw SQL over `project.*` (snake_case) in PG. Executors/orchestrators/autopilot are await-converted to drive the union store; the async store wrappers extend `EventEmitter` so SSE live-push fires in both backends. Not-yet-ported capabilities degrade gracefully (never 500) and are individually called out in commits. ## Sync with main The branch is kept continuously merged with `main` (currently through FN-7845, 2026-07-12); the earlier "final rebase deferred" note no longer applies. Use **Create a merge commit** (or squash) to land it — GitHub's rebase-merge cannot replay a merge-maintained branch. ## Residual Review Findings Multi-agent code review of the PostgreSQL satellite-store ports (U1–U5) applied 3 safe fixes (see `fix(review): apply autofix feedback`). The following are **real but gated** — recorded here as follow-up work rather than auto-applied. All are SQLite→PostgreSQL **concurrency/atomicity regressions**: the sync stores were immune only by SQLite's single-writer, single-threaded-handler execution; the async ports open multi-await read-modify-write windows. **Reachability is low today** because the execution engines that generate concurrent same-run mutations (insight run executor, research orchestrator/dispatcher) are `instanceof`-gated to sync mode in PG. No process-crash class survived (all engine fallbacks correctly guard the sync store). - **[P1] Research `appendResearchEvent` dual-write is non-atomic** (`packages/core/src/async-research-store.ts`, corroborated: adversarial + reliability). The `research_run_events` insert (own transaction) and the `run.events` jsonb update are separate writes — a crash between them, or two concurrent appends, splits the table count from the jsonb array. **Fix:** perform the seq-insert and the jsonb update in one `layer.transactionImmediate`. - **[P1] Research run terminal-reversion via stale full-row persist** (`async-research-store.ts` `persistResearchRun`/`updateResearchStatus`). Concurrent `PATCH /runs/:id/status` + `POST /runs/:id/events` can revert a terminal run to `running` by overwriting the whole row, bypassing the transition guard. **Fix:** scoped column `UPDATE`s with a `WHERE status …` guard, or optimistic version column. - **[P2] `updateResearchRun`/`updateInsightRun` read-then-write TOCTOU** — concurrent PATCHes last-writer-wins on the lifecycle merge. **Fix:** `SELECT … FOR UPDATE` / enclosing transaction. - **[P2] `upsertRun`/`createRunOrThrowConflict` check-then-create race** (`async-insight-store.ts`) — two callers can each create an "active" run. **Fix:** partial unique index on `(projectId, trigger) WHERE status IN ('pending','running')`. - **[P3] `createResearchRetryRun` return-value divergence** — sync returns the pre-update `queued` snapshot; async returns the reloaded `retry_waiting` run (persisted state is identical). Pick one side for cross-backend parity. - **[P2/perf] Mission `getMissionWithHierarchy`/`getMissionHealth` N+1 fan-out** — O(milestones×slices) sequential round-trips hold one pool slot per request; can starve the pool for large hierarchies. **Fix:** batched/joined reads. - **Testing gaps:** no PG-mode concurrency tests (interleaved status/event mutations), no sync↔async parity assertion for the lifecycle-error codes, and no mission status/health rollup parity test vs the sync `MissionStore`. ~~Out of scope (deferred): AI run *execution* (insight/research) + mission autopilot + live SSE mission events remain sync-gated/degraded in PG mode.~~ **Since ported** — insight/research run execution, mission autopilot, and SSE live push all run on the async layer now, which also makes the concurrency findings above genuinely reachable; they remain open follow-ups. --- ## Update — 2026-07-12: production-readiness hardening & live acceptance Everything below landed on this branch since the description above was written: **Production blockers from review — fixed** - `recoverStaleTransitionPending` ported to the async layer (backend moves write + clear the crash-safe marker; startup/maintenance sweeps no longer throw). - Lost-update class fixed: `atomicWriteTaskJson`/`WithAudit` write changed columns only (full-row upserts silently resurrected stale fields across concurrent store instances — the "task stuck unplanned forever" bug). - First-boot **auto-migration**: booting the PG backend over a project with a legacy `fusion.db` migrates it automatically (loud failure, SQLite kept as backup), and the dashboard shows a one-time **"your data was migrated" banner** with the backup paths and a Need-help Discord link. - `pg_dump`/`pg_restore` discovered from common install locations for embedded-mode backups. - The PG suite is part of the blocking merge gate (`test:pg-gate`). **Multi-project isolation (PR #2007, merged into this branch)** - `project_id` partition key on tasks / archived tasks / config, `taskProjectScope` threaded through every scan/claim/count, per-project config rows, layer bound to the project at startup. - Review P1 follow-up: the shared cold-storage `archive.archived_tasks` table is also partitioned and all archived-board reads/counts/searches are scoped. - Schema drift self-heal generalized to schema-qualified columns so existing databases upgrade in place. **Other changes** - Node settings sync **removed** in PG mode (409 `settings-sync-disabled-postgres`) — nodes share state by connecting to the same database; auth sync kept (per-machine file). - Perf (review findings): `listTasks` pushes column filter + ORDER BY + LIMIT/OFFSET into SQL; `getConversation` capped to the most recent 200 messages. - Fixed a false "operator action required" pause-abort log fired on every successfully auto-merged task. **Live acceptance — PASSED (2026-07-12)** A sandboxed instance (isolated HOME, embedded PG, real Opus executor) ran a task through the complete cycle: create → triage (AI spec) → execute → in-review → AI squash-merge landed on the project's `main` → done. A write+read sweep of every data surface (settings, comments, documents, attachments + artifact bridge + artifact edit, chat with real generation, goals, missions, agent mail, secrets, workflows, memory, CC analytics) was green on embedded PG. **Known remaining work** - The per-project `config` PK re-key has no upgrade path for pre-isolation embedded-PG databases (needs a real `DROP CONSTRAINT`/re-key migration; fresh databases are fine). - `pg_dump`/`pg_restore` binaries are not yet bundled in release artifacts (PATH/common-location discovery only). - The satellite-store concurrency findings listed above. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Phil Larson <hello@phillarson.xyz> Co-authored-by: fusion-merge <fusion-merge@local>
138 lines
5.8 KiB
TypeScript
138 lines
5.8 KiB
TypeScript
/**
|
|
* Task comments / activity-log / prompt-section rewriting helpers.
|
|
*
|
|
* FNXC:TaskStoreDecompose 2026-06-24-00:00:
|
|
* Extracted from the monolithic packages/core/src/store.ts (U5 decomposition).
|
|
* Pure behavior-invariant move: function bodies are byte-identical to their
|
|
* pre-extraction form. The mutable activity-log limit state is encapsulated
|
|
* here; store.ts re-imports the helpers and the test-only override seam.
|
|
*/
|
|
import type { TaskLogEntry } from "../types.js";
|
|
import { buildBootstrapPrompt } from "../mesh-task-replication.js";
|
|
|
|
const DEFAULT_TASK_ACTIVITY_LOG_ENTRY_LIMIT = 1_000;
|
|
const DEFAULT_TASK_ACTIVITY_LOG_OUTCOME_LIMIT = 4_000;
|
|
|
|
let taskActivityLogEntryLimit = DEFAULT_TASK_ACTIVITY_LOG_ENTRY_LIMIT;
|
|
let taskActivityLogOutcomeLimit = DEFAULT_TASK_ACTIVITY_LOG_OUTCOME_LIMIT;
|
|
|
|
export function getTaskActivityLogEntryLimit(): number {
|
|
return taskActivityLogEntryLimit;
|
|
}
|
|
|
|
/**
|
|
* Test-only seam for overriding task activity log retention/truncation limits.
|
|
* Must not be used by production code. Tests overriding limits must restore
|
|
* defaults in afterEach/afterAll by passing null.
|
|
*/
|
|
export function __setTaskActivityLogLimitsForTesting(
|
|
overrides: { entryLimit?: number; outcomeLimit?: number } | null,
|
|
): void {
|
|
if (overrides == null || (overrides.entryLimit == null && overrides.outcomeLimit == null)) {
|
|
taskActivityLogEntryLimit = DEFAULT_TASK_ACTIVITY_LOG_ENTRY_LIMIT;
|
|
taskActivityLogOutcomeLimit = DEFAULT_TASK_ACTIVITY_LOG_OUTCOME_LIMIT;
|
|
return;
|
|
}
|
|
|
|
if (overrides.entryLimit != null) {
|
|
if (!Number.isInteger(overrides.entryLimit) || overrides.entryLimit < 1) {
|
|
throw new Error("Task activity log entryLimit must be an integer >= 1");
|
|
}
|
|
taskActivityLogEntryLimit = overrides.entryLimit;
|
|
}
|
|
|
|
if (overrides.outcomeLimit != null) {
|
|
if (!Number.isInteger(overrides.outcomeLimit) || overrides.outcomeLimit < 1) {
|
|
throw new Error("Task activity log outcomeLimit must be an integer >= 1");
|
|
}
|
|
taskActivityLogOutcomeLimit = overrides.outcomeLimit;
|
|
}
|
|
}
|
|
|
|
function truncateTaskLogOutcome(outcome: string | undefined): string | undefined {
|
|
if (!outcome || outcome.length <= taskActivityLogOutcomeLimit) {
|
|
return outcome;
|
|
}
|
|
return `${outcome.slice(0, taskActivityLogOutcomeLimit)}\n... outcome truncated to ${taskActivityLogOutcomeLimit} characters ...`;
|
|
}
|
|
|
|
export { truncateTaskLogOutcome };
|
|
|
|
export function compactTaskActivityLog(entries: TaskLogEntry[]): TaskLogEntry[] {
|
|
const recentEntries = entries.slice(-taskActivityLogEntryLimit);
|
|
return recentEntries.map((entry) => ({
|
|
...entry,
|
|
outcome: truncateTaskLogOutcome(entry.outcome),
|
|
}));
|
|
}
|
|
|
|
/**
|
|
* Detect whether a PROMPT.md body is the auto-generated bootstrap stub
|
|
* (`# heading\n\n<description>\n`) that `createTask` writes for triage tasks,
|
|
* versus a real specification produced by triage or planning.
|
|
*
|
|
* Detection is wrapper-shape-exact: the on-disk content is compared against
|
|
* the exact bytes `createTask` would have written for the *pre-update*
|
|
* title/description. Earlier heuristic detectors (size caps, `##` header
|
|
* presence, `**Created:**` / `**Size:**` markers) misfired on imported issue
|
|
* bodies that contain `## Repro`, `**Created:** ...`, etc. — those are real
|
|
* stubs but look like real specs to a content-inspecting check. By matching
|
|
* against the wrapper produced from the previous title/description, we are
|
|
* robust to anything the description itself contains.
|
|
*/
|
|
export function isBootstrapPromptStub(
|
|
content: string,
|
|
taskId: string,
|
|
preUpdateTitle: string | undefined,
|
|
preUpdateDescription: string,
|
|
): boolean {
|
|
return content === buildBootstrapPrompt(taskId, preUpdateTitle, preUpdateDescription);
|
|
}
|
|
|
|
/**
|
|
* Replace just the leading `# ...` heading line of a PROMPT.md body, leaving
|
|
* every other section untouched. Used when a metadata edit (title or
|
|
* description change) needs to keep the displayed heading in sync without
|
|
* disturbing the rest of a real specification.
|
|
*
|
|
* If the file does not start with a `#` heading, it is returned verbatim —
|
|
* the caller has no clean place to splice the heading and the spec's content
|
|
* is more important to preserve than the displayed title (task.json is the
|
|
* canonical source for title/description anyway).
|
|
*/
|
|
export function rewriteHeadingLine(content: string, newHeading: string): string {
|
|
const match = content.match(/^#[^\n]*\n?/);
|
|
if (!match) {
|
|
return content;
|
|
}
|
|
const trailingNewline = match[0].endsWith("\n") ? "\n" : "";
|
|
return `# ${newHeading}${trailingNewline}${content.slice(match[0].length)}`;
|
|
}
|
|
|
|
/**
|
|
* Replace the body of the `## Mission` section with `newDescription`, leaving
|
|
* every other section untouched. Used to propagate `task.description` edits
|
|
* into a real spec without disturbing custom sections (Review Level, Frontend
|
|
* UX Criteria, File Scope, Acceptance Criteria, etc.) that a section-whitelist
|
|
* regen would silently drop.
|
|
*
|
|
* Returns the original content unchanged if there is no `## Mission` section.
|
|
*/
|
|
export function rewriteMissionSection(content: string, newDescription: string): string {
|
|
const missionMatch = content.match(/^##\s+Mission\s*$/m);
|
|
if (!missionMatch || missionMatch.index === undefined) {
|
|
return content;
|
|
}
|
|
const headerEnd = missionMatch.index + missionMatch[0].length;
|
|
const rest = content.slice(headerEnd);
|
|
// Find the next `## ` heading (start of next section). The match position is
|
|
// relative to `rest`, so we re-anchor to the absolute offset.
|
|
const nextHeading = rest.search(/\n##\s/);
|
|
const sectionEndAbsolute = nextHeading === -1 ? content.length : headerEnd + nextHeading;
|
|
const before = content.slice(0, headerEnd);
|
|
const after = content.slice(sectionEndAbsolute);
|
|
// Reconstruct: header line + blank line + new description + blank line +
|
|
// trailing content (which begins with the newline before the next heading).
|
|
return `${before}\n\n${newDescription}\n${after}`;
|
|
}
|