**Batch branch is live: `batch-dashboard-app`.** Push conversions here as commits rather than opening per-file PRs — that is the CI-run bottleneck this model removes. **One-line ownership note for you to arbitrate:** you have addressed me as U11, U12 and U7 at different points, so the `u12 worker -> batch-dashboard-app` mapping is ambiguous from my side. I claimed it because `dashboard/app` is where I have done the most work this session (TaskContextMenu, Column, TaskCard, TaskDetailModal, columnRoles, taskActivity) and I know which of its guards are load-bearing fallbacks. **If another worker is the intended owner, say so and I will hand the branch over rather than both of us pushing to it** — two workers on one shared branch is exactly what silently discarded a reviewed fix in #2645 today. ## The work order (measured at branch point, tests excluded) **75 guards across 32 files.** Largest: `TaskContextMenu.tsx` 9 · `Column.tsx` 7 · `ListView.tsx` 6 · `TaskDetailModal.tsx` 4 · then a long tail of 3s, 2s and 1s. Full per-file list is in the committed work order so feeders can claim without re-measuring. ## Two rules this surface keeps tripping on **1. A literal after `??`, or in the `else` of a `flags ?` ternary, is a DEGRADED-MODE answer — not an unconverted guard.** Two real states reach it: the **pre-load window** (board renders before the workflows fetch resolves) and a card stranded on an id its workflow no longer declares. In both, `columnFlagsById` has no entry at all. Deleting the fallback does not remove a decision — it substitutes "no role" silently, and affordances vanish during first paint. Those sites reach 0 by **marking**, not deleting. Expect `TaskContextMenu.tsx` and the `utils` files to be **mostly marks**. A "9 → 0" that deleted 9 fallbacks is a regression wearing a green census. **2. A marker excuses ONLY the construct it is attached to** — the statement or function holding the literal, not a sibling declaration. This has cost three passes, two of them mine; my first attempt on `reliability-metrics.ts` scored **1 of 6**. **Verify by the count moving, not by the comment existing.** With the ratchet gate-blocking, a mis-marked batch either wedges the gate or locks the miss into a re-recorded baseline. ## Status Opening commit is the work order only — **0 of 75 converted so far.** I am near the end of my context, so I am establishing the branch and the shared list rather than starting conversions I cannot finish cleanly. Feeders can begin immediately; I will keep the branch rebased. My other PR **#2762** (`live-agent-count.ts` 6 → 0) is green and unconflicted — per your rule it should land rather than fold into a batch, and it is `packages/core` so it belongs to batch-core anyway. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Task UI now resolves workflow “column roles” per task to drive diffs/merge details, routing/steering, progress/runtime visibility, and review badges. * Right-dock/overflow views and dev-server now use per-task column traits for “executing” behavior and dependency-based “Up Next” eligibility. * **Bug Fixes** * Fixed bulk action selection/delete/archive eligibility and prevented cross-workflow role leakage. * Made in-review/stale-paused-review, stuck, and effective executor/validator model logic role-aware. * **Tests** * Added regression coverage for degraded-flag behavior and ensured resolved-flag props aren’t ignored. * Added a static check to fail builds on inert optional flag seams. * **Documentation** * Updated batch work-order and mega-batch branch guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- ## Late addition: the seam gate was masking a real offender `scripts/check-inert-flag-seams.mjs` matched call sites by NAME, so two same-named functions in different modules were conflated. I had documented that as a known false-positive source and moved on — reports mentioning `sortTasksForDisplayColumn` are noise, read past them. That annotation was the damage. Core's `sortTasksForDisplayColumn` genuinely never receives its `columnFlags` argument outside its own tests. The dashboard's separate function of the same name (`app/components/taskSorting.ts`), called with up to five arguments from `Lane`/`Board`/`ListView`, was raising the arg-count max and clearing core's seam. The offender was behind a row everyone had been told to skip. The gate now records the module each callee is imported from and matches it against the seam's declaring module. **Measured, by reverting the change:** the scan prints `17 seams, all supplied` and emits **no row** for the function. With the change, it is reported. Both directions watched. Reported on #2783 rather than fixed from outside — core owns it, and "wire the flags" vs "drop the parameter and let the literal stay counted" is their judgment call. TEMPORARY allow-list entry carries it meanwhile; the existing staleness check fails the moment the site becomes supplied, so the entry cannot outlive the fix. Two known limits remain, both inherent to name matching and both documented in the script: the one-supplier floor, and the `__tests__` exclusion (hence the two permanent `ALLOWED` entries). ## And the one-supplier floor, closed the same way I wrote in the section above that the floor "hasn't cost anything yet." That is verbatim the reasoning that kept the imported-shadow bug alive, so I closed it instead of leaving the note. `best < arity` asked only whether SOME caller supplied the argument. One correct call site cleared the seam while every sibling took the legacy fallback — the `isTaskStuck` defect class, where two of three sites omitted the flags and the gate stayed green because the third was right. Review caught that one. A partially-supplied seam is the harder of the two: wholly-unsupplied is uniformly wrong, this works on the board you tested and degrades on the column you did not. **Measured:** dropping the flags argument at `Column.tsx`'s supplied call site produces `supplied by 5/6 call sites; omitted at packages/dashboard/app/components/Column.tsx:1 (of 2)`; restoring returns `all supplied at every call site`. Red and green both watched. Two real omissions found, both on `isNearDuplicateCanonicalInactive`: - **`TaskDetailModal.tsx`** — deliberate, and it **corrects a note I left at that site**. The old note said hoisting the flags state was "the actual fix." It is not, for this call: the flags in scope describe the *modal's* task, and the canonical is a **different task** on a column this component never resolves. Passing them would type-check, read as a conversion, and answer about the wrong task — exactly what `column-role-degraded-flags.test.ts` exists to catch. Supplying it correctly needs a fetch, which is a data change and out of scope. - **`core/task-store/branch-group-ops.ts`** — genuinely wireable (the impl is async and already holds `store` and `canonicalId`). Reported on #2783, not edited from outside. Exemptions for this class are keyed by **call site** (`<file>::<function>`), not by function name. A name-level entry would waive every site of a partially-supplied seam, which is backwards — its other sites are correct and are the reason the omission is worth reporting. Both entries carry the same staleness check as the name-level list and cannot outlive their fix. Remaining known limit, now the only one: the `__tests__` exclusion, which makes a test-only export read as having no callers. That is what the two permanent `ALLOWED` entries are. ## The `__tests__` exclusion, and two allow-list entries built on false reasons Named as the "last remaining limit" above, so it got closed too. The scan now reads test files for call sites — but counts them **separately**, and a test never clears a seam. That direction is the dangerous one: counting test callers as suppliers would have re-hidden core's `sortTasksForDisplayColumn`, whose only suppliers are its own tests. Measured by lifting its exemption: still reported. Both permanent allow-list entries claimed the scanner couldn't see their callers. **Both reasons were false**, and reading tests is what proved it: - **`evaluateMergeBlockerGuard`** — zero callers in tests either. Its only reference in the repo is its own declaration; never registered as a trait hook; the `evaluateDefaultWorkflowGuards` reader its file header credits does not exist. The `lifecycleColumns` conversion went onto dead code, and its note describes a crossing the guard cannot make. Reported on #2783, including the two things I am explicitly *not* concluding (no `"guard"` hook is registered in production; whether that is residue or a dropped registration needs core's intent). - **`isRecoverableMissingWorktreeReviewFailure`** — 5 test call sites. It wraps `...WithProgress`/`...NoProgress`, the live pair called from `self-healing.ts`, both supplying `reviewColumns`. Entry kept, true reason recorded. ### A wrong turn, recorded because it is the failure mode this PR is about I first classified no-production-caller seams as *informational* when they weren't re-exported from a package index, reasoning that a public export might be called externally. That silently downgraded `sortTasksForDisplayColumn` — a confirmed real offender — from failing to a footnote. Publication status has nothing to do with whether there is production behaviour to be wrong. Reverted to the simple rule: no production caller means inert, and it fails. It is worth stating plainly because it is the exact shape of everything else in this PR: a change that made the gate read *cleaner* while making it catch *less*, and it type-checked, passed every test, and would have reviewed fine. ### Where that leaves the check Every blind spot named in this PR has now been closed, and **each one produced a real defect within minutes of closing it** — imported shadows, the one-supplier floor, the `__tests__` exclusion. Four verified findings went to core, one to engine. I would not read the remaining ~240 guards' green gates as evidence that they are clean; I would read them as untested. ## Two guards for one question, one of them worse Having hardened the script, I checked its older twin rather than assuming it was fine. `resolved-flags-seams-have-suppliers.test.ts` carried its own copy of the trailing-flags-parameter check — written before the script existed — with **all three** holes the script has since closed. **Measured on one reintroduced defect** (dropping the flags argument at `Column.tsx`'s supplied `isNearDuplicateCanonicalInactive` call): | | result | |---|---| | `scripts/check-inert-flag-seams.mjs` | `supplied by 5/6 call sites; omitted at .../Column.tsx:1 (of 2)` | | this test's arity half | **3 passed** | Deleted the arity half. Redundancy between a strong and a weak check isn't redundancy — it's a green result available to whoever runs the weak one, and there was no signal at the call site telling you which you were looking at. The **props-shape half stays**: it has no twin in the script, and I confirmed it still fires by reintroducing the original `PrPanel` defect (outer component stops destructuring `taskColumnFlags`) — it reports `PrPanel declares taskColumnFlags but never takes it`. Dashboard app suite: **113 files / 3921 tests** (was 3922 — the deleted case is the difference). ## The gate started catching defects as they landed Syncing with main brought in three fresh conversions from other workers. The hardened check flagged all three immediately — the first time these guards have fired on someone else's landed code rather than on my own. - **`TaskCard`** — `getRunningOptionalGateBadge(task)` omitted flags while *both* `ListView` sites supplied. Fixed, and `taskColumnFlags` added to the `useMemo` deps: no `exhaustive-deps` rule here, so a memo that reads flags without listing them keeps the first-paint `undefined` answer and reproduces the bug through staleness instead of omission. - **`TaskTokenStatsPanel`** — `getTotalAgentActiveMs` omitted while `TaskCard` supplied, so the same runtime number came from the real column on a card and from legacy ids in the detail modal. Now takes `columnFlags`, supplied from `detailColumnFlags` — correct here because the panel renders the modal's **own** task, unlike the near-duplicate canonical above. - **`ListView` ×2** — passed `columnFlagsById.get(task.column)`, the cross-workflow **union**. A task whose own workflow doesn't declare that column gets a *neighbour workflow's* traits. The landed comment justified it as "this list already owns `columnFlagsById`" — exactly the reasoning `column-role-degraded-flags.test.ts` exists to reject. It failed on merge and is how I found this. Also: the `getTotalAgentActiveMs` exemption I was carrying **self-retired**. Main wired the seam, the staleness check failed the entry, and I removed it. That mechanism has now paid for itself once. ### Pre-existing, NOT from this PR: `App.test.tsx` is red on main `app/components/__tests__/App.test.tsx` fails **10 of 141** identically with my changes, with my changes stashed, and with main's own `App.tsx` restored. Not mine, and not in the merge gate. **Bisected on clean `main` checkouts, so this is measured rather than inferred:** | commit | date | result | |---|---|---| | `main~400` (`41d60f0355`) | 2026-07-25 | **140 passed** (140 tests) | | `main~275` (`74d6513fae`) | 2026-07-27 | 3 failed / 141 | | `main~210` (`d2ce1ba8b5`) | 2026-07-29 | 10 failed / 141 | | `main` (`6fc98fd6c7`) | 2026-07-30 | 10 failed / 141 | So it is **not one regression** — it degraded in two stages across 2026-07-25 → 07-29, and the test file itself changed in that window (140 → 141 tests). Three commits touched it there: `73b2a32e2b`, `f26cbedf4f`, `f157bf7460`. That window overlaps the workflow-owned lifecycle migration, which is suggestive but not something I confirmed. The failures are render-level, not assertion-level — `Unable to find an element with the text: + New Task`, `Unable to find role="dialog"`, `Unable to find ... Back nav task`. The board appears to render nothing. That reads like a real regression or a harness mismatch after the lifecycle migration, not a flake, so I have deliberately **not** quarantined it — quarantine is for flakes, and using it here would hide the signal. Flagging for whoever owns `App.tsx`. My suites: `app/__tests__` **113 files / 3921 tests** green, `tsc` 0, lint 0, census `--strict` 0, seam gate 0. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
173 lines
6.5 KiB
TypeScript
173 lines
6.5 KiB
TypeScript
import type { Task } from "@fusion/core";
|
|
import { getPathBasename } from "./pathDisplay";
|
|
import { isArchivedColumnRole, isCompleteColumnRole, isHoldColumnRole, isReviewColumnRole } from "./columnRoles";
|
|
|
|
export interface WorktreeGroupData {
|
|
label: string;
|
|
activeTasks: Task[];
|
|
queuedTasks: Task[];
|
|
}
|
|
|
|
/**
|
|
* Extract a clean display name from a worktree path.
|
|
* e.g. ".worktrees/FN-001" → "FN-001", "/path/to/fn/fn-001" → "fn-001"
|
|
*/
|
|
export function getWorktreeLabel(worktreePath: string): string {
|
|
return getPathBasename(worktreePath) || worktreePath;
|
|
}
|
|
|
|
/**
|
|
* Topological sort of tasks by dependency order.
|
|
* Mirrors resolveDependencyOrder from @fusion/core but inlined to avoid
|
|
* build alias issues (Vite aliases @fusion/core to types.ts only).
|
|
*/
|
|
function resolveDependencyOrder(tasks: Task[]): string[] {
|
|
const taskMap = new Map(tasks.map((t) => [t.id, t]));
|
|
const ordered: string[] = [];
|
|
const visited = new Set<string>();
|
|
const visiting = new Set<string>();
|
|
|
|
function visit(id: string): void {
|
|
if (visited.has(id)) return;
|
|
if (visiting.has(id)) return;
|
|
visiting.add(id);
|
|
const task = taskMap.get(id);
|
|
if (task) {
|
|
for (const depId of task.dependencies || []) {
|
|
if (taskMap.has(depId)) visit(depId);
|
|
}
|
|
}
|
|
visiting.delete(id);
|
|
visited.add(id);
|
|
ordered.push(id);
|
|
}
|
|
|
|
for (const task of tasks) visit(task.id);
|
|
return ordered;
|
|
}
|
|
|
|
/**
|
|
* Group in-progress tasks by worktree and collect queued todo tasks
|
|
* as visual previews in the "Up Next" group.
|
|
*
|
|
* Queued tasks (eligible "todo" tasks whose dependencies are all satisfied)
|
|
* are always placed in the "Up Next" group — they are never distributed
|
|
* to worktree-specific groups since they have no worktree assignment yet.
|
|
* The number of queued tasks shown is capped at `maxConcurrent`.
|
|
*/
|
|
export function groupByWorktree(
|
|
inProgressTasks: Task[],
|
|
allTasks: Task[],
|
|
maxConcurrent: number,
|
|
/*
|
|
FNXC:WorkflowResolvedColumns 2026-07-29-00:00 (U12 — R8 drift conversion):
|
|
The ids of TASKS whose own column is a hold lane in their own workflow, when the caller
|
|
resolved them.
|
|
|
|
Task ids, not column ids (PR #2625 review — greptile). This helper scans `allTasks`, which
|
|
can span workflows, and column ids are namespaced per workflow — two workflows may both
|
|
declare `staging` with only one of them marking it `hold`. A unioned column-id set cannot
|
|
tell those apart and would list every executing card of the second workflow as waiting.
|
|
Only a card's own workflow can answer "is this waiting?", so the caller answers it per task
|
|
and passes the result.
|
|
|
|
Board resolves this; Lane does not pass it and keeps the legacy-id fallback.
|
|
*/
|
|
holdTaskIds?: ReadonlySet<string>,
|
|
/*
|
|
FNXC:WorkflowResolvedColumns 2026-07-30-11:30 (batch-dashboard-app):
|
|
Per-dependency column flags, mirroring the `holdTaskIds` seam directly above: the caller resolves,
|
|
this stays pure. Omitted -> the legacy ids, i.e. today's behaviour for every unconverted caller.
|
|
|
|
Without it, "are this card's dependencies satisfied?" was three legacy ids. On a renamed board a
|
|
FINISHED dependency matched none of them, so the dependent never appeared in the worktree view's
|
|
upcoming-work list — it looked like there was nothing ready to run while there was.
|
|
*/
|
|
dependencyColumnFlags?: ReadonlyMap<string, Parameters<typeof isCompleteColumnRole>[0]>,
|
|
): WorktreeGroupData[] {
|
|
// Separate assigned vs unassigned in-progress tasks
|
|
const assigned = inProgressTasks.filter((t) => t.worktree);
|
|
const unassigned = inProgressTasks.filter((t) => !t.worktree);
|
|
|
|
// Group assigned tasks by worktree
|
|
const worktreeMap = new Map<string, Task[]>();
|
|
for (const task of assigned) {
|
|
const key = task.worktree!;
|
|
const list = worktreeMap.get(key) || [];
|
|
list.push(task);
|
|
worktreeMap.set(key, list);
|
|
}
|
|
|
|
/*
|
|
FNXC:WorkflowResolvedColumns 2026-07-29-00:00 (U12 — R8 drift conversion):
|
|
The filter wants "cards waiting for capacity" — the HOLD role, resolved from the board's
|
|
columns rather than the id `todo`.
|
|
|
|
THE BUG THIS CLOSES, measured rather than assumed: on the default board the id and the
|
|
role coincide (U11 gave `todo` the hold trait), so this looked healthy. On a board whose
|
|
hold column is renamed the filter matched NOTHING, so the worktree view showed no upcoming
|
|
work at all and read as idle — a whole panel silently empty, with nothing failing.
|
|
|
|
Dependency satisfaction below still names terminal ids. That is a separate question from
|
|
the hold role and is left alone deliberately: it needs `complete`/`mergeBlocker`/`archived`
|
|
traits for the DEPENDENCY's column, which is another lookup and another unit of work.
|
|
*/
|
|
// Find queued hold-lane tasks: cards in the hold column with all deps satisfied.
|
|
const taskById = new Map(allTasks.map((t) => [t.id, t]));
|
|
const isWaitingTask = (task: Task): boolean =>
|
|
holdTaskIds ? holdTaskIds.has(task.id) : isHoldColumnRole(undefined, task.column);
|
|
const todoTasks = allTasks.filter(isWaitingTask);
|
|
const eligible = todoTasks.filter((t) =>
|
|
!t.paused &&
|
|
(t.dependencies || []).every((depId) => {
|
|
const dep = taskById.get(depId);
|
|
if (!dep) return false;
|
|
const depFlags = dependencyColumnFlags?.get(dep.id);
|
|
/* Satisfied = the dependency rests in its OWN board's terminal pair, or its review lane —
|
|
the same union the scheduler's legacy rule uses, preserved exactly. */
|
|
return isCompleteColumnRole(depFlags, dep.column)
|
|
|| isArchivedColumnRole(depFlags, dep.column)
|
|
|| isReviewColumnRole(depFlags, dep.column);
|
|
}),
|
|
);
|
|
|
|
// Order eligible tasks by dependency order
|
|
const orderedIds = resolveDependencyOrder(eligible);
|
|
const orderedEligible = orderedIds
|
|
.map((id) => taskById.get(id))
|
|
.filter((t): t is Task => t !== undefined && eligible.includes(t));
|
|
|
|
// Build groups from worktree map
|
|
const groups: WorktreeGroupData[] = [];
|
|
const worktreeKeys = Array.from(worktreeMap.keys());
|
|
|
|
for (const key of worktreeKeys) {
|
|
groups.push({
|
|
label: getWorktreeLabel(key),
|
|
activeTasks: worktreeMap.get(key)!,
|
|
queuedTasks: [],
|
|
});
|
|
}
|
|
|
|
// Add unassigned group if needed
|
|
if (unassigned.length > 0) {
|
|
groups.push({
|
|
label: "Unassigned",
|
|
activeTasks: unassigned,
|
|
queuedTasks: [],
|
|
});
|
|
}
|
|
|
|
// All eligible queued tasks go into the "Up Next" group (capped at maxConcurrent)
|
|
const queued = orderedEligible.slice(0, maxConcurrent);
|
|
if (queued.length > 0) {
|
|
groups.push({
|
|
label: "Up Next",
|
|
activeTasks: [],
|
|
queuedTasks: queued,
|
|
});
|
|
}
|
|
|
|
return groups;
|
|
}
|