Add collapsible workflow selectors for board workflow controls and inline task creation. - add a collapsible board workflow toolbar with persisted per-project state - make the inline create workflow selector collapsible and store its expanded state per project - update workflow selector styling, storage key allowlist, and regression coverage for collapse behavior Files changed: packages/dashboard/app/components/Board.tsx | 104 +++++++++++++-------- .../dashboard/app/components/InlineCreateCard.css | 9 ++ .../dashboard/app/components/InlineCreateCard.tsx | 3 + packages/dashboard/app/components/Lane.css | 23 +++++ .../dashboard/app/components/WorkflowSelector.css | 20 +++- .../dashboard/app/components/WorkflowSelector.tsx | 81 ++++++++++++++-- .../app/components/__tests__/Board.test.tsx | 101 ++++++++++++++++++-- .../components/__tests__/InlineCreateCard.test.tsx | 57 ++++++++++- .../components/__tests__/WorkflowSelector.test.tsx | 73 ++++++++++++++- .../app/utils/__tests__/projectStorage.test.ts | 4 +- packages/dashboard/app/utils/projectStorage.ts | 2 + 11 files changed, 420 insertions(+), 57 deletions(-) Fusion-Task-Id: FN-6046 Fusion-Task-Lineage: 07cbe7a8-5740-479d-94a3-b178c72a5273
244 lines
8.0 KiB
TypeScript
244 lines
8.0 KiB
TypeScript
import "./WorkflowSelector.css";
|
|
import { useCallback, useEffect, useId, useState } from "react";
|
|
import { useTranslation } from "react-i18next";
|
|
import { ChevronDown, ChevronRight, Workflow as WorkflowIcon } from "lucide-react";
|
|
import type { WorkflowDefinition } from "@fusion/core";
|
|
import { getErrorMessage } from "@fusion/core";
|
|
import { fetchWorkflow, fetchWorkflows, fetchProjectDefaultWorkflow, setProjectDefaultWorkflow } from "../api";
|
|
import type { ToastType } from "../hooks/useToast";
|
|
import { useConfirm } from "../hooks/useConfirm";
|
|
import { getScopedItem, setScopedItem } from "../utils/projectStorage";
|
|
|
|
interface WorkflowSelectorProps {
|
|
/** Currently selected workflow id, or null for none. */
|
|
value: string | null;
|
|
/** Apply a selection. Receives the chosen workflow id, or null to clear. */
|
|
onChange: (workflowId: string | null) => void | Promise<void>;
|
|
projectId?: string;
|
|
addToast?: (message: string, type?: ToastType) => void;
|
|
disabled?: boolean;
|
|
label?: string;
|
|
/** Optional affordance to open the graph editor. */
|
|
onManage?: () => void;
|
|
/** Render an opt-in collapsed/expanded shell around the selector. */
|
|
collapsible?: boolean;
|
|
/** Base projectStorage key used to persist collapsible state. */
|
|
collapseStorageKey?: string;
|
|
/** Label shown when the selector is collapsed. */
|
|
collapsedLabel?: string;
|
|
/**
|
|
* U9: when the task whose workflow is being switched has an active session,
|
|
* switching aborts that session and re-homes the card into the new workflow's
|
|
* entry column. Pass `true` to require an abort-warning confirmation before
|
|
* applying (parallels Column.tsx's preserve-progress confirm).
|
|
*/
|
|
hasActiveSession?: boolean;
|
|
}
|
|
|
|
export function WorkflowSelector({
|
|
value,
|
|
onChange,
|
|
projectId,
|
|
addToast,
|
|
disabled,
|
|
label = "Workflow",
|
|
onManage,
|
|
collapsible = false,
|
|
collapseStorageKey,
|
|
collapsedLabel = "Workflow",
|
|
hasActiveSession,
|
|
}: WorkflowSelectorProps) {
|
|
const { t } = useTranslation("app");
|
|
const selectId = useId();
|
|
const { confirm } = useConfirm();
|
|
const [workflows, setWorkflows] = useState<WorkflowDefinition[]>([]);
|
|
const [loading, setLoading] = useState(false);
|
|
const [applying, setApplying] = useState(false);
|
|
const [collapsed, setCollapsed] = useState(() => {
|
|
if (!collapsible || !collapseStorageKey) return false;
|
|
return getScopedItem(collapseStorageKey, projectId) === "true";
|
|
});
|
|
|
|
useEffect(() => {
|
|
if (!collapsible || !collapseStorageKey) {
|
|
setCollapsed(false);
|
|
return;
|
|
}
|
|
|
|
setCollapsed(getScopedItem(collapseStorageKey, projectId) === "true");
|
|
}, [collapsible, collapseStorageKey, projectId]);
|
|
|
|
const setPersistedCollapsed = useCallback(
|
|
(nextCollapsed: boolean) => {
|
|
setCollapsed(nextCollapsed);
|
|
if (collapsible && collapseStorageKey) {
|
|
setScopedItem(collapseStorageKey, nextCollapsed ? "true" : "false", projectId);
|
|
}
|
|
},
|
|
[collapsible, collapseStorageKey, projectId],
|
|
);
|
|
|
|
useEffect(() => {
|
|
let cancelled = false;
|
|
setWorkflows([]);
|
|
setLoading(true);
|
|
fetchWorkflows(projectId)
|
|
.then(async (data) => {
|
|
if (value && !data.some((workflow) => workflow.id === value)) {
|
|
try {
|
|
const current = await fetchWorkflow(value, projectId);
|
|
data = [...data, current];
|
|
} catch {
|
|
// The selected workflow may have been deleted; leave the filtered list as-is.
|
|
}
|
|
}
|
|
if (!cancelled) setWorkflows(data);
|
|
})
|
|
.catch((err) => {
|
|
if (!cancelled) setWorkflows([]);
|
|
addToast?.(getErrorMessage(err) || "Failed to load workflows", "error");
|
|
})
|
|
.finally(() => {
|
|
if (!cancelled) setLoading(false);
|
|
});
|
|
return () => {
|
|
cancelled = true;
|
|
};
|
|
}, [projectId, addToast, value]);
|
|
|
|
const handleChange = useCallback(
|
|
async (next: string) => {
|
|
const workflowId = next === "" ? null : next;
|
|
if (hasActiveSession) {
|
|
const confirmed = await confirm({
|
|
title: t("workflowSelector.switchActiveTitle", "Switch workflow?"),
|
|
message: t(
|
|
"workflowSelector.switchActiveMessage",
|
|
"This task has an active session. Switching workflows aborts it and re-homes the card into the new workflow's entry column. Continue?",
|
|
),
|
|
confirmLabel: t("workflowSelector.switchConfirm", "Switch and abort"),
|
|
cancelLabel: t("workflowSelector.switchCancel", "Cancel"),
|
|
danger: true,
|
|
});
|
|
if (!confirmed) return;
|
|
}
|
|
setApplying(true);
|
|
try {
|
|
await onChange(workflowId);
|
|
} catch (err) {
|
|
addToast?.(getErrorMessage(err) || "Failed to apply workflow", "error");
|
|
} finally {
|
|
setApplying(false);
|
|
}
|
|
},
|
|
[onChange, addToast, hasActiveSession, confirm, t],
|
|
);
|
|
|
|
if (collapsible && collapsed) {
|
|
return (
|
|
<div className="workflow-selector workflow-selector--collapsed" data-testid="workflow-selector">
|
|
<button
|
|
type="button"
|
|
className="btn btn-sm workflow-selector-toggle workflow-selector-collapsed-button"
|
|
aria-expanded="false"
|
|
aria-controls={selectId}
|
|
onClick={() => setPersistedCollapsed(false)}
|
|
>
|
|
<ChevronRight size={14} aria-hidden />
|
|
<WorkflowIcon size={14} aria-hidden />
|
|
{collapsedLabel}
|
|
</button>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="workflow-selector" data-testid="workflow-selector">
|
|
<div className="workflow-selector-label">
|
|
<div className="workflow-selector-label-text">
|
|
{collapsible && (
|
|
<button
|
|
type="button"
|
|
className="btn btn-icon btn-sm workflow-selector-toggle"
|
|
aria-expanded="true"
|
|
aria-controls={selectId}
|
|
aria-label={t("workflowSelector.collapse", "Collapse workflow selector")}
|
|
onClick={() => setPersistedCollapsed(true)}
|
|
>
|
|
<ChevronDown size={14} aria-hidden />
|
|
</button>
|
|
)}
|
|
<label htmlFor={selectId} className="workflow-selector-title">
|
|
<WorkflowIcon size={14} aria-hidden /> {label}
|
|
</label>
|
|
</div>
|
|
<select
|
|
id={selectId}
|
|
value={value ?? ""}
|
|
disabled={disabled || loading || applying}
|
|
onChange={(e) => void handleChange(e.target.value)}
|
|
>
|
|
<option value="">None</option>
|
|
{workflows.map((w) => (
|
|
<option key={w.id} value={w.id}>
|
|
{w.name}
|
|
</option>
|
|
))}
|
|
</select>
|
|
</div>
|
|
{onManage && (
|
|
<button type="button" className="workflow-selector-manage" onClick={onManage}>
|
|
Manage…
|
|
</button>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
interface ProjectDefaultWorkflowFieldProps {
|
|
projectId?: string;
|
|
addToast?: (message: string, type?: ToastType) => void;
|
|
onManage?: () => void;
|
|
}
|
|
|
|
/** Self-contained project-default workflow picker for the settings modal. */
|
|
export function ProjectDefaultWorkflowField({ projectId, addToast, onManage }: ProjectDefaultWorkflowFieldProps) {
|
|
const [value, setValue] = useState<string | null>(null);
|
|
|
|
useEffect(() => {
|
|
let cancelled = false;
|
|
setValue(null);
|
|
fetchProjectDefaultWorkflow(projectId)
|
|
.then((res) => {
|
|
if (!cancelled) setValue(res.workflowId);
|
|
})
|
|
.catch(() => {
|
|
if (!cancelled) setValue(null);
|
|
/* default is optional; ignore load failures */
|
|
});
|
|
return () => {
|
|
cancelled = true;
|
|
};
|
|
}, [projectId]);
|
|
|
|
const handleChange = useCallback(
|
|
async (workflowId: string | null) => {
|
|
const res = await setProjectDefaultWorkflow(workflowId, projectId);
|
|
setValue(res.workflowId);
|
|
addToast?.(workflowId ? "Default workflow set" : "Default workflow cleared", "success");
|
|
},
|
|
[projectId, addToast],
|
|
);
|
|
|
|
return (
|
|
<WorkflowSelector
|
|
value={value}
|
|
onChange={handleChange}
|
|
projectId={projectId}
|
|
addToast={addToast}
|
|
label="Default workflow for new tasks"
|
|
onManage={onManage}
|
|
/>
|
|
);
|
|
}
|