Three defects of the same family, all of which let a LABEL decide BEHAVIOUR.
1. `workflowNodeRequiresWorktree` matched `/(?:^|\b)(?:review|verification)(?:\b|$)/i`
against `config.name`. A deterministic verification gate — exit codes only, no
mutation path — was therefore classified write-capable purely because it is
called "Verification", and the review seal refused it on every post-approval
replay. It now keys on `reviewKind`, `workflowAction` and the optional-group id.
2. The review seal's `isCodeReview` also matched `/code review/i`, so its central
question — "is this THE review that seals the tree?" — depended on a name an
operator may change. Renaming the gate to "Final Review" would have silently
stopped it being recognised while every other gate kept being sealed against it.
That is why the rename was blocked; it no longer is.
3. `getRunningOptionalGateBadge` gated on a closed list of three step ids, so gates
a workflow adds showed no badge at all: the operator watched an apparently idle
card until "Merging" appeared at the end. It now asks whether the running step
is a lane-owned gate.
Also: task cards arrive in the review lane with their step list EXPANDED, as they
already were in in-progress. The initial state is computed once per mount and a
column move remounts the card, so a card the operator had open collapsed itself
exactly when its review gates started running.
Lifecycle-column ratchet ceilings lowered to the measured counts (todo 64→12,
in-progress 197→72, in-review 213→28). They had drifted so far above reality that
the ratchet was inert for the thing it exists to stop — the TaskCard guard that hid
review-lane progress was one of those tolerated sites, and it had no way to notice.
Tests updated to the new truth rather than around it: the seal ratchet now asserts
a deterministic gate must NOT be write-capable, and the badge tests assert the
expanded list.
pnpm lint 0 errors, test:gate, verify:fast, dashboard 695, core 38, engine 8, and
three consecutive smoke runs: 122.4s, 126.3s, 124.8s of the 150s budget.
4750b689ea