Code review (8 reviewers) fixes: - P1: embedded board task-detail now passes onRequestClose so delete/merge/retry dismiss the panel (no ghost task). - P1: RightDock + TerminalModal drag handlers add pointercancel + unmount teardown (no leaked document listeners / rAF / stuck userSelect); remove dead onOpenChange prop. - Planning slot DOM-poll interval now caps (self-cancels on mobile); heartbeat slider persist debounced + mounted-guarded. - Cleanup: remove dead ViewHeader-migration CSS (Skills/Insights), extract shared GithubIcon, move Activity Log embedded CSS to ActivityLogModal.css, FNXC date-format fixes, AGENTS lazy-view note. - Update stale RightDock roster tests + LeftSidebarNav 'Compound Eng' test to current behavior. Live UI tweaks: - Default load lands on board, never the Command Center Dashboard. - View Board/View Agents moved to the Command Center Overview tab (under the live-activity strip). - Heartbeat card full-width with spaced, wrapping controls. - Dev Server panel scrolls in the dock; ChatView right-pane title takes the full line. - Files pop-out renders deterministic left-right two-pane. - Mailbox list pane narrower + narrow by default; Add Goal button height matches the Compound stage button; Memory Working-Memory tab no longer overlaps; Skills view fills full width. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
510 lines
11 KiB
CSS
510 lines
11 KiB
CSS
/* === MemoryView === */
|
|
/*
|
|
FNXC:Navigation 2026-06-22-01:10:
|
|
The title row now comes from the shared .view-header (which supplies the --space-lg top/side padding). The root drops its uniform padding; the description, tab bar, and content area carry their own horizontal inset so they align under the header.
|
|
*/
|
|
.memory-view {
|
|
display: flex;
|
|
flex-direction: column;
|
|
height: 100%;
|
|
overflow: hidden;
|
|
}
|
|
|
|
/*
|
|
FNXC:Navigation 2026-06-22-02:30:
|
|
After the header migrated to the shared .view-header (which is flex-shrink:0), the sibling description and tab bar must also be flex-shrink:0. Without it they collapse under the flex column at constrained heights, letting .memory-view-content overlap the header/tabs. The scroll owner is the active tab pane (.memory-*-tab, flex:1 + min-height:0 + overflow-y:auto); the editor container keeps min-height:0 through the chain so CodeMirror bounds itself and never overruns the action bar.
|
|
*/
|
|
.memory-view-description {
|
|
color: var(--text-muted);
|
|
font-size: 13px;
|
|
margin: 0;
|
|
padding: 0 var(--space-lg);
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.memory-view-tabs {
|
|
display: flex;
|
|
flex-direction: row;
|
|
gap: var(--space-xs);
|
|
border-bottom: 1px solid var(--border);
|
|
margin: var(--space-md) 0 var(--space-lg);
|
|
padding: 0 var(--space-lg);
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.memory-view-tab {
|
|
padding: var(--space-sm) var(--space-md);
|
|
border-radius: var(--radius-sm) var(--radius-sm) 0 0;
|
|
color: var(--text-muted);
|
|
background: transparent;
|
|
border: none;
|
|
cursor: pointer;
|
|
font-size: 13px;
|
|
transition: background var(--transition-fast), color var(--transition-fast);
|
|
}
|
|
|
|
.memory-view-tab:hover {
|
|
background: var(--card-hover);
|
|
color: var(--text);
|
|
}
|
|
|
|
.memory-view-tab:focus-visible {
|
|
outline: none;
|
|
box-shadow: var(--focus-ring);
|
|
}
|
|
|
|
.memory-view-tab--active {
|
|
color: var(--text);
|
|
border-bottom: 2px solid var(--todo);
|
|
font-weight: 500;
|
|
}
|
|
|
|
.memory-view-content {
|
|
flex: 1;
|
|
min-height: 0;
|
|
display: flex;
|
|
flex-direction: column;
|
|
padding: 0 var(--space-lg) var(--space-lg);
|
|
}
|
|
|
|
.memory-working-tab,
|
|
.memory-insights-tab,
|
|
.memory-engines-tab {
|
|
flex: 1;
|
|
min-height: 0;
|
|
display: flex;
|
|
flex-direction: column;
|
|
overflow-y: auto;
|
|
}
|
|
|
|
/*
|
|
FNXC:MemoryView 2026-06-22-16:15:
|
|
The Working Memory tab is BOTH the scroll owner (overflow-y:auto) and a flex column. Its non-editor siblings — the label/char-count action bar (.memory-action-bar) and the settings stack (.memory-config-section) — must never be flex-compressed by the greedy editor section. Flex children default to flex-shrink:1, so when .memory-editor-section claims flex:1 of the tab height, the siblings shrank below their natural height and their content overran into the next block: the "{n} characters" count overlapped the MEMORY FILE label, the file <select> struck through its divider, and the "Project Memory (Compressed)" header overlapped the card beneath it. Pinning the siblings to flex-shrink:0 keeps each block at its intrinsic height so they stack vertically and the tab scrolls instead of overlapping.
|
|
*/
|
|
.memory-action-bar,
|
|
.memory-config-section {
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.memory-editor-section {
|
|
display: flex;
|
|
flex-direction: column;
|
|
min-height: 0;
|
|
flex: 1;
|
|
}
|
|
|
|
/*
|
|
FNXC:MemoryView 2026-06-22-16:15:
|
|
Inside the editor section only .memory-editor-form-group is allowed to grow/shrink (it hosts the CodeMirror editor). The file-picker form-group and the layer summary must hold their natural height; otherwise the <select> and its hint collapse onto the divider line and look struck-through. Direct-child form-groups other than the editor one are pinned to flex-shrink:0.
|
|
*/
|
|
.memory-editor-section > .form-group:not(.memory-editor-form-group),
|
|
.memory-editor-section > .memory-file-summary {
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.memory-editor-form-group {
|
|
flex: 1;
|
|
min-height: 0;
|
|
display: flex;
|
|
flex-direction: column;
|
|
}
|
|
|
|
.memory-editor-container {
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-md);
|
|
overflow: hidden;
|
|
display: flex;
|
|
flex-direction: column;
|
|
flex: 1 1 auto;
|
|
min-height: calc(var(--space-xl) * 13 + var(--space-xs) * 2);
|
|
}
|
|
|
|
.memory-insights-editor-layout {
|
|
display: flex;
|
|
flex: 1;
|
|
min-height: 0;
|
|
flex-direction: column;
|
|
}
|
|
|
|
.memory-category-section {
|
|
margin-bottom: var(--space-lg);
|
|
}
|
|
|
|
.memory-category-header {
|
|
display: flex;
|
|
flex-direction: row;
|
|
justify-content: space-between;
|
|
align-items: center;
|
|
cursor: pointer;
|
|
padding: var(--space-sm) 0;
|
|
border-bottom: 1px solid var(--border);
|
|
transition: opacity var(--transition-fast);
|
|
}
|
|
|
|
.memory-category-header:hover {
|
|
opacity: 0.8;
|
|
}
|
|
|
|
.memory-category-header h4 {
|
|
font-size: 14px;
|
|
font-weight: 500;
|
|
margin: 0;
|
|
color: var(--text);
|
|
}
|
|
|
|
.memory-category-count {
|
|
font-size: calc(var(--space-sm) + var(--space-xs) * 0.75);
|
|
color: var(--text-muted);
|
|
background: color-mix(in srgb, var(--text-muted) 15%, transparent);
|
|
padding: 2px 8px;
|
|
border-radius: var(--radius-pill);
|
|
}
|
|
|
|
.memory-category-items {
|
|
padding-top: var(--space-sm);
|
|
}
|
|
|
|
.memory-insight-item {
|
|
padding: var(--space-xs) var(--space-sm);
|
|
margin-bottom: var(--space-xs);
|
|
border-left: 3px solid var(--border);
|
|
font-size: 13px;
|
|
color: var(--text);
|
|
line-height: 1.5;
|
|
}
|
|
|
|
.memory-engine-card {
|
|
background: var(--card);
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-lg);
|
|
padding: var(--space-xl);
|
|
margin-bottom: var(--space-lg);
|
|
}
|
|
|
|
.memory-engine-card h3 {
|
|
font-size: 14px;
|
|
font-weight: 500;
|
|
margin: 0 0 var(--space-md) 0;
|
|
color: var(--text);
|
|
}
|
|
|
|
.memory-engine-status {
|
|
display: flex;
|
|
flex-direction: row;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.memory-health-badge {
|
|
display: inline-block;
|
|
padding: 2px 10px;
|
|
border-radius: var(--radius-pill);
|
|
font-size: 12px;
|
|
}
|
|
|
|
.memory-health-badge--healthy {
|
|
background: color-mix(in srgb, var(--color-success) 15%, transparent);
|
|
color: var(--color-success);
|
|
}
|
|
|
|
.memory-health-badge--warning {
|
|
background: color-mix(in srgb, var(--color-warning) 15%, transparent);
|
|
color: var(--color-warning);
|
|
}
|
|
|
|
.memory-health-badge--issues {
|
|
background: color-mix(in srgb, var(--color-error) 15%, transparent);
|
|
color: var(--color-error);
|
|
}
|
|
|
|
.memory-action-bar {
|
|
display: flex;
|
|
flex-direction: row;
|
|
gap: var(--space-sm);
|
|
margin-top: var(--space-md);
|
|
align-items: center;
|
|
}
|
|
|
|
.memory-empty-extract-button {
|
|
margin-top: var(--space-md);
|
|
}
|
|
|
|
.memory-stat-value--updated {
|
|
font-size: var(--space-lg);
|
|
}
|
|
|
|
.memory-capability-row {
|
|
display: flex;
|
|
gap: var(--space-xs);
|
|
margin-top: var(--space-sm);
|
|
flex-wrap: wrap;
|
|
}
|
|
|
|
.memory-emphasis-text {
|
|
font-weight: 500;
|
|
}
|
|
|
|
.memory-health-header {
|
|
display: flex;
|
|
justify-content: space-between;
|
|
align-items: center;
|
|
margin-bottom: var(--space-md);
|
|
}
|
|
|
|
.memory-health-grid {
|
|
display: grid;
|
|
grid-template-columns: 1fr 1fr;
|
|
gap: var(--space-md);
|
|
}
|
|
|
|
.memory-health-label {
|
|
font-size: var(--space-md);
|
|
color: var(--text-muted);
|
|
text-transform: uppercase;
|
|
margin-bottom: var(--space-xs);
|
|
}
|
|
|
|
.memory-health-detail {
|
|
font-size: var(--space-md);
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.memory-health-section {
|
|
margin-top: var(--space-md);
|
|
padding-top: var(--space-md);
|
|
border-top: 1px solid var(--border);
|
|
}
|
|
|
|
.memory-status-text--success {
|
|
color: var(--color-success);
|
|
}
|
|
|
|
.memory-status-text--error {
|
|
color: var(--color-error);
|
|
}
|
|
|
|
.memory-status-text--warning {
|
|
color: var(--color-warning);
|
|
}
|
|
|
|
.memory-status-text--muted {
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.memory-audit-check-content {
|
|
flex: 1;
|
|
}
|
|
|
|
.memory-settings-note {
|
|
margin-top: var(--space-lg);
|
|
font-size: var(--space-md);
|
|
color: var(--text-muted);
|
|
display: flex;
|
|
align-items: center;
|
|
gap: var(--space-xs);
|
|
flex-wrap: wrap;
|
|
}
|
|
|
|
.memory-settings-note-button {
|
|
background: none;
|
|
border: none;
|
|
color: inherit;
|
|
cursor: pointer;
|
|
font: inherit;
|
|
padding: 0;
|
|
text-decoration: underline;
|
|
}
|
|
|
|
.memory-settings-note-button:focus-visible {
|
|
outline: none;
|
|
border-radius: var(--radius-sm);
|
|
box-shadow: var(--focus-ring-strong);
|
|
}
|
|
|
|
.memory-empty-state {
|
|
color: var(--text-muted);
|
|
padding: var(--space-2xl);
|
|
text-align: center;
|
|
display: flex;
|
|
flex-direction: column;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.memory-stats-row {
|
|
display: flex;
|
|
flex-direction: row;
|
|
gap: var(--space-lg);
|
|
margin-bottom: var(--space-lg);
|
|
}
|
|
|
|
.memory-stat-card {
|
|
background: var(--card);
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-md);
|
|
padding: var(--space-md) var(--space-lg);
|
|
flex: 1;
|
|
}
|
|
|
|
.memory-stat-value {
|
|
font-size: 24px;
|
|
font-weight: 600;
|
|
color: var(--text);
|
|
margin-bottom: var(--space-xs);
|
|
}
|
|
|
|
.memory-stat-label {
|
|
font-size: 12px;
|
|
color: var(--text-muted);
|
|
text-transform: uppercase;
|
|
letter-spacing: 0.5px;
|
|
}
|
|
|
|
.memory-audit-check {
|
|
display: flex;
|
|
flex-direction: row;
|
|
padding: var(--space-sm) 0;
|
|
border-bottom: 1px solid var(--border);
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.memory-audit-check:last-child {
|
|
border-bottom: none;
|
|
}
|
|
|
|
.memory-audit-check-passed {
|
|
color: var(--color-success);
|
|
font-weight: 600;
|
|
}
|
|
|
|
.memory-audit-check-failed {
|
|
color: var(--color-error);
|
|
font-weight: 600;
|
|
}
|
|
|
|
.memory-capability-badge {
|
|
font-size: 11px;
|
|
padding: 2px 8px;
|
|
border-radius: var(--radius-pill);
|
|
background: color-mix(in srgb, var(--todo) 15%, transparent);
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.memory-readonly-banner {
|
|
background: color-mix(in srgb, var(--color-warning) 10%, transparent);
|
|
border: 1px solid color-mix(in srgb, var(--color-warning) 30%, transparent);
|
|
border-radius: var(--radius-md);
|
|
padding: var(--space-md);
|
|
color: var(--color-warning);
|
|
font-size: 13px;
|
|
margin-bottom: var(--space-md);
|
|
}
|
|
|
|
.memory-char-count {
|
|
font-size: 12px;
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.memory-categories-list {
|
|
margin-top: var(--space-lg);
|
|
}
|
|
|
|
.memory-config-section {
|
|
margin-top: var(--space-lg);
|
|
padding-top: var(--space-lg);
|
|
border-top: 1px solid var(--border);
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: var(--space-md);
|
|
}
|
|
|
|
.memory-settings-group {
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-md);
|
|
background: var(--surface);
|
|
padding: var(--space-sm) 0;
|
|
}
|
|
|
|
.memory-flex-spacer {
|
|
flex: 1;
|
|
}
|
|
|
|
.memory-qmd-card {
|
|
border-style: solid;
|
|
}
|
|
|
|
.memory-retrieval-card {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.memory-retrieval-input-row {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.memory-retrieval-input-row .input {
|
|
flex: 1;
|
|
}
|
|
|
|
.memory-retrieval-card .memory-test-result {
|
|
margin-top: var(--space-sm);
|
|
}
|
|
|
|
/* === Memory View Styles === */
|
|
|
|
/* Mobile responsive for memory view */
|
|
@media (max-width: 768px) {
|
|
/* ViewHeader supplies its own responsive padding; the body blocks tighten their horizontal inset here. */
|
|
.memory-view-description,
|
|
.memory-view-tabs {
|
|
padding-inline: var(--space-md);
|
|
}
|
|
|
|
.memory-view-content {
|
|
padding: 0 var(--space-md) var(--space-md);
|
|
}
|
|
|
|
.memory-editor-container {
|
|
min-height: calc(var(--space-xl) * 10);
|
|
}
|
|
|
|
.memory-stats-row {
|
|
flex-wrap: wrap;
|
|
}
|
|
|
|
.memory-stat-card {
|
|
min-width: calc(50% - var(--space-sm));
|
|
}
|
|
|
|
.memory-view-tab {
|
|
min-height: 36px;
|
|
padding: var(--space-sm);
|
|
}
|
|
|
|
.memory-engine-card {
|
|
padding: var(--space-md);
|
|
}
|
|
|
|
.memory-retrieval-input-row {
|
|
flex-direction: column;
|
|
align-items: stretch;
|
|
}
|
|
|
|
.memory-settings-group {
|
|
padding: var(--space-xs) 0;
|
|
}
|
|
|
|
.memory-health-grid {
|
|
grid-template-columns: 1fr;
|
|
}
|
|
|
|
.memory-config-section {
|
|
margin-top: var(--space-md);
|
|
padding-top: var(--space-md);
|
|
}
|
|
}
|
|
|