**Batch branch is live: `batch-dashboard-app`.** Push conversions here as commits rather than opening per-file PRs — that is the CI-run bottleneck this model removes. **One-line ownership note for you to arbitrate:** you have addressed me as U11, U12 and U7 at different points, so the `u12 worker -> batch-dashboard-app` mapping is ambiguous from my side. I claimed it because `dashboard/app` is where I have done the most work this session (TaskContextMenu, Column, TaskCard, TaskDetailModal, columnRoles, taskActivity) and I know which of its guards are load-bearing fallbacks. **If another worker is the intended owner, say so and I will hand the branch over rather than both of us pushing to it** — two workers on one shared branch is exactly what silently discarded a reviewed fix in #2645 today. ## The work order (measured at branch point, tests excluded) **75 guards across 32 files.** Largest: `TaskContextMenu.tsx` 9 · `Column.tsx` 7 · `ListView.tsx` 6 · `TaskDetailModal.tsx` 4 · then a long tail of 3s, 2s and 1s. Full per-file list is in the committed work order so feeders can claim without re-measuring. ## Two rules this surface keeps tripping on **1. A literal after `??`, or in the `else` of a `flags ?` ternary, is a DEGRADED-MODE answer — not an unconverted guard.** Two real states reach it: the **pre-load window** (board renders before the workflows fetch resolves) and a card stranded on an id its workflow no longer declares. In both, `columnFlagsById` has no entry at all. Deleting the fallback does not remove a decision — it substitutes "no role" silently, and affordances vanish during first paint. Those sites reach 0 by **marking**, not deleting. Expect `TaskContextMenu.tsx` and the `utils` files to be **mostly marks**. A "9 → 0" that deleted 9 fallbacks is a regression wearing a green census. **2. A marker excuses ONLY the construct it is attached to** — the statement or function holding the literal, not a sibling declaration. This has cost three passes, two of them mine; my first attempt on `reliability-metrics.ts` scored **1 of 6**. **Verify by the count moving, not by the comment existing.** With the ratchet gate-blocking, a mis-marked batch either wedges the gate or locks the miss into a re-recorded baseline. ## Status Opening commit is the work order only — **0 of 75 converted so far.** I am near the end of my context, so I am establishing the branch and the shared list rather than starting conversions I cannot finish cleanly. Feeders can begin immediately; I will keep the branch rebased. My other PR **#2762** (`live-agent-count.ts` 6 → 0) is green and unconflicted — per your rule it should land rather than fold into a batch, and it is `packages/core` so it belongs to batch-core anyway. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Task UI now resolves workflow “column roles” per task to drive diffs/merge details, routing/steering, progress/runtime visibility, and review badges. * Right-dock/overflow views and dev-server now use per-task column traits for “executing” behavior and dependency-based “Up Next” eligibility. * **Bug Fixes** * Fixed bulk action selection/delete/archive eligibility and prevented cross-workflow role leakage. * Made in-review/stale-paused-review, stuck, and effective executor/validator model logic role-aware. * **Tests** * Added regression coverage for degraded-flag behavior and ensured resolved-flag props aren’t ignored. * Added a static check to fail builds on inert optional flag seams. * **Documentation** * Updated batch work-order and mega-batch branch guidance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- ## Late addition: the seam gate was masking a real offender `scripts/check-inert-flag-seams.mjs` matched call sites by NAME, so two same-named functions in different modules were conflated. I had documented that as a known false-positive source and moved on — reports mentioning `sortTasksForDisplayColumn` are noise, read past them. That annotation was the damage. Core's `sortTasksForDisplayColumn` genuinely never receives its `columnFlags` argument outside its own tests. The dashboard's separate function of the same name (`app/components/taskSorting.ts`), called with up to five arguments from `Lane`/`Board`/`ListView`, was raising the arg-count max and clearing core's seam. The offender was behind a row everyone had been told to skip. The gate now records the module each callee is imported from and matches it against the seam's declaring module. **Measured, by reverting the change:** the scan prints `17 seams, all supplied` and emits **no row** for the function. With the change, it is reported. Both directions watched. Reported on #2783 rather than fixed from outside — core owns it, and "wire the flags" vs "drop the parameter and let the literal stay counted" is their judgment call. TEMPORARY allow-list entry carries it meanwhile; the existing staleness check fails the moment the site becomes supplied, so the entry cannot outlive the fix. Two known limits remain, both inherent to name matching and both documented in the script: the one-supplier floor, and the `__tests__` exclusion (hence the two permanent `ALLOWED` entries). ## And the one-supplier floor, closed the same way I wrote in the section above that the floor "hasn't cost anything yet." That is verbatim the reasoning that kept the imported-shadow bug alive, so I closed it instead of leaving the note. `best < arity` asked only whether SOME caller supplied the argument. One correct call site cleared the seam while every sibling took the legacy fallback — the `isTaskStuck` defect class, where two of three sites omitted the flags and the gate stayed green because the third was right. Review caught that one. A partially-supplied seam is the harder of the two: wholly-unsupplied is uniformly wrong, this works on the board you tested and degrades on the column you did not. **Measured:** dropping the flags argument at `Column.tsx`'s supplied call site produces `supplied by 5/6 call sites; omitted at packages/dashboard/app/components/Column.tsx:1 (of 2)`; restoring returns `all supplied at every call site`. Red and green both watched. Two real omissions found, both on `isNearDuplicateCanonicalInactive`: - **`TaskDetailModal.tsx`** — deliberate, and it **corrects a note I left at that site**. The old note said hoisting the flags state was "the actual fix." It is not, for this call: the flags in scope describe the *modal's* task, and the canonical is a **different task** on a column this component never resolves. Passing them would type-check, read as a conversion, and answer about the wrong task — exactly what `column-role-degraded-flags.test.ts` exists to catch. Supplying it correctly needs a fetch, which is a data change and out of scope. - **`core/task-store/branch-group-ops.ts`** — genuinely wireable (the impl is async and already holds `store` and `canonicalId`). Reported on #2783, not edited from outside. Exemptions for this class are keyed by **call site** (`<file>::<function>`), not by function name. A name-level entry would waive every site of a partially-supplied seam, which is backwards — its other sites are correct and are the reason the omission is worth reporting. Both entries carry the same staleness check as the name-level list and cannot outlive their fix. Remaining known limit, now the only one: the `__tests__` exclusion, which makes a test-only export read as having no callers. That is what the two permanent `ALLOWED` entries are. ## The `__tests__` exclusion, and two allow-list entries built on false reasons Named as the "last remaining limit" above, so it got closed too. The scan now reads test files for call sites — but counts them **separately**, and a test never clears a seam. That direction is the dangerous one: counting test callers as suppliers would have re-hidden core's `sortTasksForDisplayColumn`, whose only suppliers are its own tests. Measured by lifting its exemption: still reported. Both permanent allow-list entries claimed the scanner couldn't see their callers. **Both reasons were false**, and reading tests is what proved it: - **`evaluateMergeBlockerGuard`** — zero callers in tests either. Its only reference in the repo is its own declaration; never registered as a trait hook; the `evaluateDefaultWorkflowGuards` reader its file header credits does not exist. The `lifecycleColumns` conversion went onto dead code, and its note describes a crossing the guard cannot make. Reported on #2783, including the two things I am explicitly *not* concluding (no `"guard"` hook is registered in production; whether that is residue or a dropped registration needs core's intent). - **`isRecoverableMissingWorktreeReviewFailure`** — 5 test call sites. It wraps `...WithProgress`/`...NoProgress`, the live pair called from `self-healing.ts`, both supplying `reviewColumns`. Entry kept, true reason recorded. ### A wrong turn, recorded because it is the failure mode this PR is about I first classified no-production-caller seams as *informational* when they weren't re-exported from a package index, reasoning that a public export might be called externally. That silently downgraded `sortTasksForDisplayColumn` — a confirmed real offender — from failing to a footnote. Publication status has nothing to do with whether there is production behaviour to be wrong. Reverted to the simple rule: no production caller means inert, and it fails. It is worth stating plainly because it is the exact shape of everything else in this PR: a change that made the gate read *cleaner* while making it catch *less*, and it type-checked, passed every test, and would have reviewed fine. ### Where that leaves the check Every blind spot named in this PR has now been closed, and **each one produced a real defect within minutes of closing it** — imported shadows, the one-supplier floor, the `__tests__` exclusion. Four verified findings went to core, one to engine. I would not read the remaining ~240 guards' green gates as evidence that they are clean; I would read them as untested. ## Two guards for one question, one of them worse Having hardened the script, I checked its older twin rather than assuming it was fine. `resolved-flags-seams-have-suppliers.test.ts` carried its own copy of the trailing-flags-parameter check — written before the script existed — with **all three** holes the script has since closed. **Measured on one reintroduced defect** (dropping the flags argument at `Column.tsx`'s supplied `isNearDuplicateCanonicalInactive` call): | | result | |---|---| | `scripts/check-inert-flag-seams.mjs` | `supplied by 5/6 call sites; omitted at .../Column.tsx:1 (of 2)` | | this test's arity half | **3 passed** | Deleted the arity half. Redundancy between a strong and a weak check isn't redundancy — it's a green result available to whoever runs the weak one, and there was no signal at the call site telling you which you were looking at. The **props-shape half stays**: it has no twin in the script, and I confirmed it still fires by reintroducing the original `PrPanel` defect (outer component stops destructuring `taskColumnFlags`) — it reports `PrPanel declares taskColumnFlags but never takes it`. Dashboard app suite: **113 files / 3921 tests** (was 3922 — the deleted case is the difference). ## The gate started catching defects as they landed Syncing with main brought in three fresh conversions from other workers. The hardened check flagged all three immediately — the first time these guards have fired on someone else's landed code rather than on my own. - **`TaskCard`** — `getRunningOptionalGateBadge(task)` omitted flags while *both* `ListView` sites supplied. Fixed, and `taskColumnFlags` added to the `useMemo` deps: no `exhaustive-deps` rule here, so a memo that reads flags without listing them keeps the first-paint `undefined` answer and reproduces the bug through staleness instead of omission. - **`TaskTokenStatsPanel`** — `getTotalAgentActiveMs` omitted while `TaskCard` supplied, so the same runtime number came from the real column on a card and from legacy ids in the detail modal. Now takes `columnFlags`, supplied from `detailColumnFlags` — correct here because the panel renders the modal's **own** task, unlike the near-duplicate canonical above. - **`ListView` ×2** — passed `columnFlagsById.get(task.column)`, the cross-workflow **union**. A task whose own workflow doesn't declare that column gets a *neighbour workflow's* traits. The landed comment justified it as "this list already owns `columnFlagsById`" — exactly the reasoning `column-role-degraded-flags.test.ts` exists to reject. It failed on merge and is how I found this. Also: the `getTotalAgentActiveMs` exemption I was carrying **self-retired**. Main wired the seam, the staleness check failed the entry, and I removed it. That mechanism has now paid for itself once. ### Pre-existing, NOT from this PR: `App.test.tsx` is red on main `app/components/__tests__/App.test.tsx` fails **10 of 141** identically with my changes, with my changes stashed, and with main's own `App.tsx` restored. Not mine, and not in the merge gate. **Bisected on clean `main` checkouts, so this is measured rather than inferred:** | commit | date | result | |---|---|---| | `main~400` (`41d60f0355`) | 2026-07-25 | **140 passed** (140 tests) | | `main~275` (`74d6513fae`) | 2026-07-27 | 3 failed / 141 | | `main~210` (`d2ce1ba8b5`) | 2026-07-29 | 10 failed / 141 | | `main` (`6fc98fd6c7`) | 2026-07-30 | 10 failed / 141 | So it is **not one regression** — it degraded in two stages across 2026-07-25 → 07-29, and the test file itself changed in that window (140 → 141 tests). Three commits touched it there: `73b2a32e2b`, `f26cbedf4f`, `f157bf7460`. That window overlaps the workflow-owned lifecycle migration, which is suggestive but not something I confirmed. The failures are render-level, not assertion-level — `Unable to find an element with the text: + New Task`, `Unable to find role="dialog"`, `Unable to find ... Back nav task`. The board appears to render nothing. That reads like a real regression or a harness mismatch after the lifecycle migration, not a flake, so I have deliberately **not** quarantined it — quarantine is for flakes, and using it here would hide the signal. Flagging for whoever owns `App.tsx`. My suites: `app/__tests__` **113 files / 3921 tests** green, `tsc` 0, lint 0, census `--strict` 0, seam gate 0. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
281 lines
12 KiB
TypeScript
281 lines
12 KiB
TypeScript
import { useState, useEffect, useCallback, useRef } from "react";
|
|
import { isReviewColumnRole } from "../utils/columnRoles";
|
|
import type { Task, TraitFlags } from "@fusion/core";
|
|
import { enrichRunningAgentTaskShapeFromFlags, isRunningAgentTask, isWaitingAgentTask } from "../../../core/src/live-agent-count";
|
|
import { fetchExecutorStats } from "../api";
|
|
import type { ExecutorStats, ExecutorState } from "../api";
|
|
import { isTaskStuck } from "../utils/taskStuck";
|
|
import { isLikelyTabSuspensionError, isVisibilityResumeError, useTabVisibilitySuspension, useVisibilityAwarePoll } from "./visibilitySuspension";
|
|
|
|
const POLL_INTERVAL_MS = 5000; // 5 seconds - different from useProjectHealth's 10s
|
|
/*
|
|
* FNXC:ExecutorStatusBar 2026-06-27-00:00:
|
|
* Executor stats polling can hit one-off tab-suspension-like fetch errors while the tab remains visible. Keep the last-good footer stats through one transient poll so the bottom bar does not flash "Connecting…"; only sustained consecutive transient failures may surface the connection state.
|
|
*/
|
|
const TRANSIENT_FAILURE_THRESHOLD = 2;
|
|
|
|
export interface UseExecutorStatsResult {
|
|
/** Aggregated executor statistics */
|
|
stats: ExecutorStats;
|
|
/** Whether the stats are currently loading */
|
|
loading: boolean;
|
|
/** Error message if the last fetch failed */
|
|
error: string | null;
|
|
/** Manually refresh stats */
|
|
refresh: () => Promise<void>;
|
|
}
|
|
|
|
/**
|
|
* Derive the executor state from globalPause, enginePaused, and runningTaskCount.
|
|
*
|
|
* - "stopped": globalPause is true
|
|
* - "paused": enginePaused is true (regardless of runningTaskCount)
|
|
* - "running": globalPause is false AND enginePaused is false AND runningTaskCount > 0
|
|
* - "idle": nothing paused and nothing running
|
|
*
|
|
* FNXC:EngineControls 2026-06-22-00:00:
|
|
* `globalPause` dominates the footer state matrix so an operator-stopped engine is distinct from idle even if in-progress tasks still exist.
|
|
*
|
|
* FNXC:EngineControls 2026-07-24-18:35:
|
|
* A paused engine must read "Paused" even when nothing is running. The prior matrix mapped (enginePaused && runningTaskCount === 0) to "idle", so the footer was indistinguishable from a healthy engine waiting for work — and that is precisely the state a pause produces once in-flight tasks drain. Operators saw triage tasks sitting untouched with an "Idle" badge and no visible cause; the pause is only otherwise surfaced by the Engine Control menu item label, which requires opening the menu. Pause state now dominates run state: the badge reports the operator-set condition, and the separate running/queued counters already report throughput.
|
|
*/
|
|
export function deriveExecutorState(
|
|
globalPause: boolean,
|
|
enginePaused: boolean,
|
|
runningTaskCount: number
|
|
): ExecutorState {
|
|
if (globalPause) {
|
|
return "stopped";
|
|
}
|
|
if (enginePaused) {
|
|
return "paused";
|
|
}
|
|
// globalPause is false and enginePaused is false
|
|
if (runningTaskCount > 0) {
|
|
return "running";
|
|
}
|
|
return "idle";
|
|
}
|
|
|
|
/**
|
|
* Derive statistics from the task list.
|
|
*
|
|
* FNXC:ExecutorStatusBar 2026-07-21-14:30:
|
|
* FN-8453 / #2359 requires footer capacity indicators to share the live top-level
|
|
* agent predicate with admission: Waiting is trait-derived intake/hold membership,
|
|
* Running is unpaused WIP plus live planners/reviewers, and custom columns require
|
|
* task-scoped workflow flags rather than legacy column-id assumptions.
|
|
*
|
|
* FNXC:ExecutorStatusBar 2026-07-21-19:00:
|
|
* Do not require task.sessionFile for Running — it is not on board/listTasks rows.
|
|
*/
|
|
export type ExecutorColumnFlags = Pick<TraitFlags, "complete" | "archived" | "intake" | "hold" | "countsTowardWip" | "mergeOrchestration" | "mergeBlocker">;
|
|
|
|
export function deriveStatsFromTasks(tasks: Task[], taskStuckTimeoutMs?: number, lastFetchTimeMs?: number, columnFlagsById?: ReadonlyMap<string, ExecutorColumnFlags>, columnFlagsByTaskId?: ReadonlyMap<string, ExecutorColumnFlags>): Pick<
|
|
ExecutorStats,
|
|
"runningTaskCount" | "blockedTaskCount" | "stuckTaskCount" | "queuedTaskCount" | "inReviewCount"
|
|
> {
|
|
let runningTaskCount = 0;
|
|
let blockedTaskCount = 0;
|
|
let stuckTaskCount = 0;
|
|
let queuedTaskCount = 0;
|
|
let inReviewCount = 0;
|
|
|
|
for (const task of tasks) {
|
|
// Task-scoped flags preserve custom workflow meaning when aggregate boards reuse column ids.
|
|
const enriched = enrichRunningAgentTaskShapeFromFlags(task, columnFlagsByTaskId?.get(task.id) ?? columnFlagsById?.get(task.column));
|
|
if (isRunningAgentTask(enriched)) {
|
|
runningTaskCount++;
|
|
/*
|
|
FNXC:WorkflowResolvedColumns 2026-07-30-00:20 (PR #2772 review):
|
|
Per-task WIP flags, same precedence as line ~86. `isTaskStuck` gained this parameter and
|
|
TaskCard supplies it, so the repo-wide seam gate was satisfied by that ONE caller — this path
|
|
was still passing three arguments and counting zero stuck tasks on a renamed board.
|
|
|
|
That is the gate's documented limit made concrete: it proves SOME caller supplies the
|
|
parameter, never that ALL do. Worth knowing before trusting it as coverage.
|
|
*/
|
|
if (isTaskStuck(task, taskStuckTimeoutMs, lastFetchTimeMs,
|
|
columnFlagsByTaskId?.get(task.id) ?? columnFlagsById?.get(task.column))) stuckTaskCount++;
|
|
}
|
|
if (isWaitingAgentTask(enriched)) queuedTaskCount++;
|
|
// Kept in the API shape for compatibility; the footer no longer renders it.
|
|
/*
|
|
FNXC:WorkflowResolvedColumns 2026-07-30-13:10 (batch-dashboard-app):
|
|
Review-lane count, resolved. Kept in the API shape for compatibility (the footer no longer
|
|
renders it), but a counter that silently reads 0 on a renamed board is worse than one that is
|
|
absent — a future consumer would take it at face value.
|
|
*/
|
|
/* Per-TASK flags first, exactly as line ~86 does: `columnFlagsById` is keyed by column id and
|
|
is a cross-workflow union, so two workflows reusing an id would answer for each other. */
|
|
if (isReviewColumnRole(
|
|
columnFlagsByTaskId?.get(task.id) ?? columnFlagsById?.get(task.column),
|
|
task.column,
|
|
)) inReviewCount++;
|
|
if (hasActionableBlockedBy(task.blockedBy)) {
|
|
blockedTaskCount++;
|
|
}
|
|
}
|
|
|
|
return {
|
|
runningTaskCount,
|
|
blockedTaskCount,
|
|
stuckTaskCount,
|
|
queuedTaskCount,
|
|
inReviewCount,
|
|
};
|
|
}
|
|
|
|
function hasActionableBlockedBy(blockedBy: Task["blockedBy"] | string[] | null): boolean {
|
|
if (Array.isArray(blockedBy)) {
|
|
return blockedBy.some((id) => typeof id === "string" && id.trim().length > 0);
|
|
}
|
|
|
|
return typeof blockedBy === "string" && blockedBy.trim().length > 0;
|
|
}
|
|
|
|
/**
|
|
* Hook for aggregating executor statistics for the status bar.
|
|
*
|
|
* - Receives the shared task list directly (same instance used by the board)
|
|
* so footer counts always match the board state
|
|
* - Polls `/api/executor/stats` every 5 seconds for executor state
|
|
* - Derives blockedTaskCount from tasks with blockedBy field set
|
|
* - Derives stuckTaskCount using the project's `taskStuckTimeoutMs` setting;
|
|
* returns 0 when the setting is undefined/disabled
|
|
* - Derives executorState from globalPause and enginePaused flags, with globalPause mapping to "stopped" and enginePaused to "paused" at any running count
|
|
* - Returns ExecutorStats object with reactive updates
|
|
*/
|
|
const DEFAULT_API_DATA: Pick<ExecutorStats, "maxConcurrent" | "lastActivityAt"> & {
|
|
globalPause: boolean;
|
|
enginePaused: boolean;
|
|
} = {
|
|
globalPause: false,
|
|
enginePaused: false,
|
|
maxConcurrent: 2,
|
|
};
|
|
|
|
export function useExecutorStats(tasks: Task[], projectId?: string, taskStuckTimeoutMs?: number, lastFetchTimeMs?: number, columnFlagsByTaskId?: ReadonlyMap<string, ExecutorColumnFlags>): UseExecutorStatsResult {
|
|
|
|
const [apiDataState, setApiDataState] = useState<{
|
|
projectId?: string;
|
|
data: typeof DEFAULT_API_DATA;
|
|
} | null>(null);
|
|
const [loading, setLoading] = useState(true);
|
|
const [errorState, setErrorState] = useState<{ projectId?: string; message: string } | null>(null);
|
|
const abortRef = useRef<AbortController | null>(null);
|
|
const hasFetchedStatsRef = useRef(false);
|
|
const consecutiveFailuresRef = useRef(0);
|
|
const activeProjectIdRef = useRef(projectId);
|
|
const visibilitySuspension = useTabVisibilitySuspension();
|
|
|
|
const shouldSuppressVisibilityResumeError = useCallback((errorMessage: string): boolean => {
|
|
return hasFetchedStatsRef.current && isVisibilityResumeError(errorMessage, visibilitySuspension.wasRecentlyHidden());
|
|
}, [visibilitySuspension]);
|
|
|
|
const refresh = useCallback(async () => {
|
|
// Cancel any in-flight requests
|
|
if (abortRef.current) {
|
|
abortRef.current.abort();
|
|
}
|
|
abortRef.current = new AbortController();
|
|
|
|
try {
|
|
if (activeProjectIdRef.current !== projectId) {
|
|
activeProjectIdRef.current = projectId;
|
|
hasFetchedStatsRef.current = false;
|
|
consecutiveFailuresRef.current = 0;
|
|
setErrorState(null);
|
|
}
|
|
/*
|
|
* FNXC:ExecutorStatusBar 2026-06-27-00:00:
|
|
* Routine 5s heartbeat polls must not re-enter the loading state after the first successful stats fetch. The footer loading branch swaps the root subtree while idle, which unmounts EngineControlMenu, closes an open concurrency popover, and makes the footer blink (FN-7163).
|
|
*
|
|
* FNXC:ExecutorStatusBar 2026-06-27-17:30:
|
|
* Project switches are a new initial load, not a heartbeat. Reset the per-project fetched/failure guard before fetching so project B cannot inherit project A's stats or transient-error debounce state.
|
|
*/
|
|
if (!hasFetchedStatsRef.current) {
|
|
setLoading(true);
|
|
}
|
|
const requestProjectId = projectId;
|
|
const data = await fetchExecutorStats(requestProjectId);
|
|
if (activeProjectIdRef.current !== requestProjectId) {
|
|
return;
|
|
}
|
|
consecutiveFailuresRef.current = 0;
|
|
hasFetchedStatsRef.current = true;
|
|
setErrorState(null);
|
|
setApiDataState({ projectId: requestProjectId, data });
|
|
} catch (err) {
|
|
if (activeProjectIdRef.current !== projectId) {
|
|
return;
|
|
}
|
|
if (err instanceof Error && err.name === "AbortError") {
|
|
// Ignore abort errors
|
|
return;
|
|
}
|
|
const errorMessage = err instanceof Error ? err.message : "Failed to fetch executor stats";
|
|
if (shouldSuppressVisibilityResumeError(errorMessage)) {
|
|
return;
|
|
}
|
|
if (hasFetchedStatsRef.current && isLikelyTabSuspensionError(errorMessage)) {
|
|
consecutiveFailuresRef.current += 1;
|
|
if (consecutiveFailuresRef.current >= TRANSIENT_FAILURE_THRESHOLD) {
|
|
setErrorState({ projectId, message: errorMessage });
|
|
}
|
|
return;
|
|
}
|
|
consecutiveFailuresRef.current = 0;
|
|
setErrorState({ projectId, message: errorMessage });
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, [projectId, shouldSuppressVisibilityResumeError]);
|
|
|
|
// Initial fetch
|
|
useEffect(() => {
|
|
refresh();
|
|
|
|
return () => {
|
|
if (abortRef.current) {
|
|
abortRef.current.abort();
|
|
}
|
|
};
|
|
}, [refresh]);
|
|
|
|
/*
|
|
FNXC:MobileTabRetention 2026-07-26-10:12:
|
|
This 5s poll was one of the loudest background loops. Mobile browsers discard a backgrounded page that
|
|
keeps issuing network requests, so the interval is suspended while the document is hidden and resumed
|
|
with a single immediate refresh on return. See `useVisibilityAwarePoll`.
|
|
*/
|
|
useVisibilityAwarePoll(refresh, POLL_INTERVAL_MS);
|
|
|
|
const currentProjectApiDataState = apiDataState && apiDataState.projectId === projectId ? apiDataState : null;
|
|
const apiData = currentProjectApiDataState?.data ?? DEFAULT_API_DATA;
|
|
const error = errorState && errorState.projectId === projectId ? errorState.message : null;
|
|
const effectiveLoading = loading || (!error && !currentProjectApiDataState);
|
|
|
|
// Derive stats from tasks and API data
|
|
const taskStats = deriveStatsFromTasks(tasks, taskStuckTimeoutMs, lastFetchTimeMs, undefined, columnFlagsByTaskId);
|
|
const executorState = deriveExecutorState(
|
|
apiData.globalPause,
|
|
apiData.enginePaused,
|
|
taskStats.runningTaskCount
|
|
);
|
|
|
|
const stats: ExecutorStats = {
|
|
...taskStats,
|
|
executorState,
|
|
maxConcurrent: apiData.maxConcurrent,
|
|
lastActivityAt: apiData.lastActivityAt,
|
|
};
|
|
|
|
return {
|
|
stats,
|
|
loading: effectiveLoading,
|
|
error,
|
|
refresh,
|
|
};
|
|
}
|