599a509d22
## Summary
First wave of package-internal code organization: split oversized
modules into domain-named files/folders while preserving public import
paths via re-exports, and refresh the line-count ratchet scoreboard.
- **Plan:**
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`
(multi-wave program; this PR lands U1–U4 + first U3/U6 slices)
- **Core types:** peel `types.ts` into
`types/{board,merge-queue,execution-and-ui,merge-policy,workflow-steps}.ts`
with browser-safe Vite alias preserved
- **Core TaskStore:** rename `remaining-ops-9` →
`task-commit-associations` (domain-named, not ordinal dump)
- **Engine executor:** peel pure helpers into
`executor/{browser-probe,requeue-loop,pseudo-pause,workflow-step-failures}.ts`
- **Engine heartbeat:** peel system prompts/procedures into
`agent-heartbeat-prompts.ts`
- **Ratchet:** one-time baseline truth-up + ratchet-down for touched
files
### Deferred to follow-up PRs (plan U5, U7–U9 + remaining waves)
- Self-healing folder split
- Further remaining-ops domain peels
- Dashboard `legacy.ts` / routes / UI monofiles
- CLI extension + TUI peels
## Test plan
- [x] `pnpm --filter @fusion/core exec tsc --noEmit`
- [x] `pnpm --filter @fusion/engine exec tsc --noEmit`
- [x] Focused vitest: `detect-pseudo-pause`,
`executor-browser-verification`, `clear-terminal-workflow-step-failures`
- [x] `node scripts/check-file-line-count.mjs` clean against updated
baseline
- [ ] CI merge gate (lint/typecheck/build/gate)
- [ ] Browser smoke: N/A for this PR (no dashboard UI route changes)
## Residual Review Findings
None. Review autofix applied dual-home wiring for
`clearTerminalWorkflowStepFailures` only.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Added configurable heartbeat procedures for task and no-task scenarios
(including patrol-aware rendering).
* Improved agent-browser availability verification with clearer
availability/status reporting.
* Added detection for pseudo-pauses and review-handoff requests.
* Expanded core configuration/contract options for
execution/UI/localization, merges, merge queues, and workflow steps.
* **Bug Fixes**
* Improved handling of transient execute-requeue and workflow-step
retry/cleanup behavior, including better Windows path support.
* Preserved existing public interfaces during internal restructuring.
* **Documentation**
* Added a multi-phase roadmap for future package reorganization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
30 lines
2.1 KiB
TypeScript
30 lines
2.1 KiB
TypeScript
/**
|
|
* FNXC:CodeOrganization 2026-07-15-00:00:
|
|
* Workflow step failure filter helpers peeled from executor.ts.
|
|
*/
|
|
import type { WorkflowStepResult as CoreWorkflowStepResult } from "@fusion/core";
|
|
|
|
/*
|
|
FNXC:ReviewLeniency 2026-07-02-01:00:
|
|
Retrying a task must clear PRIOR FAILURE states so the retry starts clean — including on optional gate nodes like code-review / browser-verification. Results are upserted by node id, so a re-running node overwrites its own stale entry, but a send-back-for-fix leaves the failed entry in place until (and unless) that node re-runs; meanwhile self-healing's failed-pre-merge scan and the dashboard both see a stale failure, and a node that is skipped/relaxed on the retry never clears it. Drop every terminal failure result (`failed`/`advisory_failure`) on retry while keeping `passed`/`skipped`/`pending` evidence (so a previously-passed Plan Review is not re-run). Returns the same array reference when nothing changed so callers can skip a no-op write.
|
|
|
|
FNXC:WorkflowStepResults 2026-07-09-00:30:
|
|
FN-7727 explicit decision: an explicit user/agent RETRY remains a clean-slate —
|
|
it MAY drop the current `failed`/`advisory_failure` entry entirely (along with
|
|
any `priorAttempts` history it carried), since retry is deliberately
|
|
discarding prior failure state, not preserving it. This is DIFFERENT from the
|
|
self-healing recovery re-run path (`recoverFailedPreMergeWorkflowStep` /
|
|
`recoverReviewTasksWithFailedPreMergeSteps`), which does NOT call this
|
|
function — that path re-runs the SAME node in place and its result goes
|
|
through `upsertWorkflowStepResult`, which is where prior-attempt history is
|
|
preserved. This filter must not throw on entries carrying `priorAttempts`
|
|
(it only reads `status`, so `priorAttempts` is inert here regardless).
|
|
*/
|
|
export function clearTerminalWorkflowStepFailures(
|
|
results: CoreWorkflowStepResult[] | undefined,
|
|
): CoreWorkflowStepResult[] {
|
|
const current = results ?? [];
|
|
const kept = current.filter((result) => result.status !== "failed" && result.status !== "advisory_failure");
|
|
return kept.length === current.length ? current : kept;
|
|
}
|