Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
139 lines
6.4 KiB
TypeScript
139 lines
6.4 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { loadAllAppCss } from "../test/cssFixture";
|
|
import { readFileSync } from "fs";
|
|
import { resolve } from "path";
|
|
|
|
/**
|
|
* Stylesheet regression test for Activity Log mobile layout.
|
|
*
|
|
* Parses `packages/dashboard/app/styles.css` and asserts that an
|
|
* `@media (max-width: 768px)` block contains Activity Log mobile rules
|
|
* for stacked/wrapped controls and entry layout. These selectors must
|
|
* remain inside a mobile media query so the Activity Log renders
|
|
* correctly on narrow screens.
|
|
*/
|
|
|
|
describe("activity-log-mobile-layout.css", () => {
|
|
const cssContent = loadAllAppCss();
|
|
|
|
/** Extract all content inside @media (max-width: 768px) blocks. */
|
|
function extractMobileMediaBlocks(content: string): string {
|
|
const blocks: string[] = [];
|
|
const regex = /@media\s*\(\s*max-width:\s*768px\s*\)\s*\{/g;
|
|
let match;
|
|
|
|
while ((match = regex.exec(content)) !== null) {
|
|
const startIdx = match.index + match[0].length;
|
|
let braceCount = 1;
|
|
let endIdx = startIdx;
|
|
while (braceCount > 0 && endIdx < content.length) {
|
|
if (content[endIdx] === "{") braceCount++;
|
|
if (content[endIdx] === "}") braceCount--;
|
|
endIdx++;
|
|
}
|
|
if (braceCount === 0) {
|
|
blocks.push(content.slice(startIdx, endIdx - 1));
|
|
}
|
|
}
|
|
return blocks.join("\n");
|
|
}
|
|
|
|
const mobileCss = extractMobileMediaBlocks(cssContent);
|
|
|
|
// ── Modal sizing ────────────────────────────────────────────────────
|
|
|
|
it("uses modal-lg base class for consistent wide sizing", () => {
|
|
// The activity-log-modal should NOT set its own max-width; modal-lg handles width
|
|
const modalBlock = cssContent.match(/\.activity-log-modal\s*\{[^}]*\}/)?.[0];
|
|
expect(modalBlock).toBeTruthy();
|
|
// Should NOT contain max-width (handled by modal-lg base class)
|
|
expect(modalBlock).not.toMatch(/max-width:\s*\d+px/);
|
|
});
|
|
|
|
// ── Close button ────────────────────────────────────────────────────
|
|
|
|
it("does not define a custom activity-log-close style (uses shared modal-close)", () => {
|
|
// The modal should use the shared .modal-close class instead of a custom close button
|
|
expect(cssContent).not.toMatch(/\.activity-log-close\s*\{/);
|
|
});
|
|
|
|
it("keeps close button on top row with title via explicit flex order", () => {
|
|
// The .modal-close inside activity-log-header has an explicit order value so it
|
|
// stays on the first row with the title (not pushed to a wrapped row by .activity-log-actions).
|
|
expect(mobileCss).toMatch(/\.activity-log-header\s+\.modal-close\s*\{[^}]*order:\s*\d/);
|
|
});
|
|
|
|
it("pins close button to right edge via margin-left:auto", () => {
|
|
// The .modal-close inside activity-log-header must be pushed to the right edge
|
|
// of the first row using margin-left:auto
|
|
expect(mobileCss).toMatch(/\.activity-log-header\s+\.modal-close\s*\{[^}]*margin-left:\s*auto/);
|
|
});
|
|
|
|
it("title participates in top row via flex:1 1 auto", () => {
|
|
// The .activity-log-title should flex to fill available space in the top row
|
|
expect(mobileCss).toMatch(/\.activity-log-title\s*\{[^}]*flex:\s*1\s+1\s+auto/);
|
|
});
|
|
|
|
// ── Modal header / actions ──────────────────────────────────────────
|
|
|
|
it("has mobile rule for activity-log-header to wrap on narrow screens", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-header\s*\{[^}]*flex-wrap:\s*wrap/);
|
|
});
|
|
|
|
it("has mobile rule for activity-log-actions to wrap and fill full width", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-actions\s*\{[^}]*flex-wrap:\s*wrap/);
|
|
expect(mobileCss).toMatch(/\.activity-log-actions\s*\{[^}]*flex:\s*1\s+1\s+100%/);
|
|
});
|
|
|
|
// ── Filter controls ─────────────────────────────────────────────────
|
|
|
|
it("has mobile rule for filter containers to fill available width", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-filter/);
|
|
expect(mobileCss).toMatch(/\.activity-log-filter--project/);
|
|
});
|
|
|
|
it("has mobile rule for project filter to fill available width", () => {
|
|
// Project filter selector must have mobile-specific width handling
|
|
expect(mobileCss).toMatch(/\.activity-log-filter--project\s*\{[^}]*flex:\s*1\s+1\s+0/);
|
|
});
|
|
|
|
it("has mobile rule for filter selects to fill width", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-filter-select\s*\{[^}]*width:\s*100%/);
|
|
});
|
|
|
|
// ── Active filters bar ──────────────────────────────────────────────
|
|
|
|
it("has mobile rule for active-filters bar to wrap", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-active-filters\s*\{[^}]*flex-wrap:\s*wrap/);
|
|
});
|
|
|
|
it("resets clear-filters margin-left on mobile so it doesn't force right", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-clear-filters\s*\{[^}]*margin-left:\s*0/);
|
|
});
|
|
|
|
// ── Entry layout ────────────────────────────────────────────────────
|
|
|
|
it("has mobile rule for entry details to wrap with word-break", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-entry-details\s*\{[^}]*word-break:\s*break-word/);
|
|
});
|
|
|
|
it("has mobile rule for entry text to break words", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-entry-text\s*\{[^}]*word-break:\s*break-word/);
|
|
});
|
|
|
|
it("has mobile rule for entry headers to wrap", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-entry-header\s*\{[^}]*flex-wrap:\s*wrap/);
|
|
});
|
|
|
|
// ── Confirmation dialog ─────────────────────────────────────────────
|
|
|
|
it("has mobile rule for confirm actions to stack vertically", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-confirm-actions\s*\{[^}]*flex-direction:\s*column/);
|
|
});
|
|
|
|
it("has mobile rule for confirm buttons to fill width", () => {
|
|
expect(mobileCss).toMatch(/\.activity-log-confirm-cancel[^}]*width:\s*100%/);
|
|
expect(mobileCss).toMatch(/\.activity-log-confirm-clear[^}]*width:\s*100%/);
|
|
});
|
|
});
|