Files
fusion/packages/dashboard/app/__tests__/dashboard-footer-mobile-layout.test.ts
gsxdsm c3d1716fdd refactor(dashboard): split monolithic styles.css into per-component files
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).

- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
  React.lazy + Suspense; prefetch all chunks on idle so first navigation is
  instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
  635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.

- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
  so CSS regression tests load the full per-component bundle (mirroring Vite
  source order). Migrate 30+ tests off direct readFileSync('../styles.css').

- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
  imports actually inject styles in jsdom (fixes getComputedStyle assertions).

- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
  dashboard test files; points at loadAllAppCss() instead.

- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
  .form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.

- Mobile fixes along the way: scroll containment for view containers
  (min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
  mobile (with safe-area-inset for iOS home bar), AgentsView single-row
  header layout, ActivityLogModal close button on right, model-combobox
  z-index above the mobile quick-chat panel.

- Bug fix: SkillsView toggle was display:none which hid the input from the
  accessibility tree; replaced with the visually-hidden pattern so screen
  readers + getByRole still find the checkbox.

- Bug fix: standalone Delete button in TaskDetailModal for triage-column
  tasks (Actions dropdown is hidden in triage state, so previously no way
  to delete a freshly-created task without status change first).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 19:39:20 -07:00

108 lines
4.0 KiB
TypeScript

import { describe, it, expect } from "vitest";
import { loadAllAppCss } from "../test/cssFixture";
import { readFileSync } from "fs";
import { resolve } from "path";
/**
* Stylesheet regression test for FN-824: Mobile footer-safe layout.
*
* Parses `packages/dashboard/app/styles.css` and asserts that the mobile
* `@media (max-width: 768px)` rules for `.board` do NOT use viewport-height
* sizing (`100vh` / `100dvh`) that would bypass the
* `.project-content--with-footer` padding contract.
*
* ## Why this matters
*
* `.project-content--with-footer` reserves space for the fixed
* `ExecutorStatusBar` footer via `padding-bottom: var(--executor-footer-height)`.
* If `.board` sizes itself using `calc(100dvh - X)` instead of filling its
* parent with `height: 100%`, the board extends beneath the footer bar,
* making the bottom cards partially hidden and untappable on mobile.
*
* This test ensures no future change reintroduces viewport-height sizing
* for the mobile board.
*/
describe("dashboard-footer-mobile-layout", () => {
const cssContent = loadAllAppCss();
/** Extract all content inside @media (max-width: 768px) blocks. */
function extractMobileMediaBlocks(content: string): string {
const blocks: string[] = [];
const regex = /@media\s*\(\s*max-width:\s*768px\s*\)\s*\{/g;
let match;
while ((match = regex.exec(content)) !== null) {
const startIdx = match.index + match[0].length;
let braceCount = 1;
let endIdx = startIdx;
while (braceCount > 0 && endIdx < content.length) {
if (content[endIdx] === "{") braceCount++;
if (content[endIdx] === "}") braceCount--;
endIdx++;
}
if (braceCount === 0) {
blocks.push(content.slice(startIdx, endIdx - 1));
}
}
return blocks.join("\n");
}
const mobileCss = extractMobileMediaBlocks(cssContent);
// ── Board must NOT use viewport-height sizing ────────────────────────
it("mobile .board does not use calc(100dvh - ...) for height", () => {
// This was the FN-824 bug: mobile board had height: calc(100dvh - 57px)
// which ignored the footer-safe wrapper's padding-bottom reservation.
const hasDvhCalc = mobileCss.match(
/\.board\s*\{[^}]*height\s*:\s*calc\s*\(\s*100dvh/,
);
expect(hasDvhCalc).toBeNull();
});
it("mobile .board does not use calc(100vh - ...) for height", () => {
const hasVhCalc = mobileCss.match(
/\.board\s*\{[^}]*height\s*:\s*calc\s*\(\s*100vh/,
);
expect(hasVhCalc).toBeNull();
});
it("mobile .board does not use 100dvh or 100vh directly for height", () => {
const hasDirectVh = mobileCss.match(
/\.board\s*\{[^}]*height\s*:\s*100dvh/,
);
const hasDirectVh2 = mobileCss.match(
/\.board\s*\{[^}]*height\s*:\s*100vh/,
);
expect(hasDirectVh).toBeNull();
expect(hasDirectVh2).toBeNull();
});
// ── Footer-safe wrapper contract ─────────────────────────────────────
it("mobile .project-content--with-footer sets a footer height token", () => {
// The mobile media query should override the footer height token
expect(mobileCss).toMatch(
/\.project-content--with-footer\s*\{[^}]*--executor-footer-height/,
);
});
it("desktop .project-content--with-footer uses padding-bottom for footer space", () => {
// Verify the desktop rule exists and uses the variable
const desktopMatch = cssContent.match(
/\.project-content--with-footer\s*\{[^}]*padding-bottom\s*:\s*var\(--executor-footer-height\)/,
);
expect(desktopMatch).not.toBeNull();
});
it("desktop .project-content--with-footer sets --executor-footer-height to a non-zero value", () => {
const desktopMatch = cssContent.match(
/\.project-content--with-footer\s*\{[^}]*--executor-footer-height:\s*([0-9]+px)/,
);
expect(desktopMatch).not.toBeNull();
const value = desktopMatch![1];
expect(value).not.toBe("0px");
});
});