Files
fusion/scripts/lib
gsxdsm 581e6fba43 chore(core): mark the async-mission fallback arms DELIBERATE-LITERAL (census 108→106) (#3056)
Fleet phase. Claimed `packages/core/src/async-mission-store-queries.ts`
— **the only census file with no branch, no worktree, and no open PR
against it.** Claim published by pushing the branch before doing any
work.

## Census before / after

| | total | this file | deliberate |
|---|---|---|---|
| before | **108** | 2 | 128 |
| after | **106** | 0 | **130** |

`--strict` exits 0, baseline re-recorded in the same commit.

**This is a reclassification, not a conversion.** The same two lines are
still there. A reader comparing 108 → 106 against my #3047's 126 → 121
should know only the latter changed behaviour.

## Why marking is the right answer here

Both sites are the **fallback arm** of the three-state rule:

```ts
terminalColumns?.complete ? terminalColumns.complete.has(column) : column === "done";
```

`terminalColumns` undefined means the caller could not resolve lanes.
The legacy id is then the only answer that keeps the query working at
all — converting it would delete the fallback and make an unresolvable
caller return nothing. The census counts the literal, but **the literal
is the design**.

The file's own comment shows a previous worker already reached this
conclusion. Nothing recorded it in a form the tool reads, so it stayed
in `byFile` as apparent backlog for the next pass to re-derive.

## The finding this makes concrete

I checked five unclaimed files this phase (`agent-store`,
`github-tracking-state`, `planner-overseer`, `auto-merge-finalization`,
this one). **Every site in them was either a fallback arm or an
already-documented deliberate leave** — `agent-store.ts:236` carries a
comment from today's fleet phase explaining why it stays.

So the remaining count is not a work queue. A meaningful share is
correct code the tool cannot distinguish from owed work, and each fleet
pass pays to re-derive that. Marking them is cheap, mechanical, and
makes the number mean "conversions owed" — which is what every worker
reads it as when picking a cluster.

I marked only the file I claimed. The others belong to whoever holds
them.

## Verification

- `census --strict` exit 0; `tsc --noEmit` **0 errors**
- `check:fnxc-future-dates`, `check:lane-wiring`,
`check:sql-column-literals`, `check:inert-flag-seams` — all exit 0
- No behaviour change: the two expressions are byte-identical, only
comments added

## Note on the marker's granularity

The first marker covered only `isComplete` — the census attaches markers
by *preceding comment*, so the sibling `isArchived` needed its own.
Caught by re-running the census (2 → 1, not 2 → 0) rather than by
reading. Worth knowing before marking a group of related literals.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-31 03:13:09 -07:00
..