f11800f2c6
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
67 lines
2.8 KiB
TypeScript
67 lines
2.8 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { loadAllAppCss } from "../test/cssFixture";
|
|
|
|
const css = loadAllAppCss();
|
|
|
|
function getRule(selector: string, options: { last?: boolean } = {}): string {
|
|
const escapedSelector = selector.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
|
|
const matches = [...css.matchAll(new RegExp(`${escapedSelector}\\s*\\{[^}]*\\}`, "g"))];
|
|
expect(matches.length, `Expected CSS rule for ${selector}`).toBeGreaterThan(0);
|
|
|
|
if (options.last) {
|
|
return matches[matches.length - 1]?.[0] ?? "";
|
|
}
|
|
|
|
return matches[0]?.[0] ?? "";
|
|
}
|
|
|
|
describe("Dev server view CSS layout regressions", () => {
|
|
it("allows vertical page scrolling to keep all controls reachable on short viewports", () => {
|
|
const rootRule = getRule(".dev-server-view");
|
|
expect(rootRule).toContain("overflow-y: auto");
|
|
expect(rootRule).toContain("overflow-x: hidden");
|
|
});
|
|
|
|
it("keeps config and candidate lists scrollable with bounded height", () => {
|
|
const configRule = getRule(".dev-server-config");
|
|
expect(configRule).toContain("max-height: min(52vh, calc(var(--space-2xl) * 16))");
|
|
expect(configRule).toContain("overflow-y: auto");
|
|
|
|
const candidatesRule = getRule(".dev-server-candidates");
|
|
expect(candidatesRule).toContain("max-height: min(36vh, calc(var(--space-2xl) * 9))");
|
|
expect(candidatesRule).toContain("overflow-y: auto");
|
|
});
|
|
|
|
it("renders fullscreen log viewer above fixed chrome layers", () => {
|
|
const fullscreenRule = getRule(".devserver-log-viewer--fullscreen");
|
|
const zIndexMatch = fullscreenRule.match(/z-index:\s*(\d+)/);
|
|
expect(zIndexMatch).toBeTruthy();
|
|
|
|
const zIndex = Number.parseInt(zIndexMatch?.[1] ?? "0", 10);
|
|
expect(zIndex).toBeGreaterThan(50);
|
|
});
|
|
|
|
it("separates warning fallback styling from external-only mode", () => {
|
|
const fallbackRule = getRule(".dev-server-preview-fallback", { last: true });
|
|
const externalOnlyRule = getRule(".dev-server-preview-external-only", { last: true });
|
|
|
|
expect(fallbackRule).toContain("var(--color-warning)");
|
|
expect(externalOnlyRule).toContain("border: 1px solid var(--border)");
|
|
expect(externalOnlyRule).toContain("background: var(--surface)");
|
|
expect(externalOnlyRule).not.toContain("--color-warning");
|
|
});
|
|
|
|
it("keeps the preview header responsive on narrow screens", () => {
|
|
const badgeRule = getRule(".devserver-preview-url-badge");
|
|
expect(badgeRule).toContain("flex: 1 1 auto");
|
|
expect(badgeRule).toContain("min-width: 0");
|
|
|
|
const mobileHeaderRule = getRule(".devserver-preview-header", { last: true });
|
|
expect(mobileHeaderRule).toContain("flex-wrap: wrap");
|
|
|
|
const mobileActionsRule = getRule(".devserver-preview-actions", { last: true });
|
|
expect(mobileActionsRule).toContain("width: 100%");
|
|
expect(mobileActionsRule).toContain("justify-content: flex-end");
|
|
});
|
|
});
|