8f176e3b89
Keep board and list activity styling synchronized with actual agent work. - Centralize task activity detection across cards, lists, routing, and model-resolution surfaces. - Show running workflow activity while suppressing stale, paused, stuck-killed, and terminal task states. - Cover status-null workflow activity and terminal-state regressions. Files changed: packages/dashboard/app/components/ListView.tsx | 34 ++--------- packages/dashboard/app/components/RoutingTab.tsx | 17 +----- packages/dashboard/app/components/TaskCard.tsx | 28 +++------ .../app/components/__tests__/ListView.test.tsx | 66 +++++++++++--------- .../app/components/__tests__/TaskCard.test.tsx | 44 ++++++++++++++ .../app/components/effective-model-resolution.ts | 18 +----- .../app/utils/__tests__/taskActivity.test.ts | 71 ++++++++++++++++++++++ packages/dashboard/app/utils/taskActivity.ts | 59 ++++++++++++++++++ 8 files changed, 228 insertions(+), 109 deletions(-) Fusion-Task-Id: FN-8055 Fusion-Task-Lineage: 9ce38d60-06c8-4050-83f4-263e2f765c86 Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
72 lines
3.0 KiB
TypeScript
72 lines
3.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Task } from "@fusion/core";
|
|
import { ACTIVE_STATUSES, isTaskAgentActive } from "../taskActivity";
|
|
|
|
function makeTask(overrides: Partial<Task> = {}): Task {
|
|
return {
|
|
id: "FN-8055",
|
|
title: "Activity fixture",
|
|
description: "Activity fixture",
|
|
column: "triage",
|
|
status: null,
|
|
steps: [],
|
|
enabledWorkflowSteps: [],
|
|
workflowStepResults: [],
|
|
createdAt: "2026-07-16T00:00:00.000Z",
|
|
updatedAt: "2026-07-16T00:00:00.000Z",
|
|
...overrides,
|
|
} as Task;
|
|
}
|
|
|
|
function taskWithRunningWorkflowStep(overrides: Partial<Task> = {}): Task {
|
|
return makeTask({
|
|
enabledWorkflowSteps: ["plan-review"],
|
|
workflowStepResults: [{
|
|
workflowStepId: "plan-review",
|
|
workflowStepName: "Plan Review",
|
|
status: "pending",
|
|
startedAt: "2026-07-16T00:00:00.000Z",
|
|
}],
|
|
...overrides,
|
|
});
|
|
}
|
|
|
|
describe("isTaskAgentActive", () => {
|
|
it("uses the canonical set for every active phase", () => {
|
|
expect([...ACTIVE_STATUSES]).toEqual([
|
|
"planning", "researching", "executing", "finalizing", "merging", "merging-pr", "merging-fix", "reviewing", "landing",
|
|
]);
|
|
for (const status of ACTIVE_STATUSES) {
|
|
expect(isTaskAgentActive(makeTask({ status }))).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("recognizes an in-progress task and status-null running workflow step", () => {
|
|
expect(isTaskAgentActive(makeTask({ column: "in-progress" }))).toBe(true);
|
|
expect(isTaskAgentActive(taskWithRunningWorkflowStep())).toBe(true);
|
|
});
|
|
|
|
it("does not treat a status-null task without a running item as active", () => {
|
|
expect(isTaskAgentActive(makeTask())).toBe(false);
|
|
});
|
|
|
|
it.each([
|
|
["queued task status", taskWithRunningWorkflowStep({ status: "queued" }), {}],
|
|
["paused status", taskWithRunningWorkflowStep({ status: "paused" }), {}],
|
|
["paused task", taskWithRunningWorkflowStep({ paused: true }), {}],
|
|
["failed status", taskWithRunningWorkflowStep({ status: "failed" }), {}],
|
|
["stuck-killed status", taskWithRunningWorkflowStep({ column: "in-progress", status: "stuck-killed" }), {}],
|
|
["awaiting approval", taskWithRunningWorkflowStep({ status: "awaiting-approval" }), {}],
|
|
["awaiting user input", taskWithRunningWorkflowStep({ status: "awaiting-user-input" }), {}],
|
|
["done status", taskWithRunningWorkflowStep({ status: "done" }), {}],
|
|
["done column", taskWithRunningWorkflowStep({ column: "done" }), {}],
|
|
["archived column with merging status", taskWithRunningWorkflowStep({ column: "archived", status: "merging" }), {}],
|
|
["archived column with running workflow", taskWithRunningWorkflowStep({ column: "archived" }), {}],
|
|
["render queue", taskWithRunningWorkflowStep(), { queued: true }],
|
|
["derived stuck", taskWithRunningWorkflowStep(), { isStuck: true }],
|
|
["global pause", taskWithRunningWorkflowStep(), { globalPaused: true }],
|
|
] as const)("rejects %s before running workflow activity", (_name, task, options) => {
|
|
expect(isTaskAgentActive(task, options)).toBe(false);
|
|
});
|
|
});
|