> **Re-landing the second half of #3031.** That PR merged into #3029's branch and only its first commit reached `main` — the arity rule shipped, the interface rule and its finding did not. Verified on `main`: the gate reports *"7 mirrored function(s)"* with no interface count, and the dead prop below is still there. ## What The arity rule covers exported functions. The same files also mirror **interfaces**, which is the larger surface — six copies of `PluginDashboardViewContext` alone. **One direction only.** A mirror may declare *fewer* properties, and all six do (6, 8, 7, 7, 3, 6 against the real nine) because a plugin mirrors the fields it uses. Demanding equality would fail every plugin for not using everything — which is how a check gets ignored and then deleted. A property the real type **doesn't have** is the drift that matters: a rename nobody propagated, where the plugin keeps compiling and reads a field the host never sends. ## Its first interface run found a live one ``` dashboard-interop.d.ts:67 TaskCardProps.workflowStepNameLookup is not a property of the real TaskCardProps ``` Git history says it **was** one when FN-2466 and FN-7039 added this threading. The dashboard removed it later; nothing propagated that to the plugin's hand-written declaration. So the plugin built a lookup map from `context.workflowSteps` on every render, threaded it through two components, and handed it to a `TaskCard` with no such prop. Deleted rather than exempted — a new gate shouldn't ship with a waiver for its own first finding. Behaviour-preserving: the value never reached anything. ## Measured on `main` | check | result | |---|---| | population | **7 functions + 10 interfaces across 6 plugins**, all matching after the deletion | | control probe | phantom property **caught**; clean tree exits 0 | | anti-vacuity | now also requires a non-zero *interface* comparison | | gate's own suite | **5 → 8** | | dependency-graph suite | 179 green; `tsc` clean | | other five gates · census | green | ## Running total for this check Three real drifts, none of which any other instrument reported: 1. `isTaskStuck` stuck at three parameters through the whole lane conversion (#3003) 2. `taskStuckTimeoutMs?: number` vs the required `number | undefined` — in **two independent authors'** declarations 3. `workflowStepNameLookup` outliving its removal from `TaskCard` Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
178 lines
7.1 KiB
TypeScript
178 lines
7.1 KiB
TypeScript
import type { CSSProperties, ComponentProps, HTMLAttributes } from "react";
|
|
import type { TraitFlags } from "@fusion/core";
|
|
import type { GraphPosition } from "./types.js";
|
|
import { useNodeDrag } from "./hooks/useNodeDrag.js";
|
|
import { TaskCard } from "@fusion/dashboard/app/components/TaskCard";
|
|
import { isTaskStuck } from "@fusion/dashboard/app/utils/taskStuck";
|
|
import "./GraphTaskNode.css";
|
|
import "./GraphHighlight.css";
|
|
import "./styles/drag.css";
|
|
|
|
type TaskCardComponentProps = ComponentProps<typeof TaskCard>;
|
|
|
|
type TaskCardBridgeProps = Pick<
|
|
TaskCardComponentProps,
|
|
| "task"
|
|
| "projectId"
|
|
| "onOpenDetail"
|
|
| "addToast"
|
|
| "globalPaused"
|
|
| "onUpdateTask"
|
|
| "onArchiveTask"
|
|
| "onUnarchiveTask"
|
|
| "onDeleteTask"
|
|
| "onRetryTask"
|
|
| "onOpenDetailWithTab"
|
|
| "taskStuckTimeoutMs"
|
|
| "onOpenMission"
|
|
| "onMoveTask"
|
|
| "lastFetchTimeMs"
|
|
>;
|
|
|
|
export interface GraphTaskNodeProps extends TaskCardBridgeProps, Pick<HTMLAttributes<HTMLDivElement>, "onMouseEnter" | "onMouseLeave" | "onClick"> {
|
|
/*
|
|
FNXC:WorkflowLifecycleColumns 2026-07-31-15:30:
|
|
This card's OWN resolved column traits, threaded from the host's plugin view context.
|
|
|
|
Two defects close here, both from this component having no access to the board's vocabulary:
|
|
- `isTaskStuck` was called without its `columnFlags` argument, so `isWipColumnRole` fell back to
|
|
the literal and NO card in the graph was ever shown stuck on a renamed board — while the same
|
|
card showed stuck correctly on the main board. That asymmetry was the tell.
|
|
- The `TaskCard` rendered below is a THIRD producer of unflagged cards, after the two #3025 fixed.
|
|
It bypasses `renderTaskCard` entirely by importing the component directly, so a host-side fix
|
|
could not reach it; every role helper inside it read the legacy ids.
|
|
|
|
Optional, and absent means legacy: the host omits the map for remote rows and off-board columns, and
|
|
the degraded answer there is the documented literal rather than "this board has no such lane".
|
|
*/
|
|
taskColumnFlags?: Partial<TraitFlags>;
|
|
style?: CSSProperties;
|
|
position: GraphPosition;
|
|
scale: number;
|
|
isSelected?: boolean;
|
|
isHighlighted?: boolean;
|
|
isDimmed?: boolean;
|
|
onNodePositionChange: (taskId: string, position: GraphPosition) => void;
|
|
onNodeDragStateChange?: (isDragging: boolean) => void;
|
|
onNodeDragEnd?: () => void;
|
|
}
|
|
|
|
const ACTIVE_STATUSES = new Set(["planning", "researching", "executing", "finalizing", "merging", "merging-fix"]);
|
|
|
|
function getStatusLabel(status?: string): string {
|
|
if (!status) {
|
|
return "Executing";
|
|
}
|
|
|
|
return status.charAt(0).toUpperCase() + status.slice(1);
|
|
}
|
|
|
|
export function GraphTaskNode({
|
|
taskColumnFlags,
|
|
style,
|
|
position,
|
|
scale,
|
|
isSelected = false,
|
|
isHighlighted = false,
|
|
isDimmed = false,
|
|
onMouseEnter,
|
|
onMouseLeave,
|
|
onClick,
|
|
onNodePositionChange,
|
|
onNodeDragStateChange,
|
|
onNodeDragEnd,
|
|
...taskCardProps
|
|
}: GraphTaskNodeProps) {
|
|
const { task, globalPaused, taskStuckTimeoutMs, lastFetchTimeMs, onOpenDetail } = taskCardProps;
|
|
const isFailed = task.status === "failed";
|
|
const isPaused = task.paused === true;
|
|
const isStuck = isTaskStuck(task, taskStuckTimeoutMs, lastFetchTimeMs, taskColumnFlags);
|
|
/*
|
|
FNXC:PluginLifecycleColumns 2026-07-30-03:40 (U11 #2515 audit):
|
|
Keyed on `column === "triage"`, this went permanently FALSE for default-lineage
|
|
cards once U11 merged Todo into Planning and dropped the `triage` id — an
|
|
awaiting-approval card sits in `todo` now. The node then stopped showing the
|
|
awaiting-approval state AND fell through to `isActive`, rendering a card that is
|
|
blocked on a human as if it were running.
|
|
|
|
The column condition is DELETED rather than converted, because it was always
|
|
redundant: `awaiting-approval` is written only by the plan-approval gate and the
|
|
replan-cap park, both of which act on a card in the planning lane, so the status
|
|
alone is the signal. Deleting it is also the only option that needs no resolution —
|
|
this is a synchronous React render, where an IR lookup is not available.
|
|
*/
|
|
/*
|
|
FNXC:PluginLifecycleColumns 2026-07-31-11:50 (PR #2644 review, greptile P1):
|
|
A STALE APPROVAL STATUS MUST NOT HIDE A RUNNING CARD. Dropping the column condition made the
|
|
awaiting-approval signal status-only, which is right for a planning-lane card — but `awaiting-approval`
|
|
is DURABLE, so a card that carries it into an execution lane was rendered as not-active: no active
|
|
styling, no execution-status indicator, no current-step metadata, while it was plainly running.
|
|
|
|
So the suppression now yields to an execution SIGNAL rather than to a column name. If the card shows
|
|
execution activity, it is active and the stale approval status is residue; if it does not, the approval
|
|
state is the truth. That ordering needs no IR lookup, which matters here — this is a synchronous React
|
|
render.
|
|
|
|
The `in-progress` literal is pre-existing and NOT on the triage bar; converting it needs the board's
|
|
column traits, which this component is not given. Left with this note rather than half-converted.
|
|
*/
|
|
const hasExecutionSignal = task.column === "in-progress" || ACTIVE_STATUSES.has(task.status as string);
|
|
const isAwaitingApproval = task.status === "awaiting-approval" && !hasExecutionSignal;
|
|
const isActive =
|
|
!globalPaused &&
|
|
!isFailed &&
|
|
!isPaused &&
|
|
!isStuck &&
|
|
!isAwaitingApproval &&
|
|
hasExecutionSignal;
|
|
|
|
const hasValidCurrentStep =
|
|
typeof task.currentStep === "number" &&
|
|
task.currentStep >= 0 &&
|
|
Array.isArray(task.steps) &&
|
|
task.currentStep < task.steps.length;
|
|
const isInReview = task.column === "in-review";
|
|
|
|
const drag = useNodeDrag({
|
|
taskId: task.id,
|
|
position,
|
|
scale,
|
|
canDrag: isSelected,
|
|
onPositionChange: onNodePositionChange,
|
|
onDragStateChange: onNodeDragStateChange,
|
|
onDragEnd: onNodeDragEnd,
|
|
onDoubleTap: () => onOpenDetail(task),
|
|
});
|
|
|
|
return (
|
|
<div
|
|
className={`graph-task-node${isSelected ? " graph-node--draggable graph-task-node--selected" : ""}${drag.isDragging ? " graph-node--dragging" : ""}${isHighlighted ? " graph-task-node--highlighted graph-node--highlighted" : ""}${isDimmed ? " graph-task-node--dimmed graph-node--dimmed" : ""}${isActive ? " graph-task-node--active" : ""}${isInReview ? " graph-task-node--in-review" : ""}`}
|
|
style={style}
|
|
draggable={false}
|
|
data-testid={`graph-task-node-${task.id}`}
|
|
data-current-step={isActive && hasValidCurrentStep ? String(task.currentStep) : undefined}
|
|
onMouseEnter={onMouseEnter}
|
|
onMouseLeave={onMouseLeave}
|
|
onClick={onClick}
|
|
onDoubleClick={(event) => {
|
|
if (event.defaultPrevented) {
|
|
return;
|
|
}
|
|
onOpenDetail(task);
|
|
}}
|
|
onClickCapture={drag.onClickCapture}
|
|
onPointerDown={drag.onPointerDown}
|
|
onPointerMove={drag.onPointerMove}
|
|
onPointerUp={drag.onPointerUp}
|
|
onPointerCancel={drag.onPointerCancel}
|
|
>
|
|
{isActive ? (
|
|
<div className="graph-task-active-indicator">
|
|
<span className="graph-task-active-indicator-text">{getStatusLabel(task.status)}</span>
|
|
</div>
|
|
) : null}
|
|
<TaskCard {...taskCardProps} taskColumnFlags={taskColumnFlags} onOpenDetail={() => {}} disableDrag={true} />
|
|
</div>
|
|
);
|
|
}
|