ef50244234
Instruments a surface no existing check can see. Follows #2839, and **corrects the count I reported there** (12 → 14). ## Why it was invisible The lifecycle census parses TypeScript **comparisons**; a legacy id inside a SQL string is string data. The inert-seam gate reasons about parameters and call sites. Neither has ever looked here. **What it cost:** `cleanupStaleMergeQueueRowsImpl` filtered on `t.column != 'in-review'`, so on a renamed board every queued card looked stale, its `merge_queue` row was deleted, and the card became **unleaseable**. The operator found it reviewing #2819 — in SQL I had already read past during that same work. The quieter half is analytics: five sites count `"column" = 'done'`, so throughput, cycle time, and team dashboards report **zero completed work** on a renamed board. Nothing errors, which is why nobody files it. ## What this does, and does not do It does **not** fix the sites. `resolveProjectColumnsForRoles` is the mechanism and its migration has an owner (#2839). This freezes the population so the surface cannot grow underneath that migration: a new file or a higher count fails, **and a lower count fails too** — so the baseline ratchets down as sites migrate rather than leaving slots to silently regrow into. That is the same rot as an allow-list entry for a deleted function, which this repo already hit once. AST-based, deliberately: a line grep for the same pattern reports **37** hits, **25 of them prose** quoting `column === "done"` in explanatory notes. A guard that is 68% false positives trains its readers to skip it — a lesson this program has already paid for. ## Two corrections found by mutation-testing my own gate **1. Clause fragments were missed.** Requiring a SQL keyword *in the same literal* skipped `team-analytics.ts`, which builds `["assignedAgentId IS NOT NULL", `"column" = 'done'`, ...]` and joins them into a `WHERE` later. That fragment is as vocabulary-bound as any full query but contains no keyword. Fixing it took the population **12 → 14**, so the number I put on #2839 was low. **2. My first mutation test proved a direction it had not.** I replaced the first textual occurrence in a file — which was inside a **comment** — and read the unchanged count as the scanner being broken. The scanner was right; my test was wrong. All three directions are now driven against real SQL: | mutation | result | |---|---| | add a full query with a legacy comparison | `3 SQL column literal(s), baseline allows 2` | | add a bare clause **fragment** (no keyword) | caught — same failure | | migrate one away (count drops) | `1 site(s) now, baseline still allows 2 — re-record it` | | restore | exit 0 | I am flagging that second one because it is the exact failure mode this program keeps finding: a green result read as evidence when the experiment was invalid. ## Verification `pnpm test:gate` green with the new check in it · lint 0 · single AST pass. Wired into `test:gate` and both `pretest` hooks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Added automated checks to detect increases in legacy SQL column literals. * Added baseline tracking to ensure known SQL literal counts do not regress. * **Tests** * Expanded pre-test and gated verification steps with SQL literal and mock completeness checks. * Updated test validation workflows to enforce the new safeguards. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
126 lines
7.9 KiB
JSON
126 lines
7.9 KiB
JSON
{
|
|
"name": "fusion-workspace",
|
|
"version": "0.74.0-beta.5",
|
|
"private": true,
|
|
"license": "MIT",
|
|
"homepage": "https://github.com/Runfusion/Fusion#readme",
|
|
"repository": {
|
|
"type": "git",
|
|
"url": "https://github.com/Runfusion/Fusion"
|
|
},
|
|
"bugs": {
|
|
"url": "https://github.com/Runfusion/Fusion/issues"
|
|
},
|
|
"type": "module",
|
|
"packageManager": "pnpm@10.33.0",
|
|
"scripts": {
|
|
"pretest": "node scripts/check-no-nohup.mjs && node scripts/check-no-cwd-relative-dashboard-test-reads.mjs && node scripts/check-no-kill-4040.mjs && node scripts/check-no-getdatabase.mjs && node scripts/check-capacity-pool-id.mjs && node scripts/check-no-node-only-core-imports-in-dashboard.mjs && node scripts/check-pi-versions-pinned.mjs && node scripts/check-no-test-timeout-appeasement.mjs && node scripts/check-inert-flag-seams.mjs && node scripts/check-sql-column-literals.mjs && node scripts/check-changeset-format.mjs && node scripts/check-routes-modular.mjs",
|
|
"pretest:full": "node scripts/check-inert-flag-seams.mjs && node scripts/check-sql-column-literals.mjs && node scripts/check-no-nohup.mjs && node scripts/check-no-cwd-relative-dashboard-test-reads.mjs && node scripts/check-no-kill-4040.mjs && node scripts/check-no-getdatabase.mjs && node scripts/check-capacity-pool-id.mjs && node scripts/check-no-node-only-core-imports-in-dashboard.mjs && node scripts/check-pi-versions-pinned.mjs && node scripts/check-no-test-timeout-appeasement.mjs && node scripts/check-changeset-format.mjs && node scripts/check-routes-modular.mjs",
|
|
"check:line-count": "node scripts/check-file-line-count.mjs",
|
|
"check:routes-modular": "node scripts/check-routes-modular.mjs",
|
|
"check:changesets": "node scripts/check-changeset-format.mjs",
|
|
"check:lifecycle-columns": "node scripts/lifecycle-column-census.mjs --strict",
|
|
"census:lifecycle-columns": "node scripts/lifecycle-column-census.mjs",
|
|
"check:quarantine-ledger": "node scripts/check-quarantine-ledger.mjs",
|
|
"check:mock-completeness": "node scripts/check-mock-completeness.mjs",
|
|
"test:gate": "node scripts/check-no-nohup.mjs && node scripts/check-no-cwd-relative-dashboard-test-reads.mjs && node scripts/check-no-kill-4040.mjs && node scripts/check-no-getdatabase.mjs && node scripts/check-capacity-pool-id.mjs && node scripts/check-no-node-only-core-imports-in-dashboard.mjs && node scripts/check-pi-versions-pinned.mjs && node scripts/check-no-test-timeout-appeasement.mjs && node scripts/check-sql-column-literals.mjs && node scripts/check-changeset-format.mjs && node scripts/check-mock-completeness.mjs && sh -c 'pnpm --filter @fusion/engine test:core & engine_pid=$!; pnpm --filter @fusion/core test:pg-gate & pg_pid=$!; pnpm --filter @fusion/core test:unit-gate & unit_pid=$!; status=0; wait $engine_pid || status=1; wait $pg_pid || status=1; wait $unit_pid || status=1; exit $status' && pnpm --filter @runfusion/fusion test:ci-shape",
|
|
"smoke:boot": "node scripts/boot-smoke.mjs",
|
|
"local": "node scripts/start-local.mjs",
|
|
"dev": "node scripts/dev-with-memory.mjs",
|
|
"start": "node scripts/dev-with-memory.mjs",
|
|
"dev:ui": "pnpm --filter @fusion/dashboard dev",
|
|
"dev:hmr": "node scripts/dev-hmr.mjs",
|
|
"lint": "eslint .",
|
|
"sync:fusion-skill": "node scripts/sync-fusion-skill-tools.mjs",
|
|
"sync:fusion-skill:check": "node scripts/sync-fusion-skill-tools.mjs --check",
|
|
"build": "node scripts/build-workspace.mjs",
|
|
"build:full": "node scripts/build-workspace.mjs --full",
|
|
"build:force": "node scripts/build-workspace.mjs --force",
|
|
"build:all": "pnpm -r build",
|
|
"verify:workspace": "pnpm lint && pnpm test:full && pnpm build:full",
|
|
"build:exe": "pnpm build:full && pnpm --filter @runfusion/fusion build:exe",
|
|
"build:exe:all": "pnpm build:full && pnpm --filter @runfusion/fusion build:exe:all",
|
|
"test": "node scripts/test-changed.mjs",
|
|
"verify:fast": "node scripts/verify-fast.mjs",
|
|
"test:scripts": "node scripts/run-script-tests.mjs",
|
|
"test:workflow-release-check": "node scripts/workflow-reliability-release-check.mjs",
|
|
"fn:cache-stats": "node scripts/cache-stats.mjs",
|
|
"test:full": "node scripts/test-changed.mjs --full --no-cache && pnpm --filter @fusion/engine test:slow",
|
|
"test:velocity": "node scripts/test-velocity-baseline.mjs",
|
|
"test:feedback-baseline": "node scripts/test-feedback-baseline.mjs",
|
|
"test:ci:shard": "node scripts/ci-test-shard.mjs",
|
|
"test:serial": "FUSION_TEST_CONCURRENCY=1 FUSION_TEST_WORKSPACE_CONCURRENCY=1 pnpm test:full",
|
|
"test:fast": "FUSION_TEST_CONCURRENCY=4 FUSION_TEST_WORKSPACE_CONCURRENCY=4 pnpm test:full",
|
|
"test:locked": "node scripts/test-with-lock.mjs",
|
|
"test:build": "pnpm --filter @fusion/dashboard test:build",
|
|
"test:isolated": "node scripts/check-test-isolation.mjs --before && pnpm test:full && node scripts/check-test-isolation.mjs",
|
|
"test:check-isolation": "node scripts/check-test-isolation.mjs",
|
|
"test:coverage": "pnpm -r --workspace-concurrency=1 exec vitest run --silent=passed-only --reporter=dot --coverage",
|
|
"test:coverage:core": "pnpm --filter @fusion/core exec vitest run --silent=passed-only --reporter=dot --coverage",
|
|
"test:coverage:engine": "pnpm --filter @fusion/engine exec vitest run --silent=passed-only --reporter=dot --coverage",
|
|
"test:coverage:cli": "pnpm --filter @runfusion/fusion exec vitest run --silent=passed-only --reporter=dot --coverage",
|
|
"test:coverage:dashboard": "pnpm --filter @fusion/dashboard exec vitest run --silent=passed-only --reporter=dot --coverage",
|
|
"test:slow-cli": "pnpm --filter @runfusion/fusion test:slow-cli",
|
|
"typecheck": "pnpm -r --filter=!@fusion/desktop --filter=!@fusion/mobile typecheck",
|
|
"i18n:extract": "i18next-cli extract",
|
|
"i18n:sync": "i18next-cli sync",
|
|
"i18n:types": "i18next-cli types",
|
|
"i18n:status": "tsx --no-warnings packages/i18n/scripts/check-i18n-parity.mjs",
|
|
"i18n:status:report": "i18next-cli status",
|
|
"i18n:lint": "i18next-cli lint",
|
|
"i18n:gen-cli": "pnpm --filter @fusion/i18n gen:cli-catalogs",
|
|
"changeset": "changeset",
|
|
"version": "changeset version",
|
|
"release": "node scripts/release.mjs",
|
|
"release:version": "changeset version && node scripts/sync-workspace-version.mjs && node scripts/run-ci-distill.mjs",
|
|
"mobile:build": "pnpm --filter @fusion/dashboard build && pnpm --filter @fusion/mobile cap sync",
|
|
"mobile:ios": "pnpm mobile:build && pnpm --filter @fusion/mobile cap open ios",
|
|
"mobile:android": "pnpm mobile:build && pnpm --filter @fusion/mobile cap open android",
|
|
"mobile:dev:ios": "pnpm --filter @fusion/mobile dev:ios",
|
|
"mobile:dev:android": "pnpm --filter @fusion/mobile dev:android",
|
|
"mobile:sync": "pnpm --filter @fusion/mobile cap sync",
|
|
"mobile:run:android": "bash scripts/mobile-run-android.sh",
|
|
"ios:acceptance": "node scripts/ios-acceptance.mjs",
|
|
"build:desktop": "pnpm --filter @fusion/desktop build",
|
|
"dist:desktop:win": "pnpm --filter @fusion/desktop build && pnpm --filter @fusion/desktop dist:win"
|
|
},
|
|
"pnpm": {
|
|
"ignoredBuiltDependencies": [
|
|
"@google/genai",
|
|
"cpu-features",
|
|
"electron-winstaller",
|
|
"keytar",
|
|
"sharp",
|
|
"ssh2"
|
|
],
|
|
"onlyBuiltDependencies": [
|
|
"@embedded-postgres/darwin-arm64",
|
|
"@embedded-postgres/darwin-x64",
|
|
"@embedded-postgres/linux-arm",
|
|
"@embedded-postgres/linux-arm64",
|
|
"@embedded-postgres/linux-ia32",
|
|
"@embedded-postgres/linux-ppc64",
|
|
"@embedded-postgres/linux-x64",
|
|
"@embedded-postgres/windows-x64",
|
|
"@homebridge/node-pty-prebuilt-multiarch",
|
|
"electron",
|
|
"esbuild",
|
|
"koffi",
|
|
"protobufjs"
|
|
]
|
|
},
|
|
"devDependencies": {
|
|
"@changesets/cli": "^2.30.0",
|
|
"@eslint/js": "^9.0.0",
|
|
"eslint": "^9.0.0",
|
|
"esbuild": "^0.25.12",
|
|
"fast-glob": "^3.3.3",
|
|
"i18next-cli": "^1.59.1",
|
|
"react-devtools-core": "^7.0.1",
|
|
"tsx": "^4.19.0",
|
|
"typescript": "^5.7.0",
|
|
"typescript-eslint": "^8.0.0",
|
|
"yaml": "^2.8.3"
|
|
}
|
|
}
|