Clear near-duplicate decisions when their canonical task is no longer active. - Add a shared canonical activity helper for near-duplicate detection. - Clear stale persisted near-duplicate metadata when canonical tasks are done, archived, or deleted. - Prevent triage and dashboard surfaces from presenting duplicate decisions for inactive canonicals. - Cover stale-flag cleanup and hidden dashboard affordances with regression tests. Files changed: docs/task-management.md | 4 +- .../near-duplicate-stale-flag-clear.test.ts | 105 +++++++++++++++++++++ packages/core/src/__tests__/near-duplicate.test.ts | 19 +++- packages/core/src/index.ts | 2 + packages/core/src/near-duplicate-canonical.ts | 25 +++++ packages/core/src/near-duplicate.ts | 3 + packages/core/src/store.ts | 102 +++++++++++++++++++- packages/dashboard/app/App.tsx | 7 +- packages/dashboard/app/components/Column.tsx | 10 ++ packages/dashboard/app/components/TaskCard.tsx | 12 ++- .../dashboard/app/components/TaskDetailModal.tsx | 12 ++- packages/dashboard/app/components/WorktreeGroup.tsx | 30 +++++- .../app/components/__tests__/TaskCard.test.tsx | 28 ++++++ .../__tests__/TaskDetailModal.rendering.test.tsx | 26 +++++ .../near-duplicate-intake.test.ts | 24 +++++ packages/engine/src/triage.ts | 10 ++ 16 files changed, 411 insertions(+), 8 deletions(-) Fusion-Task-Id: FN-6439 Fusion-Task-Lineage: e57b80e8-36aa-4b96-ad13-53b5a431477d
132 lines
5.0 KiB
TypeScript
132 lines
5.0 KiB
TypeScript
import { memo } from "react";
|
|
import { useTranslation } from "react-i18next";
|
|
import type { Task, TaskDetail } from "@fusion/core";
|
|
import { isNearDuplicateCanonicalInactive } from "../../../core/src/near-duplicate-canonical";
|
|
import { ClipboardList, GitBranch } from "lucide-react";
|
|
import { TaskCard } from "./TaskCard";
|
|
import type { ToastType } from "../hooks/useToast";
|
|
import type { BlockerFanoutEntry } from "../hooks/useBlockerFanout";
|
|
|
|
interface WorktreeGroupProps {
|
|
label: string;
|
|
activeTasks: Task[];
|
|
queuedTasks: Task[];
|
|
allTasks?: Task[];
|
|
projectId?: string;
|
|
onOpenDetail: (task: Task | TaskDetail) => void;
|
|
addToast: (message: string, type?: ToastType) => void;
|
|
globalPaused?: boolean;
|
|
onUpdateTask?: (
|
|
id: string,
|
|
updates: { title?: string; description?: string; dependencies?: string[] }
|
|
) => Promise<Task>;
|
|
onRetryTask?: (id: string) => Promise<Task>;
|
|
onOpenDetailWithTab?: (task: Task | TaskDetail, initialTab: "changes" | "retries" | "workflow") => void;
|
|
/** Project-level stuck task timeout in milliseconds (undefined = disabled) */
|
|
taskStuckTimeoutMs?: number;
|
|
/** Called when user clicks a mission badge on a task card */
|
|
onOpenMission?: (missionId: string) => void;
|
|
/** Timestamp (ms) when task data was last confirmed fresh from the server. Used for freshness-aware stuck detection. */
|
|
lastFetchTimeMs?: number;
|
|
/** Lookup of workflow step IDs to display names, fetched once at board level. */
|
|
workflowStepNameLookup?: ReadonlyMap<string, string>;
|
|
/** Per-task card-placed custom field definitions (U13/KTD-14). */
|
|
taskCardFieldDefs?: ReadonlyMap<string, import("../api").WorkflowFieldDefinition[]>;
|
|
/** Precomputed blocker fanout keyed by blocker task ID. */
|
|
blockerFanoutMap?: ReadonlyMap<string, BlockerFanoutEntry>;
|
|
/** Whether GitHub CLI auth is available for creating PRs from task cards. */
|
|
prAuthAvailable?: boolean;
|
|
/** Whether project-level auto-merge is enabled, which hides manual Create PR card actions. */
|
|
autoMergeEnabled?: boolean;
|
|
}
|
|
|
|
function WorktreeGroupComponent({
|
|
label,
|
|
activeTasks,
|
|
queuedTasks,
|
|
allTasks,
|
|
projectId,
|
|
onOpenDetail,
|
|
addToast,
|
|
globalPaused,
|
|
onUpdateTask,
|
|
onRetryTask,
|
|
onOpenDetailWithTab,
|
|
taskStuckTimeoutMs,
|
|
onOpenMission,
|
|
lastFetchTimeMs,
|
|
workflowStepNameLookup,
|
|
taskCardFieldDefs,
|
|
blockerFanoutMap,
|
|
prAuthAvailable,
|
|
autoMergeEnabled,
|
|
}: WorktreeGroupProps) {
|
|
const { t } = useTranslation("app");
|
|
const upNextLabel = t("worktree.upNext", "Up Next");
|
|
const unassignedLabel = t("worktree.unassigned", "Unassigned");
|
|
const resolveNearDuplicateCanonicalInactive = (task: Task): boolean | undefined => {
|
|
const nearDuplicateOf = task.sourceMetadata?.nearDuplicateOf;
|
|
if (typeof nearDuplicateOf !== "string" || !allTasks) return undefined;
|
|
return isNearDuplicateCanonicalInactive(allTasks.find((candidate) => candidate.id === nearDuplicateOf));
|
|
};
|
|
|
|
return (
|
|
<div className="worktree-group">
|
|
<div className="worktree-group-header">
|
|
<span className="worktree-icon">
|
|
{label === upNextLabel || label === unassignedLabel ? <ClipboardList size={14} /> : <GitBranch size={14} />}
|
|
</span>
|
|
<span className="worktree-label">{label}</span>
|
|
</div>
|
|
{activeTasks.map((task) => (
|
|
<TaskCard
|
|
key={task.id}
|
|
task={task}
|
|
projectId={projectId}
|
|
onOpenDetail={onOpenDetail}
|
|
addToast={addToast}
|
|
globalPaused={globalPaused}
|
|
onUpdateTask={onUpdateTask}
|
|
onRetryTask={onRetryTask}
|
|
onOpenDetailWithTab={onOpenDetailWithTab}
|
|
taskStuckTimeoutMs={taskStuckTimeoutMs}
|
|
onOpenMission={onOpenMission}
|
|
lastFetchTimeMs={lastFetchTimeMs}
|
|
workflowStepNameLookup={workflowStepNameLookup}
|
|
cardFieldDefs={taskCardFieldDefs?.get(task.id)}
|
|
fanout={blockerFanoutMap?.get(task.id)}
|
|
prAuthAvailable={prAuthAvailable}
|
|
autoMergeEnabled={autoMergeEnabled}
|
|
nearDuplicateCanonicalInactive={resolveNearDuplicateCanonicalInactive(task)}
|
|
/>
|
|
))}
|
|
{queuedTasks.map((task) => (
|
|
<TaskCard
|
|
key={task.id}
|
|
task={task}
|
|
projectId={projectId}
|
|
queued
|
|
onOpenDetail={onOpenDetail}
|
|
addToast={addToast}
|
|
globalPaused={globalPaused}
|
|
onUpdateTask={onUpdateTask}
|
|
onRetryTask={onRetryTask}
|
|
onOpenDetailWithTab={onOpenDetailWithTab}
|
|
taskStuckTimeoutMs={taskStuckTimeoutMs}
|
|
onOpenMission={onOpenMission}
|
|
lastFetchTimeMs={lastFetchTimeMs}
|
|
workflowStepNameLookup={workflowStepNameLookup}
|
|
cardFieldDefs={taskCardFieldDefs?.get(task.id)}
|
|
fanout={blockerFanoutMap?.get(task.id)}
|
|
prAuthAvailable={prAuthAvailable}
|
|
autoMergeEnabled={autoMergeEnabled}
|
|
nearDuplicateCanonicalInactive={resolveNearDuplicateCanonicalInactive(task)}
|
|
/>
|
|
))}
|
|
</div>
|
|
);
|
|
}
|
|
|
|
export const WorktreeGroup = memo(WorktreeGroupComponent);
|
|
WorktreeGroup.displayName = "WorktreeGroup";
|