- Add markOnboardingCompleted() to set completedAt timestamp when user finishes onboarding - Add isOnboardingCompleted() to check if onboarding was completed (vs dismissed) - Update ModelOnboardingModal to call markOnboardingCompleted on successful completion - Skip onboarding auto-open when already completed locally - Add completion state tracking tests in ModelOnboardingModal.test.tsx - Add model-onboarding-state unit tests - Update useAuthOnboarding to check local completion state before auto-opening - Document localStorage completion state tracking pattern in .fusion/memory.md
214 lines
6.5 KiB
TypeScript
214 lines
6.5 KiB
TypeScript
import { useCallback, useEffect, useMemo, useState } from "react";
|
|
import type { ToastType } from "../hooks/useToast";
|
|
|
|
export interface AddNodeInput {
|
|
name: string;
|
|
type: "local" | "remote";
|
|
url?: string;
|
|
apiKey?: string;
|
|
maxConcurrent: number;
|
|
}
|
|
|
|
interface AddNodeModalProps {
|
|
isOpen: boolean;
|
|
onClose: () => void;
|
|
onSubmit: (input: AddNodeInput) => Promise<void>;
|
|
addToast: (message: string, type?: ToastType) => void;
|
|
}
|
|
|
|
interface FormErrors {
|
|
name?: string;
|
|
url?: string;
|
|
maxConcurrent?: string;
|
|
}
|
|
|
|
const MAX_CONCURRENT_MIN = 1;
|
|
const MAX_CONCURRENT_MAX = 10;
|
|
|
|
function validateInput(input: AddNodeInput): FormErrors {
|
|
const errors: FormErrors = {};
|
|
|
|
if (!input.name.trim()) {
|
|
errors.name = "Name is required";
|
|
}
|
|
|
|
if (input.type === "remote" && !input.url?.trim()) {
|
|
errors.url = "URL is required for remote nodes";
|
|
}
|
|
|
|
if (!Number.isFinite(input.maxConcurrent) || input.maxConcurrent < MAX_CONCURRENT_MIN || input.maxConcurrent > MAX_CONCURRENT_MAX) {
|
|
errors.maxConcurrent = `Concurrency must be between ${MAX_CONCURRENT_MIN} and ${MAX_CONCURRENT_MAX}`;
|
|
}
|
|
|
|
return errors;
|
|
}
|
|
|
|
export function AddNodeModal({ isOpen, onClose, onSubmit, addToast }: AddNodeModalProps) {
|
|
const [name, setName] = useState("");
|
|
const [type, setType] = useState<"local" | "remote">("local");
|
|
const [url, setUrl] = useState("");
|
|
const [apiKey, setApiKey] = useState("");
|
|
const [maxConcurrent, setMaxConcurrent] = useState(2);
|
|
const [errors, setErrors] = useState<FormErrors>({});
|
|
const [isSubmitting, setIsSubmitting] = useState(false);
|
|
|
|
const resetForm = useCallback(() => {
|
|
setName("");
|
|
setType("local");
|
|
setUrl("");
|
|
setApiKey("");
|
|
setMaxConcurrent(2);
|
|
setErrors({});
|
|
setIsSubmitting(false);
|
|
}, []);
|
|
|
|
const closeModal = useCallback(() => {
|
|
if (isSubmitting) return;
|
|
resetForm();
|
|
onClose();
|
|
}, [isSubmitting, onClose, resetForm]);
|
|
|
|
useEffect(() => {
|
|
if (!isOpen) {
|
|
resetForm();
|
|
return;
|
|
}
|
|
|
|
const handleKeyDown = (event: KeyboardEvent) => {
|
|
if (event.key === "Escape") {
|
|
event.preventDefault();
|
|
closeModal();
|
|
}
|
|
};
|
|
|
|
document.addEventListener("keydown", handleKeyDown);
|
|
return () => {
|
|
document.removeEventListener("keydown", handleKeyDown);
|
|
};
|
|
}, [closeModal, isOpen, resetForm]);
|
|
|
|
const input = useMemo<AddNodeInput>(() => ({
|
|
name: name.trim(),
|
|
type,
|
|
url: type === "remote" ? url.trim() || undefined : undefined,
|
|
apiKey: type === "remote" ? apiKey || undefined : undefined,
|
|
maxConcurrent,
|
|
}), [apiKey, maxConcurrent, name, type, url]);
|
|
|
|
const handleSubmit = useCallback(async () => {
|
|
if (isSubmitting) return;
|
|
|
|
const validationErrors = validateInput(input);
|
|
setErrors(validationErrors);
|
|
|
|
if (Object.keys(validationErrors).length > 0) {
|
|
return;
|
|
}
|
|
|
|
setIsSubmitting(true);
|
|
|
|
try {
|
|
await onSubmit(input);
|
|
addToast(`Node \"${input.name}\" registered`, "success");
|
|
closeModal();
|
|
} catch (error) {
|
|
const message = error instanceof Error ? error.message : "Failed to register node";
|
|
addToast(message, "error");
|
|
} finally {
|
|
setIsSubmitting(false);
|
|
}
|
|
}, [addToast, closeModal, input, isSubmitting, onSubmit]);
|
|
|
|
if (!isOpen) return null;
|
|
|
|
return (
|
|
<div className="modal-overlay open" onClick={closeModal}>
|
|
<div className="modal modal-md add-node-modal" onClick={(event) => event.stopPropagation()} role="dialog" aria-modal="true" aria-label="Add Node">
|
|
<div className="modal-header">
|
|
<h3>Add Node</h3>
|
|
<button className="modal-close" onClick={closeModal} disabled={isSubmitting} aria-label="Close add node modal">
|
|
×
|
|
</button>
|
|
</div>
|
|
|
|
<div className="modal-body add-node-modal__body">
|
|
<label className="add-node-modal__field">
|
|
<span>Name</span>
|
|
<input
|
|
type="text"
|
|
value={name}
|
|
onChange={(event) => setName(event.target.value)}
|
|
placeholder="Build Machine"
|
|
disabled={isSubmitting}
|
|
aria-invalid={Boolean(errors.name)}
|
|
autoFocus
|
|
/>
|
|
{errors.name && <span className="add-node-modal__error">{errors.name}</span>}
|
|
</label>
|
|
|
|
<label className="add-node-modal__field">
|
|
<span>Type</span>
|
|
<select
|
|
value={type}
|
|
onChange={(event) => setType(event.target.value as "local" | "remote")}
|
|
disabled={isSubmitting}
|
|
>
|
|
<option value="local">Local</option>
|
|
<option value="remote">Remote</option>
|
|
</select>
|
|
</label>
|
|
|
|
{type === "remote" && (
|
|
<>
|
|
<label className="add-node-modal__field">
|
|
<span>URL</span>
|
|
<input
|
|
type="text"
|
|
value={url}
|
|
onChange={(event) => setUrl(event.target.value)}
|
|
placeholder="https://node.example.com"
|
|
disabled={isSubmitting}
|
|
aria-invalid={Boolean(errors.url)}
|
|
/>
|
|
{errors.url && <span className="add-node-modal__error">{errors.url}</span>}
|
|
</label>
|
|
|
|
<label className="add-node-modal__field">
|
|
<span>API Key</span>
|
|
<input
|
|
type="password"
|
|
value={apiKey}
|
|
onChange={(event) => setApiKey(event.target.value)}
|
|
placeholder="Optional"
|
|
disabled={isSubmitting}
|
|
/>
|
|
</label>
|
|
</>
|
|
)}
|
|
|
|
<label className="add-node-modal__field">
|
|
<span>Max Concurrent</span>
|
|
<input
|
|
type="number"
|
|
min={MAX_CONCURRENT_MIN}
|
|
max={MAX_CONCURRENT_MAX}
|
|
value={maxConcurrent}
|
|
onChange={(event) => setMaxConcurrent(Number(event.target.value))}
|
|
disabled={isSubmitting}
|
|
aria-invalid={Boolean(errors.maxConcurrent)}
|
|
/>
|
|
{errors.maxConcurrent && <span className="add-node-modal__error">{errors.maxConcurrent}</span>}
|
|
</label>
|
|
</div>
|
|
|
|
<div className="modal-actions">
|
|
<button className="btn btn-sm" onClick={closeModal} disabled={isSubmitting}>Cancel</button>
|
|
<button className="btn btn-primary btn-sm" onClick={handleSubmit} disabled={isSubmitting}>
|
|
{isSubmitting ? "Adding..." : "Add Node"}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|