Files
fusion/packages/core/src/approval-request-store.ts
gsxdsm 5ae6332563 refactor: collapse dead SQLite dual-path code; keep migration-only readers (#2454)
# Remove dead SQLite dual-path code; keep migration-only readers

## Summary
PostgreSQL cutover left hundreds of production dual-path branches
(`backendMode ? PG : SQLite/store.db`) whose SQLite arms only hit
throwing `Database`/`ArchiveDatabase`/`CentralDatabase` stubs. This
change mechanically collapses those unreachable arms so production
authority is AsyncDataLayer/PostgreSQL only, while preserving the six
authorized read-only migration/recovery `DatabaseSync` seams.

## Dual-path mass removed
| Metric | Before | After |
|---|---|---|
| `if (…backendMode)` (non-test) | ~328 | ~70 |
| `store.db` / `this.db` refs in core (non-test) | ~570+ | ~375 (mostly
pure legacy MissionStore/eval/insight SQLite classes + thin getters) |
| Net diff | — | **~6.7k lines removed** across 41 files |

Remaining `backendMode` checks are intentional (incomplete-PG sync
safe-defaults, settings-sync disabled-on-PG, symbol-lock PG-only gates,
“requires PostgreSQL” config versioning throws), not live SQLite
authority.

## Subsystems cleaned
- **Core TaskStore / task-store/***: collapsed if/else and early-return
dual-path across reads, moves, lifecycle, mutations, workflow, archive,
branch/PR, artifacts, comments, audit, project ops, etc. `initImpl` is
PostgreSQL-only (SQLite startup tail deleted).
- **Satellite stores**: automation, agent, routine, plugin, secrets,
approval-request, central-core dual-path arms collapsed.
- **Plugins**: reports async methods, compound-engineering pipeline +
session stores, CLI Printing Press store — SQLite fallbacks removed; PG
required.
- **Engine**: no functional dual-path change beyond whitespace
(settings-sync / peer-exchange PG-disabled behavior kept).

## Six migration-only readers retained (allowlist unchanged)
1. `packages/core/src/postgres/sqlite-migrator.ts`
2. `packages/core/src/project-identity.ts`
3. `packages/core/src/sqlite-validation.ts`
4. `packages/core/src/postgres/startup-factory.ts`
5. `packages/cli/src/commands/db.ts`
6. `scripts/lib/start-local-project.mjs`

Plus low-level `sqlite-adapter` and migrator/startup-import tests.
Inventory ratchet still requires exactly these six `new DatabaseSync(`
production sites, all `readOnly: true`.

## Not treated as SQLite
- `.fusion/project.json`, `task.json`, `agent-log.jsonl` file storage
- AsyncDataLayer / Drizzle PG paths
- Incomplete-PG sync safe-default stubs (still return empty/false/null
under backend without consulting SQLite)

## Verification
- `sqlite-production-reader-inventory.test.ts` — 15/15 pass
- `incomplete-pg-ports.pg.test.ts` — 6/6 pass
- Targeted PG tests (create-task, move, handoff, runtime-persistence,
agent, mission, insight, central-core) — green
- `tsc --noEmit` for `@fusion/core`, `@fusion/engine`,
`@fusion/dashboard` — green
- `scripts/check-no-getdatabase.mjs` — clean

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Improvements**
* Improved end-to-end consistency by making PostgreSQL/async persistence
the standard across core task/workflow, automation, agents, plugins,
routines, secrets, approvals, central operations, and session storage.
* Unified scheduling, settings, configuration revision writes,
run/workflow selection, queues/leases/transitions, and audit/lifecycle
updates around consistent async transaction behavior.
* **Bug Fixes**
* Fixed edge cases for archived/deleted reads, unarchive/recovery flows,
not-found handling, and task/artifact/document/log/comment operations,
including more reliable emissions and hydration across search/list and
lifecycle operations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-07-26 23:28:42 -07:00

274 lines
9.5 KiB
TypeScript

import { randomUUID } from "node:crypto";
import { count, eq, desc, and } from "drizzle-orm";
import type { Database } from "./db.js";
import { fromJson } from "./db.js";
import type { AsyncDataLayer } from "./postgres/data-layer.js";
import * as asyncApprovalRequestStore from "./async-approval-request-store.js";
import * as schema from "./postgres/schema/index.js";
import {
normalizeApprovalRequestActionCategory,
type ApprovalRequest,
type ApprovalRequestActorSnapshot,
type ApprovalRequestAuditEvent,
type ApprovalRequestAuditEventType,
type ApprovalRequestCompletionInput,
type ApprovalRequestCreateInput,
type ApprovalRequestDecisionInput,
type ApprovalRequestListInput,
type ApprovalRequestStatus,
} from "./types.js";
interface ApprovalRequestRow {
id: string;
status: ApprovalRequestStatus;
requesterActorId: string;
requesterActorType: ApprovalRequestActorSnapshot["actorType"];
requesterActorName: string;
targetActionCategory: string;
targetActionOperation: string;
targetActionSummary: string;
targetResourceType: string;
targetResourceId: string;
targetContext: string | null;
taskId: string | null;
runId: string | null;
requestedAt: string;
decidedAt: string | null;
completedAt: string | null;
createdAt: string;
updatedAt: string;
}
interface ApprovalRequestAuditEventRow {
id: string;
requestId: string;
eventType: ApprovalRequestAuditEventType;
actorId: string;
actorType: ApprovalRequestActorSnapshot["actorType"];
actorName: string;
note: string | null;
createdAt: string;
}
export class ApprovalRequestStore {
/**
* FNXC:ApprovalRequestStore 2026-06-24-21:15:
* When non-null, the store is in backend (PostgreSQL) mode and all data
* access delegates to the async helpers. The sync db is unused in this mode.
*/
private readonly asyncLayer: AsyncDataLayer | null;
constructor(
private db: Database | null,
options?: { asyncLayer?: AsyncDataLayer | null },
) {
this.asyncLayer = options?.asyncLayer ?? null;
}
/** True when the store is backed by PostgreSQL (AsyncDataLayer present). */
private get backendMode(): boolean {
return this.asyncLayer !== null;
}
/**
* FNXC:ApprovalRequestStore 2026-06-24-21:20:
* Asserts the sync SQLite database is available. In backend mode this is
* never called (the async branch returns first); in SQLite mode the db is
* always provided at construction.
*/
private syncDb(): Database {
if (!this.db) {
throw new Error("ApprovalRequestStore: sync Database is null (backend mode requires asyncLayer)");
}
return this.db;
}
/*
FNXC:ApprovalRedemption 2026-07-26-16:40:
In backend (PostgreSQL) mode `targetContext` is a jsonb column that Drizzle
returns ALREADY PARSED, while legacy rows may still store a JSON string.
Feeding the parsed object through the string-only `fromJson` made
`findLatestByDedupeKey` never match in PG mode, so every gate retry minted a
duplicate approval request and approved-grant reuse silently never worked in
production. Normalize both shapes here.
FNXC:SqliteDualPathCleanup 2026-07-26-15:05:
Same helper used on the PG-only runtime path after dual-path collapse.
*/
private static normalizeTargetContext(value: unknown): Record<string, unknown> | undefined {
if (value === null || value === undefined) return undefined;
if (typeof value === "string") return fromJson<Record<string, unknown>>(value);
if (typeof value === "object") return value as Record<string, unknown>;
return undefined;
}
private rowToRequest(row: ApprovalRequestRow): ApprovalRequest {
return {
id: row.id,
status: row.status,
requester: {
actorId: row.requesterActorId,
actorType: row.requesterActorType,
actorName: row.requesterActorName,
},
targetAction: {
category: normalizeApprovalRequestActionCategory(
row.targetActionCategory as Parameters<typeof normalizeApprovalRequestActionCategory>[0],
),
action: row.targetActionOperation,
summary: row.targetActionSummary,
resourceType: row.targetResourceType,
resourceId: row.targetResourceId,
context: ApprovalRequestStore.normalizeTargetContext(row.targetContext),
},
taskId: row.taskId ?? undefined,
runId: row.runId ?? undefined,
requestedAt: row.requestedAt,
decidedAt: row.decidedAt ?? undefined,
completedAt: row.completedAt ?? undefined,
createdAt: row.createdAt,
updatedAt: row.updatedAt,
};
}
private rowToAuditEvent(row: ApprovalRequestAuditEventRow): ApprovalRequestAuditEvent {
return {
id: row.id,
requestId: row.requestId,
eventType: row.eventType,
actor: {
actorId: row.actorId,
actorType: row.actorType,
actorName: row.actorName,
},
note: row.note ?? undefined,
createdAt: row.createdAt,
};
}
private appendAuditEvent(
requestId: string,
eventType: ApprovalRequestAuditEventType,
actor: ApprovalRequestActorSnapshot,
createdAt: string,
note?: string,
): ApprovalRequestAuditEvent {
const event: ApprovalRequestAuditEvent = {
id: `aprevt-${randomUUID().slice(0, 8)}`,
requestId,
eventType,
actor,
...(note !== undefined ? { note } : {}),
createdAt,
};
this.syncDb().prepare(`
INSERT INTO approval_request_audit_events (id, requestId, eventType, actorId, actorType, actorName, note, createdAt)
VALUES (?, ?, ?, ?, ?, ?, ?, ?)
`).run(
event.id,
event.requestId,
event.eventType,
event.actor.actorId,
event.actor.actorType,
event.actor.actorName,
event.note ?? null,
event.createdAt,
);
return event;
}
async create(input: ApprovalRequestCreateInput): Promise<ApprovalRequest> {
/*
FNXC:SqliteDualPathCleanup 2026-07-27-06:15:
Dual-path collapse left a local ApprovalRequest construction that was discarded
while a second random id was generated for the PG insert. Use one id and let
createApprovalRequest materialize the full row.
*/
const id = `apr-${randomUUID().slice(0, 8)}`;
return asyncApprovalRequestStore.createApprovalRequest(this.asyncLayer!, { ...input, id });
}
async get(id: string): Promise<ApprovalRequest | null> {
return asyncApprovalRequestStore.getApprovalRequest(this.asyncLayer!.db, id);
}
async list(input: ApprovalRequestListInput = {}): Promise<ApprovalRequest[]> {
return asyncApprovalRequestStore.listApprovalRequests(this.asyncLayer!.db, input);
}
async getPendingCountsByActor(): Promise<Map<string, number>> {
const table = schema.project.approvalRequests;
const rows = await this.asyncLayer!.db
.select({
actorId: table.requesterActorId,
requestCount: count(),
})
.from(table)
.where(eq(table.status, "pending"))
.groupBy(table.requesterActorId);
return new Map(rows.map((row) => [row.actorId, Number(row.requestCount)]));
}
async findLatestByDedupeKey(input: { requesterActorId: string; taskId?: string; dedupeKey: string }): Promise<ApprovalRequest | null> {
/*
FNXC:SqliteDualPathCleanup 2026-07-26-15:05:
Production path is PostgreSQL-only. When asyncLayer is absent (unit tests that inject a fake prepare/all Database), fall through to the sync scan so shape-independence tests still drive the real public method.
*/
if (this.backendMode) {
const table = schema.project.approvalRequests;
const conditions = [eq(table.requesterActorId, input.requesterActorId)];
if (input.taskId !== undefined) {
conditions.push(eq(table.taskId, input.taskId));
}
const rows = await this.asyncLayer!.db
.select()
.from(table)
.where(and(...conditions))
.orderBy(desc(table.createdAt), desc(table.id));
for (const row of rows as ApprovalRequestRow[]) {
// FNXC:ApprovalRedemption 2026-07-26-16:40: jsonb rows arrive parsed; see normalizeTargetContext.
const context = ApprovalRequestStore.normalizeTargetContext(row.targetContext);
if (context?.approvalDedupeKey === input.dedupeKey) {
return this.rowToRequest(row);
}
}
return null;
}
const where = ["requesterActorId = ?"];
const params: Array<string> = [input.requesterActorId];
if (input.taskId !== undefined) {
where.push("taskId = ?");
params.push(input.taskId);
}
const rows = this.syncDb().prepare(`
SELECT * FROM approval_requests
WHERE ${where.join(" AND ")}
ORDER BY createdAt DESC, id DESC
`).all(...params) as ApprovalRequestRow[];
for (const row of rows) {
const context = ApprovalRequestStore.normalizeTargetContext(row.targetContext);
if (context?.approvalDedupeKey === input.dedupeKey) {
return this.rowToRequest(row);
}
}
return null;
}
async decide(requestId: string, status: "approved" | "denied", input: ApprovalRequestDecisionInput): Promise<ApprovalRequest> {
return asyncApprovalRequestStore.decideApprovalRequest(this.asyncLayer!, requestId, status, input);
}
async markCompleted(requestId: string, input: ApprovalRequestCompletionInput): Promise<ApprovalRequest> {
return asyncApprovalRequestStore.markApprovalRequestCompleted(this.asyncLayer!, requestId, input);
}
async getAuditHistory(requestId: string): Promise<ApprovalRequestAuditEvent[]> {
return asyncApprovalRequestStore.getApprovalAuditHistory(this.asyncLayer!.db, requestId);
}
}