Files
fusion/packages/dashboard/app/components/nodes/node-summary.ts
gsxdsm cf6718f3c1 FN-6892: show default model for configured prompt nodes
Prompt workflow nodes with inline prompts or names now summarize their default model instead of appearing unconfigured.

- Return the localized Default model summary for model prompt nodes without pinned provider/model settings when prompt or name is present.
- Cover direct prompt summary cases and all built-in workflow prompt nodes to prevent Not configured regressions.
- Add localized summary text and workflow-step documentation for default-model prompt nodes.

Files changed:
 docs/workflow-steps.md                             |  2 +-
 .../nodes/__tests__/node-summary.test.ts           | 32 ++++++++++++++++++++++
 .../dashboard/app/components/nodes/node-summary.ts |  7 +++++
 packages/i18n/locales/en/common.json               |  1 +
 packages/i18n/locales/es/common.json               |  1 +
 packages/i18n/locales/fr/common.json               |  1 +
 packages/i18n/locales/ko/common.json               |  1 +
 packages/i18n/locales/zh-CN/common.json            |  1 +
 packages/i18n/locales/zh-TW/common.json            |  1 +
 9 files changed, 46 insertions(+), 1 deletion(-)

Fusion-Task-Id: FN-6892

Fusion-Task-Lineage: 5892429d-22ee-495e-bc40-06cbf81ee471
2026-06-21 22:14:15 -07:00

251 lines
10 KiB
TypeScript

import type { WorkflowFlowNodeData, WorkflowEditorNodeKind } from "./WorkflowNodeTypes";
/** Minimal catalog shapes the summary helper needs to resolve display names.
* Deliberately local (not imported from @fusion/core or ../api): the dashboard
* app build aliases @fusion/core to a types-only entry, and the helper only
* reads the few fields below, so a structural mirror keeps it decoupled and
* trivially testable. */
export interface SummaryModelInfo {
provider: string;
id: string;
name: string;
}
export interface SummaryNamed {
id: string;
name: string;
}
export interface NodeSummaryCatalogs {
models?: SummaryModelInfo[];
agents?: SummaryNamed[];
skills?: SummaryNamed[];
}
/** Translate function shape (matches react-i18next's `t(key, default)`). The
* helper is pure, so callers pass `t`; tests pass nothing and get the inline
* English defaults. Raw config values (ids, commands, names) are NOT
* translated — only the few structural phrases below are. */
export type SummaryTranslate = (key: string, defaultValue: string, opts?: Record<string, unknown>) => string;
const identityT: SummaryTranslate = (_key, defaultValue, opts) => {
if (!opts) return defaultValue;
// Minimal interpolation so the identity fallback mirrors i18next {{x}} output.
return defaultValue.replace(/\{\{(\w+)\}\}/g, (_m, name: string) =>
name in opts ? String(opts[name]) : `{{${name}}}`,
);
};
const COMMAND_TRUNCATE = 40;
function str(v: unknown): string {
return typeof v === "string" ? v : "";
}
function truncate(value: string, max: number): string {
const trimmed = value.trim();
if (trimmed.length <= max) return trimmed;
return `${trimmed.slice(0, max - 1)}…`;
}
function firstLine(value: string): string {
const line = value.split(/\r?\n/, 1)[0] ?? "";
return line.trim();
}
function modelSummary(config: Record<string, unknown>, catalogs: NodeSummaryCatalogs): string {
const provider = str(config.modelProvider);
const modelId = str(config.modelId);
const resolved = catalogs.models?.find((m) => m.provider === provider && m.id === modelId);
if (resolved?.name) return resolved.name;
if (provider && modelId) return `${provider}/${modelId}`;
if (modelId) return modelId;
return "";
}
function joinModeSummary(config: Record<string, unknown>): string {
const m = config.mode as unknown;
if (m && typeof m === "object" && "quorum" in (m as object)) {
return `quorum(${(m as { quorum: number }).quorum})`;
}
return typeof m === "string" ? m : "all";
}
/**
* Normalize any of the skill-name forms the workflow editor encounters down to
* a single bare token (lowercased) for matching:
* "compound-engineering:ce-work" → "ce-work" (plugin-namespaced node skillName)
* "ce-work/SKILL.md" → "ce-work" (catalog two-segment name)
* "<source>::skills/ce-work/SKILL.md" → "ce-work" (catalog id)
* "ce-work" → "ce-work"
* Builtin workflow nodes store a `pluginId:skill` skillName, but the discovered-
* skills catalog keys entries by two-segment name / `source::path` id, so an
* exact comparison never matches. Reducing both sides to the bare skill token
* lets them resolve.
*/
export function bareSkillName(name: string): string {
if (!name) return "";
const withoutSkillMd = name.replace(/\/SKILL\.md$/i, "");
const lastPathSegment = withoutSkillMd.split("/").pop() ?? withoutSkillMd;
const afterNamespace = lastPathSegment.split(":").pop() ?? lastPathSegment;
return afterNamespace.toLowerCase();
}
/**
* Map a node's `data.kind` + `data.config` to a short, single-line summary used
* by the card-style node's summary row. Returns "" for kinds with no meaningful
* summary (start/end/split/merge) so the card can skip the summary row.
*
* Catalog name resolution is best-effort: when a catalog is missing or the id is
* unknown, the raw id/command/name is returned — never blank for a configured
* node (KTD-6 raw-id fallback).
*
* FNXC:WorkflowNodeSummary 2026-06-21-00:00:
* Built-in prompt nodes that use the default model are configured by their inline prompt or display name even when they do not pin modelProvider/modelId.
* Show "Default model" for that model-executor state so workflow editor and mobile graph summaries never imply those built-ins are incomplete.
*/
export function nodeConfigSummary(
data: WorkflowFlowNodeData,
catalogs: NodeSummaryCatalogs = {},
t: SummaryTranslate = identityT,
): string {
const kind = data.kind as WorkflowEditorNodeKind;
const config = (data.config ?? {}) as Record<string, unknown>;
switch (kind) {
case "prompt": {
const seam = str(config.seam);
if (seam) {
switch (seam) {
case "execute":
return t("workflowNodes.summarySeamExecute", "Execute (engine)");
case "review":
return t("workflowNodes.summarySeamReview", "Review (engine)");
case "merge":
return t("workflowNodes.summarySeamMerge", "Merge boundary");
case "planning":
return t("workflowNodes.summarySeamPlanning", "Plan (engine)");
case "step-execute":
return t("workflowNodes.summarySeamStepExecute", "Step execute (engine)");
default:
return t("workflowNodes.summarySeamUnknown", "Seam: {{seam}}", { seam });
}
}
const executor = str(config.executor) || "model";
if (executor === "agent") {
const agentId = str(config.agentId);
if (!agentId) return t("workflowNodes.summaryNotConfigured", "Not configured");
const name = catalogs.agents?.find((a) => a.id === agentId)?.name;
return name || agentId;
}
if (executor === "skill") {
const skillName = str(config.skillName);
if (!skillName) return t("workflowNodes.summaryNotConfigured", "Not configured");
// skillName may be stored namespaced (e.g. "compound-engineering:ce-work")
// while catalog entries use a two-segment name ("ce-work/SKILL.md") or a
// "<source>::path" id — bareSkillName() normalizes all forms so plugin-
// contributed and builtin-workflow skills resolve, not just exact matches.
const bare = bareSkillName(skillName);
const match = catalogs.skills?.find(
(s) =>
s.name === skillName ||
s.id === skillName ||
bareSkillName(s.name) === bare ||
bareSkillName(s.id) === bare,
);
return match?.name || skillName;
}
if (executor === "cli") {
const cliMode = str(config.cliMode) || "command";
if (cliMode === "script") {
const script = str(config.scriptName);
return script || t("workflowNodes.summaryNotConfigured", "Not configured");
}
const command = str(config.cliCommand);
return command ? truncate(command, COMMAND_TRUNCATE) : t("workflowNodes.summaryNotConfigured", "Not configured");
}
// executor === "model"
const model = modelSummary(config, catalogs);
if (model) return model;
if (config.awaitInput === true) return t("workflowNodes.summaryAwaitInput", "Waits for user input");
if (str(config.prompt).trim() || str(config.name).trim()) {
return t("workflowNodes.summaryDefaultModel", "Default model");
}
return t("workflowNodes.summaryNotConfigured", "Not configured");
}
case "script": {
const script = str(config.scriptName);
return script || t("workflowNodes.summaryNotConfigured", "Not configured");
}
case "gate": {
const prompt = str(config.prompt);
if (prompt) return truncate(firstLine(prompt), COMMAND_TRUNCATE);
const gateMode = str(config.gateMode) || "gate";
return gateMode === "advisory"
? t("workflowNodes.summaryGateAdvisory", "Advisory")
: t("workflowNodes.summaryGateBlocks", "Gate (blocks)");
}
case "hold": {
const release = str(config.release) || "manual";
return t("workflowNodes.summaryHoldRelease", "Release: {{release}}", { release });
}
case "join":
return joinModeSummary(config);
case "foreach": {
const mode = str(config.mode) || "sequential";
const isolation = str(config.isolation) || (mode === "parallel" ? "worktree" : "shared");
return `${mode} · ${isolation}`;
}
case "loop": {
const exitWhen = config.exitWhen as unknown;
const exit =
exitWhen && typeof exitWhen === "object"
? (() => {
const condition = exitWhen as Record<string, unknown>;
const type = str(condition.type);
if (type === "output-matches") {
return t("workflowNodes.summaryLoopUntilMatches", "until matches /{{pattern}}/", {
pattern: str(condition.pattern),
});
}
if (type === "output-contains") {
return t('workflowNodes.summaryLoopUntilContains', 'until contains "{{value}}"', {
value: str(condition.value),
});
}
return "";
})()
: "";
const maxIterations =
typeof config.maxIterations === "number" && Number.isFinite(config.maxIterations)
? t("workflowNodes.summaryLoopIterations", "{{count}}x", { count: config.maxIterations })
: t("workflowNodes.summaryLoopIterations", "{{count}}x", { count: 3 });
return exit ? `${exit} · ${maxIterations}` : maxIterations;
}
case "step-review": {
const reviewType = str(config.type) || "code";
return t("workflowNodes.summaryReviewType", "{{type}} review", { type: reviewType });
}
case "parse-steps": {
const parser = str(config.parser) || "step-headings";
const artifact = str(config.artifact);
return artifact ? `${parser} · ${artifact}` : parser;
}
case "code": {
const source = firstLine(str(config.source));
return source ? truncate(source, COMMAND_TRUNCATE) : t("workflowNodes.summaryCodeDefault", "TypeScript");
}
case "notify": {
const event = str(config.event) || "workflow-notify";
const message = truncate(firstLine(str(config.message)), COMMAND_TRUNCATE);
return message ? `${event} · ${message}` : event;
}
// No meaningful summary: structural/control nodes.
case "start":
case "end":
case "split":
case "merge":
default:
return "";
}
}