- 51 fix agents covered every dirty batch from the round-1 verifiers: helper-function labels (roles, statuses, relative time), constant label maps (SETTINGS_SECTIONS, PROVIDER_INFO, EVENT_TYPE_LABELS), TUI help overlay + tab labels, toasts, placeholders, aria-labels - Inline markup flattened by round 1 restored with <Trans> (DbCorruptionBanner storage-docs link, UpdateAvailableBanner code chip) - Catalogs merged: +527 en keys across 5 locales; CLI bundles + app locale tree regenerated (6 locales) - All 23 sweep-caused test regressions fixed: delta vs the clean-main baseline is now zero (remaining 4 local failures reproduce identically on origin/main; CI-green upstream) - typecheck/lint clean; TUI 82/82, core locale 9/9 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
280 lines
11 KiB
TypeScript
280 lines
11 KiB
TypeScript
import { useCallback, useEffect } from "react";
|
|
import { useTranslation } from "react-i18next";
|
|
import type { TFunction } from "i18next";
|
|
import type { ModelPreset } from "@fusion/core";
|
|
import type { ModelInfo } from "../api";
|
|
import { applyPresetToSelection } from "../utils/modelPresets";
|
|
import { CustomModelDropdown } from "./CustomModelDropdown";
|
|
import { Brain, X } from "lucide-react";
|
|
|
|
interface ModelSelectionModalProps {
|
|
isOpen: boolean;
|
|
onClose: () => void;
|
|
models: ModelInfo[];
|
|
executorValue: string;
|
|
validatorValue: string;
|
|
onExecutorChange: (value: string) => void;
|
|
onValidatorChange: (value: string) => void;
|
|
modelsLoading: boolean;
|
|
modelsError: string | null;
|
|
onRetry: () => void;
|
|
favoriteProviders?: string[];
|
|
onToggleFavorite?: (provider: string) => void;
|
|
favoriteModels?: string[];
|
|
onToggleModelFavorite?: (modelId: string) => void;
|
|
/** Available model presets for quick selection. When provided, a preset selector is shown. */
|
|
presets?: ModelPreset[];
|
|
/** Currently selected preset ID, or undefined if no preset is active. */
|
|
selectedPresetId?: string;
|
|
/** Called when the user selects a preset or reverts to default/custom mode. */
|
|
onPresetChange?: (presetId: string | undefined) => void;
|
|
}
|
|
|
|
function getModelBadgeLabel(models: ModelInfo[], value: string, t: TFunction<"app">): string {
|
|
if (!value) return t("modelSelection.usingDefault", "Using default");
|
|
const slashIdx = value.indexOf("/");
|
|
if (slashIdx === -1) return value;
|
|
const provider = value.slice(0, slashIdx);
|
|
const modelId = value.slice(slashIdx + 1);
|
|
const matched = models.find((m) => m.provider === provider && m.id === modelId);
|
|
return matched ? `${matched.provider}/${matched.id}` : `${provider}/${modelId}`;
|
|
}
|
|
|
|
export function ModelSelectionModal({
|
|
isOpen,
|
|
onClose,
|
|
models,
|
|
executorValue,
|
|
validatorValue,
|
|
onExecutorChange,
|
|
onValidatorChange,
|
|
modelsLoading,
|
|
modelsError,
|
|
onRetry,
|
|
favoriteProviders = [],
|
|
onToggleFavorite,
|
|
favoriteModels = [],
|
|
onToggleModelFavorite,
|
|
presets,
|
|
selectedPresetId,
|
|
onPresetChange,
|
|
}: ModelSelectionModalProps) {
|
|
const { t } = useTranslation("app");
|
|
// Handle Escape key
|
|
useEffect(() => {
|
|
if (!isOpen) return;
|
|
|
|
const handleKeyDown = (event: KeyboardEvent) => {
|
|
if (event.key === "Escape") {
|
|
event.preventDefault();
|
|
onClose();
|
|
}
|
|
};
|
|
|
|
document.addEventListener("keydown", handleKeyDown);
|
|
return () => document.removeEventListener("keydown", handleKeyDown);
|
|
}, [isOpen, onClose]);
|
|
|
|
// Handle overlay click
|
|
const handleOverlayClick = useCallback(
|
|
(event: React.MouseEvent) => {
|
|
if (event.target === event.currentTarget) {
|
|
onClose();
|
|
}
|
|
},
|
|
[onClose],
|
|
);
|
|
|
|
const showPresets = !!(presets && presets.length > 0 && onPresetChange);
|
|
const selectedPreset = presets?.find((p) => p.id === selectedPresetId);
|
|
|
|
const handlePresetSelect = useCallback(
|
|
(value: string) => {
|
|
if (!onPresetChange) return;
|
|
if (value === "default") {
|
|
onPresetChange(undefined);
|
|
onExecutorChange("");
|
|
onValidatorChange("");
|
|
return;
|
|
}
|
|
if (value === "custom") {
|
|
onPresetChange(undefined);
|
|
return;
|
|
}
|
|
const preset = presets?.find((p) => p.id === value);
|
|
if (preset) {
|
|
const selection = applyPresetToSelection(preset);
|
|
onExecutorChange(selection.executorValue);
|
|
onValidatorChange(selection.validatorValue);
|
|
onPresetChange(preset.id);
|
|
}
|
|
},
|
|
[onPresetChange, presets, onExecutorChange, onValidatorChange],
|
|
);
|
|
|
|
const handleExecutorChange = useCallback(
|
|
(value: string) => {
|
|
// Manual model selection clears preset mode
|
|
if (onPresetChange && selectedPresetId) {
|
|
onPresetChange(undefined);
|
|
}
|
|
onExecutorChange(value);
|
|
},
|
|
[onPresetChange, selectedPresetId, onExecutorChange],
|
|
);
|
|
|
|
const handleValidatorChange = useCallback(
|
|
(value: string) => {
|
|
// Manual model selection clears preset mode
|
|
if (onPresetChange && selectedPresetId) {
|
|
onPresetChange(undefined);
|
|
}
|
|
onValidatorChange(value);
|
|
},
|
|
[onPresetChange, selectedPresetId, onValidatorChange],
|
|
);
|
|
|
|
if (!isOpen) return null;
|
|
|
|
const hasExecutorOverride = Boolean(executorValue);
|
|
const hasValidatorOverride = Boolean(validatorValue);
|
|
|
|
return (
|
|
<div className="modal-overlay open" onClick={handleOverlayClick} role="dialog" aria-modal="true" data-testid="model-selection-modal">
|
|
<div className="modal modal-lg">
|
|
<div className="modal-header">
|
|
<div className="detail-title-row">
|
|
<Brain size={20} style={{ color: "var(--todo)" }} />
|
|
<h3>{t("modelSelection.title", "Select Models")}</h3>
|
|
</div>
|
|
<button className="modal-close" onClick={onClose} aria-label={t("actions.close", "Close")} data-testid="model-selection-close">
|
|
<X size={20} />
|
|
</button>
|
|
</div>
|
|
|
|
<div className="planning-modal-body">
|
|
{modelsLoading ? (
|
|
<div className="planning-loading">
|
|
<div className="detail-section">
|
|
<p className="text-muted">{t("modelSelection.loading", "Loading models…")}</p>
|
|
</div>
|
|
</div>
|
|
) : modelsError ? (
|
|
<div className="detail-section">
|
|
<div className="form-error planning-error">
|
|
<span>{modelsError}</span>
|
|
</div>
|
|
<button type="button" className="btn btn-sm" onClick={onRetry} data-testid="model-selection-retry">
|
|
{t("actions.retry", "Retry")}
|
|
</button>
|
|
</div>
|
|
) : models.length === 0 ? (
|
|
<div className="detail-section">
|
|
<div className="inline-create-model-empty">
|
|
{t("modelSelection.noModels", "No models available. Configure authentication in Settings to enable model selection.")}
|
|
</div>
|
|
</div>
|
|
) : (
|
|
<div className="planning-summary">
|
|
<div className="planning-view-scroll planning-summary-scroll">
|
|
<div className="planning-summary-header">
|
|
<p className="text-muted">{t("modelSelection.choose", "Choose models for this task. If not selected, default models will be used.")}</p>
|
|
</div>
|
|
|
|
<div className="planning-summary-form">
|
|
{showPresets && (
|
|
<div className="task-detail-section">
|
|
<div className="inline-create-model-row">
|
|
<label htmlFor="model-selection-preset" className="inline-create-model-label">
|
|
{t("modelSelection.preset", "Preset")}
|
|
</label>
|
|
<span
|
|
className={`model-badge ${selectedPresetId ? "model-badge-custom" : "model-badge-default"}`}
|
|
data-testid="preset-badge"
|
|
>
|
|
{selectedPreset ? selectedPreset.name : t("modelSelection.useDefault", "Use default")}
|
|
</span>
|
|
<select
|
|
id="model-selection-preset"
|
|
value={selectedPresetId || "default"}
|
|
onChange={(e) => handlePresetSelect(e.target.value)}
|
|
data-testid="model-selection-preset"
|
|
>
|
|
<option value="default">{t("modelSelection.useDefault", "Use default")}</option>
|
|
{presets!.length > 0 && <option disabled>──────────</option>}
|
|
{presets!.map((preset) => (
|
|
<option key={preset.id} value={preset.id}>{preset.name}</option>
|
|
))}
|
|
<option value="custom">{t("modelSelection.custom", "Custom")}</option>
|
|
</select>
|
|
</div>
|
|
</div>
|
|
)}
|
|
|
|
<div className="task-detail-section">
|
|
<div className="inline-create-model-row">
|
|
<label htmlFor="model-selection-executor" className="inline-create-model-label">
|
|
{t("modelSelection.executorModel", "Executor Model")}
|
|
</label>
|
|
<span
|
|
className={`model-badge ${hasExecutorOverride ? "model-badge-custom" : "model-badge-default"}`}
|
|
data-testid="executor-badge"
|
|
>
|
|
{getModelBadgeLabel(models, executorValue, t)}
|
|
</span>
|
|
<CustomModelDropdown
|
|
id="model-selection-executor"
|
|
label={t("modelSelection.executorModel", "Executor Model")}
|
|
value={executorValue}
|
|
onChange={handleExecutorChange}
|
|
models={models}
|
|
placeholder={t("modelSelection.executorPlaceholder", "Select executor model…")}
|
|
favoriteProviders={favoriteProviders}
|
|
onToggleFavorite={onToggleFavorite}
|
|
favoriteModels={favoriteModels}
|
|
onToggleModelFavorite={onToggleModelFavorite}
|
|
/>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="task-detail-section">
|
|
<div className="inline-create-model-row">
|
|
<label htmlFor="model-selection-validator" className="inline-create-model-label">
|
|
{t("modelSelection.reviewerModel", "Reviewer Model")}
|
|
</label>
|
|
<span
|
|
className={`model-badge ${hasValidatorOverride ? "model-badge-custom" : "model-badge-default"}`}
|
|
data-testid="validator-badge"
|
|
>
|
|
{getModelBadgeLabel(models, validatorValue, t)}
|
|
</span>
|
|
<CustomModelDropdown
|
|
id="model-selection-validator"
|
|
label={t("modelSelection.reviewerModel", "Reviewer Model")}
|
|
value={validatorValue}
|
|
onChange={handleValidatorChange}
|
|
models={models}
|
|
placeholder={t("modelSelection.reviewerPlaceholder", "Select reviewer model…")}
|
|
favoriteProviders={favoriteProviders}
|
|
onToggleFavorite={onToggleFavorite}
|
|
favoriteModels={favoriteModels}
|
|
onToggleModelFavorite={onToggleModelFavorite}
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="planning-actions planning-summary-actions">
|
|
<button className="btn" onClick={onClose} data-testid="model-selection-done">
|
|
{t("actions.done", "Done")}
|
|
</button>
|
|
</div>
|
|
</div>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|