# Migrate storage from SQLite to PostgreSQL — full dashboard cutover Migrates Fusion's storage layer to the embedded PostgreSQL `AsyncDataLayer` (the default backend) and **completes the satellite-store + feature cutover** so every dashboard and Command Center surface works in PG mode. ## Status — every surface works in embedded-PG mode Verified live against a running embedded-Postgres dashboard (all **200**, zero 5xx) and gate-tested (**23 files / 99 tests** on embedded PG, plus engine-core 294 and ci-shape 63 in the blocking merge gate; core/engine/cli/dashboard typecheck clean). | Area | Surfaces | State | |---|---|---| | Satellite stores | workflows, todos, insights, research, missions, goals, mailbox | ✅ | | Views | artifacts, documents, evals | ✅ | | Command Center | activity, productivity, team, tokens, tools, **workflows**, **github**, **signals**, **plugin-activations**, **live** (all 10) | ✅ | | Run execution | insight generation, research run execution | ✅ (store-path; AI step needs a provider) | | Live updates | SSE push for mission/research/insight events | ✅ | | Workflow editing | create / update / delete / select (+ id counter) | ✅ | | Engine | mission autopilot, incident-signal ingestion, regression storm-guard, agent wake-on-message | ✅ | | Core | tasks, agents, secrets, automations, memory, chat, usage, PRs, git | ✅ | ## Approach Each satellite store gets an `Async<Store>` wrapper exposing the sync store's method names over the existing `async-*-store.ts` helpers; `get<Store>Store()` returns a `Sync | Async` union; consumers `await` (harmless on sync), and engine/CLI paths that can't convert use `instanceof Sync` graceful fallback. Analytics aggregators branch on `"ping" in dbOrLayer` to run schema-qualified raw SQL over `project.*` (snake_case) in PG. Executors/orchestrators/autopilot are await-converted to drive the union store; the async store wrappers extend `EventEmitter` so SSE live-push fires in both backends. Not-yet-ported capabilities degrade gracefully (never 500) and are individually called out in commits. ## Sync with main The branch is kept continuously merged with `main` (currently through FN-7845, 2026-07-12); the earlier "final rebase deferred" note no longer applies. Use **Create a merge commit** (or squash) to land it — GitHub's rebase-merge cannot replay a merge-maintained branch. ## Residual Review Findings Multi-agent code review of the PostgreSQL satellite-store ports (U1–U5) applied 3 safe fixes (see `fix(review): apply autofix feedback`). The following are **real but gated** — recorded here as follow-up work rather than auto-applied. All are SQLite→PostgreSQL **concurrency/atomicity regressions**: the sync stores were immune only by SQLite's single-writer, single-threaded-handler execution; the async ports open multi-await read-modify-write windows. **Reachability is low today** because the execution engines that generate concurrent same-run mutations (insight run executor, research orchestrator/dispatcher) are `instanceof`-gated to sync mode in PG. No process-crash class survived (all engine fallbacks correctly guard the sync store). - **[P1] Research `appendResearchEvent` dual-write is non-atomic** (`packages/core/src/async-research-store.ts`, corroborated: adversarial + reliability). The `research_run_events` insert (own transaction) and the `run.events` jsonb update are separate writes — a crash between them, or two concurrent appends, splits the table count from the jsonb array. **Fix:** perform the seq-insert and the jsonb update in one `layer.transactionImmediate`. - **[P1] Research run terminal-reversion via stale full-row persist** (`async-research-store.ts` `persistResearchRun`/`updateResearchStatus`). Concurrent `PATCH /runs/:id/status` + `POST /runs/:id/events` can revert a terminal run to `running` by overwriting the whole row, bypassing the transition guard. **Fix:** scoped column `UPDATE`s with a `WHERE status …` guard, or optimistic version column. - **[P2] `updateResearchRun`/`updateInsightRun` read-then-write TOCTOU** — concurrent PATCHes last-writer-wins on the lifecycle merge. **Fix:** `SELECT … FOR UPDATE` / enclosing transaction. - **[P2] `upsertRun`/`createRunOrThrowConflict` check-then-create race** (`async-insight-store.ts`) — two callers can each create an "active" run. **Fix:** partial unique index on `(projectId, trigger) WHERE status IN ('pending','running')`. - **[P3] `createResearchRetryRun` return-value divergence** — sync returns the pre-update `queued` snapshot; async returns the reloaded `retry_waiting` run (persisted state is identical). Pick one side for cross-backend parity. - **[P2/perf] Mission `getMissionWithHierarchy`/`getMissionHealth` N+1 fan-out** — O(milestones×slices) sequential round-trips hold one pool slot per request; can starve the pool for large hierarchies. **Fix:** batched/joined reads. - **Testing gaps:** no PG-mode concurrency tests (interleaved status/event mutations), no sync↔async parity assertion for the lifecycle-error codes, and no mission status/health rollup parity test vs the sync `MissionStore`. ~~Out of scope (deferred): AI run *execution* (insight/research) + mission autopilot + live SSE mission events remain sync-gated/degraded in PG mode.~~ **Since ported** — insight/research run execution, mission autopilot, and SSE live push all run on the async layer now, which also makes the concurrency findings above genuinely reachable; they remain open follow-ups. --- ## Update — 2026-07-12: production-readiness hardening & live acceptance Everything below landed on this branch since the description above was written: **Production blockers from review — fixed** - `recoverStaleTransitionPending` ported to the async layer (backend moves write + clear the crash-safe marker; startup/maintenance sweeps no longer throw). - Lost-update class fixed: `atomicWriteTaskJson`/`WithAudit` write changed columns only (full-row upserts silently resurrected stale fields across concurrent store instances — the "task stuck unplanned forever" bug). - First-boot **auto-migration**: booting the PG backend over a project with a legacy `fusion.db` migrates it automatically (loud failure, SQLite kept as backup), and the dashboard shows a one-time **"your data was migrated" banner** with the backup paths and a Need-help Discord link. - `pg_dump`/`pg_restore` discovered from common install locations for embedded-mode backups. - The PG suite is part of the blocking merge gate (`test:pg-gate`). **Multi-project isolation (PR #2007, merged into this branch)** - `project_id` partition key on tasks / archived tasks / config, `taskProjectScope` threaded through every scan/claim/count, per-project config rows, layer bound to the project at startup. - Review P1 follow-up: the shared cold-storage `archive.archived_tasks` table is also partitioned and all archived-board reads/counts/searches are scoped. - Schema drift self-heal generalized to schema-qualified columns so existing databases upgrade in place. **Other changes** - Node settings sync **removed** in PG mode (409 `settings-sync-disabled-postgres`) — nodes share state by connecting to the same database; auth sync kept (per-machine file). - Perf (review findings): `listTasks` pushes column filter + ORDER BY + LIMIT/OFFSET into SQL; `getConversation` capped to the most recent 200 messages. - Fixed a false "operator action required" pause-abort log fired on every successfully auto-merged task. **Live acceptance — PASSED (2026-07-12)** A sandboxed instance (isolated HOME, embedded PG, real Opus executor) ran a task through the complete cycle: create → triage (AI spec) → execute → in-review → AI squash-merge landed on the project's `main` → done. A write+read sweep of every data surface (settings, comments, documents, attachments + artifact bridge + artifact edit, chat with real generation, goals, missions, agent mail, secrets, workflows, memory, CC analytics) was green on embedded PG. **Known remaining work** - The per-project `config` PK re-key has no upgrade path for pre-isolation embedded-PG databases (needs a real `DROP CONSTRAINT`/re-key migration; fresh databases are fine). - `pg_dump`/`pg_restore` binaries are not yet bundled in release artifacts (PATH/common-location discovery only). - The satellite-store concurrency findings listed above. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Phil Larson <hello@phillarson.xyz> Co-authored-by: fusion-merge <fusion-merge@local>
95 lines
3.7 KiB
JavaScript
95 lines
3.7 KiB
JavaScript
/**
|
|
* FNXC:PostgresCutover 2026-07-05-13:00:
|
|
* Shared PostgreSQL backend access for operational scripts.
|
|
*
|
|
* The ops/maintenance scripts under scripts/ used to open `.fusion/fusion.db`
|
|
* directly (node:sqlite or the sqlite3 CLI). After the PostgreSQL cutover the
|
|
* live data lives in the embedded PostgreSQL cluster (or an external cluster
|
|
* via DATABASE_URL), so a direct SQLite open would silently operate on a
|
|
* stale/empty marker file. Every script now boots the real backend through
|
|
* @fusion/core's startup factory via this helper.
|
|
*
|
|
* Requires packages/core to be built (`pnpm --filter @fusion/core build`).
|
|
*/
|
|
import { cpSync, existsSync } from "node:fs";
|
|
import { resolve, dirname } from "node:path";
|
|
import { fileURLToPath, pathToFileURL } from "node:url";
|
|
|
|
const repoRoot = resolve(dirname(fileURLToPath(import.meta.url)), "..", "..");
|
|
|
|
/**
|
|
* Stage the PostgreSQL baseline migration SQL into core's dist. `tsc` emits
|
|
* only JS, so dist lacks src/postgres/migrations/*.sql; the schema applier
|
|
* resolves them relative to the compiled file (__dirname/migrations). The CLI
|
|
* bundle does the same staging in packages/cli/tsup.config.ts.
|
|
*/
|
|
function ensureMigrationsStaged() {
|
|
const src = resolve(repoRoot, "packages/core/src/postgres/migrations");
|
|
const dest = resolve(repoRoot, "packages/core/dist/postgres/migrations");
|
|
if (existsSync(src) && !existsSync(resolve(dest, "0000_initial.sql"))) {
|
|
cpSync(src, dest, { recursive: true });
|
|
}
|
|
}
|
|
|
|
async function importCore() {
|
|
ensureMigrationsStaged();
|
|
try {
|
|
return await import(pathToFileURL(resolve(repoRoot, "packages/core/dist/index.js")).href);
|
|
} catch (error) {
|
|
const message = error instanceof Error ? error.message : String(error);
|
|
throw new Error(
|
|
`Unable to import packages/core/dist/index.js (${message}). Run: pnpm --filter @fusion/core build`,
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Boot a PostgreSQL-backed TaskStore for the given project root.
|
|
*
|
|
* Returns `{ core, store, asyncLayer, sql, schema, shutdown }`:
|
|
* - `core` — the @fusion/core module (for helpers like recordRunAuditEvent).
|
|
* - `store` — the initialized TaskStore (backend mode).
|
|
* - `asyncLayer` — the AsyncDataLayer; `asyncLayer.db.execute(sql\`...\`)`
|
|
* runs raw SQL. Project tables are schema-qualified (`project."tasks"`).
|
|
* - `sql` — the drizzle-orm `sql` template tag (re-exported as drizzleSql).
|
|
* - `schema` — postgresSchema (drizzle table objects, e.g. schema.project.tasks).
|
|
* - `shutdown` — releases the pool and stops an embedded cluster this boot
|
|
* started. Always call it in `finally`.
|
|
*
|
|
* Throws when the factory opts out (FUSION_NO_EMBEDDED_PG=1): these scripts
|
|
* must never fall back to the removed SQLite runtime.
|
|
*/
|
|
export async function openBackend(rootDir = process.cwd()) {
|
|
const core = await importCore();
|
|
const boot = await core.createTaskStoreForBackend({ rootDir });
|
|
if (!boot) {
|
|
throw new Error(
|
|
"PostgreSQL backend unavailable (FUSION_NO_EMBEDDED_PG=1 opt-out is set). " +
|
|
"This script requires the PostgreSQL backend; the SQLite runtime was removed.",
|
|
);
|
|
}
|
|
const asyncLayer = boot.taskStore.getAsyncLayer();
|
|
if (!asyncLayer) {
|
|
await boot.shutdown().catch(() => {});
|
|
throw new Error("Backend TaskStore has no AsyncDataLayer; cannot run this script.");
|
|
}
|
|
return {
|
|
core,
|
|
store: boot.taskStore,
|
|
asyncLayer,
|
|
sql: core.drizzleSql,
|
|
schema: core.postgresSchema,
|
|
shutdown: boot.shutdown,
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Normalize a drizzle `db.execute(...)` result to a plain array of rows.
|
|
* postgres-js returns a RowList (array-like); this keeps call sites simple.
|
|
*/
|
|
export function rowsOf(result) {
|
|
if (Array.isArray(result)) return [...result];
|
|
if (result && Array.isArray(result.rows)) return [...result.rows];
|
|
return [];
|
|
}
|