Files
fusion/plugins/fusion-plugin-hermes-runtime/src/probe.ts
gsxdsm 743251a5d3 FN-9099: harden Hermes Windows CLI launches
Reliably resolve and safely launch operator-installed Hermes binaries on Windows.

- Resolve Windows Hermes shims using PATH and PATHEXT-aware lookup with bounded caching
- Launch .cmd and .bat shims through escaped cmd.exe payloads while preserving direct executable launches
- Supervise CLI turns and cover Windows shim, probe, cache, timeout, and injection behavior

Files changed:
 .changeset/fn-9099-hermes-windows-launch.md        |   7 +
 plugins/fusion-plugin-hermes-runtime/README.md     |   4 +
 plugins/fusion-plugin-hermes-runtime/package.json  |   1 +
 .../src/__tests__/cli-spawn.test.ts                | 139 +++++++++++++++-
 .../src/__tests__/probe.test.ts                    |  61 +++++++
 .../src/__tests__/windows-binary-launch.test.ts    |  64 +++++++
 .../fusion-plugin-hermes-runtime/src/cli-spawn.ts  |  72 ++++----
 plugins/fusion-plugin-hermes-runtime/src/index.ts  |   8 +
 plugins/fusion-plugin-hermes-runtime/src/probe.ts  |  19 ++-
 .../src/windows-binary-launch.ts                   | 184 +++++++++++++++++++++
 pnpm-lock.yaml                                     |   3 +
 11 files changed, 508 insertions(+), 54 deletions(-)

Fusion-Task-Id: FN-9099

Fusion-Task-Lineage: 37b1f255-07ce-4952-aac6-1556890849be

Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
2026-08-15 12:38:24 -07:00

148 lines
4.5 KiB
TypeScript

/**
* Hermes binary probe helper.
*
* Mirrors the probeClaudeCli pattern from packages/dashboard/src/claude-cli-probe.ts.
* Never throws — all failures are captured as `available: false` with a reason.
*/
import { spawn } from "node:child_process";
import { resolveHermesLaunch } from "./windows-binary-launch.js";
/** Default probe timeout in milliseconds. */
const DEFAULT_PROBE_TIMEOUT_MS = 2000;
/**
* Result of probing for the hermes binary.
*/
export interface HermesBinaryStatus {
/** True if the binary was found and ran to completion successfully. */
available: boolean;
/** Absolute path resolved via `which`/`where`, if found. */
binaryPath?: string;
/** Version string from `hermes --version` stdout, if available. */
version?: string;
/** Human-readable failure reason when `available === false`. */
reason?: string;
/** Wall-clock duration of the probe in milliseconds. */
probeDurationMs: number;
}
/**
* Probe for the hermes binary.
*
* Runs `<binaryPath> --version` with a short timeout. Use this from
* the dashboard status endpoint to check binary presence without crashing.
*
* @param opts.binaryPath - Override the binary path (default: "hermes").
* @param opts.timeoutMs - Override probe timeout in ms (default: 2000).
*/
export async function probeHermesBinary(opts?: {
binaryPath?: string;
timeoutMs?: number;
}): Promise<HermesBinaryStatus> {
const startedAt = Date.now();
const binary =
typeof opts?.binaryPath === "string" && opts.binaryPath.trim().length > 0
? opts.binaryPath.trim()
: "hermes";
const timeoutMs = opts?.timeoutMs ?? DEFAULT_PROBE_TIMEOUT_MS;
const launch = await resolveHermesLaunch(binary, ["--version"], { env: process.env });
// POSIX launch resolution is intentionally a no-op; retain which for the documented reporting path.
const resolvedPath = launch.resolvedBinaryPath ?? await tryResolvePosixBinaryPath(binary);
return new Promise<HermesBinaryStatus>((resolvePromise) => {
const finish = (result: Omit<HermesBinaryStatus, "probeDurationMs">): void => {
resolvePromise({ ...result, probeDurationMs: Date.now() - startedAt });
};
let settled = false;
const child = spawn(launch.command, launch.args, {
stdio: ["ignore", "pipe", "pipe"],
windowsVerbatimArguments: launch.windowsVerbatimArguments,
});
const timer = setTimeout(() => {
if (settled) return;
settled = true;
try {
child.kill("SIGKILL");
} catch {
// Process already gone.
}
finish({
available: false,
binaryPath: resolvedPath,
reason: `Probe timed out after ${timeoutMs}ms`,
});
}, timeoutMs);
let stdout = "";
let stderr = "";
child.stdout?.on("data", (chunk: Buffer) => {
stdout += chunk.toString("utf-8");
});
child.stderr?.on("data", (chunk: Buffer) => {
stderr += chunk.toString("utf-8");
});
child.on("error", (err: NodeJS.ErrnoException) => {
if (settled) return;
settled = true;
clearTimeout(timer);
const isNotFound = err.code === "ENOENT";
finish({
available: false,
binaryPath: resolvedPath,
reason: isNotFound
? `\`${binary}\` not found on PATH`
: err.message,
});
});
child.on("close", (code: number | null) => {
if (settled) return;
settled = true;
clearTimeout(timer);
if (code === 0) {
finish({
available: true,
version: stdout.trim() || undefined,
binaryPath: resolvedPath,
});
} else {
finish({
available: false,
binaryPath: resolvedPath,
reason:
stderr.trim() || `hermes --version exited with code ${String(code)}`,
});
}
});
});
}
/** Best-effort POSIX reporting lookup; Windows resolution belongs to windows-binary-launch. */
async function tryResolvePosixBinaryPath(binary: string): Promise<string | undefined> {
if (process.platform === "win32") return undefined;
return new Promise((resolvePromise) => {
const child = spawn("which", [binary], { stdio: ["ignore", "pipe", "ignore"] });
let out = "";
child.stdout?.on("data", (chunk: Buffer) => {
out += chunk.toString("utf-8");
});
child.on("error", () => resolvePromise(undefined));
child.on("close", (code: number | null) => {
if (code === 0) {
const first = out.trim().split(/\r?\n/)[0];
resolvePromise(first?.length ? first : undefined);
} else {
resolvePromise(undefined);
}
});
});
}