Files
fusion/packages/engine/src/executor/build-parse-steps-deps.ts
gsxdsm 1cf86baa1c refactor: package code organization wave 18 (executor pure peels) (#3317)
## Summary

Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).

### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.

| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |

`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).

### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)

### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate

**Stack:** wave17 (merged) → **this PR**

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.

* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
  * Added clearer refusal messages and more reliable revision restarts.
  * Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-09 15:46:09 -10:00

54 lines
2.4 KiB
TypeScript

/**
* FNXC:CodeOrganization 2026-08-03-17:00:
* buildParseStepsDeps peeled from TaskExecutor (U4).
*
* Artifact/step-write deps bag for the parse-steps graph handler, including
* foreach expansion pin protection (KTD-3).
*/
import type { TaskStep, TaskStore } from "@fusion/core";
import type { ParseStepsHandlerDeps } from "../workflows/workflow-node-handlers.js";
import type { WorkflowStepInstanceState } from "../workflows/workflow-graph-foreach.js";
import { executorLog } from "../logger.js";
export type BuildParseStepsDepsDeps = {
store: TaskStore;
readTaskArtifact: (taskId: string, key: string) => Promise<string | undefined>;
};
export function buildParseStepsDeps(
deps: BuildParseStepsDepsDeps,
runId?: string,
): ParseStepsHandlerDeps {
return {
readArtifact: (task, key): Promise<string | undefined> => deps.readTaskArtifact(task.id, key),
writeSteps: async (task, steps: TaskStep[]): Promise<void> => {
await deps.store.updateTask(task.id, { steps });
},
hasExpandedForeach: async (task): Promise<boolean> => {
const store = deps.store as unknown as {
loadWorkflowRunStepInstancesAsync?: (taskId: string, runId: string) => Promise<WorkflowStepInstanceState[]>;
loadWorkflowRunStepInstances?: (taskId: string, runId: string) => WorkflowStepInstanceState[];
};
if (typeof store.loadWorkflowRunStepInstancesAsync !== "function" && typeof store.loadWorkflowRunStepInstances !== "function") return false;
try {
// Any persisted instance row for THIS run means a foreach has expanded —
// re-parsing would desynchronize the pinned instance set (KTD-3). Probe
// under the REAL run id (threaded from executeWorkflowGraph) so the
// pin protection actually fires; fall back to the legacy literal only when
// the run id was not threaded (older store / no definition).
const rows = await store.loadWorkflowRunStepInstancesAsync?.(task.id, runId ?? `${task.id}:run`)
?? store.loadWorkflowRunStepInstances?.(task.id, runId ?? `${task.id}:run`)
?? [];
return rows.length > 0;
} catch {
return false;
}
},
audit: (reason, detail) => {
// The detail string carries the task id (handler convention); emit on the
// engine log so the routable failure is auditable without a taskId arg.
executorLog.warn(`[parse-steps] ${reason}: ${detail}`);
},
};
}